| Time |
Nick |
Message |
| 00:48 |
|
MintChipMadness joined #minetest |
| 02:21 |
|
dridron joined #minetest |
| 02:21 |
|
seasharp joined #minetest |
| 02:22 |
|
MintChipMadness joined #minetest |
| 02:27 |
|
peterz joined #minetest |
| 02:32 |
|
amfl2 joined #minetest |
| 02:35 |
|
peterz joined #minetest |
| 02:40 |
|
stormchaser3000 joined #minetest |
| 04:00 |
|
MTDiscord joined #minetest |
| 04:07 |
|
gregon joined #minetest |
| 04:59 |
|
gregon joined #minetest |
| 05:04 |
|
gregon1 joined #minetest |
| 05:06 |
|
gregon2 joined #minetest |
| 05:07 |
|
tarsovbak joined #minetest |
| 05:10 |
|
micro_bowels joined #minetest |
| 05:11 |
|
MacroFaxSax joined #minetest |
| 05:25 |
|
SFENCE joined #minetest |
| 05:32 |
|
fluxionary joined #minetest |
| 06:00 |
|
TomTom joined #minetest |
| 07:39 |
|
cation joined #minetest |
| 07:41 |
|
ireallyhateirc joined #minetest |
| 08:02 |
|
YuGiOhJCJ joined #minetest |
| 08:02 |
|
tarsovbak joined #minetest |
| 08:49 |
|
gregon joined #minetest |
| 09:05 |
|
Verticen joined #minetest |
| 09:41 |
|
shaft joined #minetest |
| 09:41 |
shaft |
Can someone review please? https://github.com/minetest-mods/mesecons/pull/669 |
| 09:54 |
|
gregon joined #minetest |
| 09:54 |
|
seasharp joined #minetest |
| 09:55 |
|
tarsovbak joined #minetest |
| 10:06 |
shaft |
It's already been reviewed it just needs a second okay. Please help! |
| 10:15 |
|
gregon1 joined #minetest |
| 10:35 |
|
gregon joined #minetest |
| 11:09 |
|
micro_bowels joined #minetest |
| 11:19 |
|
tarsovbak joined #minetest |
| 11:24 |
|
gregon joined #minetest |
| 11:41 |
|
tarsovbak joined #minetest |
| 11:58 |
|
gregon joined #minetest |
| 12:08 |
Niklp |
Review != approval btw |
| 12:13 |
|
tarsovbak joined #minetest |
| 12:16 |
|
erstazi_ joined #minetest |
| 12:19 |
|
gregon joined #minetest |
| 12:19 |
|
d0p1 joined #minetest |
| 12:20 |
|
mrkubax10 joined #minetest |
| 12:24 |
|
Glaedr joined #minetest |
| 12:31 |
|
tarsovbak joined #minetest |
| 12:43 |
shaft |
Do you approve or not Niklp? |
| 13:23 |
|
grorp joined #minetest |
| 13:29 |
|
Trifton joined #minetest |
| 13:32 |
grorp |
shaft: these comments certainly don't sound like approval |
| 13:33 |
shaft |
Then what does he want? |
| 13:33 |
shaft |
He should tell me |
| 13:33 |
shaft |
It's a block on the roadmap of my texturepack |
| 13:34 |
shaft |
So I need to get it done |
| 13:34 |
shaft |
If he disapproves he should say: I disapprove, you should do it like that |
| 13:35 |
shaft |
Instead I'm stuck here talking to myself |
| 13:36 |
MTDiscord |
<warr1024> If you disapprove of their disapproval then you should probably say: I disapprove, you should disapprove like that |
| 13:36 |
MTDiscord |
<warr1024> Instead you're here talking to yourself |
| 13:38 |
MinetestBot |
[git] chmodsayshello -> minetest/minetest: Display background & moving progress bar on shutdown screen (#14597) ab783b9 https://github.com/minetest/minetest/commit/ab783b9bb2355a38de7e001f114dacfb03a312f3 (2024-05-21T13:37:35Z) |
| 13:38 |
MinetestBot |
[git] sfence -> minetest/minetest: Fix inventory: Quickly picking up item and placing it again no longer… b21a974 https://github.com/minetest/minetest/commit/b21a97434278eaeb8dfef806ab563f9f2b56842a (2024-05-21T13:38:12Z) |
| 13:40 |
shaft |
STOP BEATING AROUND THE BUSH |
| 13:47 |
MinetestBot |
[git] appgurueu -> minetest/minetest: Add unit test and feature flag for override_item 5009259 https://github.com/minetest/minetest/commit/50092594732dbdfc519a12e48ec837ec88c6e031 (2024-05-21T13:46:33Z) |
| 13:50 |
ROllerozxa |
Niklp: aren't you a member of the minetest-mods org? |
| 13:50 |
|
stormchaser3000 joined #minetest |
| 13:50 |
ROllerozxa |
unsure about the organisational structure there since I'm not in it |
| 13:51 |
Niklp |
yes, that's why I said my comments weren't an approval |
| 13:52 |
shaft |
Are they disapproval? What do I need to change? |
| 13:54 |
ROllerozxa |
Niklp: and what would be necessary for an approval? are there changes that need to be made or do you want someone else to give one approval? |
| 13:54 |
ROllerozxa |
assuming minetest-mods follows about the same merge rules as the engine does (two approvals then merge, dunno if that's what it follows) then if you approve but someone else reviews and has additional concerns then those can be voiced without it getting merged prematurely |
| 13:55 |
ROllerozxa |
also, maybe Krock (Smalljoker) could take a look at it |
| 13:56 |
shaft |
Thanks for helping me rollerozxa |
| 13:59 |
ROllerozxa |
no problem. |
| 14:06 |
|
tarsovbak joined #minetest |
| 14:07 |
definitelya |
shaft: hi |
| 14:07 |
shaft |
hi |
| 14:08 |
|
gregon joined #minetest |
| 14:09 |
|
olliy joined #minetest |
| 14:16 |
Niklp |
I think the new delayer model/texture is worse, everything else lgtm. This is very subjective, so I want someone else (SmallJoker?) to look at it. |
| 14:18 |
Niklp |
Usually only one approval is required, but I don't really know the rules (if they even exist...) |
| 14:26 |
|
tarsovbak joined #minetest |
| 14:27 |
|
gregon joined #minetest |
| 14:27 |
|
TheCoffeMaker joined #minetest |
| 14:29 |
shaft |
what kind of delayer would you like to see except how it currently is? |
| 14:30 |
|
definitelya left #minetest |
| 14:30 |
|
definitelya joined #minetest |
| 14:35 |
Niklp |
I think the current is pretty fine |
| 14:39 |
shaft |
It looks shit with any texture pack that isn't 16x16 |
| 14:44 |
MinetestBot |
[git] appgurueu -> minetest/minetest: Fix broken unit test 567f857 https://github.com/minetest/minetest/commit/567f85752de80d89559ca6dcedf58d684dc71710 (2024-05-21T14:31:05Z) |
| 15:01 |
|
ireallyhateirc joined #minetest |
| 15:10 |
|
jaca122 joined #minetest |
| 15:20 |
|
Kimapr joined #minetest |
| 15:53 |
|
gregon joined #minetest |
| 15:53 |
|
tarsovbak joined #minetest |
| 15:54 |
|
MintChipMadness joined #minetest |
| 15:54 |
MinetestBot |
[git] sfence -> minetest/minetest: Fix glitch through ceiling with Sneak Glitch (#14332) df8a600 https://github.com/minetest/minetest/commit/df8a600b228c93e0a2ab1ef40dfa250b0c994718 (2024-05-21T15:52:54Z) |
| 15:55 |
|
gregon1 joined #minetest |
| 15:57 |
|
gregon2 joined #minetest |
| 16:00 |
|
gregon joined #minetest |
| 16:10 |
MinetestBot |
[git] appgurueu -> minetest/minetest: Fix broken CI bd4572c https://github.com/minetest/minetest/commit/bd4572cfd129aa17b79f50f8c08719781d288e5e (2024-05-21T16:10:09Z) |
| 16:12 |
|
tarsovbak joined #minetest |
| 16:12 |
|
gregon joined #minetest |
| 16:27 |
|
MintChipMadness joined #minetest |
| 16:38 |
|
Thomas-S joined #minetest |
| 16:38 |
|
Thomas-S joined #minetest |
| 16:39 |
|
tarsovbak joined #minetest |
| 16:40 |
|
Elouin joined #minetest |
| 17:01 |
|
SFENCE joined #minetest |
| 17:26 |
|
olliy joined #minetest |
| 17:35 |
|
mrkubax10 joined #minetest |
| 17:37 |
|
Talkless joined #minetest |
| 17:44 |
|
PoochInquisitor joined #minetest |
| 17:55 |
|
MintChipMadness joined #minetest |
| 18:06 |
|
monstanner joined #minetest |
| 18:06 |
|
monstanner left #minetest |
| 18:17 |
|
SFENCE joined #minetest |
| 18:28 |
|
Miner34 joined #minetest |
| 18:30 |
|
Miner34 left #minetest |
| 18:39 |
|
stormchaser3000 joined #minetest |
| 19:52 |
|
silverwolf73828 joined #minetest |
| 20:29 |
|
stormchaser3000 joined #minetest |
| 20:55 |
|
MisterE123 joined #minetest |
| 20:59 |
|
nore joined #minetest |
| 21:02 |
|
MintChipMadness joined #minetest |
| 21:19 |
|
boingman joined #minetest |
| 21:40 |
|
Kimapr joined #minetest |
| 22:28 |
|
turtleman joined #minetest |
| 22:31 |
|
panwolfram joined #minetest |
| 22:48 |
|
big-MAC0 joined #minetest |
| 22:54 |
|
bodiccea joined #minetest |
| 23:16 |
|
sys4 joined #minetest |
