Time Nick Message 09:41 shaft Can someone review please? https://github.com/minetest-mods/mesecons/pull/669 10:06 shaft It's already been reviewed it just needs a second okay. Please help! 12:08 Niklp Review != approval btw 12:43 shaft Do you approve or not Niklp? 13:32 grorp shaft: these comments certainly don't sound like approval 13:33 shaft Then what does he want? 13:33 shaft He should tell me 13:33 shaft It's a block on the roadmap of my texturepack 13:34 shaft So I need to get it done 13:34 shaft If he disapproves he should say: I disapprove, you should do it like that 13:35 shaft Instead I'm stuck here talking to myself 13:36 MTDiscord If you disapprove of their disapproval then you should probably say: I disapprove, you should disapprove like that 13:36 MTDiscord Instead you're here talking to yourself 13:38 MinetestBot 02[git] 04chmodsayshello -> 03minetest/minetest: Display background & moving progress bar on shutdown screen (#14597) 13ab783b9 https://github.com/minetest/minetest/commit/ab783b9bb2355a38de7e001f114dacfb03a312f3 (152024-05-21T13:37:35Z) 13:38 MinetestBot 02[git] 04sfence -> 03minetest/minetest: Fix inventory: Quickly picking up item and placing it again no longer… 13b21a974 https://github.com/minetest/minetest/commit/b21a97434278eaeb8dfef806ab563f9f2b56842a (152024-05-21T13:38:12Z) 13:40 shaft STOP BEATING AROUND THE BUSH 13:47 MinetestBot 02[git] 04appgurueu -> 03minetest/minetest: Add unit test and feature flag for override_item 135009259 https://github.com/minetest/minetest/commit/50092594732dbdfc519a12e48ec837ec88c6e031 (152024-05-21T13:46:33Z) 13:50 ROllerozxa Niklp: aren't you a member of the minetest-mods org? 13:50 ROllerozxa unsure about the organisational structure there since I'm not in it 13:51 Niklp yes, that's why I said my comments weren't an approval 13:52 shaft Are they disapproval? What do I need to change? 13:54 ROllerozxa Niklp: and what would be necessary for an approval? are there changes that need to be made or do you want someone else to give one approval? 13:54 ROllerozxa assuming minetest-mods follows about the same merge rules as the engine does (two approvals then merge, dunno if that's what it follows) then if you approve but someone else reviews and has additional concerns then those can be voiced without it getting merged prematurely 13:55 ROllerozxa also, maybe Krock (Smalljoker) could take a look at it 13:56 shaft Thanks for helping me rollerozxa 13:59 ROllerozxa no problem. 14:07 definitelya shaft: hi 14:07 shaft hi 14:16 Niklp I think the new delayer model/texture is worse, everything else lgtm. This is very subjective, so I want someone else (SmallJoker?) to look at it. 14:18 Niklp Usually only one approval is required, but I don't really know the rules (if they even exist...) 14:29 shaft what kind of delayer would you like to see except how it currently is? 14:35 Niklp I think the current is pretty fine 14:39 shaft It looks shit with any texture pack that isn't 16x16 14:44 MinetestBot 02[git] 04appgurueu -> 03minetest/minetest: Fix broken unit test 13567f857 https://github.com/minetest/minetest/commit/567f85752de80d89559ca6dcedf58d684dc71710 (152024-05-21T14:31:05Z) 15:54 MinetestBot 02[git] 04sfence -> 03minetest/minetest: Fix glitch through ceiling with Sneak Glitch (#14332) 13df8a600 https://github.com/minetest/minetest/commit/df8a600b228c93e0a2ab1ef40dfa250b0c994718 (152024-05-21T15:52:54Z) 16:10 MinetestBot 02[git] 04appgurueu -> 03minetest/minetest: Fix broken CI 13bd4572c https://github.com/minetest/minetest/commit/bd4572cfd129aa17b79f50f8c08719781d288e5e (152024-05-21T16:10:09Z)