Minetest logo

IRC log for #minetest, 2022-11-06

| Channels | #minetest index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:36 proller joined #minetest
00:45 YuGiOhJCJ joined #minetest
00:47 fluxionary joined #minetest
00:57 smk joined #minetest
01:40 Verticen joined #minetest
01:47 Lesha_Vel joined #minetest
01:48 Lesha_Vel joined #minetest
02:16 justache joined #minetest
02:59 diceLibrarian joined #minetest
03:00 smk joined #minetest
03:02 vampirefrog joined #minetest
03:04 luk3yx joined #minetest
03:44 fluxionary joined #minetest
03:51 Krock joined #minetest
03:59 celeron55 joined #minetest
03:59 Izaya joined #minetest
03:59 wsor joined #minetest
03:59 Fulgen joined #minetest
03:59 behalebabo joined #minetest
03:59 Calinou joined #minetest
03:59 Mc joined #minetest
03:59 nuala joined #minetest
03:59 BuckarooBanzai joined #minetest
03:59 jojje joined #minetest
03:59 Mc joined #minetest
04:00 MTDiscord joined #minetest
04:00 cheapie joined #minetest
04:03 Norkle joined #minetest
04:03 asdflkj_sh joined #minetest
04:04 Pokey joined #minetest
04:04 search_social joined #minetest
04:04 illwieckz joined #minetest
04:04 simon816 joined #minetest
04:05 nogajun[m] joined #minetest
04:06 Tochigi joined #minetest
04:07 Parnikkapore_m joined #minetest
04:09 YuGiOhJCJ joined #minetest
04:10 giov4[m] joined #minetest
04:16 iamweasel joined #minetest
04:16 Evil joined #minetest
04:17 LandarVargan[m] joined #minetest
04:19 schwarzwald[m] joined #minetest
04:20 programmerjake joined #minetest
04:29 justache joined #minetest
04:32 Edgy2 joined #minetest
04:32 Fusl joined #minetest
04:34 Andrew joined #minetest
04:34 bigfoot547 joined #minetest
04:34 mpmc joined #minetest
04:35 Cork joined #minetest
04:42 izzyb joined #minetest
04:45 Lesha_Vel joined #minetest
05:05 Trifton joined #minetest
05:08 luk3yx joined #minetest
05:17 justache joined #minetest
05:19 fling joined #minetest
06:02 Fulgen- joined #minetest
06:08 search_social joined #minetest
06:09 jojje joined #minetest
06:20 illwieckz joined #minetest
06:24 grouinos joined #minetest
06:27 calcul0n joined #minetest
06:53 Oblomov joined #minetest
07:05 definitelya joined #minetest
07:12 luk3yx joined #minetest
07:30 sys4 joined #minetest
08:02 grouinos joined #minetest
08:02 TomTom joined #minetest
08:05 x2048 joined #minetest
08:05 Fulgen joined #minetest
08:12 fling joined #minetest
08:13 cranezhou joined #minetest
08:51 Markow joined #minetest
08:57 Oblomov joined #minetest
09:02 x2048 joined #minetest
09:09 Talkless joined #minetest
09:15 luk3yx joined #minetest
09:22 Warr10248 joined #minetest
09:34 eahm joined #minetest
10:04 Warr1024 joined #minetest
10:12 jluc joined #minetest
10:25 grouinos joined #minetest
10:43 Fixer joined #minetest
10:43 fling joined #minetest
10:47 MTDiscord <jordan4ibanez> Yeah I literally had to import it back into the current release
10:56 proller joined #minetest
10:57 fling joined #minetest
12:22 MTDiscord <Abdou-31> Does a PR need to be re-reviewed after rebasing?
12:25 rubenwardy Depends how much has changed, should have a look through and a retest
12:27 MTDiscord <Abdou-31> So there is no way to make sure that the new, post-rebase branch introduce exactly the same changes as the original pre-rebase set of commits?
12:27 rubenwardy You can compare the diffs but other stuff may have changed
12:28 MTDiscord <Abdou-31> Exactly
12:28 rubenwardy It's not a complete rereview, you don't need to start from scratch
12:28 MTDiscord <Abdou-31> Yep
12:29 MTDiscord <Abdou-31> In stack overflow, someone suggested the use of git diff-range
12:29 MTDiscord <Abdou-31> But its output is not straightforward it seems
12:32 MTDiscord <Abdou-31> So it does need to be re-reviewed... that's unfortunate. Because someone with bad intention can make a "good" PR, gets approvals, and when asked to rebase they can insert some malicious code between the lines
12:33 MTDiscord <Abdou-31> Wouldn't be nice if Github showed the difference in patches between pre and post rebases topic branches?
12:34 MTDiscord <Abdou-31> I mean rebasing topic branches is part of Github workflow, so why they didn't include such a feature? O.O
12:36 rubenwardy GitHub does
12:37 rubenwardy It allows you to compare changes when there is a force push
12:50 MTDiscord <Abdou-31> How please?
12:50 MTDiscord <Abdou-31> I did a force push
12:57 rubenwardy There's a compare button on the force push event
12:59 MTDiscord <Abdou-31> I mean
13:00 MTDiscord <Abdou-31> This is a simple comparaison
13:00 MTDiscord <Abdou-31> I was asking for comparing the patches introduced by the pre and post rebase branch, to ensure that the rebased one hasn't introduced something else than the original one
13:14 appguru joined #minetest
13:55 grouinos joined #minetest
14:03 fling joined #minetest
14:25 Thelie joined #minetest
14:33 orwell96 joined #minetest
14:50 calcul0n_ joined #minetest
15:05 kilbith joined #minetest
15:17 mazes_81 joined #minetest
15:17 mazes_81 any channel specific to mineclone2
15:19 calcul0n joined #minetest
15:50 kilbith https://www.youtube.com/watch?v=5YU28gkM1rA
15:53 MTDiscord <GreenXenith> Hello to you too ;p
16:53 aryak joined #minetest
17:13 Fixer_ joined #minetest
17:14 search_social joined #minetest
17:21 calcul0n_ joined #minetest
17:28 grouinos joined #minetest
17:33 MTDiscord <MisterE> kilbith, can you put player-specific cameras on the entity? The usecase is making a mirror that each player gets a different viewpoint depending on their position.
17:35 kilbith it will render what the camera sees
17:36 kilbith performance's pretty smooth btw
17:40 MisterE[m] what I mean is, can you set multiple cameras to the entity, one for each player. So, there is a camera for each player (set at the player's height + viewheight, and at the position of the mirror, and looking at the player). The different scenes get rendered for each player based on their own camera. Like, how a real mirror would work.
17:42 kilbith again, it renders what the camera sees from its POV, player-independent wise
17:42 kilbith so yes, you can have a mirror, although this needs some flipping
17:44 kilbith I'll only do that on entities, not nodes
17:45 kilbith nodes are a different story
17:54 TomTom joined #minetest
18:02 dash joined #minetest
18:02 mazes_83 joined #minetest
18:04 garywhite joined #minetest
18:04 garywhite joined #minetest
19:08 Verticen joined #minetest
19:14 diceLibrarian joined #minetest
19:20 search_social joined #minetest
19:21 MTDiscord <Jonathon> seems minetest indirectly reached front page of hackernews again https://tchncs.de/ includes the illuna minetest server, and also is the host for the minetest matrix room
19:31 lhofhansl joined #minetest
19:40 lhofhansl left #minetest
19:41 appguru joined #minetest
20:03 mazes_84 joined #minetest
20:30 proller joined #minetest
20:36 kilbith https://www.youtube.com/watch?v=rssVMF1UcPw
20:48 Fixer joined #minetest
21:17 garywhite1 joined #minetest
21:27 garywhite1 joined #minetest
21:29 Felfa joined #minetest
21:42 proller joined #minetest
22:32 proller joined #minetest
22:38 Verticen joined #minetest
22:39 cranezhou joined #minetest
23:04 Cork joined #minetest
23:05 Duvalon joined #minetest
23:24 dv^_^ joined #minetest
23:34 panwolfram joined #minetest

| Channels | #minetest index | Today | | Google Search | Plaintext