Time Nick Message 10:47 MTDiscord Yeah I literally had to import it back into the current release 12:22 MTDiscord Does a PR need to be re-reviewed after rebasing? 12:25 rubenwardy Depends how much has changed, should have a look through and a retest 12:27 MTDiscord So there is no way to make sure that the new, post-rebase branch introduce exactly the same changes as the original pre-rebase set of commits? 12:27 rubenwardy You can compare the diffs but other stuff may have changed 12:28 MTDiscord Exactly 12:28 rubenwardy It's not a complete rereview, you don't need to start from scratch 12:28 MTDiscord Yep 12:29 MTDiscord In stack overflow, someone suggested the use of git diff-range 12:29 MTDiscord But its output is not straightforward it seems 12:32 MTDiscord So it does need to be re-reviewed... that's unfortunate. Because someone with bad intention can make a "good" PR, gets approvals, and when asked to rebase they can insert some malicious code between the lines 12:33 MTDiscord Wouldn't be nice if Github showed the difference in patches between pre and post rebases topic branches? 12:34 MTDiscord I mean rebasing topic branches is part of Github workflow, so why they didn't include such a feature? O.O 12:36 rubenwardy GitHub does 12:37 rubenwardy It allows you to compare changes when there is a force push 12:50 MTDiscord How please? 12:50 MTDiscord I did a force push 12:57 rubenwardy There's a compare button on the force push event 12:59 MTDiscord I mean 13:00 MTDiscord This is a simple comparaison 13:00 MTDiscord I was asking for comparing the patches introduced by the pre and post rebase branch, to ensure that the rebased one hasn't introduced something else than the original one 15:17 mazes_81 any channel specific to mineclone2 15:50 kilbith https://www.youtube.com/watch?v=5YU28gkM1rA 15:53 MTDiscord Hello to you too ;p 17:33 MTDiscord kilbith, can you put player-specific cameras on the entity? The usecase is making a mirror that each player gets a different viewpoint depending on their position. 17:35 kilbith it will render what the camera sees 17:36 kilbith performance's pretty smooth btw 17:40 MisterE[m] what I mean is, can you set multiple cameras to the entity, one for each player. So, there is a camera for each player (set at the player's height + viewheight, and at the position of the mirror, and looking at the player). The different scenes get rendered for each player based on their own camera. Like, how a real mirror would work. 17:42 kilbith again, it renders what the camera sees from its POV, player-independent wise 17:42 kilbith so yes, you can have a mirror, although this needs some flipping 17:44 kilbith I'll only do that on entities, not nodes 17:45 kilbith nodes are a different story 19:21 MTDiscord seems minetest indirectly reached front page of hackernews again https://tchncs.de/ includes the illuna minetest server, and also is the host for the minetest matrix room 20:36 kilbith https://www.youtube.com/watch?v=rssVMF1UcPw