Minetest logo

IRC log for #minetest-dev, 2022-04-30

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
01:06 v-rob joined #minetest-dev
04:00 MTDiscord joined #minetest-dev
05:32 v-rob joined #minetest-dev
05:46 calcul0n joined #minetest-dev
06:57 Wuzzy joined #minetest-dev
08:01 proller joined #minetest-dev
08:05 Baytuch joined #minetest-dev
09:03 Fixer joined #minetest-dev
09:53 Zughy[m] Krock: can I close this? https://github.com/minetest/minetest/issues/11780
09:53 Zughy[m] *should
10:11 clavi joined #minetest-dev
10:11 clavi joined #minetest-dev
10:17 HuguesRoss joined #minetest-dev
10:21 erle Zughy[m] haha that issue is absolute bollocks
10:21 erle > There's a 1 in 2^32 -1 chance that you can play the same world without knowing it.
10:22 erle i don't see why it uses the lower 32 bit though, celeron55 do you have any idea?
10:35 MTDiscord <luatic> I would say the 1 of 2^32-1 chance of the player having a déjà vu effect is an intended easter egg :D
10:43 erle i would say if you mess with how the seed is applied to map generation, more than 1 in 2³² players are going to have a bad time
10:59 celeron55 i don't know why it's so. it was probably just left to whatever worked as there were other priorities
10:59 Zughy[m] I suggest to add a "UI/UX" label, for issues like this https://github.com/minetest/minetest/issues/12227
11:00 celeron55 i would probably recommend just getting rid of the rest of the bits where possible
11:03 celeron55 Zughy[m]: there's a "@ Mainmenu" label
11:03 celeron55 it's basically the same
11:06 Zughy[m] celeron55:  partially, because the user brings up three issues in one, where only issue C is about main menu, but all 3 are UX related
11:16 celeron55 it feels like there are too many labels already though
11:18 celeron55 well, i'll add it. any color preferences? 8)
11:19 celeron55 github randomized me yellow which is the same as formspec. i guess it's fine
11:45 erle i think just displaying the relevant part of the seed in the debug screen might be the appropriate solution?
11:45 erle i mean, the same seeds as before still need to function as inputs
11:45 erle for various reasons
11:45 erle or maybe doing nothing is the correct solution ^^
11:47 Zughy[m] celeron55: thank you! Actually, what's the Neglect Closure one? I've never seen that anywhere
11:48 Zughy[m] or Neglect Close, can't remember
11:52 MTDiscord <luatic> I'd guess it's applied to close PRs that are neglected?
11:53 MTDiscord <luatic> But yes, it hasn't been used yet
11:53 MTDiscord <luatic> (correction: only used 6 times: https://github.com/minetest/minetest/issues?q=label%3A%22Neglect+closure%22+is%3Aclosed)
12:01 Zughy[m] yeah, pretty useless though as it becomes redundant with possible close and action/change needed + the guidelines. Also, nobody uses it
14:24 Zughy[m] my job here is done, food for thought for the next meeting: https://forum.minetest.net/viewtopic.php?f=7&amp;t=28060
14:32 Zughy[m] 26 issues closed, I plan as a next step (prob after the next meeting) to label all those issues that went unnoticed (0 comments and default tag only)
14:33 sfan5 that would be useful, thanks
14:41 sfan5 merging #12243 in 5m
14:41 ShadowBot https://github.com/minetest/minetest/issues/12243 -- [no squash] Enable a few more compiler warnings by sfan5
15:02 sfan5 I will cherry pick some commits to a 'backport-5' branch later so server owners have something they can easily use
15:02 sfan5 (but unless there is significant support for it this won't mean a 5.5.1)
15:52 josiah_wi joined #minetest-dev
15:54 josiah_wi Hi. I'm doing some experimentation with the Minetest project structure, and I discovered that the node and item definitions depend on the client tile definition.
15:54 josiah_wi I'm very interested in why this was done this way and whether there's a better way to do it.
17:45 erle Zughy[m] what does “need feedback” mean for #11742?
17:45 ShadowBot https://github.com/minetest/minetest/issues/11742 -- Creating float vector with x outside of -2.14748e+06 < x < 2.14748e+06 crashes server
17:50 erle i mean it is a crash and arguably an API smell and i don't know what else could be added to the issue
18:35 x2048 joined #minetest-dev
19:06 v-rob joined #minetest-dev
19:07 appguru joined #minetest-dev
20:14 sfan5 backport branch created as promised
20:15 sfan5 josiah_wi: what do you mean by "depend on the client tile definitions"?
20:37 erle sfan5 could you share a list of the important commits on master so i can forward it to debian ppl?
20:37 erle like if there is more than the auth thing
20:37 erle you'd want them to use
20:37 sfan5 do you want me to tell you the current time of day too
20:39 sfan5 (that's a "no, run git log yourself")
20:40 erle i admit, i wanted to save work because you did not keep the old commit ids in the backport-5 branch
20:40 erle i'm looking at the log
20:40 erle sorry
21:27 x2048 joined #minetest-dev
21:28 x2048 If anyone has time, #12254 is a trivial fix for #12245
21:28 ShadowBot https://github.com/minetest/minetest/issues/12254 -- Initialize wield mesh colors when changing item. by x2048
21:28 ShadowBot https://github.com/minetest/minetest/issues/12245 -- Wield images not colored correctly
22:32 panwolfram joined #minetest-dev
22:34 Zughy[m] Wuzzy: any chance you're gonna rebase #11463? I'd feel bad to put a "Possible close" after you already went through a rebase
22:34 ShadowBot https://github.com/minetest/minetest/issues/11463 -- Add many limits to settingtypes by Wuzzy2
22:45 fluxionary joined #minetest-dev
23:05 hlqkj joined #minetest-dev
23:05 Zughy[m] well, there were a lot of "rebase needed" PRs where the label was several months old (like, from 2021, sometimes 2020), so I've put a "possible close" to each one of them. Currently, there are 22 PRs out of 115 that could be possibly close in a month, so... well, that's a lot
23:06 Baytuch joined #minetest-dev
23:11 erle Zughy[m] how many of those can be effortlessly rebased?
23:11 erle Zughy[m], like, without conflicts
23:11 Zughy[m] I'm also warning the author in every PR with a "Supported by core dev" label, just in case they want to actually rebase
23:11 Zughy[m] I have no idea
23:11 erle wouldn't it make sense to warn every author? you don't get mail when a label is added AFAIK
23:12 erle like they might not even notice
23:14 Toothless joined #minetest-dev
23:14 Zughy[m] in some PRs is kinda useless, like #11175, where someone warned them almost a year ago
23:14 ShadowBot https://github.com/minetest/minetest/issues/11175 -- Add transfer_player function to request client move to new server by grapereader
23:17 AliasStillTaken joined #minetest-dev
23:39 calcul0n joined #minetest-dev
23:43 v-rob joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext