| Time |
Nick |
Message |
| 00:12 |
|
v-rob joined #minetest-dev |
| 00:52 |
|
Toothless joined #minetest-dev |
| 01:58 |
|
v-rob joined #minetest-dev |
| 02:02 |
|
behalebabo joined #minetest-dev |
| 02:04 |
rubenwardy |
Zughy[m]: btw, pr authors don't get notifications just from labels, it's a good idea to comment as well if their attention is needed |
| 02:16 |
paradust |
Are servers allowed to make arbitrary http requests from the client? |
| 02:18 |
paradust |
I mean, can they send code/requests that cause clients to make http requests |
| 02:27 |
MTDiscord |
<Jonathon> sscsm doesnt exist yet, outside of a few mods. |
| 02:27 |
MTDiscord |
<Jonathon> remote media servers might causes clients to request the media from that server? im not sure |
| 02:29 |
rubenwardy |
Yeah, remote media causes clients to make http requests |
| 02:29 |
rubenwardy |
But not especially arbitrary |
| 02:30 |
rubenwardy |
Not sure how much clients validate hashes. Maybe you could inject paths like thst |
| 02:42 |
erle |
wdym “inject paths” |
| 02:43 |
paradust |
hm. When I connect to certain servers from web, I see http requests to random urls |
| 02:44 |
paradust |
(from emscripten/web build) |
| 02:51 |
paradust |
to clarify, random hostnames (like one was "minetest.daconcepts.com"). I don't have the full url. I just noticed this in the proxy log, since it rejects everything that isn't (servers/content).minetest.net |
| 02:55 |
MTDiscord |
<Jonathon> That's remote media server that doesn't exist anymore |
| 02:56 |
MTDiscord |
<Jonathon> Sofars is still up I think |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:27 |
|
v-rob joined #minetest-dev |
| 05:07 |
paradust |
There's a strange problem happening on Catlandia, where every minute or so it sends a very large TOCLIENT_BLOCKDATA packet |
| 05:08 |
paradust |
packet size 14,754,746 bytes |
| 05:08 |
paradust |
it freezes the game for several seconds while the packet processes |
| 05:08 |
paradust |
is this a known server issue, or is it likely they just messed it up on their own? |
| 05:29 |
paradust |
apparently this is the attack that's been happening and I've not been paying attention |
| 06:41 |
MTDiscord |
<LandarVargan> Is it related to itemstack meta? Try to find the block |
| 06:44 |
erle |
i don't think you can have such a large itemstack meta |
| 06:45 |
erle |
might be a lot of items in chests or what? |
| 06:48 |
|
calcul0n joined #minetest-dev |
| 08:18 |
|
Fixer joined #minetest-dev |
| 08:26 |
paradust |
I was able to identify the cursed block/item. Removing it will be another matter. (a problem for the server mods) |
| 08:26 |
paradust |
When I tried to pick it up it restarted the server, kicked everyone. |
| 08:28 |
luk3yx |
paradust: Are you still in-game? |
| 08:28 |
paradust |
not at the moment |
| 08:29 |
luk3yx |
Do you have the co-ordinates of the item or something? |
| 08:29 |
paradust |
yea one sec |
| 08:29 |
luk3yx |
Okay, thanks |
| 08:30 |
paradust |
can I PM on discord or irc? |
| 08:30 |
luk3yx |
IRC would be better |
| 08:48 |
|
appguru joined #minetest-dev |
| 08:48 |
appguru |
GitHub build actions seem to be falling apart |
| 08:48 |
appguru |
See f.E. https://github.com/minetest/minetest.github.io/runs/6245739642?check_suite_focus=true |
| 08:48 |
appguru |
"E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/c/curl/libcurl4-openssl-dev_7.68.0-1ubuntu2.7_amd64.deb 404 Not Found [IP: 52.154.174.208 80]" |
| 08:50 |
appguru |
Or https://github.com/appgurueu/minetest/runs/6245758911?check_suite_focus=true: |
| 08:50 |
appguru |
"The following packages have unmet dependencies: |
| 08:50 |
appguru |
postgresql-server-dev-all : Depends: postgresql-common (>= 117~) but it is not going to be installed |
| 08:50 |
appguru |
Depends: postgresql-server-dev-10 but it is not going to be installed |
| 08:50 |
appguru |
E: Unable to correct problems, you have held broken packages. |
| 08:50 |
appguru |
Error: Process completed with exit code 100." |
| 09:23 |
sfan5 |
microsoft ? |
| 09:25 |
sfan5 |
erle: the rebase label is added if there *are* conflicts |
| 09:27 |
appguru |
Anyways, luk3yx has made a PR that fixes the issue: https://github.com/minetest/minetest.github.io/pull/251 |
| 09:27 |
luk3yx |
And reveals another issue |
| 09:27 |
appguru |
(https://packages.gentoo.org/packages/games-action/minetest throwing 502 Bad Gateway) |
| 09:27 |
sfan5 |
actually |
| 09:27 |
appguru |
but I hope that the latter is only temporary |
| 09:27 |
sfan5 |
you're supposed to run apt-get update |
| 09:28 |
sfan5 |
...yeah |
| 09:28 |
appguru |
merge it is |
| 09:30 |
appguru |
https://github.com/minetest/minetest/blob/master/.github/workflows/cpp_lint.yml#L49 has the same problem |
| 09:30 |
appguru |
(apt install without apt update before) |
| 09:33 |
appguru |
this doesn't look good |
| 09:34 |
appguru |
doing grep -r "apt-get install" and comparing that against grep -r "apt-get update" shows that 1. there are many variants of apt-get update around in our scripts (-q, -qy, without flags) and 2. some apt-get installs are missing apt-get updates |
| 09:37 |
sfan5 |
I don't think -q or the second -y actually does anything |
| 10:35 |
|
HuguesRoss joined #minetest-dev |
| 13:20 |
sfan5 |
appguru: #12255 |
| 13:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/12255 -- Sort out some issues with our CI setup by sfan5 |
| 13:25 |
MTDiscord |
<luatic> looks good |
| 15:00 |
|
HuguesRoss joined #minetest-dev |
| 18:52 |
|
v-rob joined #minetest-dev |
| 19:24 |
|
v-rob joined #minetest-dev |
| 21:28 |
|
v-rob joined #minetest-dev |
| 21:59 |
Zughy[m] |
luatic: did you contact celeron for the triager thing? I'd really like a hand with the "unconfirmed bug" things, as I'm right now focusing on labels in general |
| 22:32 |
|
panwolfram joined #minetest-dev |
| 22:50 |
Zughy[m] |
so, I've cleaned up all the "Adoption needed" labels to actually make them useful to people that want to resume a closed PR (and to MisterE, for the blog). I know it doesn't sound great, but it'd be nice if core devs went through the remaining 12 to actually evaluate if they still want to see those PRs eventually happen or not. Link: https://github.com/minetest/minetest/pulls?page=1&q=is%3Apr+label%3A%22Adoption+needed%22+is%3Aclosed |
| 23:16 |
|
AliasAlreadyTake joined #minetest-dev |
