| Time |
Nick |
Message |
| 00:01 |
|
v-rob joined #minetest-dev |
| 00:41 |
|
MTDiscord joined #minetest-dev |
| 01:27 |
MTDiscord |
<exe_virus> Oh, hurm, just expose the SDL scancode name rather than the keysym name? |
| 01:28 |
MTDiscord |
<exe_virus> For qwerty users it won't matter, and for everyone else, they won't be surprised |
| 03:08 |
|
Toothless joined #minetest-dev |
| 03:13 |
|
v-rob joined #minetest-dev |
| 03:37 |
|
v-rob joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:05 |
|
erle joined #minetest-dev |
| 04:26 |
|
dzho joined #minetest-dev |
| 05:53 |
|
calcul0n joined #minetest-dev |
| 07:13 |
|
v-rob joined #minetest-dev |
| 09:18 |
|
appguru joined #minetest-dev |
| 09:51 |
|
CoolJar10 joined #minetest-dev |
| 09:51 |
CoolJar10 |
Aa |
| 09:59 |
sfan5 |
Bb |
| 10:08 |
MTDiscord |
<luatic> Cc |
| 10:21 |
|
qur joined #minetest-dev |
| 10:21 |
|
HuguesRoss joined #minetest-dev |
| 10:38 |
|
Fixer joined #minetest-dev |
| 11:12 |
|
Fixer_ joined #minetest-dev |
| 12:11 |
|
proller joined #minetest-dev |
| 13:00 |
|
Taoki joined #minetest-dev |
| 13:20 |
|
Taoki joined #minetest-dev |
| 13:29 |
|
Toothless joined #minetest-dev |
| 15:00 |
|
Toothless joined #minetest-dev |
| 15:05 |
sfan5 |
reminder that some bigger PRs need reviews #11545 #11131 #10100 #8679 (though that one was recently discussed) |
| 15:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/11545 -- Animated particlespawners by velartrill |
| 15:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/11131 -- [MANUAL MERGE] Async environment for mods to do concurrent tasks by sfan5 |
| 15:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/10100 -- Additional texture modifiers by Treer |
| 15:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/8679 -- Add FormSpec key and mouse events by v-rob |
| 15:43 |
rubenwardy |
the async PR is high quality |
| 15:43 |
rubenwardy |
I like the devtest tests |
| 15:51 |
sfan5 |
there should be more tests of engine functionality like this |
| 15:52 |
rubenwardy |
yeah definitely |
| 15:57 |
rubenwardy |
merging #11876 in 5 |
| 15:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/11876 -- Update mods_here.txt to mention installing mods via CDB by qwerty123a2 |
| 16:19 |
rubenwardy |
why are there multiple packers? |
| 16:20 |
sfan5 |
what |
| 16:24 |
rubenwardy |
ohh it's per userdata/etc |
| 16:25 |
sfan5 |
each userdata can have (un)packing callbacks, other types don't need it |
| 16:52 |
rubenwardy |
this PR is huge |
| 16:52 |
rubenwardy |
checks position half way through. Yay? |
| 16:53 |
|
Toothless joined #minetest-dev |
| 17:09 |
rubenwardy |
ok done a first pass, will try it out later |
| 17:30 |
|
Toothless joined #minetest-dev |
| 18:47 |
paradust |
sfan5: I just noticed... https://github.com/minetest/minetest/blob/master/src/terminal_chat_console.cpp#L97 |
| 18:48 |
sfan5 |
does that no longer work with your changes? |
| 18:48 |
paradust |
The LL_TRACE level would now be included in this. That might be the desired result, because previously that would only happen if --trace was also given on the command-line |
| 18:48 |
paradust |
It will be more noisy |
| 18:48 |
sfan5 |
ah, doesn't matter |
| 18:48 |
paradust |
Should I make it do the old behavior you think? |
| 18:48 |
paradust |
ah ok |
| 18:48 |
paradust |
*be an undesired |
| 18:50 |
Krock |
it would be so much easier to offload those particle animations to CSM with basically zero additional operator/function parsing libraries |
| 18:50 |
Krock |
(context: animated particle spawners) |
| 19:17 |
Zughy[m] |
celeron55: can you look at your Matrix account when you have a chance? |
| 19:18 |
celeron55 |
in a moment |
| 19:20 |
|
x2048 joined #minetest-dev |
| 19:23 |
celeron55 |
ok so, i would like to add Zughy as a triager on github, any objections? |
| 19:24 |
MTDiscord |
<Jonathon> no objections from me. |
| 19:25 |
sfan5 |
sure |
| 19:25 |
sfan5 |
as in "no objection" |
| 19:42 |
celeron55 |
added |
| 19:49 |
rubenwardy |
sure |
| 20:34 |
|
YuGiOhJCJ joined #minetest-dev |
| 21:05 |
|
MTDiscord1 joined #minetest-dev |
| 21:18 |
erle |
celeron55 is the role of triager defined somewhere? are there more people than zughy? from what i understand, it is just marking bugs as “confirmed” right? |
| 21:19 |
Zughy[m] |
I'm mostly closing "possible close" issues for now, following these guidelines https://dev.minetest.net/Git_Guidelines#Issue_and_Pull-Request_Management |
| 21:21 |
Zughy[m] |
I think Wuzzy and wsor are the other ones |
| 21:22 |
erle |
well i hope you are careful with that, given that some people use possible close for both “i don't want to deal with this” and “i do not believe this issue exists” (even in the face of evidence) |
| 21:24 |
erle |
Zughy[m] can you also remove “possible close”, i.e. from this, once you confirmed it? it's a reproducible crash: https://github.com/minetest/minetest/issues/11742 |
| 21:25 |
Zughy[m] |
My role is to apply those guidelines, if nobody said anything within one month after putting the label, I just close it |
| 21:25 |
erle |
oh lol |
| 21:26 |
Zughy[m] |
(which is not the case of that issue) |
| 21:26 |
erle |
uh, but it has not been active for over a month. you mean over a month after the label was applied? |
| 21:28 |
erle |
because in the latter case it doesn't really matter to me ig |
| 21:29 |
erle |
but the thing above is not the only crash that was marked with “possible close” instead of “confirmed” where i think the reason is not wenting to fix the crash |
| 21:29 |
Zughy[m] |
yes, I see that the label as a "ok, we're gonna close this unless someone can prove us that this shouldn'be closed" |
| 21:29 |
erle |
ah okay |
| 21:29 |
erle |
then i guess the amount and quality of comments *after* the possible close matter |
| 21:31 |
erle |
i just don't want minetests issue tracker to turn into the kubernetes or mindustry issue trackers. the former closes everything after 90 (?) days of inactivity (even if confirmed), the latter closes everything that can not be confirmed within a very short time period. sorry for being so sceptical, i wish you great success! |
| 21:32 |
erle |
Zughy[m], just to confirm: you wouldn't close this one either, right? https://github.com/minetest/minetest/issues/11829 |
| 21:32 |
wsor |
to clarify, wuzzy and caloun are triagers |
| 21:33 |
wsor |
i am not |
| 21:35 |
wsor |
*Calinou |
| 21:35 |
Zughy[m] |
erle: that's up to core devs to decide, it requires techincal knowledge, I won't touch it. It feels like something to discuss on meetings, but I might be wrong |
| 21:39 |
erle |
Zughy[m] if that is your standard of being careful, i am not worried! :) |
| 21:56 |
MTDiscord |
<luatic> Can I get a triager role too? |
| 21:57 |
rubenwardy |
I think Triagers should also be able to do unconfirmed -> confirmed if they're able to reproduce it |
| 21:57 |
MTDiscord |
<luatic> ^ |
| 21:57 |
MTDiscord |
<luatic> that's what I would like the role for |
| 21:57 |
MTDiscord |
<luatic> I already raised the issue of too damn many unconfirmed bugs™️ a while ago |
| 22:01 |
erle |
i can't promise i would do too much (basically i only want to reproduce), but i have also complained about unconfirmed bugs. i would, of course, never mark my own bugs as confirmed, even if they stay unconfirmed after months despite having clear repro instructions. and i would obv never want to close issues. |
| 22:02 |
erle |
so can i have the role too? limited to reproducing things and setting unconfirmed to confirmed only. |
| 22:02 |
erle |
(but only if you are okay with me doing 8 bugs in a week and then nothing for 2 or 3 weeks) |
| 22:24 |
|
proller joined #minetest-dev |
| 22:28 |
Zughy[m] |
pointing out that as a triager I can't edit issues titles nor edit people's comments. It would help for issues like #12235 |
| 22:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/12235 -- I can't open Mindset on my Macbook |
| 22:33 |
|
panwolfram joined #minetest-dev |
| 23:18 |
|
AliasAlreadyTake joined #minetest-dev |
