| Time |
Nick |
Message |
| 00:12 |
|
behalebabo joined #minetest-dev |
| 00:16 |
|
kaeza joined #minetest-dev |
| 00:22 |
|
benrob0329 joined #minetest-dev |
| 00:47 |
|
ANAND joined #minetest-dev |
| 00:55 |
|
paramat joined #minetest-dev |
| 01:12 |
|
Lone-Star joined #minetest-dev |
| 01:46 |
|
argyle77 joined #minetest-dev |
| 02:59 |
|
benrob0329 joined #minetest-dev |
| 04:38 |
|
Ruslan1 joined #minetest-dev |
| 06:21 |
|
Darcidride joined #minetest-dev |
| 06:32 |
nerzhul |
please release this weekend we can release 5.0.2 later, 1 week later if needed |
| 08:08 |
|
Darcidride joined #minetest-dev |
| 08:30 |
|
karamel joined #minetest-dev |
| 08:51 |
|
kaeza joined #minetest-dev |
| 08:54 |
|
YuGiOhJCJ joined #minetest-dev |
| 09:50 |
|
proller joined #minetest-dev |
| 10:02 |
|
Fixer joined #minetest-dev |
| 10:50 |
|
proller joined #minetest-dev |
| 11:20 |
|
proller joined #minetest-dev |
| 12:14 |
|
calcul0n joined #minetest-dev |
| 12:16 |
|
twoelk joined #minetest-dev |
| 13:06 |
|
calcul0n joined #minetest-dev |
| 13:36 |
|
Icedream joined #minetest-dev |
| 13:38 |
|
Icedream joined #minetest-dev |
| 13:47 |
|
Icedream joined #minetest-dev |
| 13:55 |
ANAND |
Is the connection between a client and server established by the time the client sends `TOSERVER_CLIENT_READY`? |
| 13:56 |
sfan5 |
what do you mean and why are you asking this question? |
| 13:58 |
ANAND |
https://github.com/minetest/minetest/pull/7557#issuecomment-478006996 |
| 13:58 |
ANAND |
Sorry for not being able to put it in better words :) |
| 13:59 |
ANAND |
I'm not much of an expert in this area, I'm afraid. I just wanted to know if `TOSERVER_CLIENT_READY` is a good option for reporting the FOV to the server. |
| 14:00 |
ANAND |
Is there any specific point in the connection process, when the connection is said to be established? |
| 14:00 |
ANAND |
Or does that not matter for my purpose? |
| 14:02 |
nerzhul |
the ready state is for the session itself, to define client has finished loading |
| 14:02 |
nerzhul |
it's not good to report client FOV which is a setting |
| 14:06 |
|
Icedream joined #minetest-dev |
| 14:58 |
|
Icedream joined #minetest-dev |
| 15:02 |
|
YuGiOhJCJ joined #minetest-dev |
| 15:09 |
ANAND |
I agree that isn't the best way, but FOV can't be changed during runtime, which is why I thought this would be possible. |
| 15:09 |
|
epod joined #minetest-dev |
| 15:11 |
ANAND |
Client's FOV is required for providing a very similar experience to all players. Setting a client's FOV to a fixed value without taking their current FOV into consideration won't be of much help in providing a uniform experience to all clients. |
| 15:11 |
ANAND |
See https://github.com/minetest/minetest/pull/7557#issuecomment-477824551 |
| 15:13 |
sfan5 |
>This logic can be applied to many APIs, and would lead to combinable modifiers for many APIs, which we cannot do, and is unnecessary, almost all of the APIs work fine as they are. |
| 15:13 |
sfan5 |
I disagree with this entirely |
| 15:14 |
sfan5 |
the fact that barely any APIs allow modifiers and just provide a way to set a value is a problem and should be fixed |
| 15:15 |
sfan5 |
having multiple mods work correctly together is hard if the API does not provide the correct means |
| 15:15 |
ANAND |
I agree |
| 15:16 |
sfan5 |
>We have to be very careful about adding completely unnecessary fancy features and luxuries. |
| 15:16 |
sfan5 |
also this |
| 15:17 |
sfan5 |
someone else (you) has already made the effort of programming an implementation, if it is up to our standards and considered useful by the coredevs there are few reasons not to merge it |
| 15:17 |
sfan5 |
it's not like these require constant maintenance once added |
| 15:18 |
|
Icedream joined #minetest-dev |
| 15:19 |
ANAND |
I'm unsure of it's mergeability at the moment - it either needs the player's FOV on join, or it has to work with modifiers. Otherwise, there's no way to provide the experience of a 4x scope (for example) to all players in a consistent, uniform manner. |
| 15:19 |
sfan5 |
ANAND: btw, please don't mix style fixes into your PRs |
| 15:20 |
sfan5 |
(for code you are not touching, obviously) |
| 15:20 |
ANAND |
I realized my folly. Won't repeat it again :) |
| 15:20 |
ANAND |
That's the main reason why 7557 is a mess |
| 15:21 |
ANAND |
Haven't repeated it in 8409, for example :) |
| 15:21 |
|
Icedream joined #minetest-dev |
| 15:24 |
|
Icedream joined #minetest-dev |
| 15:43 |
ANAND |
I just noticed the CSMRestrictions enum is defined in networkprotocol.h |
| 15:44 |
ANAND |
Isn't that a little out-of-place? |
| 15:44 |
|
Icedream joined #minetest-dev |
| 15:45 |
|
Icedream joined #minetest-dev |
| 15:47 |
|
Icedream joined #minetest-dev |
| 15:48 |
|
Icedream joined #minetest-dev |
| 15:50 |
|
Icedream joined #minetest-dev |
| 15:51 |
|
Icedream joined #minetest-dev |
| 15:51 |
|
kaeza joined #minetest-dev |
| 15:57 |
|
Megaf joined #minetest-dev |
| 15:58 |
|
Icedream joined #minetest-dev |
| 16:01 |
ANAND |
https://github.com/minetest/minetest/pull/8409/commits/c02270e5d9e789e0dc4fe001da15b84085e3192d#diff-ad60d65b34e16a3319296bb5d683acd6L1873 |
| 16:01 |
ANAND |
lol :P |
| 16:02 |
ANAND |
Just committed a bunch of minor fixes in 8409, and it finally compiled without errors. |
| 16:03 |
ANAND |
Tested the camera mode restrictions using the `luacmd` mod, and they work perfectly fine |
| 16:03 |
ANAND |
nrz's suggestions and documentation are the only things left to do as of now |
| 16:04 |
ANAND |
Could the WIP label be removed if possible? |
| 16:05 |
|
Icedream joined #minetest-dev |
| 16:07 |
|
Icedream joined #minetest-dev |
| 16:08 |
|
calcul0n_ joined #minetest-dev |
| 16:09 |
|
Edroen joined #minetest-dev |
| 16:10 |
|
Megaf_ joined #minetest-dev |
| 16:16 |
|
kaeza joined #minetest-dev |
| 16:21 |
|
GreenDimond joined #minetest-dev |
| 16:36 |
|
Icedream joined #minetest-dev |
| 16:44 |
|
Ruslan1 joined #minetest-dev |
| 16:51 |
|
Ruslan1_ joined #minetest-dev |
| 16:53 |
|
proller joined #minetest-dev |
| 16:53 |
|
Ruslan1_ left #minetest-dev |
| 16:54 |
|
Ruslan1 joined #minetest-dev |
| 16:56 |
|
Ruslan1 joined #minetest-dev |
| 16:59 |
|
Sofie joined #minetest-dev |
| 17:01 |
|
twoelk left #minetest-dev |
| 17:01 |
|
JDCodeIt joined #minetest-dev |
| 17:09 |
|
jexi joined #minetest-dev |
| 17:21 |
|
Icedream joined #minetest-dev |
| 17:24 |
|
tzh joined #minetest-dev |
| 17:27 |
|
Icedream joined #minetest-dev |
| 17:35 |
|
Icedream joined #minetest-dev |
| 17:43 |
|
roben1430 joined #minetest-dev |
| 17:45 |
|
ensonic joined #minetest-dev |
| 17:50 |
|
Icedream joined #minetest-dev |
| 18:03 |
|
Icedream joined #minetest-dev |
| 18:04 |
|
Icedream joined #minetest-dev |
| 18:05 |
|
Icedream joined #minetest-dev |
| 18:07 |
|
Icedream joined #minetest-dev |
| 18:15 |
|
Fixer_ joined #minetest-dev |
| 18:28 |
|
Icedream joined #minetest-dev |
| 18:47 |
|
Icedream joined #minetest-dev |
| 18:52 |
|
Icedream joined #minetest-dev |
| 18:54 |
|
DI3HARD139 joined #minetest-dev |
| 19:13 |
|
Icedream joined #minetest-dev |
| 19:35 |
|
ensonic joined #minetest-dev |
| 19:48 |
|
Ruslan1 joined #minetest-dev |
| 19:59 |
|
Icedream joined #minetest-dev |
| 20:01 |
|
Icedream joined #minetest-dev |
| 20:06 |
|
Icedream joined #minetest-dev |
| 20:06 |
|
Icedream joined #minetest-dev |
| 20:24 |
|
Nutty8 joined #minetest-dev |
| 20:47 |
|
Icedream joined #minetest-dev |
| 20:50 |
|
Icedream joined #minetest-dev |
| 20:51 |
|
Icedream joined #minetest-dev |
| 20:53 |
|
Icedream joined #minetest-dev |
| 21:04 |
|
Icedream joined #minetest-dev |
| 21:09 |
|
Icedream joined #minetest-dev |
| 21:16 |
|
Icedream joined #minetest-dev |
| 21:19 |
|
Icedream joined #minetest-dev |
| 21:22 |
|
kaeza joined #minetest-dev |
| 21:23 |
|
Icedream joined #minetest-dev |
| 21:25 |
|
Icedream joined #minetest-dev |
| 21:25 |
|
Icedream joined #minetest-dev |
| 21:29 |
|
Icedream joined #minetest-dev |
| 21:52 |
|
Icedream joined #minetest-dev |
| 21:55 |
|
Icedream joined #minetest-dev |
| 21:56 |
|
Icedream joined #minetest-dev |
| 21:59 |
|
Icedream joined #minetest-dev |
| 21:59 |
|
Icedream joined #minetest-dev |
| 22:27 |
|
Icedream joined #minetest-dev |
| 22:28 |
|
Icedream joined #minetest-dev |
| 22:31 |
|
Icedream joined #minetest-dev |
| 22:41 |
|
Icedream joined #minetest-dev |
| 22:42 |
|
Cornelia joined #minetest-dev |
| 22:43 |
|
Icedream joined #minetest-dev |
| 22:43 |
|
Icedream joined #minetest-dev |
| 22:57 |
|
sacxy joined #minetest-dev |
| 23:17 |
|
Lone-Star joined #minetest-dev |
| 23:35 |
|
Icedream joined #minetest-dev |
| 23:39 |
|
Icedream joined #minetest-dev |
| 23:43 |
|
Icedream joined #minetest-dev |
| 23:48 |
|
Icedream joined #minetest-dev |
