Time  Nick    Message
06:32 nerzhul please release this weekend we can release 5.0.2 later, 1 week later if needed
13:55 ANAND   Is the connection between a client and server established by the time the client sends `TOSERVER_CLIENT_READY`?
13:56 sfan5   what do you mean and why are you asking this question?
13:58 ANAND   https://github.com/minetest/minetest/pull/7557#issuecomment-478006996
13:58 ANAND   Sorry for not being able to put it in better words :)
13:59 ANAND   I'm not much of an expert in this area, I'm afraid. I just wanted to know if `TOSERVER_CLIENT_READY` is a good option for reporting the FOV to the server.
14:00 ANAND   Is there any specific point in the connection process, when the connection is said to be established?
14:00 ANAND   Or does that not matter for my purpose?
14:02 nerzhul the ready state is for the session itself, to define client has finished loading
14:02 nerzhul it's not good to report client FOV which is a setting
15:09 ANAND   I agree that isn't the best way, but FOV can't be changed during runtime, which is why I thought this would be possible.
15:11 ANAND   Client's FOV is required for providing a very similar experience to all players. Setting a client's FOV to a fixed value without taking their current FOV into consideration won't be of much help in providing a uniform experience to all clients.
15:11 ANAND   See https://github.com/minetest/minetest/pull/7557#issuecomment-477824551
15:13 sfan5   >This logic can be applied to many APIs, and would lead to combinable modifiers for many APIs, which we cannot do, and is unnecessary, almost all of the APIs work fine as they are.
15:13 sfan5   I disagree with this entirely
15:14 sfan5   the fact that barely any APIs allow modifiers and just provide a way to set a value is a problem and should be fixed
15:15 sfan5   having multiple mods work correctly together is hard if the API does not provide the correct means
15:15 ANAND   I agree
15:16 sfan5   >We have to be very careful about adding completely unnecessary fancy features and luxuries.
15:16 sfan5   also this
15:17 sfan5   someone else (you) has already made the effort of programming an implementation, if it is up to our standards and considered useful by the coredevs there are few reasons not to merge it
15:17 sfan5   it's not like these require constant maintenance once added
15:19 ANAND   I'm unsure of it's mergeability at the moment - it either needs the player's FOV on join, or it has to work with modifiers. Otherwise, there's no way to provide the experience of a 4x scope (for example) to all players in a consistent, uniform manner.
15:19 sfan5   ANAND: btw, please don't mix style fixes into your PRs
15:20 sfan5   (for code you are not touching, obviously)
15:20 ANAND   I realized my folly. Won't repeat it again :)
15:20 ANAND   That's the main reason why 7557 is a mess
15:21 ANAND   Haven't repeated it in 8409, for example :)
15:43 ANAND   I just noticed the CSMRestrictions enum is defined in networkprotocol.h
15:44 ANAND   Isn't that a little out-of-place?
16:01 ANAND   https://github.com/minetest/minetest/pull/8409/commits/c02270e5d9e789e0dc4fe001da15b84085e3192d#diff-ad60d65b34e16a3319296bb5d683acd6L1873
16:01 ANAND   lol :P
16:02 ANAND   Just committed a bunch of minor fixes in 8409, and it finally compiled without errors.
16:03 ANAND   Tested the camera mode restrictions using the `luacmd` mod, and they work perfectly fine
16:03 ANAND   nrz's suggestions and documentation are the only things left to do as of now
16:04 ANAND   Could the WIP label be removed if possible?