Time |
Nick |
Message |
01:13 |
|
YuGiOhJCJ joined #minetest-dev |
02:06 |
|
fireglow joined #minetest-dev |
02:55 |
|
CalebDavis joined #minetest-dev |
03:10 |
|
CalebDavis joined #minetest-dev |
03:11 |
|
ThomasMonroe joined #minetest-dev |
03:18 |
|
Hunterz joined #minetest-dev |
03:26 |
ThomasMonroe |
i gtg to bed, cya tomorrow |
03:31 |
|
paramat joined #minetest-dev |
03:32 |
paramat |
will re-merge #6026 in a few mins as is now approved by sfan5 |
03:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/6026 -- Ores: Make 'absheight' flag non-functional by paramat |
03:32 |
|
Hasan2 joined #minetest-dev |
03:39 |
paramat |
merging |
03:42 |
paramat |
done |
04:25 |
|
Natechip-m joined #minetest-dev |
04:26 |
Natechip |
If im needed talk to my mobile when its here. |
04:40 |
|
jsgrant joined #minetest-dev |
05:08 |
|
Hunterz joined #minetest-dev |
05:24 |
|
Raven262 joined #minetest-dev |
05:37 |
|
nerzhul joined #minetest-dev |
06:35 |
|
burli joined #minetest-dev |
06:36 |
burli |
Hi |
06:37 |
burli |
Is it correct that Minetest currently uses UDP for network communication? |
06:39 |
VanessaE |
yes mostly |
06:39 |
VanessaE |
TCP is used for some stuff, like the cURL code that fetches media from a http server |
06:39 |
VanessaE |
an* |
06:39 |
VanessaE |
but in-game it's all UDP |
06:39 |
burli |
Hm, so UDP and TCP is mixed? |
06:40 |
VanessaE |
UDP and TCP during sign-in, and pretty much UDP-only while playing |
06:40 |
burli |
I learned right now that it is not a good idea to mix both in the same app |
06:40 |
VanessaE |
it's fine in this case. |
06:40 |
burli |
ah, ok |
06:42 |
burli |
found a nice article about that http://gafferongames.com/networking-for-game-programmers/udp-vs-tcp/ |
06:42 |
nerzhul |
UDP is used everywhere except media downloading & server list which use TCP/HTTP |
06:42 |
burli |
The problem is that since TCP and UDP are both built on top of IP, the underlying packets sent by each protocol will affect each other. Exactly how they affect each other is quite complicated and relates to how TCP performs reliability and flow control, but fundamentally you should remember that TCP tends to induce packet loss in UDP packets |
06:43 |
nerzhul |
burli, yes it was especially right in 56k, with modern bandwidth this problem disappear |
06:43 |
VanessaE |
nerzhul: one exception to that btw |
06:43 |
nerzhul |
you have same problem if you listen stream music on youtube when playing MT |
06:43 |
VanessaE |
http used in-game if you have a mod installed that uses that feature. |
06:47 |
burli |
However. Was just curious. As far as I remember there is a bottleneck in networking. |
07:22 |
|
YuGiOhJCJ joined #minetest-dev |
07:34 |
|
kilbith joined #minetest-dev |
07:47 |
|
nerzhul joined #minetest-dev |
08:25 |
|
YuGiOhJCJ joined #minetest-dev |
08:43 |
sfan5 |
burli: like nerzh​ul already said this is not a problem at all on modern connections |
08:44 |
sfan5 |
also tcp is only used during sign-in and the amount of traffic used by mt (on the client) isn't enough to fill up all bandwidth anyway |
08:45 |
sfan5 |
the exception VanessaE mentioned only applies to the server, which should be running on a good connection anyway |
08:45 |
VanessaE |
right. |
08:45 |
sfan5 |
i don't know from which year that article you linked it but if my connection started dropping packets just because i have some tcp connection under mild load i'd call my isp to complain |
08:51 |
jomat |
The oldest comments are from 2008 :-) |
08:52 |
burli |
That's what I want to say right now |
08:52 |
burli |
So it's not that old I think |
08:56 |
jomat |
No, Internet wasn't that bad back then :-) It's just the architecure of udp that allows packets beeing dropped... |
09:25 |
|
juhdanad joined #minetest-dev |
09:36 |
|
nerzhul joined #minetest-dev |
10:54 |
|
juhdanad joined #minetest-dev |
11:33 |
|
ThomasMonroe joined #minetest-dev |
11:33 |
|
ThomasMonroe joined #minetest-dev |
11:35 |
|
Fixer joined #minetest-dev |
11:35 |
|
proller__ joined #minetest-dev |
11:47 |
|
Megaf joined #minetest-dev |
11:53 |
|
Megaf joined #minetest-dev |
12:14 |
|
Fixer joined #minetest-dev |
12:30 |
|
twoelk joined #minetest-dev |
12:33 |
|
RobbieF joined #minetest-dev |
12:44 |
|
Shara joined #minetest-dev |
12:47 |
|
DS-minetest joined #minetest-dev |
12:49 |
|
CalebDavis joined #minetest-dev |
13:08 |
|
Grandolf joined #minetest-dev |
13:24 |
|
Fixer joined #minetest-dev |
13:52 |
|
Fixer_ joined #minetest-dev |
13:56 |
|
antims joined #minetest-dev |
14:01 |
|
octacian joined #minetest-dev |
14:01 |
|
octacian joined #minetest-dev |
14:11 |
|
Igorek536 joined #minetest-dev |
14:12 |
|
Igorek536 left #minetest-dev |
14:38 |
red-001 |
can someone review #5965? |
14:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/5965 -- Create a filesystem abstraction layer for CSM and only allow accessing files that are scanned into it. by red-001 |
14:48 |
|
cx384 joined #minetest-dev |
15:04 |
|
Megaf joined #minetest-dev |
15:12 |
|
DI3HARD139 joined #minetest-dev |
15:46 |
|
CalebDavis joined #minetest-dev |
16:05 |
|
Hunterz joined #minetest-dev |
16:27 |
|
VanessaE joined #minetest-dev |
16:41 |
|
Darcidride joined #minetest-dev |
16:55 |
|
Krock joined #minetest-dev |
16:55 |
|
octacian_ joined #minetest-dev |
17:09 |
|
ThomasMonroe joined #minetest-dev |
17:13 |
|
proller joined #minetest-dev |
17:35 |
|
kilbith joined #minetest-dev |
17:38 |
|
ssieb joined #minetest-dev |
17:40 |
|
bigfoot547 joined #minetest-dev |
17:48 |
|
sofar joined #minetest-dev |
17:49 |
|
sofar joined #minetest-dev |
17:57 |
|
nerzhul joined #minetest-dev |
17:59 |
nerzhul |
merging #6041 in ~5 mins |
18:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/6041 -- Isolate irrlicht references and use a singleton by nerzhul |
18:00 |
nerzhul |
(if GH permits it, else doing it manually) |
18:04 |
nerzhul |
oops merged the wrong PR, forcepush to solve that |
18:04 |
|
Fixer joined #minetest-dev |
18:05 |
lisac |
nerzhul, No need this PR is also nice |
18:05 |
lisac |
:P |
18:05 |
nerzhul |
oh seems we only need to rename one function for Krock |
18:05 |
nerzhul |
will push the fix, it's better |
18:05 |
nerzhul |
ok Krock if i push the fix ? gh doesn't show the kilbith branch fix and doesn't merged it too |
18:06 |
Krock |
yes, LGTM |
18:07 |
nerzhul |
okay doing that, i compile it locally and if okay push it with kilbith name |
18:07 |
kilbith |
nah, no need |
18:07 |
kilbith |
I mean for the name |
18:07 |
nerzhul |
okay |
18:09 |
Krock |
nerzhul, uhm.. wrong commit? |
18:09 |
nerzhul |
Krock, ? |
18:09 |
Krock |
whatever, this trivial function name change can be omitted |
18:09 |
nerzhul |
i would merge 6041 and i merged 6050 |
18:09 |
nerzhul |
too late :p |
18:10 |
nerzhul |
thanks kilbith for that feature, i think players will like it :) |
18:11 |
nerzhul |
then now merging 6041 |
18:11 |
kilbith |
I expect $500 from the community now |
18:11 |
nerzhul |
thanks Krock for your time |
18:11 |
nerzhul |
kilbith, sorry no github bounty |
18:12 |
kilbith |
$1500 if you want the god rays and deferred rendering |
18:12 |
nerzhul |
i think it's a lgtm price in private software, it's 2 days of senior dev development |
18:12 |
nerzhul |
then it's not very expensive :p |
18:13 |
Krock |
$1337 for a kingdom |
18:15 |
red-001 |
https://www.openhub.net/p/minetest-c55/estimated_cost |
18:18 |
nerzhul |
wow :p |
18:20 |
Krock |
heh, Linux: $ 287,679,508 |
18:21 |
red-001 |
#6054 |
18:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/6054 -- Hand isn't visible with arm inertia enabled. |
18:21 |
kilbith |
nerzhul has the same issue afaik |
18:21 |
kilbith |
*had |
18:22 |
kilbith |
you set the setting to true in-game? |
18:23 |
kilbith |
nevermind |
18:23 |
red-001 |
no, it was enabled when starting the game |
18:23 |
red-001 |
disabling it fixes the issue |
18:23 |
nerzhul |
red-001, same pb, i have removed my cmake-build-debug and rebuild |
18:23 |
kilbith |
are you compiling in debug mode? |
18:23 |
nerzhul |
i don't understand why i have that problem |
18:23 |
nerzhul |
but cleanup your cmake env and rebuild fix the problem |
18:24 |
Krock |
did a release build and it worked alright |
18:24 |
kilbith |
it shouldn't cause that even without cleaning cmake |
18:24 |
nerzhul |
debug and release works |
18:24 |
nerzhul |
kilbith, agreed |
18:24 |
red-001 |
huh |
18:25 |
kilbith |
it's the compiler doing some things in your back when using fabsf or std::fabs |
18:27 |
kilbith |
at least it's my theory |
18:27 |
kilbith |
does your CPU supports SSE/AVX? |
18:28 |
red-001 |
I think so let me check |
18:30 |
|
Fixer_ joined #minetest-dev |
18:31 |
red-001 |
SSE4.1/4.2, AVX 2.0 |
18:31 |
kilbith |
right |
18:32 |
sfan5 |
does gcc even generate avx instructions by default? |
18:32 |
sofar |
with the right -march yes |
18:32 |
sfan5 |
by default |
18:32 |
sofar |
depends on the distro default gcc flags, most of the times |
18:33 |
|
octacian joined #minetest-dev |
18:35 |
nerzhul |
oh sofar hi |
18:35 |
nerzhul |
in debug mode march is not defined |
18:35 |
nerzhul |
for me only cleaning up cmake build dir fix the problem, and i got it on two machines, home + work |
18:35 |
nerzhul |
very strange |
18:36 |
nerzhul |
(one is AMD FX 8350 and the other core i3) |
18:36 |
red-001 |
testing it on a freshly cloned copy of the repo |
18:36 |
nerzhul |
red-001, you don't need to clone |
18:36 |
kilbith |
add this flag if necessary: -march=native |
18:36 |
nerzhul |
just remove your cmake build dir |
18:36 |
nerzhul |
(i hope you have a specific cmake dir and don't use source tree :p |
18:37 |
red-001 |
alright it worked now |
18:37 |
kilbith |
very strange |
18:38 |
nerzhul |
yeah, nothing in cmake config changed between builds it's very strange |
18:40 |
red-001 |
huh this looks a lot nicer in person then in the example video |
18:41 |
kilbith |
yeah, I agree |
18:41 |
|
Grandolf joined #minetest-dev |
18:43 |
|
Grandolf joined #minetest-dev |
18:43 |
|
Grandolf joined #minetest-dev |
18:43 |
jcalve |
I have the arm disappearing bug too in a debug build, freshly cloned |
18:43 |
red-001 |
huh |
18:44 |
* red-001 |
smells undefined behavior |
18:45 |
kilbith |
well I don't see how |
18:46 |
nerzhul |
sounds like a underfined variable init ? |
18:46 |
nerzhul |
oh |
18:46 |
nerzhul |
bool m_arm_inertia; is not inited |
18:46 |
nerzhul |
but yes inited in constructor |
18:46 |
nerzhul |
no sense |
18:47 |
red-001 |
some werid bug in incremental linking? |
18:49 |
nerzhul |
seems jcalve said he has the bug on fresh build |
18:49 |
jcalve |
I do |
18:50 |
jcalve |
I cleaned the folder and I'm rebuilding to see if it goes away |
18:58 |
jcalve |
still there |
19:09 |
nerzhul |
i can reproduce it and i know where it is |
19:09 |
nerzhul |
i found where is the problem |
19:09 |
nerzhul |
there is division per zero |
19:12 |
nerzhul |
if i forbid 0.0 division bug disappear |
19:25 |
kilbith |
red-001: #6055 |
19:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/6055 -- Camera: Fix possible division per zero by kilbith |
19:31 |
|
ThomasMonroe joined #minetest-dev |
19:36 |
jcalve |
without knowing anything about c++, looks like your json lib has a problem |
19:38 |
sfan5 |
are you linking to system jsoncpp? |
19:39 |
sfan5 |
do you have -DENABLE_SYSTEM_JSONCPP=TRUE |
19:51 |
Fixer |
compiled newest mt just fine via msys2/mingw64 |
19:56 |
sfan5 |
-DENABLE_SYSTEM_JSONCPP=TRUE |
20:06 |
Shara |
dra :P |
20:11 |
nerzhul |
no problem i'm here :p |
20:14 |
|
Raven262 joined #minetest-dev |
20:52 |
|
XtremeHacker joined #minetest-dev |
20:56 |
|
RobbieF left #minetest-dev |
20:57 |
Shara |
old sneak* |
20:58 |
Shara |
Eww, wrong tab sorry |
21:10 |
nerzhul |
jcalve, are you there , |
21:10 |
jcalve |
nerzhul: yes |
21:10 |
nerzhul |
can you edit camera.cpp L199 to 203 to replace the two fabs with |
21:10 |
nerzhul |
https://pastebin.com/MRBAMNzv |
21:11 |
nerzhul |
and tell me if it works (for me okay) |
21:11 |
jcalve |
sure |
21:12 |
nerzhul |
red-001, ^ |
21:13 |
|
kilbith joined #minetest-dev |
21:13 |
jcalve |
nerzhul: that fixed it for me too |
21:13 |
|
Raven262 joined #minetest-dev |
21:16 |
|
troller joined #minetest-dev |
21:19 |
nerzhul |
jcalve, nice |
21:19 |
nerzhul |
red-001, ? |
21:19 |
nerzhul |
okay pushing he fix to master |
21:19 |
red-001 |
sorry I was afk |
21:19 |
red-001 |
testing now |
21:19 |
nerzhul |
pj |
21:19 |
nerzhul |
nice i'm preparing the patch |
21:23 |
nerzhul |
red-001, waiting you |
21:25 |
red-001 |
yeah that worked |
21:27 |
|
Raven262 joined #minetest-dev |
21:31 |
nerzhul |
nice |
21:31 |
nerzhul |
pushing the fix |
21:31 |
|
est31 joined #minetest-dev |
21:31 |
nerzhul |
+ optim reinit += operation |
21:32 |
red-001 |
any idea why it worked in release builds? |
21:32 |
nerzhul |
i don't have idea |
21:34 |
nerzhul |
i don't know why compiler let division by zero, if i remember i crash programs genrally |
21:34 |
nerzhul |
it's not an exception in C++ hmmm |
21:35 |
|
proller joined #minetest-dev |
21:35 |
red-001 |
* red-001 smells undefined behavior |
21:35 |
nerzhul |
red-001, yes |
21:35 |
red-001 |
I guess it optimized out the crash |
21:35 |
nerzhul |
https://stackoverflow.com/questions/3004095/division-by-zero-undefined-behavior-or-implementation-defined-in-c-and-or-c |
21:35 |
kilbith |
well, that was a good lesson |
21:35 |
nerzhul |
no crash, just undefined behaviour as it seems |
21:36 |
nerzhul |
whenever you do a division ensure you never have zero, if you have, handle |
21:40 |
red-001 |
at least it's not JS |
21:41 |
red-001 |
which seems to think it's infinaty |
21:41 |
red-001 |
infinity* |
21:42 |
nerzhul |
:p |
21:44 |
red-001 |
huh |
21:44 |
red-001 |
I should check if it returns negative infinite when dividing a negative number |
21:45 |
|
Tmanyo joined #minetest-dev |
21:48 |
|
Hasan2 joined #minetest-dev |
21:52 |
|
Lunatrius` joined #minetest-dev |
21:53 |
|
kaeza joined #minetest-dev |
22:09 |
nerzhul |
sfan5, when you get time can you review #5963 ? i'm waiting for your approval to merge, it looks nice but i need your expertise :p |
22:09 |
nerzhul |
i should go |
22:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/5963 -- Fix msvc annoyances by adrido |
22:22 |
|
^v joined #minetest-dev |
22:28 |
|
twoelk left #minetest-dev |
22:31 |
|
jin_xi joined #minetest-dev |
22:32 |
|
Player_2 joined #minetest-dev |
22:48 |
|
octacian_ joined #minetest-dev |
22:54 |
|
octacian joined #minetest-dev |
22:55 |
|
Hasan2 joined #minetest-dev |