Time |
Nick |
Message |
00:07 |
|
Megaf_ joined #minetest-dev |
00:36 |
|
paramat joined #minetest-dev |
00:37 |
paramat |
#6026 |
00:37 |
ShadowBot |
https://github.com/minetest/minetest/issues/6026 -- Ores: Make 'absheight' flag non-functional by paramat |
00:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/5797 -- [CSM] Add function to set the FOV of the local player by bigfoot547 |
00:39 |
paramat |
i'll look |
00:41 |
|
Lunatrius` joined #minetest-dev |
00:47 |
paramat |
nore rubenwardy maybe i should merge 6026 ? i suspect no-one knows much about it other than me, and i know it's useless and rarely used (if at all) |
00:51 |
paramat |
i might later |
00:59 |
|
Taoki joined #minetest-dev |
01:31 |
red-001 |
#6026 |
01:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/6026 -- Ores: Make 'absheight' flag non-functional by paramat |
02:20 |
|
YuGiOhJCJ joined #minetest-dev |
02:33 |
|
CalebDavis joined #minetest-dev |
02:40 |
|
ThomasMonroe joined #minetest-dev |
02:41 |
|
ThomasMonroe joined #minetest-dev |
02:42 |
|
jin_xi joined #minetest-dev |
02:48 |
|
paramat joined #minetest-dev |
02:57 |
paramat |
yes i will merge 6026 later, i now remember talking to hmmmm about the flag and we agreed it was crude and unuseful |
03:27 |
|
bigfoot547 joined #minetest-dev |
03:34 |
|
bigfoot547 joined #minetest-dev |
03:55 |
paramat |
will merge #6026 #6043 in a few mins |
03:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/6026 -- Ores: Make 'absheight' flag non-functional by paramat |
03:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/6043 -- Mgv7: Clean up divide-by-zero fix by paramat |
04:04 |
paramat |
merging |
04:06 |
paramat |
done |
04:32 |
|
Natechip-m joined #minetest-dev |
06:40 |
|
Hunterz joined #minetest-dev |
07:06 |
|
nerzhul joined #minetest-dev |
07:34 |
|
Raven262 joined #minetest-dev |
07:36 |
|
DS-minetest joined #minetest-dev |
07:41 |
|
Fritigern joined #minetest-dev |
08:09 |
|
Megaf_ joined #minetest-dev |
08:22 |
|
EDAKIRI joined #minetest-dev |
08:36 |
|
lisac joined #minetest-dev |
08:41 |
|
red-001 joined #minetest-dev |
09:08 |
|
Krock joined #minetest-dev |
09:18 |
Krock |
merging game#1795 |
09:18 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1795 -- Make sapling, leaves and fence descriptions consistent by Ezhh |
09:27 |
Krock |
merging #6039 in 10 mins |
09:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/6039 -- Inventory: Fix wrong stack size behaviour and item loss by SmallJoker |
10:18 |
|
Darcidride joined #minetest-dev |
10:41 |
|
Fixer joined #minetest-dev |
11:20 |
|
jin_xi joined #minetest-dev |
11:29 |
|
nerzhul joined #minetest-dev |
11:46 |
nerzhul |
!tell paramat where is the approval for 90ed6fc732ca667ca970b7c38d39c809e5c3553e ? i don't see anybody who approve this PR |
11:46 |
ShadowBot |
nerzhul: O.K. |
11:46 |
nerzhul |
!tell paramat you removed a feature from engine it should at least be reviewed by some coredevs |
11:46 |
ShadowBot |
nerzhul: O.K. |
11:51 |
nerzhul |
Krock, fixed the 0.5 post |
11:51 |
Krock |
nerzhul, thank you |
12:13 |
|
Gundul joined #minetest-dev |
12:42 |
|
kilbith joined #minetest-dev |
13:28 |
|
troller joined #minetest-dev |
13:52 |
|
numzero joined #minetest-dev |
14:15 |
|
Fixer_ joined #minetest-dev |
14:22 |
|
Taoki_1 joined #minetest-dev |
14:25 |
|
juhdanad joined #minetest-dev |
14:30 |
juhdanad |
Hi! Is there somebody familiar with the c++ side of client-side modding? |
14:30 |
nerzhul |
i and red-001 i think |
14:31 |
juhdanad |
So, my question is: are client-side object references implemented yet? |
14:31 |
nerzhul |
if i remember no |
14:32 |
juhdanad |
I would like to finish #4421, but I need those references. |
14:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/4421 -- Expose getPointedThing() as Raycast by juhdanad |
14:33 |
juhdanad |
So I should code them, and maybe you could give me advice on how to start. |
14:33 |
nerzhul |
CAO are not referenced atm |
14:33 |
nerzhul |
if you want to reference them into CSM Lua you should do same exposure thing as SSM |
14:34 |
juhdanad |
Somebody already made a local player object, right? |
14:36 |
red-001 |
yeah |
14:37 |
red-001 |
but it's not based on the c++ version |
14:37 |
red-001 |
CAO and SAO are basically completely seperate class |
14:39 |
red-001 |
in theory they share a base class |
14:39 |
red-001 |
but it's basically an empty class that does nothing useful |
14:41 |
juhdanad |
So a server entity is an ObjectRef, which can be a SAO or a Player. |
14:42 |
nerzhul |
yeah LocalPlayer is a pure... thing to remove |
14:42 |
nerzhul |
like RemotePlayer |
14:42 |
nerzhul |
but not yet |
14:42 |
nerzhul |
RemotePlayer -> PlayerSAO & LocalPlayer -> PlayerCAO |
14:42 |
juhdanad |
In my opinion it is goot to separate the local player and remote players. |
14:43 |
nerzhul |
yes |
14:43 |
nerzhul |
but i mean in server we have RemotePlayer & PlayerSAO which are basicly the same object but separated |
14:43 |
nerzhul |
and in Client we have LocalPlayer and PlayerCAO |
14:45 |
juhdanad |
So for the client other players are just plain objects. |
14:45 |
Krock |
what else should they be? |
14:45 |
juhdanad |
The have extra properties, like their name. |
14:45 |
juhdanad |
*they |
14:47 |
|
DI3HARD139 joined #minetest-dev |
14:47 |
juhdanad |
About the file system: both server side and client side modding files are in src/script. This might cause confusion when CSM requires more files. |
14:47 |
Krock |
well, the name is included in the GenericCAO class |
14:47 |
juhdanad |
Maybe they should be separated somehow? |
14:48 |
|
cx384 joined #minetest-dev |
14:56 |
red-001 |
yeah maybe |
14:56 |
red-001 |
some files are common through |
15:24 |
|
DS-minetest joined #minetest-dev |
15:36 |
nerzhul |
juhdanad, i have internal plans to refactor LocalPlayer making it a proper GenericCAO child |
15:37 |
nerzhul |
but i someone want to work on this part i will be glad to see :) |
16:00 |
|
kilbith joined #minetest-dev |
16:32 |
|
Sokomine joined #minetest-dev |
16:43 |
|
Krock joined #minetest-dev |
16:57 |
|
Darcidride joined #minetest-dev |
18:06 |
|
DI3HARD139 joined #minetest-dev |
18:25 |
|
Hunterz joined #minetest-dev |
18:41 |
|
torgdor joined #minetest-dev |
19:09 |
|
zein11 joined #minetest-dev |
19:56 |
|
proller__ joined #minetest-dev |
20:01 |
|
numzero joined #minetest-dev |
20:08 |
|
lisac joined #minetest-dev |
20:18 |
|
jsgrant joined #minetest-dev |
20:45 |
|
juhdanad joined #minetest-dev |
20:56 |
|
numzero joined #minetest-dev |
21:01 |
|
kaeza joined #minetest-dev |
21:03 |
|
torgdor joined #minetest-dev |
21:07 |
nerzhul |
reverting 90ed6fc732ca667ca970b7c38d39c809e5c3553e, nobody approved it, in 24h paramat didn't answered on the comments |
21:08 |
|
numzero joined #minetest-dev |
21:15 |
|
paramat joined #minetest-dev |
21:15 |
paramat |
you should consult before reverting nore rubenwardy sfan5 what are your opinions? |
21:16 |
paramat |
hmmmm and i agreed to remove it |
21:16 |
paramat |
celeron55 your opinion? |
21:16 |
sfan5 |
what matters is approval on that pr in particular |
21:16 |
sfan5 |
and that isn't present |
21:17 |
sfan5 |
seeing at it isn't a trivial bugfix either it deserves to be reverted according to the rules |
21:17 |
paramat |
did anyone read my reasons for merging it? |
21:17 |
sfan5 |
you can't reason your way around rules |
21:18 |
paramat |
could you consider it before reverting to avoid extra work? |
21:18 |
sfan5 |
i'm probably fine with the pr content itself, but instead of ignoring the rules just ask for approval first |
21:18 |
sfan5 |
it's already reverted btw |
21:19 |
paramat |
nerz has merged 'trivial' commits that were not, we accept t because we trust him |
21:19 |
paramat |
*it |
21:19 |
sfan5 |
did we? |
21:19 |
sfan5 |
i remember complaining to him |
21:19 |
sfan5 |
but you're correct that those weren't reverted |
21:20 |
paramat |
now if you read https://github.com/minetest/minetest/pull/6026#issuecomment-310922572 you will see this was fairly reasonable |
21:21 |
paramat |
hmmmm is still technically the other mapgen dev, and we both agreed to remove it when possible |
21:21 |
paramat |
i was given authority over the biome API by him |
21:22 |
paramat |
reversion should happen on agreement, not by one person with a grudge |
21:23 |
paramat |
so pleae can devs consider it so i can re-merge? |
21:26 |
paramat |
nerzhul how would you feel if i went back through your borderline-trivial PRs and reverted them on my own judgement? i would not dare to |
21:27 |
paramat |
please drop your grudge, your harassment and obsessive attacks |
21:27 |
paramat |
i hold no grudge against you |
21:28 |
paramat |
i do make a fuss in some PRs, but that is nothing personal, i would do the same whoever made the PR |
21:28 |
paramat |
and yes when i make a fuss it is irritaing, but don't take it personally |
21:29 |
paramat |
i have had non-stop personal attacks from you recently, please stop |
21:31 |
paramat |
your actions are being decided by whether it can be an attack on me or not |
21:32 |
paramat |
your arrogance has been extreme since hmmmm left, you are not in charge of this project |
21:33 |
paramat |
you have been much worse than hmmmm ever was |
21:33 |
paramat |
however, i am tolerant and appreciate all your work |
21:36 |
paramat |
anyway, for this PR another dev agrees with revert now so i accept that, please can devs consider it? |
21:40 |
paramat |
when no devs are active and do not respond, and since this was agreed with hmmmm, and due to the other factors, this was reasonable, i took the initiative to keep MT alive |
21:43 |
|
XtremeHacker joined #minetest-dev |
21:43 |
nerzhul |
hmmmm is not active on this project anymore and your PR quality deserve you. i.e. buggy mapgen |
21:44 |
paramat |
that's not a bug |
21:44 |
nerzhul |
no you don't keep MT alive with a PR with 3 hours lifetime sorry guy |
21:44 |
nerzhul |
IT IS A BUG FUCK |
21:44 |
nerzhul |
it's ugly it deserve minetest and users are complaining about it |
21:44 |
paramat |
it's intentional and i will add a setting |
21:44 |
paramat |
many like those |
21:45 |
paramat |
the 6026 PR was open for 1-2 days |
21:45 |
nerzhul |
if i think like you i think i should merge all my PR > 1 day lifetimpe at least just to make MT active. But no i didn't because it's not reasonable and there are active coredev |
21:46 |
paramat |
please drop your grudge |
21:46 |
paramat |
i still have no grudge against you, all i want to do is get on with you |
21:47 |
nerzhul |
stop your bad arguments, you are C++ noob i don't see why you are a coredev, when i ask you about a single test you cannot, when i ask you for changing to a function, no i don't want (and then i lost 4 hours of my life to talk to a man who doesn't understand c++), no i will see later, you don't know what is "this" qualifier and why it is used in mapgen |
21:47 |
paramat |
after a couple of says i calm down and feel all chilled towards you, then you attack again, please stop |
21:47 |
VanessaE |
both of you stop it. |
21:47 |
VanessaE |
this is NOT productive |
21:47 |
VanessaE |
*knocks heads together, cartoon-like* |
21:47 |
nerzhul |
yeah you know a little bit tuning the mapgen, but no you don't have any skill to be a coredev as you don't undrstand c++ you just understand tuning maths |
21:48 |
nerzhul |
(and it's limit because when i ask you to do a unittest for mapgen limit you didn't and you do 3 commits ot have the correct formula whereas a single unittest can permit to develop this properly the first time) |
21:48 |
paramat |
MT work is voluntary, i do not want to write a unittest, so you have to accept that, you attacked me over that too |
21:48 |
nerzhul |
voluntary != arnarchy != unkill men |
21:48 |
nerzhul |
openssl is also by volunteers and ... ? |
21:49 |
nerzhul |
i want quality, you want to define ugly rules for mapgens because there is aliens ? WTF man it's a map generation, not paramat's desire generation |
21:49 |
paramat |
can you design and create a mapgen? or understand perlin noise completely? i do more than tune |
21:50 |
nerzhul |
mapgen is agnostic of stupid desires it's just a reallistic world map |
21:50 |
paramat |
that has nothing to do with aliens |
21:50 |
nerzhul |
i wrote perlin noise functions on other games, yes |
21:50 |
nerzhul |
it was your argument |
21:51 |
paramat |
i have never defended protruding dungeons by aliens, that was kilbith's attack |
21:51 |
nerzhul |
https://github.com/minetest/minetest/issues/5204 |
21:51 |
paramat |
i will add a setting and am ok withh that |
21:51 |
kilbith |
wait what? |
21:51 |
nerzhul |
on the caputres shown, the one you show is why not, other are not acceptable |
21:51 |
kilbith |
oh it's too late for a fight now |
21:52 |
kilbith |
especially with a fucking jobless idiot |
21:52 |
paramat |
i can post many beautiful examples |
21:52 |
paramat |
and they are rare |
21:52 |
nerzhul |
and sorry but there are 2 bugs here |
21:52 |
XtremeHacker |
I'm not even going to say anything... |
21:52 |
nerzhul |
and no they are not rare, it's not the first time i see that |
21:53 |
paramat |
rare does not mean happens once |
21:53 |
nerzhul |
(and i'm moving randomly on random maps for test on all PR i test/do) |
21:53 |
paramat |
ok i will add a setting, so why attack? |
21:54 |
nerzhul |
setting ? default good map, let alien map enable them if they want but for a default and bad user experience don't let this |
21:54 |
paramat |
i will forgive you quickly enough, why can't you drop your personal grudge? |
21:54 |
kilbith |
lol, say the guy who usually refuse settings... |
21:54 |
paramat |
yeah i may be ok with default disabled |
21:54 |
nerzhul |
and disapprove all game enhancement if there is no community shield |
21:55 |
paramat |
? |
21:55 |
nerzhul |
it's late it, see you tomorrow with PR to fix that issue |
21:55 |
paramat |
i can't stop anything alone |
21:55 |
nerzhul |
and stop refuse game immersion enhancement PR |
21:55 |
paramat |
i'll write the PR |
21:56 |
paramat |
i can have opinions |
21:56 |
nerzhul |
you can but as i said you should be moderated on issues |
21:56 |
nerzhul |
"I thought you were not goimg to backport anything from your fork to to MT?" |
21:56 |
nerzhul |
you said that on a PR |
21:56 |
paramat |
that;s not reasonable, freedom of speech |
21:56 |
nerzhul |
what does that mean ? |
21:57 |
nerzhul |
you are a coredev you should have some respect to PR owners |
21:57 |
kilbith |
it's a provocation and has nothing to do in that PR |
21:57 |
nerzhul |
what is that sentence |
21:57 |
paramat |
you cannot stop devs stating opinions |
21:57 |
paramat |
just wondering |
21:57 |
nerzhul |
you are spiting on a PR owner because he wants to improve MT by backporting features to core ? |
21:57 |
paramat |
kilbith stated he will not backport |
21:57 |
paramat |
no |
21:58 |
paramat |
i appreciate he is backporting |
21:58 |
kilbith |
and how does it relates with this PR? |
21:58 |
paramat |
just dislike the feature |
21:58 |
nerzhul |
then don't use rude sentences like this |
21:58 |
paramat |
it's only rude in your head |
21:59 |
nerzhul |
the sentence meaning is : "oh you backport, but why do you backport i doesn't want you to", it's the text feeling, there is no voice to enhance your sentence on GH |
21:59 |
paramat |
that's your negative interpretation |
21:59 |
kilbith |
well, let's go to the bed nerz |
21:59 |
nerzhul |
yeah i have many work at work tomorrow i need to sleep :p |
21:59 |
paramat |
but i will edit sure |
21:59 |
nerzhul |
see you |
22:00 |
paramat |
ok :] |
22:12 |
paramat |
#6026 re-opened, please consider |
22:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/6026 -- Ores: Make 'absheight' flag non-functional by paramat |
22:12 |
paramat |
rubenwardy sfan5 ^ |
22:13 |
red-001 |
ahhh |
22:13 |
red-001 |
who added unicode to game.cpp??! |
22:15 |
jcalve |
inb4 poop emojy |
22:17 |
Fixer |
what? |
22:17 |
Fixer |
i still have incorrect cyrillic symbols for infotexts... |
22:18 |
red-001 |
huh I think it was Wuzzy |
22:19 |
Fixer |
red-001: you sure? Wuzzy change is in PR right now |
22:19 |
Fixer |
IT IS ALL IN YOUR HEAD |
22:19 |
Fixer |
oops |
22:19 |
Fixer |
https://github.com/minetest/minetest/pull/5795 |
22:20 |
red-001 |
Fixer, https://github.com/minetest/minetest/commit/08f57e1e387580b0487d1da5c195e5bf532c672b#diff-18513665750ef5adf42b5ec29e14162eR4337 |
22:20 |
Fixer |
i will check it once game.cpp conflict is fixed |
22:20 |
red-001 |
it messes with my editor |
22:23 |
|
bigfoot547 joined #minetest-dev |
22:40 |
paramat |
oh dear just saw this .. kilbith > "oh it's too late for a fight now, especially with a fucking jobless idiot" |
22:40 |
red-001 |
it's kilbtih |
22:40 |
red-001 |
what do you expect? |
22:41 |
sfan5 |
red-001: you should fix your editor then |
22:41 |
Fixer |
maximum troll |
22:41 |
Fixer |
but I would like to see this fighting and trolling go away |
22:41 |
Fixer |
cancerous |
22:43 |
paramat |
thanks for review |
22:43 |
paramat |
now do i dare merge it again? i'm worried |
22:43 |
paramat |
#6026 |
22:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/6026 -- Ores: Make 'absheight' flag non-functional by paramat |
22:43 |
* red-001 |
hopes to finnaly see a revent being revented |
22:44 |
sfan5 |
paramat: the rules permit you to merge it (again) as your own approval also counts |
22:44 |
paramat |
yeah .. |
22:45 |
paramat |
ok will do |
22:51 |
paramat |
yes my only income currently is MT dev donations and it's nowhere near enough to live on, no other employment |
22:55 |
Fixer |
this is offtopic |
22:59 |
paramat |
#6045 is too dangerous |
22:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/6045 -- minetest.set_node(pos) by zaoqi |
23:00 |
paramat |
see comments |
23:03 |
paramat |
that's irrelevant :] |
23:05 |
sfan5 |
it places whatever node you have selected |
23:20 |
|
jin_xi joined #minetest-dev |
23:20 |
paramat |
i'll re-merge 6026 later |
23:39 |
paramat |
will make a PR for a protruding dungeon setting, as many have asked for it |