Time |
Nick |
Message |
00:02 |
|
Taoki joined #minetest-dev |
00:14 |
|
paramat joined #minetest-dev |
01:01 |
Tmanyo |
Is there anyone here who could help me with formspec tables? |
01:02 |
est31 |
Tmanyo: more a question for #minetet |
01:02 |
est31 |
#minetest |
01:02 |
Tmanyo |
ok |
01:27 |
paramat |
will merge game#1334 game#1339 in a moment |
01:27 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1334 -- Metal sounds by sofar |
01:27 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1339 -- Make flammable: flowers, grasses and several crafitems by Ferk |
01:41 |
paramat |
now merging |
01:42 |
|
MrIbby joined #minetest-dev |
01:47 |
paramat |
complete |
02:15 |
|
hiradur joined #minetest-dev |
02:29 |
|
torgdor joined #minetest-dev |
02:43 |
|
Hunterz joined #minetest-dev |
02:48 |
paramat |
game#1341 will merge later. sofar |
02:48 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1341 -- Default: Update and set volume of damage sounds by paramat |
02:49 |
|
OldCoder joined #minetest-dev |
03:09 |
|
kaeza joined #minetest-dev |
03:13 |
paramat |
will merge this too game#1342 another sounds tweak |
03:13 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1342 -- Fire: Reduce volume of flint and steel sound by paramat |
03:18 |
paramat |
will merge both in a moment |
03:23 |
paramat |
merging |
03:27 |
paramat |
complete |
03:29 |
paramat |
sofar could you approve this simple PR? it's just proper treatment of ignore #4630 |
03:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/4630 -- Fix sandslides and node destruction by falling nodes. by t4im |
03:30 |
paramat |
t4im hasn't been around recently, might have to rebase that myself |
03:33 |
paramat |
hmmmm this may interest you, we have someone working on 'updateLighting', single-node updates here #4655 but contributor says they might rewrite bulk-node updates in future, perhaps the lighting bugs may get fixed |
03:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/4655 -- Improved lighting by juhdanad |
03:51 |
|
jin_xi joined #minetest-dev |
05:13 |
|
Hunterz joined #minetest-dev |
05:23 |
|
paramat joined #minetest-dev |
05:30 |
|
nrzkt joined #minetest-dev |
05:49 |
nrzkt |
merging #4662 |
05:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/4662 -- Shaders: Apply tone mapping before fog calculation. by lhofhansl |
06:06 |
paramat |
good :] |
06:13 |
nrzkt |
hi, sfan5 are you okay with #4659 ? |
06:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/4659 -- Windows: dont link to libraries that are already linked by cmake by adrido |
06:39 |
|
paramat left #minetest-dev |
06:41 |
|
gentoobr1 joined #minetest-dev |
07:14 |
|
Darcidride joined #minetest-dev |
07:52 |
|
red-001 joined #minetest-dev |
08:39 |
|
nrzkt joined #minetest-dev |
09:21 |
|
Gael-de-Sailly joined #minetest-dev |
09:23 |
|
red-001 joined #minetest-dev |
09:31 |
|
proller__ joined #minetest-dev |
09:37 |
|
proller__ joined #minetest-dev |
09:50 |
|
HonoredGlory joined #minetest-dev |
09:53 |
|
nrzkt joined #minetest-dev |
10:29 |
|
blaze joined #minetest-dev |
11:13 |
|
gpcf joined #minetest-dev |
11:14 |
gpcf |
I am writing some code treegen.cpp to add a tree ID to every node of the tree so I can implement a new leafdecay algorithm |
11:14 |
gpcf |
I want to set the ID in the node metadata, how do I do this in C++? |
11:15 |
gpcf |
In Lua, I would do meta = minetest.node_meta(pos) meta.set_string("ID", id) |
11:19 |
celeron55 |
hmm |
11:20 |
celeron55 |
https://github.com/minetest/minetest/blob/master/src/script/lua_api/l_nodemeta.cpp |
11:20 |
celeron55 |
yiu can always check what the lua api actually does |
11:20 |
celeron55 |
you* |
11:22 |
celeron55 |
so Map::getNodeMetadata and some related stuff |
11:22 |
gpcf |
hmm |
11:22 |
gpcf |
i'm going to have a look at it |
11:24 |
gpcf |
so if I write NodeMetadata meta = Map::getNodeMetadata(p0); it's going to give me the metadata? |
11:24 |
gpcf |
or do I have to create a Map object first? |
11:24 |
gpcf |
I'm a lot more familiar with C than C++ |
11:28 |
|
proller__ joined #minetest-dev |
11:32 |
gpcf |
can I post the function I just wrote? |
11:37 |
|
Fixer joined #minetest-dev |
11:49 |
red-001 |
https://github.com/minetest/minetest/blob/b88595050f3af5ccac06aac331ead4ebdcb9deb9/src/treegen.cpp#L118 |
11:51 |
sfan5 |
nrzkt: yes that wa supposed to be an approval |
11:52 |
celeron55 |
gpcf: you need to understand pointers to use that interface |
11:52 |
celeron55 |
you'll get a Map object from somewhere depending on where you are in the code |
11:53 |
celeron55 |
there exists only one but it's not available globally |
11:53 |
nrzkt |
sfan5: can you remember me on what ? xD |
11:54 |
sfan5 |
<nrzkt> hi, sfan5 are you okay with #4659 ? |
11:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/4659 -- Windows: dont link to libraries that are already linked by cmake by adrido |
11:54 |
nrzkt |
thanks sfan5 |
11:54 |
nrzkt |
i merge then |
11:54 |
|
AcidNinjaFWHR joined #minetest-dev |
11:54 |
nrzkt |
sfan5: did you get some time to review #4612, i really need feedback/approvals :) |
11:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/4612 -- Player class cleanup / PlayerSAO - LocalPlayer ownership by nerzhul |
11:55 |
sfan5 |
haven't reviewed it yet |
11:55 |
nrzkt |
yes no problem :) |
11:59 |
gpcf |
thanks red, I've found the map now |
11:59 |
gpcf |
I've got to modify all again |
12:04 |
|
johnnyjoy joined #minetest-dev |
12:09 |
red-001 |
is http://dev.minetest.net/Client_scripting_plans still up to date? |
12:14 |
|
proller__ joined #minetest-dev |
12:24 |
sfan5 |
probably not |
12:55 |
gpcf |
Can't build |
12:56 |
gpcf |
because of a leveldb error |
12:58 |
gpcf |
fails while linking |
13:01 |
gpcf |
i'm trying to build it without leveldb |
13:15 |
|
STHGOM joined #minetest-dev |
13:19 |
Calinou |
gpcf: Minetest is not buildable on Ubuntu 12.04 with LevelDB, you'll need disable LevelDB there |
13:23 |
Calinou |
I've seen https://github.com/minetest/minetest/issues/4665 though, and that's likely a bug, yeah |
13:34 |
nrzkt |
#4664 is ready for review, another backport done :) |
13:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/4664 -- Implement delayed server shutdown with cancelation by nerzhul |
13:34 |
nrzkt |
sfan5: if you get time, this is a very easy PR here :) |
13:47 |
|
garywhite joined #minetest-dev |
13:49 |
gpcf |
I've got Debian unstable |
13:49 |
gpcf |
Calinou: yeah, that's the bug I just filed |
13:49 |
|
STHGOM joined #minetest-dev |
13:52 |
|
halt_ joined #minetest-dev |
14:12 |
red-001 |
is it possible to create a light source brighter then sun light? |
14:18 |
|
FirePowi joined #minetest-dev |
14:57 |
|
Gael-de-Sailly joined #minetest-dev |
15:01 |
|
hmmmm joined #minetest-dev |
15:02 |
|
twoelk joined #minetest-dev |
15:10 |
|
OldCoder joined #minetest-dev |
15:15 |
|
jin_xi joined #minetest-dev |
15:38 |
|
Krock joined #minetest-dev |
15:38 |
|
Krock joined #minetest-dev |
15:44 |
|
SilverLuke joined #minetest-dev |
15:52 |
|
Hunterz joined #minetest-dev |
16:25 |
|
blaze joined #minetest-dev |
16:33 |
|
Foghrye4_ joined #minetest-dev |
16:47 |
|
Grandolf joined #minetest-dev |
16:58 |
SavePR4530 |
red-001: i think not, also, avoid using more than 14 |
17:11 |
|
proller__ joined #minetest-dev |
17:22 |
|
nerzhul_ joined #minetest-dev |
17:31 |
Krock |
found one of the sources why the debug build was so slow: |
17:31 |
Krock |
2016-10-25 19:30:39: WARNING[Server]: active block modifiers took 12712ms (longer than 200ms) |
17:31 |
Krock |
where it was <200ms in release mode for some reason |
17:32 |
SavePR4530 |
Krock: ti is not source |
17:32 |
SavePR4530 |
Krock: build is slow -> abms are slow -> warning message for slowness |
17:32 |
Krock |
no no, I enabled /Ox which optimizes the code everywhere, even in debug |
17:33 |
Krock |
after the AMBs are done, it rooms very smoothly |
17:34 |
SavePR4530 |
ok |
17:34 |
Krock |
default leafdecy seems to use 1s avg time |
17:34 |
nerzhul_ |
Krock, valgrind with callgrind ? |
17:34 |
Krock |
lolwhat? I'm on Windows |
17:34 |
* Krock |
turns on Google |
17:51 |
nerzhul_ |
Krock, VS permits to do things like valgrind but you need EE i think |
17:51 |
Krock |
sorry, what is "EE"? |
17:52 |
Krock |
I can use Windbg to parse crash dumps or to debug an application |
17:52 |
Krock |
but the thing is this: https://www.youtube.com/watch?v=MIJSW5MRa6E |
17:53 |
Krock |
something seems to be slowed down horribly when running in debug mode |
18:04 |
Krock |
99% of the time is spent on _Mtxunlock in MSVCP100D |
18:08 |
Calinou |
EE = Enterprise Edition |
18:11 |
nerzhul_ |
Krock, wow wtf |
18:13 |
Krock |
nvm. these 99% was the time spent in the selected function :3 |
18:15 |
nerzhul_ |
one coredev can approve #4667 ? it's a trivial fix on particle spawners |
18:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/4667 -- ParticleSpawner: fix offset being added twice by Gael-de-Sailly |
18:18 |
sfan5 |
nerzhul_: trivial fixes don't need second approval |
18:22 |
sofar |
nerzhul_: :+1: |
18:39 |
nerzhul_ |
sofar, thanks |
18:41 |
nerzhul_ |
merged thanks, sfan5 i prefer sometimes have a second review :) |
18:45 |
Hijiri |
Opinions on #4488? Should I just push the issue by making a PR with whatever interface I prefer? |
18:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/4488 -- Document the "user" parameter of on_use callbacks of items |
18:49 |
nerzhul_ |
Hijiri, if you have a solution, close the issue and open a pr based on it |
18:51 |
Hijiri |
there's no solution because the answer is an interface issue |
18:52 |
Hijiri |
or rather, there are multiple solutions and they have different implications for modding |
18:52 |
Hijiri |
I will just open a PR though |
18:56 |
Hijiri |
#4668 |
18:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/4668 -- "Document" item use callbacks' "user" parameter by raymoo |
18:58 |
|
Taoki joined #minetest-dev |
18:58 |
nerzhul_ |
thanks for our contribution |
19:01 |
Krock |
maybe I've found the problem with the debug build. The CMake variable CMAKE_C_FLAGS_DEBUG was not set |
19:01 |
Krock |
thus, no optimizations |
19:01 |
Krock |
and bloaty Lua calls (my guess) |
19:01 |
nerzhul_ |
will merge #4657 in ~10min |
19:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/4657 -- Adding LuaError on attempt to assign vectors with values out of range by Foghrye4 |
19:01 |
nerzhul_ |
Krock, lua bloat on windows ? strange :p |
19:02 |
nerzhul_ |
and #4664 in ~2h if i'm not out :) |
19:02 |
ShadowBot |
https://github.com/minetest/minetest/issues/4664 -- Implement delayed server shutdown with cancelation by nerzhul |
19:02 |
Krock |
bloaty as in talking too much time |
19:02 |
nerzhul_ |
thanks to reviewers |
19:04 |
|
ssieb joined #minetest-dev |
19:15 |
|
werwerwer joined #minetest-dev |
19:26 |
nerzhul_ |
est31, hmmmm thanks for the typos & indent all are fixed now |
19:35 |
|
Zeno` joined #minetest-dev |
19:39 |
Zeno` |
#4530 |
19:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/4530 -- Fix superflous shader setting updates by gregorycu |
19:40 |
nerzhul_ |
hi Zeno` |
19:41 |
Zeno` |
yo |
19:41 |
|
torgdor joined #minetest-dev |
19:57 |
Hijiri |
#4669 |
19:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/4669 -- Make player send control information before interacts by raymoo |
20:33 |
|
proller joined #minetest-dev |
20:36 |
|
AcidNinjaFWHR joined #minetest-dev |
20:38 |
|
VargaD joined #minetest-dev |
20:58 |
|
Tmanyo joined #minetest-dev |
20:59 |
|
proller joined #minetest-dev |
21:01 |
|
proller joined #minetest-dev |
21:02 |
|
paramat joined #minetest-dev |
21:04 |
|
troller joined #minetest-dev |
21:04 |
paramat |
hmmmm nerzhul_ sfan5 please could you consider completing #4530 ? |
21:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/4530 -- Fix superflous shader setting updates by gregorycu |
21:05 |
sfan5 |
sure |
21:05 |
paramat |
seems the author will not complete it |
21:06 |
hmmmm |
sure i'll take a look i guess |
21:06 |
hmmmm |
i'm kinda busy with work though |
21:07 |
paramat |
yeah, thought you'd be ideal since you have so much input in review |
21:11 |
sfan5 |
added my review |
21:15 |
sofar |
man I love that github added the `rebase and merge` button |
21:16 |
sofar |
paramat: I merged game#1343 |
21:16 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1343 -- Add new metal sounds func. to the game_api.txt by LNJ2 |
21:16 |
paramat |
thanks |
21:17 |
|
Fixer joined #minetest-dev |
21:18 |
paramat |
sfan5 i hope this is ok https://github.com/minetest/minetest_game/pull/1327#issuecomment-255948552 |
21:19 |
|
SloanOnLinux joined #minetest-dev |
21:19 |
|
SloanOnLinux joined #minetest-dev |
21:21 |
sfan5 |
paramat: the texture? IMO the branches are too big |
21:21 |
sfan5 |
like |
21:21 |
sfan5 |
it's just a small bush |
21:22 |
sfan5 |
cut off one or two pixels |
21:23 |
paramat |
trees have really chunky trunks relative to their size, this is consistent in style |
21:23 |
paramat |
and these drop a whole wood node |
21:23 |
sfan5 |
i know i know |
21:23 |
paramat |
but sure will consider |
21:24 |
paramat |
anyway will add screenshot of final bush soon |
21:24 |
sfan5 |
yeah but one tree is 1 full node, one wood is 1/4 tree; branches drop wood so shouldn't they be as "thick" as 1/4 of a tree |
21:24 |
sfan5 |
;) |
21:26 |
sofar |
"meh" sorry :) |
21:27 |
sofar |
tbh you've made the texture darn well |
21:27 |
paramat |
1/4 of a tree would be 8 pixels across |
21:30 |
paramat |
i'm deliberately avoiding realism and making it chunky for consistent style, i dislike plantlife's realistic skinny twisty stems. still, i might try 4 pixels across |
21:32 |
paramat |
and make screenshots of both |
21:32 |
paramat |
by thinner branches do you mean thinner 'trunk' too? |
21:33 |
|
momo joined #minetest-dev |
21:36 |
paramat |
i assume so |
21:43 |
paramat |
heh, momo PM'd me with 'hi, some new mobs on minetest'. momo you can chat about mtgame dev in this channel |
21:52 |
garywhite |
Has anyone ever thought about porting MT to Windows Phone? |
21:54 |
garywhite |
According to Wikipedia, Windows 10 Mobile (basically Windows 10 for phones) is still based off of the Windows NT kernel, thus it should be semi-compatible to Windows desktop versions |
21:59 |
paramat |
eheh .. |
22:00 |
paramat |
we can barely cope with continuing android support :] |
22:03 |
garywhite |
Just suggesting cause it says that Windows 10 Mobile you can basically use standard Windows code just adjust it a tiny bit to make it Windows 10. Just throwing it out there |
22:04 |
paramat |
that's cool |
22:47 |
|
Grandolf joined #minetest-dev |
22:54 |
|
halt_ joined #minetest-dev |
23:24 |
|
twoelk|2 joined #minetest-dev |
23:48 |
|
garywhite joined #minetest-dev |
23:53 |
|
kaeza joined #minetest-dev |