Time |
Nick |
Message |
00:10 |
|
torgdor joined #minetest-dev |
00:15 |
|
paramat left #minetest-dev |
00:22 |
|
Fritigern joined #minetest-dev |
00:59 |
|
ssieb joined #minetest-dev |
01:04 |
|
Miner_48er joined #minetest-dev |
01:39 |
|
Tmanyo joined #minetest-dev |
02:50 |
|
Void7 joined #minetest-dev |
02:58 |
|
Tmanyo joined #minetest-dev |
03:22 |
|
Vexyl joined #minetest-dev |
03:34 |
|
Tmanyo joined #minetest-dev |
03:34 |
|
DI3HARD139 joined #minetest-dev |
05:13 |
|
Hunterz joined #minetest-dev |
05:52 |
|
ElectronLibre joined #minetest-dev |
06:07 |
|
jin_xi joined #minetest-dev |
06:15 |
|
burli joined #minetest-dev |
06:37 |
|
proller joined #minetest-dev |
07:01 |
|
Darcidride joined #minetest-dev |
07:17 |
|
alkotob joined #minetest-dev |
07:28 |
Hijiri |
Can someone add labels to #4409 ? |
07:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/4409 -- Attached Particle Spawners by raymoo |
07:32 |
|
Amaz joined #minetest-dev |
08:25 |
|
ElectronLibre joined #minetest-dev |
08:37 |
|
davisonio joined #minetest-dev |
09:25 |
|
Megaf joined #minetest-dev |
09:45 |
|
Megaf joined #minetest-dev |
09:45 |
|
davisonio joined #minetest-dev |
09:57 |
|
ElectronLibre joined #minetest-dev |
09:59 |
|
nrzkt joined #minetest-dev |
10:33 |
|
davisonio joined #minetest-dev |
10:50 |
|
ElectronLibre joined #minetest-dev |
11:16 |
|
Fixer joined #minetest-dev |
11:32 |
|
Sockbat joined #minetest-dev |
11:41 |
|
DonBatman joined #minetest-dev |
12:00 |
|
ElectronLibre joined #minetest-dev |
12:06 |
|
twoelk joined #minetest-dev |
12:25 |
|
davisonio joined #minetest-dev |
12:40 |
|
est31 joined #minetest-dev |
12:44 |
|
Megaf joined #minetest-dev |
12:53 |
|
rubenwardy joined #minetest-dev |
12:56 |
|
Megaf joined #minetest-dev |
13:04 |
|
T4im joined #minetest-dev |
13:04 |
|
Megaf joined #minetest-dev |
13:39 |
|
STHGOM joined #minetest-dev |
13:57 |
|
DI3HARD139 joined #minetest-dev |
13:57 |
|
Void7 joined #minetest-dev |
13:59 |
|
KaadmY joined #minetest-dev |
13:59 |
|
Megaf joined #minetest-dev |
14:03 |
|
davisonio joined #minetest-dev |
14:05 |
|
paramat joined #minetest-dev |
14:06 |
paramat |
nore sfan5 rubenwardy can anyone cnfirm this is not acceptable? game#470 shall we close? |
14:06 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/470 -- i18n support using gettext logic by netfab |
14:06 |
paramat |
(confirm) |
14:08 |
sfan5 |
yes localisation of subgames/mods will need support in the engine and should be done client-side |
14:08 |
paramat |
ok i say close |
14:10 |
|
STHGOM joined #minetest-dev |
14:11 |
paramat |
closed |
14:24 |
|
Void7 joined #minetest-dev |
14:27 |
|
davisonio joined #minetest-dev |
14:30 |
|
ElectronLibre joined #minetest-dev |
15:17 |
|
DI3HARD139 joined #minetest-dev |
15:30 |
|
jomat joined #minetest-dev |
15:35 |
|
Void7 joined #minetest-dev |
15:35 |
|
DI3HARD139 joined #minetest-dev |
15:38 |
|
jomat joined #minetest-dev |
15:40 |
|
hmmmm joined #minetest-dev |
15:56 |
|
davisonio joined #minetest-dev |
15:57 |
|
Vexyl joined #minetest-dev |
16:01 |
rubenwardy |
I'd like reviews for these: #4416 #4417 #4294 |
16:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/4416 -- Formspecs: Fix background elements from interferring with each other by rubenwardy |
16:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/4417 -- Formspecs: Add text field enter key event, allow fields to disable form close on enter by rubenwardy |
16:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/4294 -- Formspecs: Add container[] and container_end[] elements by rubenwardy |
16:03 |
|
Hunterz joined #minetest-dev |
16:28 |
|
lisac joined #minetest-dev |
16:31 |
|
Vexyl joined #minetest-dev |
16:51 |
|
nrzkt joined #minetest-dev |
16:56 |
|
davisonio joined #minetest-dev |
16:59 |
|
Krock joined #minetest-dev |
17:00 |
|
twoelk joined #minetest-dev |
17:05 |
|
Fixer joined #minetest-dev |
17:14 |
|
Darcidride joined #minetest-dev |
17:31 |
|
davisonio joined #minetest-dev |
17:33 |
Hijiri |
what constitutes a review? so I can know whether my PR has been reviewed or not |
17:33 |
Hijiri |
sofar made some comments but I don't know if that counts as a review |
17:34 |
sofar |
I didn't do a full review of that pr |
17:37 |
|
Void7 joined #minetest-dev |
17:41 |
Krock |
either you get approvals, [Won't Fix] and sometimes nothing |
17:42 |
Krock |
(nothing because there was none who looked at it) |
17:42 |
|
ssieb joined #minetest-dev |
17:53 |
|
davisonio joined #minetest-dev |
18:01 |
|
ElectronLibre joined #minetest-dev |
18:02 |
paramat |
a proper 'review' (in order to formally approve) is a complete code review: every changed line checked |
18:06 |
Hijiri |
ok, thanks |
18:13 |
|
est31 joined #minetest-dev |
18:24 |
|
davisonio joined #minetest-dev |
18:48 |
|
Void7 joined #minetest-dev |
18:49 |
|
DI3HARD139 joined #minetest-dev |
18:50 |
paramat |
might merge game#1255 later if no objections. will also merge game#1227 |
18:50 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1255 -- Fire: Use 'enable fire' setting instead of 'disable fire' by paramat |
18:50 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1227 -- fence inventory_image touchup by pithydon |
19:02 |
|
alkotob joined #minetest-dev |
19:08 |
|
rubenwardy joined #minetest-dev |
19:10 |
|
alkotob_ joined #minetest-dev |
19:28 |
|
Miner_48er joined #minetest-dev |
19:45 |
|
damiel_ joined #minetest-dev |
19:49 |
|
twoelk joined #minetest-dev |
19:50 |
|
blaze joined #minetest-dev |
20:17 |
|
hmmmmm joined #minetest-dev |
20:28 |
|
nolsen joined #minetest-dev |
20:34 |
|
VargaD joined #minetest-dev |
20:35 |
|
rubenwardy joined #minetest-dev |
20:35 |
|
jin_xi joined #minetest-dev |
20:40 |
|
STHGOM joined #minetest-dev |
21:13 |
|
Void7 joined #minetest-dev |
21:14 |
|
ElectronLibre joined #minetest-dev |
21:25 |
|
hmmmmmm joined #minetest-dev |
21:32 |
|
DI3HARD139 joined #minetest-dev |
21:33 |
|
hmmmmm joined #minetest-dev |
21:36 |
|
hmmmm joined #minetest-dev |
21:50 |
|
hmmmmm joined #minetest-dev |
21:51 |
|
DonBatman joined #minetest-dev |
21:58 |
|
hmmmmmm joined #minetest-dev |
22:02 |
|
hmmmmm joined #minetest-dev |
22:10 |
|
SloanOnLinux joined #minetest-dev |
22:12 |
|
hmmmmmm joined #minetest-dev |
22:18 |
|
DonBatman joined #minetest-dev |
22:49 |
|
DonBatman joined #minetest-dev |
23:02 |
|
Player_2 joined #minetest-dev |
23:04 |
|
est31 joined #minetest-dev |
23:09 |
|
johnnyjoy joined #minetest-dev |
23:32 |
est31 |
okay, I think we can make rubenwardy official core dev for the engine now as well |
23:33 |
est31 |
I've heard no official -1, and there was enough time for everyone to say "no" |
23:45 |
est31 |
rubenwardy, do you accept the vote |
23:53 |
|
Warr1024 joined #minetest-dev |
23:54 |
|
Warr1024 joined #minetest-dev |
23:55 |
paramat |
yeah i've only seen positive responses to the idea +1 |