Time  Nick       Message
07:28 Hijiri     Can someone add labels to #4409 ?
07:28 ShadowBot  https://github.com/minetest/minetest/issues/4409 -- Attached Particle Spawners by raymoo
14:06 paramat    nore sfan5 rubenwardy can anyone cnfirm this is not acceptable? game#470 shall we close?
14:06 ShadowBot  https://github.com/minetest/minetest_game/issues/470 -- i18n support using gettext logic by netfab
14:06 paramat    (confirm)
14:08 sfan5      yes localisation of subgames/mods will need support in the engine and should be done client-side
14:08 paramat    ok i say close
14:11 paramat    closed
16:01 rubenwardy I'd like reviews for these: #4416 #4417 #4294
16:01 ShadowBot  https://github.com/minetest/minetest/issues/4416 -- Formspecs: Fix background elements from interferring with each other by rubenwardy
16:01 ShadowBot  https://github.com/minetest/minetest/issues/4417 -- Formspecs: Add text field enter key event, allow fields to disable form close on enter by rubenwardy
16:01 ShadowBot  https://github.com/minetest/minetest/issues/4294 -- Formspecs: Add container[] and container_end[] elements by rubenwardy
17:33 Hijiri     what constitutes a review? so I can know whether my PR has been reviewed or not
17:33 Hijiri     sofar made some comments but I don't know if that counts as a review
17:34 sofar      I didn't do a full review of that pr
17:41 Krock      either you get approvals, [Won't Fix] and sometimes nothing
17:42 Krock      (nothing because there was none who looked at it)
18:02 paramat    a proper 'review' (in order to formally approve) is a complete code review: every changed line checked
18:06 Hijiri     ok, thanks
18:50 paramat    might merge game#1255 later if no objections. will also merge game#1227
18:50 ShadowBot  https://github.com/minetest/minetest_game/issues/1255 -- Fire: Use 'enable fire' setting instead of 'disable fire' by paramat
18:50 ShadowBot  https://github.com/minetest/minetest_game/issues/1227 -- fence inventory_image touchup by pithydon
23:32 est31      okay, I think we can make rubenwardy official core dev for the engine now as well
23:33 est31      I've heard no official -1, and there was enough time for everyone to say "no"
23:45 est31      rubenwardy, do you accept the vote
23:55 paramat    yeah i've only seen positive responses to the idea +1