| Time |
Nick |
Message |
| 00:25 |
|
Miner_48er joined #minetest-dev |
| 01:26 |
|
Ritchie joined #minetest-dev |
| 02:15 |
|
Anchakor joined #minetest-dev |
| 02:22 |
paramat |
ok will soon merge games 758 911 931 932 935 941 945 just need to check for conflicts |
| 02:27 |
paramat |
not 945, will do that later |
| 02:29 |
|
Void7 joined #minetest-dev |
| 02:29 |
paramat |
ok merging the first 6 |
| 02:43 |
|
kaadmy joined #minetest-dev |
| 02:45 |
paramat |
merged =P' |
| 02:55 |
rubenwardy |
awesome |
| 02:55 |
rubenwardy |
What do I need to do to get game#579 merged? |
| 02:55 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/579 -- Add give_initial_stuff API (and a setting) by rubenwardy |
| 03:06 |
|
yang2003 joined #minetest-dev |
| 03:07 |
paramat |
heh elusive devs |
| 03:07 |
kaadmy |
^ ie you :D |
| 03:07 |
paramat |
bug the other devs to review it |
| 03:14 |
paramat |
asking directly in-channel is the best way |
| 03:23 |
sofar |
game#916 just needs one minor adjustment. Tested OK |
| 03:23 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/916 -- Create API for registration of fence gate. by Rui914 |
| 03:31 |
|
Void7 joined #minetest-dev |
| 03:47 |
paramat |
ok |
| 03:56 |
|
est31 joined #minetest-dev |
| 03:56 |
est31 |
paramat, what's the reason to -1 ? #1768 |
| 03:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/1768 -- Add ability to escape commands with a back-slash by ShadowNinja |
| 03:57 |
paramat |
ok i'll add a reason |
| 04:00 |
paramat |
hm actually i don't feel strongly enough to -1, removed |
| 04:00 |
est31 |
that's fine too :) |
| 04:04 |
sofar |
https://forum.minetest.net/viewtopic.php?f=3&t=14228 |
| 04:04 |
sofar |
any comments? |
| 04:04 |
sofar |
please read |
| 04:14 |
est31 |
paramat, i do think we should add them up |
| 04:14 |
est31 |
if we don't how should we keep track when a pr is mergeable |
| 04:17 |
paramat |
well, is someone disapproves, this doesn't remove the approval of another dev. also, the rules are that a PR is mergeable with approvals from 2 core devs |
| 04:18 |
paramat |
but yes discussion and disapprovals have to be addressed |
| 04:19 |
est31 |
paramat, so you say that if two devs approve, and two disapprove they can game the system? |
| 04:19 |
est31 |
pr gets proposed, gets two +1 and two +1 |
| 04:19 |
est31 |
gets merged because two +1 |
| 04:19 |
est31 |
second pr gets proposed, this time by dev who -1ed |
| 04:19 |
est31 |
it reverts older pr |
| 04:20 |
est31 |
gets two +1 and two -1 again |
| 04:20 |
est31 |
and so on and so on |
| 04:22 |
paramat |
well i agree that we can't mechanically follow +2 = merge, each situation has to be considered flexibly |
| 04:23 |
paramat |
but i think the labels should not be a result of addition, but show that 2 devs approve |
| 04:24 |
est31 |
well what are the labels for any way |
| 04:24 |
paramat |
sofar good idea |
| 04:24 |
est31 |
^ |
| 04:25 |
paramat |
perhaps we should use 'controversial' when there are many disapprovals |
| 04:25 |
est31 |
paramat, you just added them without a word |
| 04:25 |
paramat |
i'm going through PRs adding the labels if it is clear a dev approves |
| 04:26 |
est31 |
those labels caused some confusion in the past |
| 04:26 |
est31 |
e.g. SN has added a label to one of my PRs |
| 04:26 |
est31 |
i wondered what that means |
| 04:27 |
est31 |
1. does he think I +1 my own PR, and now he adds the label to track this |
| 04:27 |
est31 |
2. does he +1 it himself |
| 04:27 |
est31 |
so one could interpret you adding the approval label as approval yourself paramat |
| 04:28 |
est31 |
and I do think that controversial changes should have it harder to get merged |
| 04:28 |
est31 |
imagine if RBA were a dev paramat |
| 04:29 |
paramat |
yes good point about self-approval, i think only the author can self approve. approvals by others are clear from their comment '+1' |
| 04:30 |
est31 |
and he +1ed his PR #3496 |
| 04:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/3496 -- Add 3d_plantlike optional drawtype by RealBadAngel |
| 04:30 |
est31 |
i +1 it |
| 04:31 |
est31 |
and he +1es it |
| 04:31 |
est31 |
so two +1es |
| 04:31 |
est31 |
and you and others can do what they want |
| 04:31 |
paramat |
i agree |
| 04:32 |
paramat |
so the approval labels are just a guide |
| 04:32 |
est31 |
IMO it serves as a better guide if you look at the sum |
| 04:37 |
paramat |
very useful sun though |
| 04:38 |
kaadmy |
what's #3496 do? |
| 04:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/3496 -- Add 3d_plantlike optional drawtype by RealBadAngel |
| 04:50 |
est31 |
kaadmy, it was closed due to disagreement from coredevs |
| 04:50 |
est31 |
(me not included) |
| 04:57 |
|
thePalindrome joined #minetest-dev |
| 05:22 |
est31 |
paramat, on 2627 the submitter needs a perspective on getting this PR merged |
| 05:22 |
est31 |
if we don't +1 PRs and merge them in time, we create the impression (especially to only casual contributors) that we dont merge their stuff |
| 05:23 |
est31 |
and that impression is accurate in fact :) |
| 05:23 |
est31 |
err |
| 05:23 |
est31 |
s/:)/:(/ |
| 05:29 |
paramat |
yes lots of old half dead PRs, we need to get clean up more |
| 05:29 |
paramat |
(- get) |
| 05:31 |
est31 |
yeah |
| 05:31 |
paramat |
closed it |
| 05:32 |
paramat |
i'll go through them again and poke the authors |
| 05:32 |
est31 |
paramat, generally closing should be only the last resort |
| 05:32 |
est31 |
but in this case I agree, because the PR creator hasn't expressed that they would update the PR |
| 05:33 |
paramat |
ok |
| 05:33 |
paramat |
generally after a year i will poke for a resolution or a close |
| 05:34 |
paramat |
or as per git guidelines, close if no reply after a month |
| 05:34 |
paramat |
it's not just our fault, many authors will let stuff rot |
| 05:34 |
est31 |
I think the wording is "may be closed" |
| 05:34 |
est31 |
not "gets" closed |
| 05:34 |
est31 |
but yeah |
| 05:35 |
est31 |
well idk |
| 05:35 |
|
Warr1024 joined #minetest-dev |
| 05:35 |
paramat |
game is looking quite good now |
| 05:35 |
sofar |
I'm writing up my wish list for 0.4.15 |
| 05:36 |
paramat |
30 each for PRs and issues |
| 05:36 |
est31 |
30 open issues? |
| 05:36 |
est31 |
idk, we can do it like the nmap guy |
| 05:36 |
sofar |
I also suggest we do a massive merge-anything-that-smells-good after 0.4.15 to let it cook |
| 05:36 |
est31 |
close each feature request |
| 05:36 |
paramat |
yeah 30 open of each |
| 05:37 |
paramat |
0.4.15 -> farmap |
| 05:40 |
sofar |
right, that would be one of the things |
| 05:49 |
sofar |
https://forum.minetest.net/viewtopic.php?f=7&t=14229 |
| 05:49 |
sofar |
there, lol |
| 05:49 |
sofar |
should keep us busy after 0.4.14 |
| 06:06 |
OldCoder |
paramat, I've posted an edited version of our mapgen discussion in the other channel |
| 06:06 |
OldCoder |
Thank you again for your time |
| 06:06 |
paramat |
ok cool |
| 06:10 |
|
Hunterz joined #minetest-dev |
| 06:32 |
est31 |
<paramat> Answer #3: not possible in core, use a lua voxelmanip to place air below -4000 |
| 06:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/3 -- Furnace segfault |
| 06:32 |
est31 |
placing air is a bad idea |
| 06:32 |
est31 |
you mine down then you fall down indefinitely |
| 06:33 |
est31 |
and cause countless mapblocks to be generated |
| 06:34 |
est31 |
I've seen a better approach: simply teleporting players who exceed map borders |
| 06:35 |
paramat |
that was discussing adding a lower realm using a lua mapgen to place air, then lower still another realm |
| 06:35 |
est31 |
ah |
| 06:35 |
est31 |
okay |
| 06:35 |
est31 |
there is still the problem with the lighting, no? |
| 06:36 |
paramat |
the conversation is not very clear, with some misunderstandings on both sides |
| 06:37 |
paramat |
well i added a 'propagate shadow' bool to both engine and lua voxelmanip, that can stop higher realms shadowing lower ones |
| 06:37 |
paramat |
that's enabling floatlands in my next mapgen |
| 06:38 |
paramat |
and enables floatlands in mgv7 if we want that |
| 07:19 |
|
Megaf joined #minetest-dev |
| 07:21 |
est31 |
nic |
| 07:21 |
est31 |
e |
| 07:37 |
|
Obani joined #minetest-dev |
| 07:45 |
est31 |
sofar, seen this? https://github.com/minetest/minetest/issues/3874 |
| 07:46 |
est31 |
wondering whether its a dupe of #3873 |
| 07:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/3873 -- Incorrectly selected node after node change with node highlighting |
| 07:49 |
Obani |
oh |
| 07:49 |
Obani |
4aiman still is there ? |
| 08:03 |
|
Darcidride joined #minetest-dev |
| 08:42 |
|
Amaz joined #minetest-dev |
| 09:05 |
|
nrzkt joined #minetest-dev |
| 09:36 |
nore |
~tell est31 not dupe, but probably caused by same code |
| 09:36 |
ShadowBot |
nore: O.K. |
| 09:54 |
|
DevBox joined #minetest-dev |
| 10:46 |
|
Samson1 joined #minetest-dev |
| 10:54 |
|
Lunatrius` joined #minetest-dev |
| 10:54 |
|
celeron55 joined #minetest-dev |
| 11:04 |
|
celeron55 joined #minetest-dev |
| 11:15 |
|
celeron55 joined #minetest-dev |
| 11:31 |
|
est31 joined #minetest-dev |
| 11:46 |
|
celeron55 joined #minetest-dev |
| 11:57 |
|
celeron55 joined #minetest-dev |
| 12:07 |
|
celeron55 joined #minetest-dev |
| 12:09 |
|
Lunatrius` joined #minetest-dev |
| 12:17 |
|
Calinou joined #minetest-dev |
| 12:30 |
|
celeron55 joined #minetest-dev |
| 12:41 |
|
Fixer joined #minetest-dev |
| 12:41 |
|
Obani joined #minetest-dev |
| 12:44 |
|
Indohmo joined #minetest-dev |
| 13:00 |
|
turtleman joined #minetest-dev |
| 13:02 |
|
celeron55 joined #minetest-dev |
| 13:03 |
|
STHGOM joined #minetest-dev |
| 13:37 |
|
celeron55 joined #minetest-dev |
| 13:52 |
|
everamzah joined #minetest-dev |
| 14:22 |
|
blaze joined #minetest-dev |
| 14:37 |
|
kaadmy joined #minetest-dev |
| 14:38 |
|
est31 joined #minetest-dev |
| 14:50 |
|
est joined #minetest-dev |
| 15:08 |
|
davisonio joined #minetest-dev |
| 15:11 |
|
hmmmm joined #minetest-dev |
| 15:14 |
|
srifqi joined #minetest-dev |
| 15:53 |
|
srifqi joined #minetest-dev |
| 16:21 |
|
Player_2 joined #minetest-dev |
| 16:24 |
|
Hunterz joined #minetest-dev |
| 16:27 |
|
Void7 joined #minetest-dev |
| 16:42 |
|
SaKeLWorld joined #minetest-dev |
| 16:53 |
|
Fixer_ joined #minetest-dev |
| 16:57 |
|
Krock joined #minetest-dev |
| 17:03 |
|
linkedinyou joined #minetest-dev |
| 17:14 |
|
Megaf joined #minetest-dev |
| 17:37 |
|
Gael-de-Sailly joined #minetest-dev |
| 18:27 |
|
ud1 joined #minetest-dev |
| 18:36 |
|
Void7 joined #minetest-dev |
| 19:05 |
|
twoelk joined #minetest-dev |
| 19:10 |
|
kilbith joined #minetest-dev |
| 19:11 |
kilbith |
wouldn't that a good idea to stick this topic up momentarily ? https://forum.minetest.net/viewtopic.php?f=3&t=14228 |
| 19:11 |
kilbith |
the more help to RBA the better |
| 19:28 |
|
Gael-de-Sailly joined #minetest-dev |
| 20:04 |
celeron55 |
has that been actually confirmed to be true now? |
| 20:04 |
celeron55 |
last time i heard it seemed completely dubious |
| 20:07 |
|
blaze joined #minetest-dev |
| 20:09 |
sofar |
celeron55: vanessa has talked to rba's girlfiend, we both had conversations with his buddy |
| 20:10 |
VanessaE |
yeah, it's unfortunately true :( |
| 20:11 |
sofar |
also, we knew he had hearth disease before for a while. |
| 20:11 |
VanessaE |
yeah, he was taking meds for extremely high blood pressure. |
| 20:12 |
celeron55 |
well that seems kind of unfortunate |
| 20:12 |
sofar |
afk a bit for some lunch |
| 20:13 |
|
Taoki joined #minetest-dev |
| 20:16 |
celeron55 |
as for how this affects the actual subject of this channel, i guess everyone knows our bus factor for graphics related stuff wasn't very high so this might have some actual impact on something other than the feelings of people too |
| 20:18 |
celeron55 |
potentially quite a lot |
| 20:21 |
kilbith |
but you came back into that stuff so the bus factor is preserved |
| 20:21 |
celeron55 |
nope; not even close |
| 20:22 |
VanessaE |
meanwhile I've stickied the topic forum topic, per kilbith's suggestion. |
| 20:22 |
VanessaE |
s/the topic/the / |
| 20:22 |
kilbith |
thanks Vanessa |
| 20:22 |
VanessaE |
yw |
| 20:22 |
Obani |
Is he alive at least ? |
| 20:22 |
VanessaE |
yes |
| 20:23 |
Obani |
I mean, will it be possible for him to walk, go into the streets... |
| 20:23 |
VanessaE |
no. |
| 20:23 |
Obani |
The topic was quite unclear about that :s |
| 20:23 |
VanessaE |
he's alive but does not have all of his faculties, to put it mildly. |
| 20:24 |
VanessaE |
there was a conversation in #minetest yesterday where basically his best friend said he's been reduced to the mental capacity of a newborn :( |
| 20:24 |
Obani |
This is a sad period for Minetest also... |
| 20:24 |
Obani |
ow |
| 20:24 |
Obani |
ow |
| 20:25 |
Obani |
dude |
| 20:25 |
celeron55 |
shit happens |
| 20:26 |
Obani |
yeah |
| 20:27 |
celeron55 |
this just seems very inconvenient as even death could have been less worse |
| 20:27 |
Obani |
heads or tails |
| 20:27 |
kilbith |
i thought the same too |
| 20:27 |
Obani |
What would be the best |
| 20:27 |
Obani |
I seriously don't know |
| 20:28 |
Obani |
I feel bad to only think about it as a Minetest developer |
| 20:29 |
celeron55 |
well, frankly i'm going to go on with my life as if nothing happened, but it must be said that his brain starting to work again would be... more pleasant than not |
| 20:30 |
Obani |
And here I'm flying to the forum and see TMT and myholes and all this hapiness |
| 20:30 |
Obani |
And close the tab |
| 20:33 |
celeron55 |
but i'm sure some people in this community have a closer relationship with RBA and, well, obviously can do whatever they want |
| 20:39 |
celeron55 |
there are a few open PRs by RBA hanging around; maybe it would be somewhat tasteful to either merge or close them |
| 20:39 |
celeron55 |
dunno |
| 20:39 |
Fixer |
#3770 gives very big fps boost for me |
| 20:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/3770 -- Fix superflous shader setting updates by ShadowNinja |
| 20:39 |
kilbith |
i think a message of support from the leader would give an image of cohesive community |
| 20:39 |
Fixer |
but has some lighting bug |
| 20:40 |
kilbith |
RBA is a part of the Minetest's identity |
| 20:41 |
Fixer |
ofc |
| 20:41 |
celeron55 |
well, i can say something, but it will not be exactly what you want to hear |
| 20:42 |
celeron55 |
i am not that kind of public speaker |
| 20:44 |
Obani |
celeron55, if you mean that you're not a politician then that's all right |
| 20:46 |
sofar |
I don't see a need for Celeron55 to say anything official, or anyone, even |
| 20:46 |
sofar |
even my message was personal and certainly not official |
| 20:48 |
Fixer |
we can only hope for the best |
| 20:49 |
Obani |
I think it's a good idea to have an official message |
| 20:49 |
Obani |
I mean a good initiative* |
| 20:49 |
Obani |
s/a/some |
| 20:53 |
celeron55 |
well i am not going to write anything because i never do; if something official is written, then it would be a post in the forum news section by a core developer who is the closest to the matter at hand (not sure who in this case); this is how it's worked for years for everything and it will work now too |
| 20:55 |
sofar |
which I already have, so |
| 20:56 |
celeron55 |
well; it's in general discussion, but other than that it fits that picture |
| 21:00 |
celeron55 |
i replied to that topic so now it is so officially official that nobody can ask for more |
| 21:02 |
|
Taoki joined #minetest-dev |
| 21:26 |
|
ekem joined #minetest-dev |
| 21:28 |
Obani |
you know to talk |
| 21:31 |
|
_tutima joined #minetest-dev |
| 21:41 |
|
rubenwardy joined #minetest-dev |
| 22:03 |
|
Miner_48er joined #minetest-dev |
| 22:07 |
Obani |
https://up1.ca/#jtPKo2-NjY6hQaRi_eUFiQ |
| 22:33 |
|
davisonio joined #minetest-dev |
| 22:45 |
|
Void7 joined #minetest-dev |
| 22:51 |
|
turtleman joined #minetest-dev |
| 23:13 |
|
Obani joined #minetest-dev |
| 23:13 |
|
proller joined #minetest-dev |
| 23:33 |
|
kaeza joined #minetest-dev |
| 23:49 |
|
proller joined #minetest-dev |
| 23:56 |
|
kilbith joined #minetest-dev |
| 23:56 |
|
kilbith left #minetest-dev |
| 23:56 |
|
turtleman joined #minetest-dev |
