Minetest logo

IRC log for #minetest-dev, 2016-03-03

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:22 paramat now merging game 823 875 890
00:22 ssieb paramat: I see some weird shadow issues.  http://sieb.net/mt-shadow1.png http://sieb.net/mt-shadow2.png  Any idea if it's mapgen, mods, some combination, or what?  mapgen v7 (mg_flags = trees, caves, dungeons, noflat, light) with biomes mod
00:24 paramat known issue. moretrees mod causes shadows when used with with mgv7, use the mod option to place trees as saplings instead
00:26 ssieb what causes the shadows?
00:26 paramat it's an engine issue but the way moretrees works triggers the bug
00:26 ssieb is there an issue filed?
00:26 paramat it happens when l-system trees re generated to sson after mapgen, when the mapchunk above has not yet been generated
00:27 paramat (are)
00:27 paramat (too soon)
00:28 paramat yes issues are filed
00:29 iamafriend joined #minetest-dev
00:30 ssieb ok.  I had heard about moretrees causing shadows, but it wasn't clear that that was the case here.
00:30 ssieb But why does it happen with v7 and not v6?
00:31 paramat all mapgens except mgv6 use 1 up 1 down overgeneration, this seems to cause the bug
00:32 celeron55 here is a menu design that i am working on: https://github.com/celeron55/minetest/commits/menustuff
00:32 paramat something to do with the lightng call being different
00:32 celeron55 the home screen looks like this: http://i.imgur.com/Q6DWM96.png
00:35 celeron55 (singleplayer and settings work, other things don't)
00:44 celeron55 it's kind of slightly impressive what the formspec system is capable of these days without touching any C++
00:46 paramat merge complete
00:46 est31 joined #minetest-dev
00:46 paramat good to see work on menu
00:55 ssieb paramat: even with the sapling option, they still generate big square shadows, but at least it's not as dark
00:56 paramat ok, the engine's 'update lighting' does need work and is probably the cause
00:57 paramat shadows when saplings grow are a known bug too. is there a shadow for every tree or less?
00:59 est31 and now, I do work on my prs
00:59 est31 finally get them ready for review
01:03 ssieb paramat: Looks like it.  Every moretrees tree generates a big square, but not the default trees. http://sieb.net/mt-shadow3.png
01:04 paramat interesting, a different kind of bug =/
01:04 paramat the l-system code might need work too
01:05 ssieb There are still shadows for the leaves as well.
01:09 ssieb paramat: It looks like the shadow problem only affects water.  There's no obvious shadow on the sand areas.
01:10 paramat ok
01:10 ssieb And now that I think about it, I'm pretty sure it was the same when I wasn't using the saplings.
01:11 * ssieb will test that
01:13 ssieb No, I was wrong.  Without the sapling setting, the shadows are really dark and cover the ground as well.
01:24 ssieb And it still does it sometimes when the saplings grow... :-(
01:25 ssieb Maybe I'll just have to go back to v6 mapgen.
01:31 paramat nooo!
01:31 ssieb More weird.  At one spot I chopped a piece out a tree and the big shadow went back to just the lighter square.  But it didn't work on another tree nearby...
01:32 paramat yes digging updates lighting, but sometimes only partially fixes the shadow
01:33 paramat i intend to attempt a fix for these but it will be tough
01:48 Miner_48er joined #minetest-dev
02:21 Taoki_1 joined #minetest-dev
02:23 friti joined #minetest-dev
02:30 yang2003 joined #minetest-dev
03:23 ShadowBot` joined #minetest-dev
03:25 Garth joined #minetest-dev
03:25 Anchakor joined #minetest-dev
03:26 eeew joined #minetest-dev
03:28 kaadmy joined #minetest-dev
03:29 paramat joined #minetest-dev
03:32 dzho joined #minetest-dev
04:04 paramat left #minetest-dev
04:16 linkedinyou joined #minetest-dev
04:22 ShadowNinja Merging #1952.
04:22 ShadowBot https://github.com/minetest/minetest/issues/1952 -- Use the console instead of a dedicated window when pressing chat/command keys by ShadowNinja
04:24 ShadowNinja I'll leave it as 5 seperate commits unless someone has an issue with that.
04:31 Dragonop_ joined #minetest-dev
04:53 ShadowNinja #3810
04:53 ShadowBot https://github.com/minetest/minetest/issues/3810 -- Try to fix jumping at node edge again by ShadowNinja
04:53 ShadowNinja ^ Works for me, but there are all sorts of edge cases to check with this code.
05:01 est31 joined #minetest-dev
05:01 est31 anybody want to review https://github.com/minetest/minetest/pull/3677
05:02 est31 ShadowNinja, #3788 can perhaps be fixed by removing getupvalue
05:02 ShadowBot https://github.com/minetest/minetest/issues/3788 -- Bypassable security using upvalues
05:02 est31 but what about the other functions
05:02 est31 kaeza says they should be removed too
05:03 * ShadowNinja 'd : https://github.com/minetest/minetest/issues/3788#issuecomment-191585573
05:03 est31 its a reply on it :)
05:03 ShadowNinja est31: The debug library is dangerous, but some parts are safe and necessary, eg, the LuaC needs sethook.
05:05 est31 probably sethook is safe
05:08 ShadowNinja Oh, I have the getupvalue fix ready to push.  Look O.K.?
05:09 est31 my argument remains: what about the other debug methods
05:09 est31 which are required, and why
05:09 ShadowNinja est31: Well, I checked them and they all *seemed* safe.
05:11 ShadowNinja The issue is that all of the "Lua sandboxing" docs only cover sandboxing Lua from Lua, and a *lot* more things are safe if you do it from C.  Also, they don't have ReqIE to consider.
05:11 est31 ReqIE?
05:12 ShadowNinja req_insec_env
05:12 est31 ah
05:13 est31 okay, well then push the fix for the issue removing that single function, and then we can look later whether there is something insecure remaining
05:13 est31 I'm going to bed now
05:14 est31 bye
05:18 everamzah joined #minetest-dev
06:19 Hunterz joined #minetest-dev
06:53 DevBox joined #minetest-dev
07:44 DFeniks joined #minetest-dev
07:58 ssieb joined #minetest-dev
08:03 Darcidride joined #minetest-dev
08:04 vincentux joined #minetest-dev
08:04 vincentux left #minetest-dev
08:33 nrzkt joined #minetest-dev
09:29 proller joined #minetest-dev
09:56 proller joined #minetest-dev
10:15 proller joined #minetest-dev
10:19 Niebieski joined #minetest-dev
10:45 Obani joined #minetest-dev
10:49 kaeza joined #minetest-dev
10:50 Obani joined #minetest-dev
11:26 troller joined #minetest-dev
11:53 exio4 I don't deserve my name in the commit log for that :P
12:11 dfelinto joined #minetest-dev
12:15 Hunterz hi exio thanks for use console instead of dedicated window for chat!
12:16 Calinou joined #minetest-dev
12:45 turtleman joined #minetest-dev
13:18 Fixer joined #minetest-dev
13:46 Niebieski joined #minetest-dev
13:54 Niebieski joined #minetest-dev
14:00 Player_2 joined #minetest-dev
14:14 Niebieski joined #minetest-dev
14:19 Megaf joined #minetest-dev
14:46 STHGOM joined #minetest-dev
14:55 mtmodder148 joined #minetest-dev
15:23 kaeza joined #minetest-dev
15:46 kaadmy joined #minetest-dev
16:05 iqualfragile joined #minetest-dev
16:25 iqualfragile joined #minetest-dev
16:29 iqualfragile joined #minetest-dev
16:37 iqualfragile joined #minetest-dev
16:57 Krock joined #minetest-dev
16:58 hmmmm joined #minetest-dev
17:28 ud1 joined #minetest-dev
17:29 iqualfragile joined #minetest-dev
17:35 iqualfragile joined #minetest-dev
17:42 paramat joined #minetest-dev
17:52 Calinou joined #minetest-dev
17:59 paramat sfan5 any comments on the updated jungletree top? game#880 . please read first post for explanation. might make the dark brown less dark for PilzAdam
17:59 ShadowBot https://github.com/minetest/minetest_game/issues/880 -- Default: New jungletree_top texture by paramat
18:12 VanessaE paramat: let's just fix the misaligned edge of the top and otherwise leave well-enough alone.
18:12 rubenwardy joined #minetest-dev
18:16 paramat nope the current texture is ugly
18:16 VanessaE it's a tree, not the Mona Lisa :P
18:17 paramat also for PilzAdam i might make the ring a little darker
18:18 rubenwardy I think the problem is that our textures have no fixed palette, which is what pixel art should have to look good
18:18 VanessaE his argument parallels mine - those rings are too "hard", bright.
18:19 paramat yes it's too bright
18:19 Obani paramat, the ring is an error IMO
18:19 Obani And I don't understand why do you do it
18:20 Obani a real tree is circular
18:20 VanessaE ...ish.
18:20 Obani Don't play with words please
18:20 Obani :p
18:21 nolsen joined #minetest-dev
18:21 Obani paramat, do you get what I say ?
18:21 paramat read the first post for why. MT trees are mostly square
18:22 Obani Yes
18:22 Obani well
18:22 Obani We're in a world of voxels
18:22 Obani Isn't it normal ?
18:23 Obani In real life it's circular
18:23 Obani But here we're in a worl of voxels !
18:23 Obani what you do here would like if it was a square in real life
18:24 Obani (the ring)
18:24 Obani s/wouls/is
18:24 paramat mine is a square truncated by the 4 lianas at the corners, read
18:25 Obani I'm talking about the tree top
18:26 paramat me too
18:26 paramat *=/
18:27 Obani still
18:27 Obani it doesn't work
18:27 Obani And I don't see any lianas on this
18:27 Obani Except those one pixel things over straight
18:28 Obani Also
18:29 Obani I don't understand why do you take so much time talking about this amazingly important feature
18:29 Obani As it just needs to be good looking, coherent, and look a little bit like a tree
18:30 Obani Some good pixel artist could make it within 4 hours
18:30 Obani Here it's not some shit with lianas, it's just lava with wood colors
18:31 * paramat fetches popcorn
18:34 fling joined #minetest-dev
18:52 nolsen joined #minetest-dev
18:56 hcorion joined #minetest-dev
18:58 hcorion Hiya folks! I'm interested in helping to develop minetest (programming). Where might I get started? I understand C++ fairly well.
18:58 paramat hi
18:58 paramat nore sfan5 i've added 2 PR/issue labels to MTGame 'one approval' 'two approvals'
18:58 Krock Check out the GitHub repository ;)
18:58 sfan5 ok
18:59 paramat i started by reading code of a part i was most interested in (mapgen)
18:59 paramat then experimenting within my own local branches
19:00 paramat make sure to join github and follow dev work at the repo
19:01 paramat and monitoring this channel is useful
19:01 Obani hcorion, Where would you like to begin ?
19:02 hcorion Probably android, but I would like to get a feel for the minetest codebase first
19:11 Calinou hcorion, read our developer wiki: http://dev.minetest.net/
19:11 Calinou it has information about creating mods, and working on the engine
19:21 Hunterz joined #minetest-dev
19:51 paramat nore sfan5 what are your opinions on game#312 ? it has 2 -1s already
19:51 ShadowBot https://github.com/minetest/minetest_game/issues/312 -- Faster movement speeds for less boring gameplay by Calinou
19:58 ssieb paramat: How can I try the valleys mapgen?  Minetest says it's not registered.  Am I using the wrong name or is it disabled?
19:59 paramat you have 0.4.13dev?
20:00 ssieb yes
20:00 paramat !tell ShadowNinja https://github.com/minetest/minetest_game/pull/891#issuecomment-191936730
20:00 ShadowBot paramat: O.K.
20:00 paramat mgvalleys is in the mapgen selector but you might need to scroll down
20:01 ssieb ok, I had the name wrong
20:01 paramat ok
20:01 ssieb I'm running a local server, so I'm editing the config file there
20:02 ssieb oops, it looks like I didn't put the new version on the server :-(
20:03 paramat actually it is 'mg_name = valleys'
20:04 ssieb ok
20:04 paramat this is not documented in .conf, oops
20:04 paramat will fix
20:05 ssieb No errors this time about unregistered mapgen. :-)  Have to go out for a bit, will check it out later.
20:08 sfan5 paramat: commented -1 on 312
20:08 nore paramat: I agree with closing too
20:08 paramat ok will do
20:09 nore paramat: about "one approval" / "two approvals": I added those labels to a few issues this morning, also I filled the 0.4.14 milestone a bit
20:09 paramat ok
20:10 paramat sfan5 any opinion on game#880 ? i will reduce ring brightness a little
20:10 ShadowBot https://github.com/minetest/minetest_game/issues/880 -- Default: New jungletree_top texture by paramat
20:12 paramat (or, i might reduce the brightness)
20:13 hcorion Hi everybody, I'm back. I'm having trouble building Minetest via CMake and Visual Studio 2015 64-bit. I've got all the dependencies installed from here: http://dev.minetest.net/Compiling_Minetest#Cross-compilation But I'm still getting compile errors about needing sqlite3, which is not even mentioned in the compiling page
20:14 paramat anyway it will be edited slightly soon
20:15 paramat i follow the compiling instructions here in the readme https://github.com/minetest/minetest_game/pull/891#issuecomment-191936730
20:15 paramat that might be more up to date
20:15 paramat oh wrong link
20:15 paramat https://github.com/minetest/minetest
20:18 hcorion AFAIK, it still doesn't mention sqlite3
20:18 paramat libsqlite3-dev?
20:18 hcorion Sorry, windows
20:18 paramat ah
20:19 hcorion Thought you would clue in when I mentioned Visual Studio
20:19 paramat sorry
20:19 hcorion np
20:24 Robert_Zenz joined #minetest-dev
20:28 Robert_Zenz left #minetest-dev
20:30 Niebieski joined #minetest-dev
20:34 paramat maybe ask in #minetest channel too? as it's quiet here
20:34 Calinou since you are closing my pull request, are we getting sprinting? :/
20:34 paramat absolutely not ;)
20:35 kaeza that could be useful
20:36 nrzkt joined #minetest-dev
20:37 Obani joined #minetest-dev
20:39 nore yep, sprinting is definitely needed
20:40 nore it would be good to have something gameplay-wise that would make it interesting
20:40 nore (hunger?)
20:48 sofar I was thinking of putting it in my stamina mod
21:32 nore sofar: yeah, that's what I was thinking
21:32 nore but that means engine change (player meta) too :/
21:33 nore that should be added sooner or later anyway
21:33 paramat celeron55 i like this one http://i.imgur.com/SWlXmUj.png
21:33 celeron55 did you watch 55 minutes of that?
21:34 paramat lol i skipped through
21:34 paramat saw it by chance
21:34 celeron55 i wonder where that is from
21:34 celeron55 there's literally no way to tell
21:35 Fixer 55 minutes?
21:36 paramat https://www.youtube.com/watch?v=SRubE_ZrSEw
21:37 Calinou lol this is great
21:37 Fixer 2 hours?
21:37 Calinou first image is from More Blocks =)
21:50 Amaz joined #minetest-dev
23:06 Fixer joined #minetest-dev
23:27 paramat left #minetest-dev
23:53 Miner_48er joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext