| Time |
Nick |
Message |
| 00:38 |
|
Soni joined #minetest-dev |
| 01:04 |
|
luizrpgluiz joined #minetest-dev |
| 01:14 |
|
Soni joined #minetest-dev |
| 02:09 |
|
crazyR joined #minetest-dev |
| 03:09 |
|
Robby joined #minetest-dev |
| 03:14 |
|
Sokomine joined #minetest-dev |
| 03:40 |
|
OldCoder joined #minetest-dev |
| 04:17 |
|
Soni joined #minetest-dev |
| 05:26 |
|
DFeniks joined #minetest-dev |
| 05:42 |
|
Hunterz joined #minetest-dev |
| 06:06 |
|
neti_netwalker joined #minetest-dev |
| 06:17 |
|
nrzkt joined #minetest-dev |
| 07:08 |
|
PilzAdam joined #minetest-dev |
| 08:02 |
|
Icedream joined #minetest-dev |
| 08:48 |
|
rubenwardy joined #minetest-dev |
| 09:24 |
|
Megaf_ joined #minetest-dev |
| 10:11 |
|
proller joined #minetest-dev |
| 10:17 |
|
proller joined #minetest-dev |
| 11:04 |
|
julienrat joined #minetest-dev |
| 11:08 |
|
julienrat left #minetest-dev |
| 11:10 |
|
Calinou joined #minetest-dev |
| 11:53 |
|
proller joined #minetest-dev |
| 12:57 |
|
zat joined #minetest-dev |
| 13:04 |
|
Player2 joined #minetest-dev |
| 13:24 |
|
Taoki joined #minetest-dev |
| 13:26 |
|
Fritigern joined #minetest-dev |
| 14:06 |
|
luizrpgluiz joined #minetest-dev |
| 14:48 |
|
younishd joined #minetest-dev |
| 14:59 |
|
CraigyDavi joined #minetest-dev |
| 15:00 |
|
luizrpgluiz left #minetest-dev |
| 15:01 |
|
Tesseract joined #minetest-dev |
| 15:03 |
|
Guest81938 joined #minetest-dev |
| 15:04 |
|
exoplane- joined #minetest-dev |
| 15:06 |
|
exoplanet joined #minetest-dev |
| 15:08 |
|
VargaD joined #minetest-dev |
| 15:12 |
|
Player2 joined #minetest-dev |
| 15:27 |
|
nrzkt joined #minetest-dev |
| 15:30 |
|
julienrat joined #minetest-dev |
| 15:30 |
|
julienrat left #minetest-dev |
| 15:45 |
|
rubenwardy joined #minetest-dev |
| 15:58 |
|
Hunterz joined #minetest-dev |
| 16:01 |
|
electrodude512 joined #minetest-dev |
| 16:03 |
|
electrodude512 left #minetest-dev |
| 16:03 |
|
electrodude512 joined #minetest-dev |
| 16:03 |
|
electrodude512 left #minetest-dev |
| 16:06 |
|
electrodude512 joined #minetest-dev |
| 16:07 |
|
electrodude512 left #minetest-dev |
| 16:17 |
|
Robert_Zenz joined #minetest-dev |
| 16:19 |
|
est31 joined #minetest-dev |
| 16:25 |
|
Krock joined #minetest-dev |
| 16:28 |
Krock |
https://github.com/minetest/minetest/commit/6be74d1#diff-92729a668babc433abcbe4987f8e14e6R65 |
| 16:28 |
Krock |
Must be ` typedef DWORD WINAPI ThreadStartFunc(LPVOID param); ` |
| 16:30 |
est31 |
stripped parens? |
| 16:31 |
Krock |
Same goes for https://github.com/minetest/minetest/commit/765a834#diff-3465219267c4baa9779cd47acef1bf20R263 |
| 16:31 |
Krock |
est31, the brackets |
| 16:32 |
est31 |
so you say it doesnt build for you? |
| 16:32 |
Krock |
Now, after chaning it builds ;) |
| 16:32 |
Krock |
Before it threw an syntax error near ')' |
| 16:32 |
Krock |
Hold on.. more errors - this tine in egttext - are coming :) |
| 16:33 |
est31 |
hasn't hmmm tested the buildbot... |
| 16:33 |
Krock |
s/tine/time/ |
| 16:33 |
est31 |
used* |
| 16:34 |
Krock |
https://github.com/minetest/minetest/commit/e067cea#diff-e113376dbe38a56bd7b78ceee408d203R167 |
| 16:34 |
Krock |
appname.size -> app_name.size |
| 16:35 |
Krock |
Gonna create a hotfix branch - stopping the error discussion here |
| 16:36 |
est31 |
wow |
| 16:36 |
est31 |
that error is really bad |
| 16:36 |
est31 |
shows ShadowNinja hasn't even compiled it. |
| 16:37 |
est31 |
well shrug, easy to spot at least |
| 16:37 |
Krock |
Troutslap him. |
| 16:38 |
nrzkt |
hmmm wants rules but doesn't respect others rules. |
| 16:38 |
Krock |
And Minetest rules. |
| 16:40 |
nrzkt |
a experienced a strange problem on my server, maybe somebody have ideas. All my glass nodes are black... how can this be possible? |
| 16:40 |
nrzkt |
default:glass is normal, but if i set a node over it it become black... |
| 16:40 |
Krock |
Alpha loss? |
| 16:41 |
nrzkt |
alpha is at 255 :s |
| 16:42 |
est31 |
nrzkt, if you remove the glass node and place it again does it become normal? |
| 16:42 |
nrzkt |
https://lut.im/DuRgpAZvQj/miZhlvcXAr6yvpUJ.png |
| 16:42 |
nrzkt |
est31: no |
| 16:42 |
est31 |
wtf |
| 16:42 |
est31 |
lemme join |
| 16:43 |
est31 |
appletree right? |
| 16:43 |
nrzkt |
yes |
| 16:43 |
nrzkt |
but i show it on my test server in localhost |
| 16:46 |
Krock |
#3279 |
| 16:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/3279 -- Fix MSVC compiling errors in threading and gettext by SmallJoker |
| 16:47 |
nrzkt |
Krock: +1 |
| 16:48 |
Krock |
nrzkt, better wait 15 mins until I'm sure there's no further error after linking |
| 16:48 |
est31 |
usually you have to change the declaration in the header file as well. |
| 16:48 |
Krock |
oh right |
| 17:05 |
Robert_Zenz |
What's the etiquette about nagging about pull requests? Should I just post the number in here or just post a new comment on the request? |
| 17:05 |
|
Icedream joined #minetest-dev |
| 17:05 |
VanessaE |
keep nagging, just be polite about it ;) |
| 17:06 |
VanessaE |
(posting in here is best, so as not to pollute the PR's comments section) |
| 17:07 |
Robert_Zenz |
In that case, can somebody have a look at #3144. |
| 17:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/3144 -- check_player_privs does now accept the player/player name and varargs. by RobertZenz |
| 17:08 |
Krock |
nrzkt, there are no further errors :) |
| 17:41 |
|
PilzAdam joined #minetest-dev |
| 17:43 |
|
hmmmm joined #minetest-dev |
| 17:45 |
|
Icedream joined #minetest-dev |
| 17:54 |
|
hmmmm joined #minetest-dev |
| 18:01 |
|
est31 joined #minetest-dev |
| 18:25 |
VanessaE |
kahrl: did you ever figure out how to make use of those [+]/[-] icons? |
| 18:34 |
est31 |
okay, #3279 looks good, anybody else to have a look at it? |
| 18:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/3279 -- Fix MSVC compiling errors in threading and gettext by SmallJoker |
| 18:34 |
est31 |
then it can be merged |
| 18:35 |
hmmmm |
okay a couple things to note here |
| 18:35 |
hmmmm |
this directly conflicts with my own commit that has been sitting around for almost a week now |
| 18:35 |
hmmmm |
which fixes these |
| 18:36 |
hmmmm |
second, both me and SN tested the gettext changes on windows and it worked perfectly fine. no idea what SmallJoker is on about there |
| 18:37 |
est31 |
Krock is on win xp and compiles with msvc |
| 18:37 |
hmmmm |
so this is an error on mingw?? |
| 18:37 |
hmmmm |
Krock == SmallJoker, right? |
| 18:37 |
est31 |
yes |
| 18:37 |
Krock |
true |
| 18:37 |
hmmmm |
okay |
| 18:37 |
hmmmm |
do we not have a MinGW build on travis or something?? |
| 18:38 |
est31 |
my yes was for the second question |
| 18:38 |
hmmmm |
anyway add this one first and remove src/threading/thread.cpp |
| 18:38 |
hmmmm |
https://github.com/kwolekr/minetest/commit/deb8a9a6ba51a17502627c3df6d87778d0bddfbc |
| 18:38 |
est31 |
we do have mingw cross compiler on travis yes |
| 18:40 |
|
proller joined #minetest-dev |
| 18:40 |
hmmmm |
okay looking at init_gettext a bit more and how it's used, I think it's pretty dumb to have it conditionally compiled |
| 18:41 |
hmmmm |
can we remove the #ifdef clause please and just always pass argc/argv? |
| 18:41 |
|
Darcidride joined #minetest-dev |
| 18:41 |
hmmmm |
I think it's important to minimize the amount of #ifdef clauses in our code to stop these kinds of errors |
| 18:42 |
|
Darcidride joined #minetest-dev |
| 18:42 |
est31 |
makes sense |
| 18:43 |
hmmmm |
Krock, could you paste the actual error? I can't figure out how that code is a problem |
| 18:43 |
Krock |
hmmmm, the init_gettext one? |
| 18:43 |
hmmmm |
you should always be able to pass a non-const expression to a const-qualified parameter |
| 18:43 |
hmmmm |
yes |
| 18:43 |
hmmmm |
do you have some kind of higher warning level enabled? |
| 18:43 |
est31 |
I guess this has to do with const order |
| 18:44 |
est31 |
you know that const char * argv[] vs char *const argv[] or so |
| 18:44 |
Krock |
It was an error. It said that it can't convert a char*[] to a const char*[] variable |
| 18:44 |
hmmmm |
Krock: what's the actual error number though |
| 18:44 |
Krock |
However, there's too less time for me today to re-produce the error |
| 18:44 |
hmmmm |
you know how it's something like C5392 |
| 18:45 |
hmmmm |
est31: I suppose it's possible |
| 18:45 |
|
Calinou joined #minetest-dev |
| 18:49 |
|
Taoki joined #minetest-dev |
| 18:54 |
Krock |
hmmmm, \..\minetest\src\main.cpp(455): error C2664: 'init_gettext': Konvertierung des Parameters 4 von ' |
| 18:54 |
Krock |
.. converting parameter 4 'char *[]' to 'const char *[]' not possible |
| 18:54 |
hmmmm |
huh weird |
| 18:54 |
hmmmm |
anyway |
| 18:56 |
hmmmm |
yeah it seems like the compiler is correct here although it seems unintuitive |
| 18:58 |
hmmmm |
anyway est, PTAL https://github.com/kwolekr/minetest/commit/deb8a9a6ba51a17502627c3df6d87778d0bddfbc |
| 19:01 |
est31 |
why cant multiple threads wait on the same thread? |
| 19:02 |
hmmmm |
because "The results of multiple simultaneous calls to pthread_join() specifying the same target thread are undefined." |
| 19:05 |
est31 |
hrmm |
| 19:05 |
est31 |
but then you perhaps want to put m_joinable earlier? |
| 19:05 |
est31 |
and add a mutex |
| 19:05 |
est31 |
bc race condition |
| 19:06 |
est31 |
right now it doesn't forbid multiple threads to wait |
| 19:06 |
est31 |
it only sets m_joinable to false at the end of wait() |
| 19:06 |
est31 |
thats where pthread_join has already been called |
| 19:06 |
hmmmm |
fair enough |
| 19:07 |
hmmmm |
the atomic intrinsics SN added don't seem to include CAS |
| 19:07 |
hmmmm |
this needs a mutex |
| 19:07 |
est31 |
so why is m_joinable needed? |
| 19:08 |
hmmmm |
because joinable represents whether or not the thread can be joined, whereas running represents if the thread is in its main run loop |
| 19:08 |
hmmmm |
joinable == false implies running == false, but not the other way around |
| 19:08 |
hmmmm |
a thread could have stopped but is not yet joined |
| 19:09 |
est31 |
a mutex then? |
| 19:09 |
hmmmm |
it needs to be a mutex yes |
| 19:09 |
hmmmm |
later on somebody needs to implement Compare-And-Swap intrinsics because we don't actually need a lock here |
| 19:10 |
hmmmm |
lockless code should be preferred |
| 19:14 |
est31 |
btw where are sn's intrinsics? |
| 19:14 |
est31 |
where are they defined |
| 19:16 |
|
paramat joined #minetest-dev |
| 19:35 |
paramat |
hi hmmmm #3274 is ready for review if you have time later |
| 19:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/3274 -- Decoration API: Add flag for placement on liquid surface by paramat |
| 19:48 |
est31 |
hm it seems he didnt add intrinsics, but rather added an abstraction layer for intrinsics |
| 19:49 |
est31 |
and no MSVC support |
| 19:58 |
paramat |
sfan5 game#713 if you are able to add comments sometime |
| 19:58 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/713 -- Default/functions: ABM for moss growth on cobble near water by paramat |
| 20:10 |
|
paramat left #minetest-dev |
| 20:44 |
|
Taoki joined #minetest-dev |
| 21:44 |
|
cib0 joined #minetest-dev |
| 21:47 |
|
CraigyDavi joined #minetest-dev |
| 21:51 |
|
proller joined #minetest-dev |
| 22:14 |
|
proller joined #minetest-dev |
| 22:22 |
|
troller joined #minetest-dev |
| 22:24 |
|
deltib_ joined #minetest-dev |
| 23:23 |
|
Taoki joined #minetest-dev |
| 23:48 |
|
cib joined #minetest-dev |
