| Time |
Nick |
Message |
| 00:13 |
|
paramat joined #minetest-dev |
| 00:14 |
paramat |
now pushing game#588 |
| 00:14 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/588 -- Default: Thicker snow nodebox by paramat |
| 00:20 |
paramat |
push complete |
| 00:33 |
|
alket joined #minetest-dev |
| 01:00 |
|
paramat left #minetest-dev |
| 01:01 |
|
Darcidride joined #minetest-dev |
| 01:07 |
|
Fritigern joined #minetest-dev |
| 01:24 |
|
CraigyDavi_ joined #minetest-dev |
| 02:50 |
|
Player_2 joined #minetest-dev |
| 02:52 |
|
paramat joined #minetest-dev |
| 02:53 |
paramat |
game#596 < hmmmm back later |
| 02:53 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/596 -- Add biomes for mgv5 and mgv7 by paramat |
| 02:53 |
|
paramat left #minetest-dev |
| 03:40 |
|
Hunterz joined #minetest-dev |
| 04:34 |
|
OldCoder joined #minetest-dev |
| 04:37 |
|
Taoki[mobile] joined #minetest-dev |
| 04:38 |
|
leat1 joined #minetest-dev |
| 04:48 |
|
leat1 joined #minetest-dev |
| 04:59 |
|
leat1 joined #minetest-dev |
| 05:09 |
|
OldCoder joined #minetest-dev |
| 05:19 |
|
Hijiri joined #minetest-dev |
| 05:31 |
|
leat2 joined #minetest-dev |
| 05:39 |
|
leat2 joined #minetest-dev |
| 05:49 |
|
leat2 joined #minetest-dev |
| 05:59 |
|
jin_xi joined #minetest-dev |
| 06:07 |
|
Hunterz joined #minetest-dev |
| 06:44 |
|
nrzkt joined #minetest-dev |
| 06:57 |
|
nore joined #minetest-dev |
| 07:02 |
|
Darcidride_ joined #minetest-dev |
| 07:03 |
|
Krock joined #minetest-dev |
| 07:06 |
|
Robert_Zenz joined #minetest-dev |
| 07:15 |
|
julienrat joined #minetest-dev |
| 07:18 |
|
julienrat1 joined #minetest-dev |
| 07:19 |
|
julienrat1 left #minetest-dev |
| 07:37 |
|
julienrat joined #minetest-dev |
| 07:52 |
|
OldCoder joined #minetest-dev |
| 08:00 |
|
Yepoleb_ joined #minetest-dev |
| 08:13 |
|
kilbith joined #minetest-dev |
| 08:22 |
|
blaise joined #minetest-dev |
| 08:41 |
|
leat2 joined #minetest-dev |
| 08:44 |
|
Calinou joined #minetest-dev |
| 08:48 |
|
FR^2 joined #minetest-dev |
| 08:55 |
nrzkt |
hi, est31 are you there ? |
| 08:55 |
est31 |
nrzkt, why |
| 08:55 |
nrzkt |
can you look at this trivial performance improvement ? #2967 |
| 08:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/2967 -- Precalculate mapblock relative size. by nerzhul |
| 08:56 |
|
leat2 joined #minetest-dev |
| 08:56 |
est31 |
nrzkt, can you test it with a release build? |
| 08:59 |
nrzkt |
valgrind show this information only in debug builds |
| 09:00 |
|
leat2 joined #minetest-dev |
| 09:01 |
est31 |
can you add a comment |
| 09:01 |
nrzkt |
else we lost those informations |
| 09:01 |
nrzkt |
which comment ? |
| 09:01 |
est31 |
where you define it |
| 09:03 |
nrzkt |
where i defined what ? |
| 09:03 |
nrzkt |
to precise the valgrind report ? |
| 09:03 |
est31 |
the variable |
| 09:03 |
nrzkt |
the variable is in the diff |
| 09:04 |
est31 |
v3s16 m_pos_relative; |
| 09:04 |
nrzkt |
it's in the class itself, it's a secondary v3s16 which contain the precalculated value |
| 09:04 |
est31 |
add a comment that its the cached relative position |
| 09:04 |
est31 |
for speed |
| 09:04 |
nrzkt |
and this is initialized at class constructor |
| 09:04 |
nrzkt |
oh, in the code, okay :D |
| 09:08 |
est31 |
can you update |
| 09:08 |
est31 |
then i +1 |
| 09:09 |
nrzkt |
done |
| 09:10 |
nrzkt |
awaiting for your approval + 30 mins :p |
| 09:11 |
est31 |
well, perhaps remove the newline between the comment and the variable |
| 09:11 |
est31 |
and add one before the comment |
| 09:11 |
est31 |
but its a detail |
| 09:11 |
est31 |
also I think the valgrind stuff is not needed |
| 09:11 |
est31 |
otherwise +1 |
| 09:12 |
nrzkt |
i prefer give a screenshot to show what is say instead of say it without a poc :) |
| 09:22 |
|
julienrat joined #minetest-dev |
| 09:30 |
|
julienrat1 joined #minetest-dev |
| 09:31 |
nrzkt |
will push #2967 at 11:50AM |
| 09:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/2967 -- Precalculate mapblock relative size. by nerzhul |
| 09:32 |
est31 |
nrzkt, better use relative time, because not everybody is in our time zone :) |
| 09:33 |
nrzkt |
sorry, 9:50AM UTC :D |
| 09:33 |
nrzkt |
else in ~ 15 mins now |
| 09:34 |
est31 |
its a small patch, and obviously trivial |
| 09:34 |
est31 |
that variable is private, and its only written in the constructor |
| 09:34 |
est31 |
so nothing can go wrong here |
| 09:35 |
est31 |
btw "performances" is wrong |
| 09:35 |
est31 |
use "performance" |
| 09:36 |
est31 |
also "This caches value" is wrong |
| 09:36 |
kilbith |
wrong, you talk about performances as a globality |
| 09:36 |
kilbith |
people usually use the plural form in technical sphere |
| 09:36 |
nrzkt |
est31, i agree with time. I also agree with performance or performances, twice are okay it depend if we talk about globally or specific to the function |
| 09:37 |
est31 |
kilbith, i disagree |
| 09:37 |
est31 |
I've never used it the plural way yet |
| 09:38 |
est31 |
"This caches value" --> there is a "the" missing here |
| 09:38 |
|
bluegreen joined #minetest-dev |
| 09:38 |
nrzkt |
right |
| 09:38 |
kilbith |
if you raise a factor, you affect the globality of a complex system |
| 09:38 |
kilbith |
thus you use the plural form |
| 09:39 |
kilbith |
it's grammatically common sense |
| 09:40 |
nrzkt |
last version before push is present |
| 09:40 |
est31 |
kilbith, you are french no? |
| 09:40 |
kilbith |
correct |
| 09:40 |
est31 |
http://english.stackexchange.com/questions/165661/performance-plural-vs-singular |
| 09:41 |
kilbith |
you would find other discussions that favorize the plural form |
| 09:42 |
est31 |
its wrong, just like informations |
| 09:42 |
kilbith |
that's bikeshedding anyways ;) |
| 09:42 |
nore |
I would say "performance" as well |
| 09:43 |
nore |
but anyway: the commit looks good :) |
| 09:43 |
nrzkt |
hi nore, how are you ? :) |
| 09:43 |
kilbith |
you just don't talk in singular form when you speed-up something |
| 09:43 |
kilbith |
just disagreeing for the sake of debating |
| 09:43 |
est31 |
https://www.google.com/trends/explore#q=performance%2C performances |
| 09:44 |
nore |
hi :) |
| 09:44 |
est31 |
you are in a minorities kilbith |
| 09:45 |
kilbith |
no spontaneously you just don't talk like that |
| 09:45 |
est31 |
but agreed bikeshedding |
| 09:45 |
kilbith |
also one people can be right against one billion |
| 09:46 |
kilbith |
minority doesnt matter |
| 09:46 |
est31 |
its a misconception as it seems french people have |
| 09:46 |
est31 |
its like the german "bekommen" doesnt mean "become" but "get" |
| 09:47 |
est31 |
so german english learners will often say "can I become a hamburger" when they go to the restaurant :) |
| 09:47 |
nore |
lol :) |
| 09:47 |
nrzkt |
ich bin ein berliner ? |
| 09:47 |
nrzkt |
it's like being a donut ? |
| 09:48 |
kilbith |
english "get" is a multi-meaning word, used with lot of sauces |
| 09:49 |
bluegreen |
doesn't ich bin ein berliner mean I'm a donut? |
| 09:49 |
nrzkt |
pushed |
| 09:50 |
est31 |
well its not a real donut |
| 09:50 |
est31 |
not this thing with a hole# |
| 09:50 |
est31 |
https://commons.wikimedia.org/wiki/File:Berliner-Pfannkuchen.jpg#/media/File:Berliner-Pfannkuchen.jpg |
| 09:58 |
est31 |
are these things called donut in english too??? |
| 09:58 |
bluegreen |
yes |
| 10:00 |
bluegreen |
wait |
| 10:00 |
|
julienrat joined #minetest-dev |
| 10:00 |
bluegreen |
are they called donut in german? |
| 10:00 |
|
Darcidride_ joined #minetest-dev |
| 10:00 |
est31 |
no |
| 10:00 |
est31 |
but i might be wrong with this |
| 10:00 |
est31 |
german has many dialects |
| 10:00 |
bluegreen |
no |
| 10:01 |
bluegreen |
I think your right |
| 10:01 |
|
AnotherBrick joined #minetest-dev |
| 10:01 |
|
Krock2 joined #minetest-dev |
| 10:03 |
|
cheapie joined #minetest-dev |
| 10:04 |
kilbith |
english is comparable to Lua, english/french to C++ |
| 10:04 |
kilbith |
french/german allow more elaborated semantics overall |
| 10:04 |
bluegreen |
why? |
| 10:04 |
est31 |
hehe |
| 10:08 |
|
msantana joined #minetest-dev |
| 10:08 |
bluegreen |
I have complied minetest on windows |
| 10:10 |
bluegreen |
thanks krock |
| 10:10 |
Krock |
why? |
| 10:10 |
bluegreen |
I finally manage to compile minetest on windows |
| 10:11 |
Krock |
Looking at your error message I see it wasn't configured well yet |
| 10:11 |
bluegreen |
fixed that |
| 10:11 |
Krock |
were you able to use the pre-compiled libraries or did you compile them yourself? |
| 10:12 |
bluegreen |
per-compiled |
| 10:12 |
bluegreen |
*pre |
| 10:12 |
Krock |
oh that's great |
| 10:12 |
|
hieeekf joined #minetest-dev |
| 10:14 |
bluegreen |
I had to manually enter all the filepaths into cmake through |
| 10:16 |
Krock |
there's no workaround :P |
| 10:16 |
|
est31 joined #minetest-dev |
| 10:16 |
|
H-H-H joined #minetest-dev |
| 10:19 |
bluegreen |
krock could your instructions replace the ones on the wiki? |
| 10:19 |
bluegreen |
as they work better? |
| 10:22 |
Krock |
uhm yes, I could try to update that wiki page a bit |
| 10:24 |
bluegreen |
Is there a setting to disable mod manager? |
| 10:25 |
Krock |
You'll have to edit the builtin\mainmenu code |
| 10:25 |
bluegreen |
ok |
| 10:28 |
bluegreen |
is there any reason that with in builtin core. is used and outside minetest. |
| 10:38 |
est31 |
nrzkt, if you have time can you check out #2968 |
| 10:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/2968 -- Android: fix iconv by est31 |
| 10:40 |
|
blaise joined #minetest-dev |
| 10:43 |
est31 |
H-H-H, perhaps one day, but not right now I'll look at your sound issue |
| 10:44 |
nrzkt |
est31 seems good, but not tested |
| 10:48 |
H-H-H |
erm ty est31 lol |
| 10:55 |
est31 |
H-H-H, sorta confirm your issue |
| 11:00 |
|
enesbil joined #minetest-dev |
| 11:01 |
bluegreen |
why is no newline at end of line a problem? |
| 11:01 |
|
Wayward_One joined #minetest-dev |
| 11:03 |
bluegreen |
https://github.com/minetest/minetest/pull/2969 |
| 11:04 |
|
julienrat joined #minetest-dev |
| 11:04 |
bluegreen |
#2969 |
| 11:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/2969 -- Add a setting to enable mod manager and disable it by default by red-001 |
| 11:12 |
|
leat2 joined #minetest-dev |
| 11:18 |
Krock |
bluegreen, the .conf.example should contain the default values |
| 11:18 |
bluegreen |
ok |
| 11:18 |
bluegreen |
will fix that |
| 11:19 |
bluegreen |
done |
| 11:19 |
bluegreen |
syncing |
| 11:20 |
Krock |
syncing -> commiting |
| 11:21 |
bluegreen |
well I'm using |
| 11:21 |
bluegreen |
the app for windows |
| 11:22 |
bluegreen |
github for windows |
| 11:22 |
|
leat2 joined #minetest-dev |
| 11:23 |
bluegreen |
I think syncing == pushing |
| 11:25 |
bluegreen |
#2969 |
| 11:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/2969 -- Add a setting to enable mod manager and disable it by default by red-001 |
| 11:32 |
|
leat2 joined #minetest-dev |
| 11:35 |
|
julienrat joined #minetest-dev |
| 11:37 |
|
julienrat joined #minetest-dev |
| 11:43 |
|
leat2 joined #minetest-dev |
| 11:43 |
|
julienrat joined #minetest-dev |
| 11:45 |
|
julienrat joined #minetest-dev |
| 11:46 |
|
julienrat1 joined #minetest-dev |
| 11:54 |
|
Wayward_One joined #minetest-dev |
| 12:02 |
|
proller joined #minetest-dev |
| 12:11 |
|
VanessaE joined #minetest-dev |
| 12:12 |
|
alket joined #minetest-dev |
| 12:15 |
|
leat2 joined #minetest-dev |
| 12:23 |
|
leat2 joined #minetest-dev |
| 12:27 |
|
julienrat joined #minetest-dev |
| 12:29 |
|
julienrat joined #minetest-dev |
| 12:34 |
|
alket_ joined #minetest-dev |
| 12:36 |
|
est31 joined #minetest-dev |
| 12:38 |
|
julienrat left #minetest-dev |
| 12:39 |
|
hmmmm joined #minetest-dev |
| 12:45 |
|
julienrat1 joined #minetest-dev |
| 12:47 |
|
julienrat joined #minetest-dev |
| 12:49 |
|
julienrat1 joined #minetest-dev |
| 12:54 |
|
Megaf_ joined #minetest-dev |
| 12:55 |
|
julienrat joined #minetest-dev |
| 12:56 |
est31 |
hmmmm, nrzkt said #2968 looks ok but he hasnt tested it |
| 12:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/2968 -- Android: fix iconv by est31 |
| 12:56 |
est31 |
what do you think |
| 13:02 |
bluegreen |
can some take a look at game#595 ? |
| 13:02 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/595 -- Change a book_written into a book if empty. by red-001 |
| 13:04 |
|
julienrat joined #minetest-dev |
| 13:04 |
|
julienrat left #minetest-dev |
| 13:04 |
|
alket joined #minetest-dev |
| 13:08 |
|
julienrat1 joined #minetest-dev |
| 13:10 |
bluegreen |
does anyone have any idea why did this fail? |
| 13:10 |
bluegreen |
https://travis-ci.org/minetest/minetest/builds/73185983 |
| 13:11 |
est31 |
bluegreen, internal error |
| 13:11 |
est31 |
will tell it to rebuild |
| 13:11 |
nrzkt |
a problem with travis instance |
| 13:11 |
nrzkt |
the gpg key for installing postgresql is not good |
| 13:12 |
bluegreen |
how do I do that? |
| 13:12 |
nrzkt |
but i think travis should use debian regular package, not external repo |
| 13:12 |
est31 |
its not your faul |
| 13:12 |
est31 |
t |
| 13:12 |
est31 |
nrzkt, we dont use postgresql |
| 13:13 |
nrzkt |
in the build i see it search for apt.postgresql.org gpg key |
| 13:15 |
|
leat2 joined #minetest-dev |
| 13:17 |
est31 |
ok |
| 13:25 |
bluegreen |
#2969 |
| 13:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/2969 -- Add a setting to enable mod manager and disable it by default by red-001 |
| 13:28 |
est31 |
nrzkt, can you have a look at the minor bugfix #2970 |
| 13:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/2970 -- Android: Fix minor makefile bugs by est31 |
| 13:29 |
est31 |
if you +1 I'll merge it in 30 mins |
| 13:29 |
est31 |
at 16:00 CEST |
| 13:39 |
|
swaaws joined #minetest-dev |
| 13:40 |
bluegreen |
what does m_transforming_liquid.push_back do? |
| 13:40 |
nrzkt |
okay for me |
| 13:45 |
|
leat2 joined #minetest-dev |
| 13:50 |
hmmmm |
est31: 2968 looks good to me, but i'm not going to pretend i fully understand everything |
| 13:50 |
hmmmm |
you were the one researching the topic so you know more about it than anybody else here |
| 13:50 |
hmmmm |
I guess the real question is: does it work? |
| 13:50 |
hmmmm |
i.e. did you test it |
| 13:50 |
est31 |
it works for me |
| 13:50 |
est31 |
yes |
| 13:50 |
hmmmm |
okay then |
| 13:51 |
est31 |
pushing 2968 and 2970 |
| 13:51 |
bluegreen |
can someone check #2969 |
| 13:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/2969 -- Add a setting to enable mod manager and disable it by default by red-001 |
| 13:52 |
est31 |
bluegreen, the question is whether we want to disable mod manager by default |
| 13:52 |
est31 |
i agree its very broken |
| 13:52 |
est31 |
perhaps we should |
| 13:52 |
nrzkt |
what is the usage of the mod manager ? |
| 13:52 |
bluegreen |
at least you should disable online mod store |
| 13:53 |
bluegreen |
and if you disable that it's only a broken file manger |
| 13:54 |
bluegreen |
as in you can only remove mods |
| 13:55 |
|
leat2 joined #minetest-dev |
| 13:56 |
bluegreen |
mddb is down https://forum.minetest.net/mddb/mods |
| 13:58 |
Krock |
http://i3.kym-cdn.com/entries/icons/original/000/006/216/7nTnr.png |
| 13:59 |
kahrl |
bluegreen: it's mmdb not mddb, but that's still a 404 :/ |
| 14:02 |
bluegreen |
what happened to it anyway? |
| 14:02 |
VanessaE |
died in pain because it's too much of a hassle for modders to use it :P |
| 14:05 |
* Krock |
has reign plans in Minetest: Redirecting all mmdb requests to his search page! |
| 14:05 |
bluegreen |
also can someone that a look at game#595 |
| 14:05 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/595 -- Change a book_written into a book if empty. by red-001 |
| 14:06 |
kilbith |
be patient, bluegreen |
| 14:07 |
Krock |
bluegreen, players could erase their books by accident |
| 14:07 |
bluegreen |
how? |
| 14:08 |
|
julienrat joined #minetest-dev |
| 14:08 |
bluegreen |
you have to remove all the text a book to be erased |
| 14:09 |
bluegreen |
and save |
| 14:09 |
|
proller joined #minetest-dev |
| 14:10 |
|
julienrat joined #minetest-dev |
| 14:10 |
|
Lunatrius joined #minetest-dev |
| 14:11 |
bluegreen |
currently there is no way to empty a book |
| 14:12 |
|
swaaws joined #minetest-dev |
| 14:12 |
Krock |
a space bar looks quite empty to me |
| 14:12 |
bluegreen |
? |
| 14:13 |
bluegreen |
oh |
| 14:13 |
bluegreen |
still you can't give a book to an other player |
| 14:14 |
|
julienrat1 joined #minetest-dev |
| 14:18 |
|
julienrat joined #minetest-dev |
| 14:22 |
|
julienrat1 joined #minetest-dev |
| 14:23 |
|
rom1504 joined #minetest-dev |
| 14:24 |
|
alket_ joined #minetest-dev |
| 14:42 |
|
julienrat joined #minetest-dev |
| 15:49 |
|
sloantothebone joined #minetest-dev |
| 16:13 |
|
Hunterz joined #minetest-dev |
| 16:16 |
|
BrandonReese joined #minetest-dev |
| 16:20 |
|
blaze joined #minetest-dev |
| 16:56 |
|
VargaD joined #minetest-dev |
| 17:03 |
|
crazyR_ joined #minetest-dev |
| 17:03 |
|
crazyR_ joined #minetest-dev |
| 17:13 |
|
Darcidride joined #minetest-dev |
| 17:31 |
|
Darcidride joined #minetest-dev |
| 17:32 |
|
Darcidride joined #minetest-dev |
| 17:40 |
|
est31 joined #minetest-dev |
| 17:50 |
|
bluegreen joined #minetest-dev |
| 17:53 |
|
EvergreenTree joined #minetest-dev |
| 17:54 |
|
MinetestForFun joined #minetest-dev |
| 18:34 |
|
est31 joined #minetest-dev |
| 18:34 |
est31 |
hrmm what about an f-droid nightlies repo? |
| 18:35 |
est31 |
this way we can track android regressions much faster |
| 18:37 |
est31 |
and users can help tracking regressions too |
| 18:46 |
|
FR^2 joined #minetest-dev |
| 18:53 |
|
Player_2 joined #minetest-dev |
| 18:54 |
|
FR^2 left #minetest-dev |
| 19:30 |
|
TenPlus1 joined #minetest-dev |
| 19:30 |
TenPlus1 |
hi folks |
| 19:30 |
TenPlus1 |
I have a very strange problem and was wondering if anyone could shed some light on it |
| 19:31 |
TenPlus1 |
on server, when a player holds a cake, it crashes the game of 1 single player using minetest for android... no matter who holds this 1 item, her game crashes |
| 19:31 |
TenPlus1 |
any ideas ? |
| 19:31 |
est31 |
is it official build from f-droid or playstore?? |
| 19:32 |
bluegreen |
that is truly strange |
| 19:32 |
est31 |
perhaps ask to give debug.txt |
| 19:32 |
TenPlus1 |
it's straight from www.minetest.net/download |
| 19:32 |
est31 |
ok |
| 19:32 |
TenPlus1 |
she is on mobile phone, but will ask if she can provide it |
| 19:32 |
est31 |
/storage/sdcard0/Minetest/debug.txt |
| 19:32 |
TenPlus1 |
I've checked the node definition and it's fine, every other player isnt affected... damn strange |
| 19:33 |
bluegreen |
what mods do you have? |
| 19:33 |
est31 |
perhaps the /storage/sdcard0 part differs |
| 19:33 |
est31 |
well its a reproducible bug |
| 19:33 |
TenPlus1 |
it's the pie mod for Xanadu |
| 19:33 |
est31 |
which is usually a good thing :) |
| 19:33 |
TenPlus1 |
yeah, happens to this 1 player every single time |
| 19:33 |
TenPlus1 |
will log in just now adn see if she can give logs |
| 19:33 |
bluegreen |
maybe android can't render the texture? |
| 19:34 |
bluegreen |
of pie |
| 19:34 |
TenPlus1 |
but everyone else on android and even ipad can ?!?! |
| 19:35 |
bluegreen |
does it happen when the player see it in a chest? |
| 19:35 |
TenPlus1 |
nope, only when held in a players hands... placed as an item or in chest it's fine |
| 19:35 |
est31 |
so question is, what causes the bug |
| 19:36 |
est31 |
might be interesting to create a server with tons of similar cake node definitions |
| 19:36 |
est31 |
you know to find out what part of the nodedef is wrong |
| 19:36 |
bluegreen |
do you have Wieldview ? |
| 19:36 |
TenPlus1 |
you are welcome to join Xanadu using android minetest to see if it affects you |
| 19:36 |
TenPlus1 |
yes, using 3d_armor and wieldview |
| 19:36 |
TenPlus1 |
latest github |
| 19:37 |
bluegreen |
maybe it's something in wieldview |
| 19:37 |
bluegreen |
since it happens when a cake is wielded |
| 19:37 |
VanessaE |
I would guess, off the top of my head, it's not the thing being wielded, but the player model. |
| 19:38 |
VanessaE |
wieldview uses a custom player model. |
| 19:38 |
TenPlus1 |
but like I said, many other players using windows, linux, iphone, android and it works ok for them all... |
| 19:38 |
bluegreen |
what minetest versoin does the player have? |
| 19:38 |
TenPlus1 |
0.4.12 for android straight from minetest downlaods |
| 19:43 |
TenPlus1 |
oh yeah, I added 2 lines to the serialize.lua file for "userdata" and it stopped a lot of the random crashes on server... almost had 11 hours runtime from it today |
| 19:46 |
* bluegreen |
wonders what are the lines? |
| 19:47 |
bluegreen |
wait what? |
| 19:47 |
bluegreen |
what are the lines? |
| 19:47 |
TenPlus1 |
after line 119 I added: elseif tp == "userdata" then return "userdata" |
| 19:48 |
TenPlus1 |
so those freaky serialize errors reg. userdata dont appear anymore and crash the server |
| 19:48 |
TenPlus1 |
I know it's a nonsense line that doesnt do anything specific, but it helps a lot |
| 19:49 |
|
Puma_rc joined #minetest-dev |
| 19:50 |
bluegreen |
what does the line do? |
| 19:51 |
|
paramat joined #minetest-dev |
| 19:51 |
TenPlus1 |
the error that crashes server appears saying serialize.lua cannot handle userdata and everything stops... that 1 line takes userdata input and returns a single string to stop error... that's all |
| 19:53 |
bluegreen |
wait so serialize.lua isn't suppose to get userdata? |
| 19:53 |
paramat |
nore sfan5 Tesseract i will push game#596 in a few hours when i finish testing |
| 19:53 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/596 -- Add biomes for mgv5 and mgv7 by paramat |
| 19:53 |
TenPlus1 |
nope, if it handles userdata it returns an error and doing that halts server... |
| 19:54 |
sfan5 |
wow |
| 19:54 |
sfan5 |
that mountain looks nice |
| 19:54 |
TenPlus1 |
and the weird thing is, none of the mods I run handles userdata like that so it's within the game |
| 19:54 |
bluegreen |
so why does it get userdata? |
| 19:55 |
TenPlus1 |
no idea... hence the quick fix with that 1 single line... |
| 19:55 |
TenPlus1 |
everything still works as it should too |
| 19:55 |
VanessaE |
that DOES look nice. paramat, you're killin' me with these kickass mapgen features :P |
| 19:55 |
VanessaE |
(because they're all v5 or v7 and I use v6 :) ) |
| 19:56 |
* paramat |
kills =) |
| 19:56 |
bluegreen |
this fix should in my opinion be added to minetest |
| 19:57 |
TenPlus1 |
I really want BiomesDev added as the default v7 mapgen... it's amazing |
| 19:57 |
bluegreen |
so a warning is printed to log |
| 19:57 |
bluegreen |
instead of crash |
| 19:58 |
TenPlus1 |
for that 1 line, no.. it just returns the string "userdata" which does nothing |
| 19:59 |
bluegreen |
yes make it two lines |
| 19:59 |
bluegreen |
one that returns a random string |
| 19:59 |
TenPlus1 |
and one that prings the error to console |
| 20:00 |
bluegreen |
yes |
| 20:00 |
TenPlus1 |
I gotta find out what's passing userdata to that function in serialize.lua though... |
| 20:00 |
TenPlus1 |
that's the tricky part... |
| 20:02 |
bluegreen |
shttp://pastebin.com/wYxQZgqX |
| 20:03 |
bluegreen |
Is that what you did? |
| 20:05 |
TenPlus1 |
sorta, I just added the line I pasted into serialize.lua after line:119 and a print statement saying it happened |
| 20:06 |
TenPlus1 |
I'd put an issue in github but I dunno who else is getting those errors |
| 20:07 |
bluegreen |
you could just open a pull request |
| 20:08 |
TenPlus1 |
true... will do that now |
| 20:08 |
bluegreen |
I think most people would agree a warning is better then a crash |
| 20:08 |
est31 |
warnings get ignored |
| 20:09 |
bluegreen |
so a crash is better? |
| 20:10 |
est31 |
sometimes yes |
| 20:10 |
est31 |
before data corrupt |
| 20:10 |
bluegreen |
call it an none fatal error then |
| 20:10 |
TenPlus1 |
k, pull request added with error "serlialize.lua cannot handle userdata" |
| 20:11 |
TenPlus1 |
est31, this warning doesnt get ignored, it crashes server totally |
| 20:12 |
est31 |
perhaps its better to crash with a backtrace? |
| 20:12 |
est31 |
then the bad mod can be fixed |
| 20:13 |
TenPlus1 |
that's the thing, NONE of my mods store userdata in serlialize for entities... |
| 20:14 |
bluegreen |
isin't there a setting so that none fatal error cause crashes? |
| 20:14 |
bluegreen |
so modding is eaiser |
| 20:15 |
est31 |
thats perhaps an option |
| 20:15 |
bluegreen |
I think it is already |
| 20:16 |
bluegreen |
iirc there is a setting for it |
| 20:16 |
TenPlus1 |
we had 11 hours uptime on Xanadu after this line was added... was so happy at that... but still a few random crashes at times |
| 20:18 |
bluegreen |
do you have an auto restart for the server? |
| 20:18 |
TenPlus1 |
yeah I have a bash script setup to copy log to a backup and restart server |
| 20:20 |
bluegreen |
maybe the crash are caused by your server going out of memory? |
| 20:20 |
TenPlus1 |
no chance... server has 4gb memory and only ever uses 600mb for minetest... |
| 20:20 |
TenPlus1 |
that's been tested |
| 20:20 |
bluegreen |
oh |
| 20:21 |
bluegreen |
craigs server had 1 gb and crashed often |
| 20:21 |
bluegreen |
so I asked |
| 20:22 |
TenPlus1 |
memory is never an issue :) we have a very lite server running lubuntu to keep things fast |
| 20:24 |
bluegreen |
lubuntu - linux that doesn't hate my graphics card |
| 20:24 |
bluegreen |
:) |
| 20:25 |
TenPlus1 |
heh, what gfx card you got ? |
| 20:25 |
* bluegreen |
checks |
| 20:27 |
bluegreen |
nvidia nvs 290 |
| 20:28 |
TenPlus1 |
ahh, nice... I've got Nvidia Ion.2 |
| 20:28 |
TenPlus1 |
works well :) |
| 20:29 |
bluegreen |
the drivers don't seem to work for windows 7 through |
| 20:30 |
TenPlus1 |
strange... graphics on windows is flakey for some models... always got good speeds from lniux |
| 20:32 |
Tesseract |
est31: I've commented on your PR and the merged commit. |
| 20:33 |
bluegreen |
what pc are you using TenPlus1 |
| 20:33 |
TenPlus1 |
an old Acer Aspire Revo net-top... 64-bit, 2gb mem, 120gb SSD, nvidia ion.2 gfx :) |
| 20:33 |
bluegreen |
I got a dell-optiplex Gx620 |
| 20:33 |
TenPlus1 |
I can literally FEEL mods when they are working right cause it's not the fastest |
| 20:34 |
bluegreen |
1 tb disk for amazon :) |
| 20:34 |
bluegreen |
is the best thing about this pc |
| 20:34 |
Krock |
TenPlus1, hah. old? 64-bit? |
| 20:35 |
bluegreen |
yes 64bit |
| 20:35 |
TenPlus1 |
nice one... ebuyer are selling a really nice net-top for 99 quid that's pretty kewl, small, nippy |
| 20:35 |
bluegreen |
old? the pc or hard drive? |
| 20:35 |
Krock |
64-bit harddrive :P |
| 20:35 |
bluegreen |
lol |
| 20:35 |
Krock |
SSD is not a hard drive btw |
| 20:35 |
TenPlus1 |
my pc... no-one sells it anymore so once it dies a natural death it cant be fixed |
| 20:36 |
bluegreen |
I don't have ssd |
| 20:36 |
TenPlus1 |
ssd is more of a glorified flash drive :P |
| 20:36 |
bluegreen |
lol |
| 20:37 |
TBC_x |
I've got good old Acer Extensa 5220 |
| 20:37 |
TBC_x |
the battery is still working |
| 20:38 |
TBC_x |
i've got it since 2007 |
| 20:38 |
bluegreen |
hybrid dirve is a glorifed way of storing files you use a lot on a flash disk then |
| 20:38 |
TenPlus1 |
hybrids are kewl :) |
| 20:38 |
TenPlus1 |
oh man, they're having a blast with the new Lucky Blocks mod on Xanadu... aha |
| 20:38 |
bluegreen |
what does the mod do? |
| 20:39 |
TenPlus1 |
if you've ever watched a youtube video for Lucky Blocks for Minecraft you'll see... break open a mario styled block and it could hold ANYTHING inside... monsters, chests, cakes, armor, coloured sheep etc:) I have 52 added so far |
| 20:39 |
bluegreen |
cool mod |
| 20:39 |
|
nrzkt joined #minetest-dev |
| 20:40 |
TenPlus1 |
when i get to 100 I'll add it to forums :) |
| 20:40 |
bluegreen |
so It uses math.random |
| 20:40 |
TenPlus1 |
exactly :) |
| 20:40 |
bluegreen |
and then spawns a item or monster |
| 20:41 |
TenPlus1 |
lava traps, monsters, items flying around, chest full of goodies etc. etc. |
| 20:41 |
TBC_x |
that looks interesting |
| 20:42 |
TenPlus1 |
come in Xanadu sometime and I'll let you try it out |
| 20:42 |
* bluegreen |
joins |
| 20:43 |
TenPlus1 |
suggestions are welcome :-0 |
| 20:47 |
paramat |
nore sfan5 anyone want to check and +1 the biome commit? i won't be able to stop myself pushing it later after testing |
| 20:48 |
sfan5 |
commit looks good |
| 20:48 |
sfan5 |
already looked at it when you mentioned it earlier |
| 20:48 |
nore |
commit looks good, I did not test it though |
| 20:48 |
paramat |
thanks |
| 20:48 |
nore |
and the screenshot is beautiful :) |
| 20:51 |
TenPlus1 |
love the biomes paramat :) |
| 20:51 |
TenPlus1 |
nite all |
| 21:25 |
|
paramat left #minetest-dev |
| 21:52 |
|
zat joined #minetest-dev |
| 22:08 |
|
crazyR_ joined #minetest-dev |
| 22:16 |
|
bluegreen joined #minetest-dev |
| 22:37 |
|
est31 joined #minetest-dev |
| 22:53 |
|
proller joined #minetest-dev |
| 23:35 |
|
est31 joined #minetest-dev |
| 23:35 |
est31 |
Wayward_One, you there? |
| 23:36 |
est31 |
for the sound issue #2904, can you try to experiment which change did it? |
| 23:36 |
ShadowBot |
https://github.com/minetest/minetest/issues/2904 -- No sound on Android dev build |
| 23:36 |
est31 |
just revert it to old state, and make the changes one by one |
| 23:37 |
est31 |
perhaps its only one of those options |
| 23:37 |
est31 |
or perhaps i should read first about custom optimisation params for libopenal |
