Minetest logo

IRC log for #minetest, 2021-06-27

| Channels | #minetest index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:39 Gustavo6046 joined #minetest
00:47 v-rob joined #minetest
01:12 Gustavo6046_ joined #minetest
02:04 est31 joined #minetest
02:06 est31 joined #minetest
02:32 Extex joined #minetest
03:03 sys4 joined #minetest
03:05 v-rob joined #minetest
03:18 YuGiOhJCJ joined #minetest
03:22 v-rob joined #minetest
03:59 aldo joined #minetest
04:11 riff-IRC joined #minetest
04:13 merazi joined #minetest
05:01 delta23 joined #minetest
05:02 Swift110-mobile_ Hey folks
05:16 Sven_vB hi :)
05:18 MTDiscord <Jonathon> hi
05:44 VanessaE so I was looking at the profiler output on one of my servers..
05:44 VanessaE https://pastebin.com/yfCUewEu
05:44 VanessaE line 126...  why is the mod there identified only as "??"  ?
05:44 VanessaE I think it's biome_lib, and if so I'd like to fix that, but how?
06:18 Flabb joined #minetest
06:20 CWz joined #minetest
06:54 independent56 ok... so is this how bouncers work? http://2.26.38.198/Stikked/htdocs/view/35cb6657 i disconnect, and it replays all the history?
07:00 Kimapr joined #minetest
07:28 asterismo joined #minetest
07:28 asterismo joined #minetest
07:34 specing_ joined #minetest
08:01 SwissalpS joined #minetest
08:07 Kimapr joined #minetest
08:49 ghoti joined #minetest
09:02 jfred_ joined #minetest
09:02 luk3yx` joined #minetest
10:01 QwertyDragon joined #minetest
10:01 absurb joined #minetest
10:09 olliy joined #minetest
10:17 CWz joined #minetest
10:24 erlehmann joined #minetest
11:04 entuland joined #minetest
11:12 calcul0n joined #minetest
11:34 MTDiscord <Jonathon> ?? Is used when the engine cant figure out what a mod is. For crashes/mod origin/profiling
11:47 VanessaE sure, but that raises the question of why it can't figure it out.  no mapblocks were harmed in the making of that profiler dump (i.e. no crashes were involved) :)
11:54 Fixer joined #minetest
11:57 AndrewYu joined #minetest
12:02 MTDiscord <Jonathon> If you register a node in register_on_mods loaded it cant figure it out
12:04 celeron55 i was thinking the same, the only time the engine knows what mod is running is when it loads them
12:04 celeron55 anything they do in a callback is a complete mystery to the engine
12:05 celeron55 so make sure to use a good label in those
12:05 celeron55 well, except that only abms support profiler labels
12:05 VanessaE but I'm talking about a globalstep, they don't have labels :)
12:05 celeron55 i guess those should be added to others too
12:05 celeron55 labels i mean
12:06 sfan5 there's core.set_last_run_mod
12:06 celeron55 or, just register the globalstep callback at load time
12:06 sfan5 which is also used to identify callbacks
12:06 VanessaE I... um... do.
12:06 celeron55 ok show the code
12:07 VanessaE https://gitlab.com/VanessaE/biome_lib/-/blob/master/block_queue_checks.lua
12:07 VanessaE ah wait
12:07 sfan5 (what I mean are these -> https://0x0.st/-pp6.txt)
12:07 VanessaE that bit of code is loaded in a minetest.after()
12:08 VanessaE I completely forgot about that
12:09 sfan5 so the engine could probably tell you it was biome_lib in a crash message but the profiler doesn't seem to use this info
12:10 VanessaE sfan5: your link doesn't load for me.
12:10 sfan5 it's the output of grep -n -C4 'last_run' builtin -r
12:12 VanessaE set_last_run_mod() isn't mentioned in lua_api.txt...
12:12 sfan5 of course not, it's internal
12:14 VanessaE right.
12:15 VanessaE that still leaves me with no way to identify this bit of code in the profiler :)
12:15 VanessaE here's where it's loaded, btw: https://gitlab.com/VanessaE/biome_lib/-/blob/master/init.lua#L80
12:18 sfan5 https://github.com/minetest/minetest/blob/master/builtin/game/register.lua#L472
12:18 sfan5 since get_current_modname only works at load time this could probably fall back to get_last_run_mod
12:19 VanessaE wait wait, so I actually found an engine bug for once? ;)
12:19 sfan5 just a missing feature ;)
12:20 VanessaE heh
12:22 robyndrake joined #minetest
12:43 Flabb joined #minetest
12:50 AndrewYu https://andrewyu.org/bin/mtbuilderror -- what am i doing wrong?
12:52 AndrewYu gnutls?
12:54 celeron55 try adding #include <memory> to the beginning-ish of clientiface.cpp like it suggests
12:55 * AndrewYu may try
12:55 celeron55 what OS is that?
12:56 celeron55 and compiler
12:56 celeron55 also versions of those
12:58 AndrewYu Linux core 5.12.13-arch1-1 #1 SMP PREEMPT Wed, 23 Jun 2021 16:19:29 +0000 x86_64 GNU/Linux
12:58 ShadowBot https://github.com/minetest/minetest/issues/1 -- GlowStone code by anonymousAwesome
12:58 AndrewYu gcc version 11.1.0 (GCC)
12:59 sfan5 are you building 5.4.1?
12:59 sfan5 we have this fix in master github.com/minetest/minetest/commit/7c2826cbc
13:00 celeron55 well that's definitely it
13:01 AndrewYu hmm
13:02 AndrewYu i cloned that repo like a long time ago, that's why
13:06 celeron55 you just need to git pull then
13:06 AndrewYu yeh
13:16 AliasAlreadyTake VanessaE: We had a similar problem when it came to profiling core.after, so we added profiling to builtin. Our "profiling" doesn't go to the MT profiler, but writes to a table which you can then export eventually. It does nothing but calculate the times core.after uses for each one.
13:42 Pexin joined #minetest
13:43 Talkless joined #minetest
13:45 AndrewYu left #minetest
14:46 calcul0n_ joined #minetest
15:03 riff-IRC joined #minetest
15:50 Extex joined #minetest
15:59 Hawk777 joined #minetest
16:13 y5nw joined #minetest
16:23 Lone_Wolf joined #minetest
16:45 SwissalpS joined #minetest
17:49 Flabb joined #minetest
19:05 y5nw joined #minetest
19:31 Xenon joined #minetest
19:35 specing_ joined #minetest
19:48 hecks joined #minetest
21:00 v-rob joined #minetest
21:02 CeeGee joined #minetest
21:19 illwieckz joined #minetest
22:00 Sven_vB joined #minetest
22:07 riff-IRC joined #minetest
22:37 AristotIe joined #minetest
22:46 v-rob joined #minetest
23:22 Fixer_ joined #minetest
23:55 Alias2 joined #minetest

| Channels | #minetest index | Today | | Google Search | Plaintext