| Time |
Nick |
Message |
| 00:08 |
|
SFENCE joined #minetest-dev |
| 00:45 |
|
SFENCE joined #minetest-dev |
| 01:08 |
|
SFENCE joined #minetest-dev |
| 01:26 |
|
SFENCE joined #minetest-dev |
| 01:45 |
|
SFENCE joined #minetest-dev |
| 02:05 |
|
SFENCE joined #minetest-dev |
| 02:24 |
|
SFENCE joined #minetest-dev |
| 02:41 |
|
SFENCE joined #minetest-dev |
| 03:12 |
|
SFENCE joined #minetest-dev |
| 03:29 |
|
SFENCE joined #minetest-dev |
| 03:32 |
|
SFENCE_arch joined #minetest-dev |
| 03:44 |
|
SFENCE joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 06:10 |
|
whosit joined #minetest-dev |
| 10:33 |
|
YuGiOhJCJ joined #minetest-dev |
| 14:43 |
[MatrxMT] |
<Zughy> I wouldn't call "regression" something that is almost 4 year old, #15401 |
| 14:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/15401 -- Color problems with semitransparency & mipmapping enabled since ~5.4.0 |
| 14:46 |
sfan5 |
depends on the definition but not incorrect |
| 14:57 |
MTDiscord |
<luatic> the more irrlicht code i read, the more i think that if we ever put luanti on a big endian machine it will just commit sudoku |
| 14:58 |
MTDiscord |
<luatic> anyways. regression is for all regressions imo. it basically says "there once was a way this worked". regressions for the current rc are additionally added to the milestone. |
| 15:57 |
MTDiscord |
<luatic> if anyone would like to give #15353 a quick look, i'd appreciate it. it's not necessary for the 5.10 release but the docs are pretty broken currently (my fault) and there's practically no risk in fixing them. should also be relatively easy to review, just read the corresponding code and/or test it. |
| 15:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/15353 -- Fix `set_bone_override` documentation by appgurueu |
| 16:10 |
[MatrxMT] |
<Zughy> luatic: do you mean seppuku? |
| 16:12 |
MTDiscord |
<luatic> Zughy: yeah, sudoku is an euphemism i tend to use for that |
| 16:12 |
MTDiscord |
<luatic> euphemism / pun |
| 16:21 |
[MatrxMT] |
<grorp> luatic: ah, I already reviewed that earlier. approved. |
| 16:36 |
MTDiscord |
<luatic> grorp: thanks! |
| 16:41 |
|
Desour joined #minetest-dev |
| 16:57 |
MTDiscord |
<luatic> pushing a minor (one line) doc fix regarding gltf |
| 16:57 |
MTDiscord |
<luatic> https://github.com/minetest/minetest/commit/cce4fe5a3fb574de20303b227ba4bedba5a57b7c |
| 16:59 |
MTDiscord |
<luatic> while i'm at it also merging #15409 #15353 #15404 in 10m |
| 16:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/15409 -- Improve error messages for failed mesh loading by appgurueu |
| 16:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/15353 -- Fix `set_bone_override` documentation by appgurueu |
| 16:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/15404 -- Re-fix CAO mesh lighting with shaders disabled by sfan5 |
| 17:03 |
|
ivanbu joined #minetest-dev |
| 17:04 |
MTDiscord |
<luatic> actually i might hold off on the last one, i have a concern |
| 17:19 |
[MatrxMT] |
<Zughy> Dlin dlon: almost 24h until release, let's get ready c: |
| 17:57 |
|
fluxionary joined #minetest-dev |
| 18:22 |
|
hwpplayer1 joined #minetest-dev |
| 18:23 |
|
hwpplaye` joined #minetest-dev |
| 18:50 |
ROllerozxa |
it seems like the website PR won't be merged until right before the release? should I prepare it for that |
| 18:56 |
MTDiscord |
<luatic> ROllerozxa: That seems to be the current plan, yes |
| 18:56 |
MTDiscord |
<luatic> right before or right after I suppose |
| 18:57 |
ROllerozxa |
well I assume c55 will also drag his feet on the domain migration so I guess right after won't sound unrealistic |
| 18:58 |
ROllerozxa |
should I bump version numbers to 5.10.0 while I'm at it then? |
| 19:02 |
sfan5 |
don't mix changes, it will only complicate things |
| 19:11 |
|
hwpplayer1 joined #minetest-dev |
| 19:13 |
|
turtleman joined #minetest-dev |
| 19:13 |
|
hwpplayer1 joined #minetest-dev |
| 19:13 |
Krock |
proto version 46 is already for 5.10.0 |
| 19:15 |
ROllerozxa |
well I can simplify things if that's desired |
| 19:15 |
ROllerozxa |
https://github.com/minetest/minetest.github.io/pull/312 |
| 19:15 |
|
hwpplayer1 joined #minetest-dev |
| 19:15 |
ROllerozxa |
(have not tested with jekyll locally, let CI run first) |
| 19:18 |
Krock |
is this jekyll part of the core team? |
| 19:19 |
Krock |
(just kidding) |
| 19:19 |
ROllerozxa |
haha |
| 19:19 |
Krock |
How shall we proceed with the Collision bugs/PRs? |
| 19:20 |
ROllerozxa |
anyways build succeeds but the broken site tests are broken as usual. ready to merge if anyone is interested |
| 19:20 |
Krock |
revert and revert the revert after 5.10.0? |
| 19:20 |
ROllerozxa |
(sorry for talking over you) |
| 19:20 |
Krock |
no problem. I should've given that topic more time |
| 19:21 |
Krock |
That PR does make sense but I'm not really the correct one to judge |
| 19:23 |
pgimeno |
web#312 |
| 19:23 |
ShadowBot |
https://github.com/minetest/minetest.github.io/issues/312 -- Read latest version in downloads from release data by rollerozxa |
| 20:02 |
|
fluxionary joined #minetest-dev |
| 20:11 |
MTDiscord |
<luatic> Krock: my stance on it pretty much is revert because it's too late to test whatever fix comes in properly and clearly the fixes aren't trivial. |
| 20:11 |
MTDiscord |
<luatic> in other words, if we don't revert i would insist on a rc2. |
| 20:13 |
Krock |
as of now, the hotfix appears rather trivial. we're however not yet sure what other bugs resulted from that èR |
| 20:14 |
MTDiscord |
<luatic> Krock: oh, a trivial hotfix has emerged? |
| 20:14 |
[ |
èR? |
| 20:15 |
MTDiscord |
<luatic> MR is short for french "merdre" |
| 20:15 |
Krock |
* PR, but with the wrong key hit. |
| 20:16 |
Krock |
@luatic No. Nothing's merged yet. |
| 20:16 |
MTDiscord |
<luatic> if you're calling #15408 trivial, i would disagree |
| 20:16 |
ShadowBot |
https://github.com/minetest/minetest/issues/15408 -- [no squash] Collision fixes by kno10 |
| 20:16 |
MTDiscord |
<luatic> looking at the history of this PR alone shows that it definitely isn't trivial |
| 20:16 |
Krock |
I was refererring to #15378 |
| 20:16 |
ShadowBot |
https://github.com/minetest/minetest/issues/15378 -- [NO SQUASH] Collision fixes by SmallJoker |
| 20:17 |
MTDiscord |
<luatic> ah, does it fix all the issues now? |
| 20:17 |
MTDiscord |
<luatic> last i checked that introduced issues with t=0 collisions didn't it? |
| 20:17 |
Krock |
https://i.kym-cdn.com/photos/images/original/000/954/660/350.jpg |
| 20:18 |
Krock |
yes. that was a dumb blooper. I tested the falling node while being in fly mode for the entire time; not catching that issue. |
| 20:18 |
|
SFENCE joined #minetest-dev |
| 20:20 |
MTDiscord |
<luatic> Krock: okay, so if the PR is in a good state right now, you can put it back on the milestone i guess |
| 20:21 |
Krock |
I took note of your opinion. I'd prefer to not switch back and forth but to orient based on the majority |
| 20:21 |
Krock |
perhaps a poll would be more suitable for this |
| 21:06 |
MTDiscord |
<luatic> what is the status of #15303? what is preventing it from being merged? |
| 21:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/15303 -- Support generation of working Xcode project for signature purposes on MacOS by sfence |
| 21:08 |
Krock |
can't test. the changes might not appear to be very fancy but should be OK |
| 21:09 |
MTDiscord |
<luatic> Krock: yeah, sfence is probably the only core dev who can test this, so I would be fine with making an exception here. |
| 21:09 |
MTDiscord |
<luatic> Not to mention that this should be low risk. If it's broken that's hardly worse than it not existing to begin with. |
| 21:10 |
MTDiscord |
<wsor4035> you could poke the couple of macos users that have raised issues here before to see if they would be willing to test this |
| 21:10 |
MTDiscord |
<luatic> or they just become testers once we've merged it and then there is a fixup PR if they find issues ;) |
| 21:10 |
MTDiscord |
<wsor4035> seems legit |
| 21:11 |
ROllerozxa |
that PR seems to just be build system related? |
| 21:11 |
MTDiscord |
<luatic> yes |
| 21:12 |
ROllerozxa |
I don't know if anyone has registered an apple developer account yet, but if not then it's just hibernating code so shouldn't be an issue |
| 21:12 |
MTDiscord |
<luatic> hence, if according to another core dev no horrors against our build system were committed, i don't see a problem with merging it |
| 21:14 |
MTDiscord |
<luatic> ROllerozxa: sfence seems to be willing to get Luanti notarized on MacOS. |
| 21:15 |
ROllerozxa |
well if they're willing to put down the money then full speed ahead |
| 21:17 |
MTDiscord |
<luatic> I believe they are. Though celeron has also offered to pay for it in the past if necessary. |
| 21:17 |
MTDiscord |
<luatic> (there is a private discussion you can't see) |
| 21:19 |
MTDiscord |
<luatic> anyways. as far as i can tell #15303 and #15405 are in a mergeable state. |
| 21:19 |
ShadowBot |
https://github.com/minetest/minetest/issues/15303 -- Support generation of working Xcode project for signature purposes on MacOS by sfence |
| 21:19 |
ShadowBot |
https://github.com/minetest/minetest/issues/15405 -- Update credits for 5.10.0 by sfan5 |
| 21:20 |
MTDiscord |
<luatic> #15400 is competing with #15378 or possibly #15408 though the latter seems less trivial (and not just because it's a mashup with the unit test PR) |
| 21:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/15400 -- Revert "Fix collisions with long dtime, in particular with bouncing" by SmallJoker |
| 21:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/15378 -- [NO SQUASH] Collision fixes by SmallJoker |
| 21:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/15408 -- [no squash] Collision fixes by kno10 |
| 21:21 |
MTDiscord |
<luatic> #15404 is meh, i would prefer a cleaner solution. but if i don't come up with one in time it seems fine as a last resort. |
| 21:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/15404 -- Re-fix CAO mesh lighting with shaders disabled by sfan5 |
| 22:16 |
|
fluxionary joined #minetest-dev |
| 23:32 |
|
panwolfram joined #minetest-dev |
| 23:37 |
|
Sokomine joined #minetest-dev |
