| Time |
Nick |
Message |
| 01:15 |
|
fluxionary joined #minetest-dev |
| 02:45 |
|
pmp-p joined #minetest-dev |
| 03:35 |
MTDiscord |
<goodclover> I have dared accidentally play with the gods of Minetest mapgen, and discovered it's still full of the horrors of two years ago. |
| 03:36 |
MTDiscord |
<goodclover> Seeing as I hit the same thing by accident twice, couldn't figure it out the first time, and took lots of time changing everything to no avail this time, only to discover the joke. I think it's worth documenting it as a snag, or changing the engine. |
| 03:38 |
MTDiscord |
<goodclover> mapgen_river_water_source cannot be set to air, thought it is acceptable to just never set it |
| 03:39 |
MTDiscord |
<goodclover> setting it to air makes the mapgenerator (at least v7) treat the entire world as underwater for biome gen purposes, so node_riverbed is placed everywhere, and node_top is never placed (node_dust still works also) |
| 03:40 |
MTDiscord |
<goodclover> I don't know why the mapgenerator does this… rather than using it's knowledge of where it generated water, which it should know as it placed the water and carved out the rivers… it for some reason does a "node under mapgen_river_water" match afterwards |
| 03:41 |
MTDiscord |
<goodclover> anyway I'll open a GitHub issue maybe at some point |
| 03:41 |
MTDiscord |
<goodclover> ^ but that's the whole issue |
| 03:42 |
MTDiscord |
<goodclover> (as for why I was setting it to air: I do not want water nodes) |
| 03:42 |
MTDiscord |
<goodclover> actually I should test if this also applies for node_river_water in biome defs... |
| 03:44 |
MTDiscord |
<goodclover> It does not! Only the global alias! |
| 03:44 |
MTDiscord |
<goodclover> (note none of this applies for non-river, it's only river it applies to) |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:01 |
MTDiscord |
<goodclover> Issue made, I apologise for the noise. |
| 04:46 |
|
pmp-p joined #minetest-dev |
| 04:51 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:45 |
|
SFENCE joined #minetest-dev |
| 05:47 |
|
hwpplayer1 joined #minetest-dev |
| 07:00 |
|
YuGiOhJCJ joined #minetest-dev |
| 07:06 |
|
whosit joined #minetest-dev |
| 08:58 |
MTDiscord |
<nrz0> merging ##15181 |
| 08:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/15181 -- Cleanup headers in irr/include/ by Desour |
| 09:27 |
[MatrxMT] |
<grorp> nrz0: looks like that one would one would have needed a rebase after Krock's settings PR |
| 09:55 |
sfan5 |
I'll fix that in a few minutes |
| 11:24 |
|
hwpplayer1 joined #minetest-dev |
| 11:57 |
[MatrxMT] |
<grorp> most of the remaining Minetest mentions after the two currently open PRs are in copyright headers |
| 11:57 |
[MatrxMT] |
<grorp> not sure if we're even allowed to replace them? |
| 11:57 |
[MatrxMT] |
<grorp> it would be very smart move to change all of them to SPDX headers (#14439) and rename at the same time |
| 11:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/14439 -- Switch to SPDX licensing information |
| 11:57 |
[MatrxMT] |
<grorp> if we're touching them anyway |
| 11:59 |
[MatrxMT] |
<grorp> sfan5: thanks |
| 12:05 |
MTDiscord |
<nrz0> grorp: ah ! my bad, thanks sfan5 |
| 12:05 |
MTDiscord |
<nrz0> how could we have detected it before merge ? on gitlab we can force a branch rebase from UI not on GH without being more disruptive for branch owner |
| 12:25 |
|
hwpplayer1 joined #minetest-dev |
| 12:53 |
|
farribeiro joined #minetest-dev |
| 13:14 |
[MatrxMT] |
<Zughy> Not sure if anyone can answer that question |
| 13:14 |
[MatrxMT] |
<Zughy> (re grorp) |
| 14:04 |
|
imi joined #minetest-dev |
| 14:09 |
|
hwpplayer1 joined #minetest-dev |
| 14:37 |
|
Desour joined #minetest-dev |
| 17:44 |
|
YuGiOhJCJ joined #minetest-dev |
| 18:35 |
|
SFENCE joined #minetest-dev |
| 18:53 |
|
SFENCE joined #minetest-dev |
| 19:29 |
|
SFENCE joined #minetest-dev |
| 19:48 |
|
SFENCE joined #minetest-dev |
| 19:52 |
|
Noisytoot joined #minetest-dev |
| 20:35 |
|
SFENCE joined #minetest-dev |
| 21:07 |
|
SFENCE joined #minetest-dev |
| 21:40 |
|
SFENCE joined #minetest-dev |
| 22:04 |
|
GreenXenith joined #minetest-dev |
| 22:21 |
|
SFENCE joined #minetest-dev |
| 22:33 |
|
panwolfram joined #minetest-dev |
| 22:57 |
|
SFENCE joined #minetest-dev |
| 23:05 |
|
Eragon joined #minetest-dev |
| 23:33 |
|
SFENCE joined #minetest-dev |
| 23:51 |
|
SFENCE joined #minetest-dev |
