Time Nick Message 03:35 MTDiscord I have dared accidentally play with the gods of Minetest mapgen, and discovered it's still full of the horrors of two years ago. 03:36 MTDiscord Seeing as I hit the same thing by accident twice, couldn't figure it out the first time, and took lots of time changing everything to no avail this time, only to discover the joke. I think it's worth documenting it as a snag, or changing the engine. 03:38 MTDiscord mapgen_river_water_source cannot be set to air, thought it is acceptable to just never set it 03:39 MTDiscord setting it to air makes the mapgenerator (at least v7) treat the entire world as underwater for biome gen purposes, so node_riverbed is placed everywhere, and node_top is never placed (node_dust still works also) 03:40 MTDiscord I don't know why the mapgenerator does this… rather than using it's knowledge of where it generated water, which it should know as it placed the water and carved out the rivers… it for some reason does a "node under mapgen_river_water" match afterwards 03:41 MTDiscord anyway I'll open a GitHub issue maybe at some point 03:41 MTDiscord ^ but that's the whole issue 03:42 MTDiscord (as for why I was setting it to air: I do not want water nodes) 03:42 MTDiscord actually I should test if this also applies for node_river_water in biome defs... 03:44 MTDiscord It does not! Only the global alias! 03:44 MTDiscord (note none of this applies for non-river, it's only river it applies to) 04:01 MTDiscord Issue made, I apologise for the noise. 08:58 MTDiscord merging ##15181 08:58 ShadowBot https://github.com/minetest/minetest/issues/15181 -- Cleanup headers in irr/include/ by Desour 09:27 [MatrxMT] nrz0: looks like that one would one would have needed a rebase after Krock's settings PR 09:55 sfan5 I'll fix that in a few minutes 11:57 [MatrxMT] most of the remaining Minetest mentions after the two currently open PRs are in copyright headers 11:57 [MatrxMT] not sure if we're even allowed to replace them? 11:57 [MatrxMT] it would be very smart move to change all of them to SPDX headers (#14439) and rename at the same time 11:57 ShadowBot https://github.com/minetest/minetest/issues/14439 -- Switch to SPDX licensing information 11:57 [MatrxMT] if we're touching them anyway 11:59 [MatrxMT] sfan5: thanks 12:05 MTDiscord grorp: ah ! my bad, thanks sfan5 12:05 MTDiscord how could we have detected it before merge ? on gitlab we can force a branch rebase from UI not on GH without being more disruptive for branch owner 13:14 [MatrxMT] Not sure if anyone can answer that question 13:14 [MatrxMT] (re grorp)