| Time |
Nick |
Message |
| 00:18 |
|
\o` joined #minetest-dev |
| 00:23 |
|
SFENCE joined #minetest-dev |
| 00:25 |
\o` |
SFENCE a lot of that whitespace was for readability |
| 00:42 |
|
SFENCE joined #minetest-dev |
| 01:10 |
|
SFENCE joined #minetest-dev |
| 01:30 |
|
SFENCE joined #minetest-dev |
| 01:49 |
|
SFENCE joined #minetest-dev |
| 02:11 |
|
SFENCE joined #minetest-dev |
| 02:29 |
|
SFENCE joined #minetest-dev |
| 02:40 |
MTDiscord |
<thresher09> i have a large documentation refactoring pull request that i've been working on for a while. sfan5 says he does not have time to go through and review it. so i am asking if any of you can pick up #14287 and do a careful review. please do not ignore this message! every message ive posted in this channel has been ignored |
| 02:40 |
ShadowBot |
https://github.com/minetest/minetest/issues/14287 -- Refactor markdown files by Bituvo |
| 02:49 |
|
SFENCE joined #minetest-dev |
| 03:38 |
|
YuGiOhJCJ joined #minetest-dev |
| 03:50 |
|
SFENCE joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:24 |
Mantar |
weird deprecation warning: Deprecated call to `minetest.show_formspec`:`formname` must not be empty (at ...p/minetest-master/bin/../games/Exile/mods/lore/login.lua:94) |
| 04:24 |
Mantar |
but the line in question is: minetest.close_formspec(playername, "") -- forcibly close the previous fs |
| 04:24 |
Mantar |
and the lua api says: to close a formspec regardless of the formname, call `minetest.close_formspec(playername, "")`. |
| 04:27 |
MTDiscord |
<wsor4035> it was already called out here. pr https://github.com/minetest/minetest/pull/14601 at fault |
| 04:27 |
MTDiscord |
<wsor4035> here being discord |
| 04:28 |
|
SFENCE joined #minetest-dev |
| 04:28 |
Mantar |
cool then ^_^ b |
| 04:30 |
MTDiscord |
<wsor4035> someone should probably file a proper issue for it |
| 04:31 |
Mantar |
will do |
| 04:41 |
|
SFENCE joined #minetest-dev |
| 04:58 |
|
AwesomeAdam54321 joined #minetest-dev |
| 05:11 |
|
SFENCE joined #minetest-dev |
| 05:42 |
|
SFENCE joined #minetest-dev |
| 07:17 |
MTDiscord |
<nrz0> merging #15006 |
| 07:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/15006 -- [no sq] Move shaders & remove dead Irrlicht tests by sfan5 |
| 07:24 |
MTDiscord |
<nrz0> hmm sorry sfan5 i forgot to switch to rebase and merged... i has been squashed |
| 13:56 |
MTDiscord |
<thresher09> would anyone be interested in picking up #14287 |
| 13:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/14287 -- Refactor markdown files by Bituvo |
| 13:57 |
MTDiscord |
<luatic> thresher09: for what it's worth, i have other priorities as well. as i've already said by the way, i think any community member can review this. |
| 13:58 |
MTDiscord |
<thresher09> thats good to hear but i dont remember you saying that |
| 13:58 |
MTDiscord |
<luatic> "First, an observation: This PR does not require a core dev to review it. I suggest the @minetest/docs team (or anyone trustworthy, really) be allowed to review this (and have their approval count)." |
| 13:58 |
MTDiscord |
<thresher09> oh yeah that was a while ago |
| 13:58 |
MTDiscord |
<luatic> indeed |
| 13:59 |
MTDiscord |
<thresher09> so, where would i ask something like that |
| 14:09 |
MTDiscord |
<luatic> this place is not wrong, but you might also want to ask in other minetest community spaces |
| 14:14 |
ROllerozxa |
the PR is still way too big to properly review. it would be easier if it was *only* formatting changes but it also changes contents so it is difficult to know what the scope is, and various things like your title casing is inconsistent throughout |
| 14:16 |
[MTMatrix]_ |
<Zughy> Smells like possible close.. |
| 14:16 |
[MTMatrix]_ |
<Zughy> Anyway, we're on fire in these days, gg us |
| 14:21 |
ROllerozxa |
or if it is in the same PR, separate each bulk reformatting as its own commit. one commit for turning all bullet points into asterisks consistently, one for turning things into admonitions, one for changing http:// to https://, etc. that way one can just skim through those and focus on the actual changes that were made |
| 14:21 |
ROllerozxa |
Zughy: yeah probably |
| 14:53 |
MTDiscord |
<thresher09> if its inconsistent then tell me about it |
| 14:53 |
MTDiscord |
<thresher09> the title casing |
| 15:01 |
ROllerozxa |
well I have told you about it now |
| 15:01 |
ROllerozxa |
you don't need to strictly follow any guidebook but generally you don't capitalise minor words such as articles and prepositions |
| 15:02 |
ROllerozxa |
(and when skimming through the PR, sometimes they are and sometimes they aren't) |
| 19:22 |
MTDiscord |
<thresher09> can you show me some examples |
| 19:43 |
|
YuGiOhJCJ joined #minetest-dev |
| 20:09 |
|
Desour joined #minetest-dev |
| 21:59 |
[MTMatrix]_ |
<Zughy> did we get rid of "\" as default block renderer key or it's just SDL? |
| 21:59 |
[MTMatrix]_ |
<Zughy> \ |
| 22:11 |
rubenwardy |
what do you mean? keymap_toggle_block_bounds? |
| 22:21 |
[MTMatrix]_ |
<Zughy> I guess, the one rendering red lines to separate blocks |
| 22:21 |
rubenwardy |
looks like it's unbound by default |
| 22:25 |
[MTMatrix]_ |
<Zughy> Huh. In my stable release it says OEM5. Are you telling me I mapped it months/years ago and I don't remember? |
| 22:25 |
Juri |
I can be wrong but I think in a previous version it was bound by default |
| 22:26 |
Juri |
There is a player on my server who is having interesting crashes: ERROR[MeshUpdate]: C++ out of memory |
| 22:26 |
[MTMatrix]_ |
<Zughy> Dump it into an issue I guess |
| 22:27 |
Juri |
Well I can't access GitHub from here... |
| 22:27 |
Juri |
I would appreciate if you experts could have a look at what he provided me: https://wunderwelt.one/data/share/5.9.0-crash/ |
| 22:31 |
Juri |
His device has 8 GB ram btw |
| 22:36 |
|
panwolfram joined #minetest-dev |
| 22:37 |
rubenwardy |
oh yeah, if it says OEM you need to rebind it Zughy |
| 22:37 |
rubenwardy |
actually save the config first |
| 22:37 |
rubenwardy |
do we have an issue for irr -> sdl keymap compatibility? |
| 22:46 |
|
pgimeno_ joined #minetest-dev |
| 23:03 |
[MTMatrix]_ |
<Zughy> Throwing this in: there is a contributor who's been making debatable PRs - something I can tell even if I barely know C++ - and, even if their attempt is noble, I feel like we should stop them somehow unless both the parties want to waste time. I previously tried suggesting them to focus on one thing at a time and improve that thing but it doesn't seem like it worked. Yes, I could have written an internal message but our di |
| 23:04 |
rubenwardy |
heh, your message was cut off after "our di" |
| 23:04 |
rubenwardy |
dictator? |
| 23:04 |
Mantar |
uh oh guys, I think candleja |
| 23:05 |
rubenwardy |
oh no I think Zughy's been taken |
| 23:05 |
[MTMatrix]_ |
<Zughy> haha "but our discussions on GH takes ages" |
| 23:05 |
[MTMatrix]_ |
<Zughy> I'm also making no explicit names, since this log is public and it wouldn't be fair. I suggest anyone to keep the name for themselves |
| 23:05 |
[MTMatrix]_ |
<Zughy> *take |
| 23:07 |
|
Eragon_ joined #minetest-dev |
| 23:39 |
|
vampirefrog joined #minetest-dev |
