| Time |
Nick |
Message |
| 00:14 |
|
razzlom joined #minetest-dev |
| 00:33 |
|
Noisytoot joined #minetest-dev |
| 00:57 |
|
Noisytoot joined #minetest-dev |
| 01:01 |
|
Noisytoot joined #minetest-dev |
| 01:27 |
|
Noisytoot joined #minetest-dev |
| 01:51 |
|
Noisytoot joined #minetest-dev |
| 02:08 |
|
Noisytoot joined #minetest-dev |
| 03:19 |
|
Krock joined #minetest-dev |
| 03:47 |
|
Noisytoot joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:03 |
|
Noisytoot joined #minetest-dev |
| 04:11 |
|
Noisytoot joined #minetest-dev |
| 04:22 |
|
Noisytoot joined #minetest-dev |
| 04:55 |
|
Noisytoot joined #minetest-dev |
| 05:17 |
|
Noisytoot joined #minetest-dev |
| 05:28 |
|
Noisytoot joined #minetest-dev |
| 05:42 |
|
d0p1 joined #minetest-dev |
| 06:01 |
|
cranez joined #minetest-dev |
| 06:08 |
|
Soni joined #minetest-dev |
| 07:06 |
|
Noisytoot joined #minetest-dev |
| 07:18 |
|
Noisytoot joined #minetest-dev |
| 07:23 |
|
loggingbot_ joined #minetest-dev |
| 07:23 |
|
Topic for #minetest-dev is now Minetest core development and maintenance. FEATURE FREEZE IN EFFECT. Chit-chat goes to #minetest. https://dev.minetest.net/ https://irc.minetest.net/ https://github.com/minetest |
| 07:49 |
|
diceLibrarian joined #minetest-dev |
| 07:54 |
|
YuGiOhJCJ joined #minetest-dev |
| 09:39 |
|
thelounge6564 joined #minetest-dev |
| 10:06 |
|
TheCoffeMaker joined #minetest-dev |
| 10:27 |
|
cranez joined #minetest-dev |
| 11:09 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:19 |
|
Sokomine joined #minetest-dev |
| 11:37 |
MTDiscord |
<kimapr> i am definitely not the fatest |
| 11:47 |
|
Niklp joined #minetest-dev |
| 14:45 |
[MTMatrix] |
<Zughy> 100 PRs again :( |
| 15:28 |
|
jonadab joined #minetest-dev |
| 15:52 |
MTDiscord |
<josiah_wi> Would you prefer 101? I could make that happen after dinner maybe. |
| 15:54 |
pgimeno |
I'd like to propose a slightly different workflow: permanent feature freeze (disclaimer: IANACD). It would work like this: after release, every feature PR that is ready is automatically merged, and the rest of the release time is dedicated to letting people test it, fixing bugs, reviewing other features as they appear, and so on. |
| 15:56 |
pgimeno |
The advantage is that it would give more testing time to new features, and hopefully reduce release time. |
| 16:18 |
[MTMatrix] |
<Zughy> people don't test PRs. The fastest way for a test is to put them in a release |
| 16:19 |
[MTMatrix] |
<Zughy> RE josiah_wi: I'd prefer another core dev |
| 16:20 |
Krock |
testing PR's is best done with a Release Candidate, which would also be an option for 5.9.0 |
| 16:21 |
Krock |
pgimeno: this would definitely be the fastest way to proceed, yes. I'd like to bring this up in the meeting. Editing the wiki ....ΓΆ |
| 16:22 |
pgimeno |
@Zughy OK but does that have something to do with my proposal? if so, maybe you have misunderstood it? |
| 16:44 |
[MTMatrix] |
<Zughy> RE pgimeno: you said "and the rest of the release time is dedicated to letting people test it". What people exactly? Core devs aside, I don't think many people would actually give it a try |
| 16:46 |
Krock |
it's not so many but those who do it are the most helpful ones in opening issues |
| 17:01 |
[MTMatrix] |
<Zughy> you might be right. Another doubt: wouldn't this provoke a rush for debatably written feature PRs, since the goal is to have them published before a release? |
| 17:03 |
Krock |
only if release cycles are bianually |
| 17:04 |
Krock |
it would work best with a release every two months |
| 17:04 |
Krock |
or maybe every month |
| 17:05 |
Krock |
rebase hell would come sudden, though. |
| 17:10 |
pgimeno |
it's pretty much the same as now, with the difference that the merge date for feature PRs is moved to immediately after the release, and all are merged at the same time. I believe many people are using the devel version; that would give those people time to test all the new features. |
| 17:13 |
pgimeno |
Rushed PR's would still need two approvals, which might take a while, especially if they are bad quality. I don't think people would try to squeeze them into the release. But that might be me. |
| 17:16 |
Krock |
I can be rather picky at times so don't worry much about quality :3 |
| 17:19 |
[MTMatrix] |
<Zughy> pgimeno: fair point |
| 17:19 |
[MTMatrix] |
<Zughy> I think 3 months are a good compromise |
| 17:19 |
|
wsor4035 joined #minetest-dev |
| 17:20 |
[MTMatrix] |
<Zughy> wait: wouldn't that cause a rebase hell? |
| 17:21 |
[MTMatrix] |
<Zughy> Like, if you have 20 PRs ready to go in, there will be definitely PRs touching the same part of code |
| 17:24 |
pgimeno |
maybe, that's something Krock has mentioned, but good luck getting 20 PRs ready to merge at once :) |
| 20:15 |
|
chmodsagtwas joined #minetest-dev |
| 20:34 |
|
fluxionary joined #minetest-dev |
| 21:46 |
|
Sharpman joined #minetest-dev |
| 22:06 |
MTDiscord |
<josiah_wi> Lars has been doing a lot of reviews. I don't know that I have the domain knowledge required to review any of the graphics stuff. |
| 22:08 |
MTDiscord |
<josiah_wi> I could review anything that has nothing to do with graphics or OS specific stuff, probably. |
| 22:10 |
MTDiscord |
<josiah_wi> https://github.com/minetest/minetest I would approve right now if not for the weird formatting thing, for example. |
| 22:11 |
MTDiscord |
<josiah_wi> Waaait nevermind. |
| 22:11 |
MTDiscord |
<josiah_wi> He did weird stuff. |
| 22:11 |
MTDiscord |
<luatic> currently looking at some PRs, will go back to exam prep tomorrow |
| 22:11 |
MTDiscord |
<luatic> it appears you just sent a link to the minetest repo josiah? |
| 22:13 |
MTDiscord |
<josiah_wi> Whoops. |
| 22:13 |
MTDiscord |
<josiah_wi> Here wo go: https://github.com/minetest/minetest/pull/14864. |
| 22:14 |
MTDiscord |
<jordan4ibanez> That's alright, everyone makes mistakes |
| 22:14 |
MTDiscord |
<josiah_wi> I finished looking through this. The PR has an unfortunate name but yes this looks like an immediate approval. |
| 22:14 |
|
wsor4035 joined #minetest-dev |
| 22:15 |
MTDiscord |
<josiah_wi> Maybe since we don't have an automated formatter and the formatting change is consistent with the style guide we just ignore it. |
| 22:15 |
MTDiscord |
<josiah_wi> Hmm. |
| 22:17 |
MTDiscord |
<luatic> Heh, I just commented on that PR. I'm not really happy with it yet, primarily because I don't see the issue in the first place (what is the code path where uninitialized data is being read and why?), and I'm not yet convinced that this fixes it in a proper way. |
| 22:18 |
MTDiscord |
<josiah_wi> I'm glad you called out that it could indicate a real bug. We want to do this either way, though. |
| 22:18 |
MTDiscord |
<josiah_wi> I think the issue he's trying to fix is that there's a compiler warning. That's an issue in itself. |
| 22:18 |
MTDiscord |
<luatic> This is a failing run-time check as far as I understood |
| 22:21 |
MTDiscord |
<josiah_wi> Oh interesting. |
| 22:22 |
MTDiscord |
<josiah_wi> This is why I'm not a core dev. π |
| 22:22 |
MTDiscord |
<josiah_wi> (Or maybe it's because I'm pair debugging a race condition at the same time.) |
| 22:23 |
MTDiscord |
<luatic> multitasking is tricky π
|
| 22:24 |
MTDiscord |
<josiah_wi> I suppose I ought to be able to reproduce the bug as well. |
| 22:27 |
MTDiscord |
<josiah_wi> In any case, my suggestion would be to merge this and leave the issue open. |
| 22:27 |
MTDiscord |
<josiah_wi> It shouldn't be called a "fix" since it isn't. It's just a code quality update. |
| 22:32 |
|
panwolfram joined #minetest-dev |
| 22:49 |
[MTMatrix] |
<Zughy> luatic: any chance to see comments in the limited observers PR addressed? |
| 22:52 |
MTDiscord |
<josiah_wi> Is there any process whereby core devs are assigned to review PRs? It might help chip away at the number of PRs over time. |
| 22:53 |
MTDiscord |
<josiah_wi> At ATS we meet once a week and try to stay under 1 page of open PRs (currently at 20). A non-funded project could probably meet much less frequently. |
| 22:54 |
MTDiscord |
<luatic> Zughy: I don't want to get your hopes up, but in about a week I can probably get to it (after I have finished the second exam I plan on taking in this first period). |
| 22:55 |
MTDiscord |
<luatic> (There's technically a third and a fourth after that, but they are harder math exams I plan on taking in the second period anyways.) |
| 22:58 |
[MTMatrix] |
<Zughy> josiah_wi: what's ATS? |
| 23:02 |
MTDiscord |
<josiah_wi> Apache Trafficserver; I am a paid contributor. |
| 23:02 |
MTDiscord |
<josiah_wi> I guess I haven't mentioned that in the IRC bridges before. |
| 23:05 |
|
Eragon joined #minetest-dev |
| 23:09 |
|
izzyb joined #minetest-dev |
| 23:29 |
|
BuckarooBanzai joined #minetest-dev |
| 23:43 |
|
dzho joined #minetest-dev |
