| Time |
Nick |
Message |
| 00:04 |
sfan5 |
as promised: #14489 |
| 00:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/14489 -- Batched rendering of particles by sfan5 |
| 00:04 |
rubenwardy |
Also see Antarctica in Supertuxkart |
| 00:09 |
sfan5 |
Mantar: not having a feature release for 12 years is for all purposes equivalent to "dead" |
| 00:11 |
sfan5 |
and the recent bugfix release didn't even address any of the year-long known issues impacting Minetest users |
| 00:13 |
sfan5 |
upstream also has totally different opinions: don't want to use C++11 or rely on the STL, want to keep support for direct3d + the software renderer, no ambitions for SDL2 support |
| 00:14 |
sfan5 |
I bet this was discussed some day but it's buried in some issue or irc log |
| 00:53 |
MTDiscord |
<herowl> OGL 3 can't be ditched though, so there's that |
| 00:54 |
MTDiscord |
<herowl> That's trash upstream tbh. |
| 00:55 |
MTDiscord |
<herowl> Considering Minetest wants to be an engine itself, it does make sense to not have two projects going on, especially that little is going on upstream. |
| 03:26 |
MTDiscord |
<josiah_wi> Thank you wsor. |
| 03:34 |
|
v-rob joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:20 |
|
ivanb joined #minetest-dev |
| 06:06 |
|
d0p1 joined #minetest-dev |
| 08:24 |
|
Warr1024 joined #minetest-dev |
| 08:46 |
|
Warr1024 joined #minetest-dev |
| 10:44 |
|
cranez joined #minetest-dev |
| 10:56 |
sfan5 |
pushing https://github.com/sfan5/minetest/commit/bac7d323690d4f79e96e2908da8f56d1ac662b9c soon |
| 11:42 |
sfan5 |
ok great the syntax was invalid and I didn't notice |
| 11:42 |
sfan5 |
force pushing... |
| 11:43 |
|
appguru joined #minetest-dev |
| 12:09 |
MTDiscord |
<luatic> Herowl: I'm aware, I'm not planning to ditch OGL 3. Users who are still on OGL 3 just won't benefit of the advantages OGL 4 could bring (better performance, more correct rendering). |
| 12:11 |
sfan5 |
the ogl 3 renderer could use some work before anyone starts investing time into something else |
| 12:13 |
MTDiscord |
<luatic> sfan5: what kind of work? (the reason i would sometime in the distant future like to invest time into OGL 4 is because it would enable a particular implementation of OIT which AFAIK isn't possible with OGL 3) |
| 12:13 |
sfan5 |
https://github.com/minetest/irrlicht/pull/234 |
| 12:54 |
|
proller joined #minetest-dev |
| 14:12 |
|
Lupercus joined #minetest-dev |
| 14:58 |
[MTMatrix] |
<Zughy> would it be possible to add #13987 into the 5.9 milestone? I think it'd give a great tool to modders to play with |
| 14:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/13987 -- [pls do not squash :3] Allow limiting object observers by appgurueu |
| 15:21 |
|
Noisytoot joined #minetest-dev |
| 15:58 |
sfan5 |
go ahead imo |
| 15:58 |
sfan5 |
small fixes waiting for reviews: #14464 #14487 #14490 |
| 15:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/14464 -- Rework iconv encoding detection by sfan5 |
| 15:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/14487 -- Sanity-check reliable packet size at earlier point by sfan5 |
| 15:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/14490 -- Fix tests that rely on UTF-8 literals by sfan5 |
| 16:13 |
|
appguru joined #minetest-dev |
| 16:43 |
sfan5 |
also someone should still really approve #14230 |
| 16:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/14230 -- Docker image workflow (publish on `ghcr.io`) by AFCMS |
| 16:44 |
|
v-rob joined #minetest-dev |
| 16:47 |
MTDiscord |
<wsor4035> will docker images be made for previous 5.x releases, or is this only going forward? |
| 16:47 |
sfan5 |
forward only, older images are on gitlab |
| 16:47 |
MTDiscord |
<wsor4035> except for 5.7 |
| 16:47 |
MTDiscord |
<wsor4035> *5.8 |
| 16:47 |
sfan5 |
🤷 |
| 16:48 |
MTDiscord |
<wsor4035> ill just keep using buckaroos images then https://github.com/mt-mods/dreambuilder_game/blob/master/.github/workflows/test.yml#L15 |
| 17:06 |
rubenwardy |
Merging #12315 in 10 |
| 17:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/12315 -- Add world-independent storage directory for mods by rubenwardy |
| 17:07 |
rubenwardy |
and #13825 |
| 17:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/13825 -- Add button_url[] and hypertext element to allow mods to open web pages by rubenwardy |
| 17:07 |
rubenwardy |
thanks |
| 17:36 |
|
Desour joined #minetest-dev |
| 17:43 |
sfan5 |
merging #14243, #14230 in 10 |
| 17:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/14243 -- Update docs to allow non-liquid nodes to use "liquid" drawtype by ryvnf |
| 17:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/14230 -- Docker image workflow (publish on `ghcr.io`) by AFCMS |
| 17:50 |
sfan5 |
and #14482 too |
| 17:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/14482 -- Replace antipattern translation example in lua_api.md by grorp |
| 17:55 |
[MTMatrix] |
<Zughy> sfan5: if you wanna see the HUD rendering thing I was talking the other day, join AES now and press E repeatedly (11 people online) |
| 18:03 |
[MTMatrix] |
<Zughy> video: https://i.imgur.com/TuDY2JH.mp4 |
| 18:04 |
rubenwardy |
Maybe bloat, but would be super easy to add a self.properties or self.object.properties metatable that allowed get/setting object properties like fields |
| 18:04 |
rubenwardy |
not sure if set_properties() is batched |
| 18:05 |
sfan5 |
an update command is only generated once per step or so |
| 18:05 |
sfan5 |
@zughy yeah definitely didn't look like that for me |
| 18:07 |
[MTMatrix] |
<Zughy> so I guess it's hardware related? |
| 18:07 |
sfan5 |
hard to say, there's many factors |
| 18:08 |
sfan5 |
first, what's your mt version and platform? |
| 18:10 |
MTDiscord |
<wsor4035> holding down the e key, cant replicate (5.8, windows) |
| 18:10 |
sfan5 |
the most obvious question that comes to mind is: are you sure that's not network delay / jitter? |
| 18:11 |
sfan5 |
if the fps does not drop while this is happening then it's pretty much guaranteed to be that |
| 18:13 |
Desour |
Zughy: can you link the mod source code? |
| 18:14 |
[MTMatrix] |
<Zughy> sfan5: FPS stable at around 60 |
| 18:15 |
[MTMatrix] |
<Zughy> Desour: https://gitlab.com/zughy-friends-minetest/hub/-/blob/master/playerlist/src/HUD.lua |
| 18:15 |
Desour |
thx |
| 18:16 |
[MTMatrix] |
<Zughy> good luck |
| 18:23 |
Desour |
Zughy: my guess would be that with the loop in playerlist.HUD_show, you're sending so many hud_change packets that there are network issues |
| 18:24 |
Krock |
you could turn on the network package profiler client-side |
| 18:24 |
Krock |
to count incoming types |
| 18:24 |
Desour |
(the `for i = 1, 999 do` loop I mean) |
| 18:25 |
Desour |
why do you do this in the first place btw, is there something not working reliably? |
| 18:25 |
Krock |
hmm. is that profiler hidden by the trace option? |
| 18:34 |
[MTMatrix] |
<Zughy> Desour: it's been a while, frankly I don't remember. How would you do that? |
| 18:35 |
Krock |
how can I let that HUD show up? |
| 18:35 |
Krock |
nvm. "E" |
| 18:35 |
Krock |
cannot reproduce with lastest master |
| 18:35 |
Desour |
idk anything about a packet profiler. did you mean to address Krock ? |
| 18:35 |
[MTMatrix] |
<Zughy> no, I was referring to my code |
| 18:35 |
Desour |
(only thing I know is the packet count thing in F5) |
| 18:36 |
[MTMatrix] |
<Zughy> comment says "so to render empty slots as well" |
| 18:37 |
Desour |
>How would you do that? <-- do what? |
| 18:37 |
[MTMatrix] |
<Zughy> optimise it |
| 18:37 |
Desour |
replace the loop with just calling the function once |
| 18:38 |
Desour |
idk what empty slots the comment is referring to |
| 18:38 |
sfan5 |
the client prints a table of received packets every 30s to verbosestream IIRC |
| 18:38 |
Krock |
the loop isn't a problem as long it doesn't invoke and HUD changes |
| 18:38 |
Krock |
sfan5: ah. I had trace enabled, thus it gets entirely drowned by that :3 |
| 18:38 |
Desour |
ah oh, wait, I didn't see the i was actually used |
| 18:42 |
Krock |
https://pastebin.com/raw/qsmi5y1b |
| 18:43 |
Krock |
measured while holding E |
| 18:43 |
Krock |
there's probably plenty of set_properties going on. aside from that the HUD changes are pretty high but not too high |
| 18:53 |
Desour |
I got 3904 TOCLIENT_HUDCHANGE (sum=4793) in 30s |
| 18:58 |
|
lionkor joined #minetest-dev |
| 18:59 |
Krock |
interestingly this server seems to use the old movement code |
| 19:08 |
Krock |
@Zughy found a bug |
| 19:08 |
sfan5 |
rip server |
| 19:08 |
Krock |
sorry guys |
| 19:13 |
Krock |
oh |
| 19:14 |
Krock |
guess I'll stop for now to not annoy the players |
| 19:25 |
[MTMatrix] |
<Zughy> I mean, the more crashes you find the better (so we can fix them). Thank you for the issue Krock |
| 19:25 |
[MTMatrix] |
<Zughy> (In my defence, it's a WIP mod, in fact it's not on CDB) |
| 19:27 |
Krock |
(filed two bugs on gitlab, maybe you can find more, similar issues) |
| 19:33 |
Desour |
I've made a small test mod to send many hud change packets (<https://codeberg.org/Desour/test_tmp/src/branch/hud_perf1/init.lua>). it's surprising how smooth it is in singleplayer as soon as the packet quote is used up |
| 19:33 |
Desour |
quota* |
| 20:26 |
rubenwardy |
We should release a 5.8.1 soonish. I've started a branch, but it's not especially clear what to add especially given all the sfan5 mega fix PRs :D |
| 20:33 |
rubenwardy |
yeah not sure I'm best placed to do this |
| 20:49 |
sfan5 |
not that it helps but imo 5.9-dev is stable enough for server usage |
| 21:14 |
sfan5 |
i would rather prioritize a 5.9 release but there's a bunch of troublesome client bugs that aren't easily fixed |
| 21:15 |
sfan5 |
in any case I don't want to spend my time on a backport release |
| 21:26 |
|
Desour joined #minetest-dev |
| 21:28 |
|
appguru joined #minetest-dev |
| 21:37 |
|
Lupercus joined #minetest-dev |
| 21:56 |
rubenwardy |
ok, how about we just do security fixes then |
| 21:56 |
rubenwardy |
and not all the minor fixes |
| 22:03 |
sfan5 |
does that exclude that many? |
| 22:37 |
sfan5 |
feel free to in any case |
| 23:33 |
|
panwolfram joined #minetest-dev |
