| Time |
Nick |
Message |
| 00:03 |
|
TheCoffeMaker joined #minetest-dev |
| 00:05 |
|
TheCoffeMaker joined #minetest-dev |
| 00:37 |
[MTMatrix] |
<Zughy> #14436: why are calling "backwards compatibility" the fact of keeping a bug? If modders don't code properly, why should we be at fault? |
| 00:40 |
MTDiscord |
<jordan4ibanez> Break that thing break it |
| 00:40 |
MTDiscord |
<jordan4ibanez> That bug goes into the hole |
| 00:41 |
[MTMatrix] |
<Zughy> (Note: I'm at fault as well) |
| 00:44 |
MTDiscord |
<jordan4ibanez> If it's attached to the entity, when the entity disappears, kill the entity |
| 00:44 |
MTDiscord |
<jordan4ibanez> Or it should be a setting like "die_with_entity" |
| 00:44 |
MTDiscord |
<jordan4ibanez> I mean, kill the sound, the entity already died |
| 00:47 |
|
ShadowBot joined #minetest-dev |
| 00:53 |
|
proller joined #minetest-dev |
| 01:01 |
|
ShadowBot joined #minetest-dev |
| 01:07 |
|
TheCoffeMaker joined #minetest-dev |
| 02:44 |
|
SFENCE joined #minetest-dev |
| 03:31 |
|
SFENCE joined #minetest-dev |
| 04:14 |
|
andarius68 joined #minetest-dev |
| 04:14 |
|
andarius68 left #minetest-dev |
| 04:46 |
MTDiscord |
<redundantcc> @Anti Null Pointer Administrator this would actually be a really good way to kill audio streams, right now the best solution is having two separate instances of the world map and positioned mono audio. That could be simplified if sounds died with the entities they were attached to. |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 05:08 |
MTDiscord |
<jordan4ibanez> Yes |
| 05:09 |
MTDiscord |
<jordan4ibanez> Will it happen when it's fixed? |
| 05:09 |
MTDiscord |
<jordan4ibanez> No |
| 05:44 |
MTDiscord |
<redundantcc> @Anti Null Pointer Administrator some other ideas could be a stop function, or a callback that let you know when the audio stream naturally stopped. |
| 08:38 |
|
SFENCE joined #minetest-dev |
| 11:04 |
|
imi joined #minetest-dev |
| 11:25 |
|
Lupercus joined #minetest-dev |
| 11:32 |
|
proller joined #minetest-dev |
| 11:32 |
|
appguru joined #minetest-dev |
| 12:01 |
MTDiscord |
<luatic> Zughy: First off, note that there is no blatant "contract violation" by modders here. The behavior on entity removal was simply unspecified. |
| 12:01 |
MTDiscord |
<luatic> It is not unreasonable for modders to then assume that the observed behavior is the expected behavior. (Though I would encourage modders to seek API guarantees.) |
| 12:05 |
MTDiscord |
<luatic> My PR poses no significant reduction in functionality: If modders want to stop sounds on entity removal or deactivation, they can still do it themselves. |
| 12:06 |
MTDiscord |
<luatic> As an additional bonus, my PR stops the sounds serverside, meaning clients don't have to update to get the fix for #8094 - only servers have to update. |
| 12:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/8094 -- Audio attached to object stops moving when object leaves |
| 12:08 |
MTDiscord |
<luatic> There are however admittedly two slight downsides I should point out: |
| 12:08 |
MTDiscord |
<luatic> (1) having to store the sound handle may be slightly inconvenient (though it really amounts to just +1 line of code, +3 if on_die / on_deactivate would otherwise be undefined) |
| 12:09 |
MTDiscord |
<luatic> (2) if the "stop sound" packet from the server is delayed vs. the entity remove packet, the sound may continue playing slightly longer than expected |
| 12:09 |
MTDiscord |
<luatic> For these reasons, we might want to add a new field for sounds that are supposed to be removed on object removal, as jordan suggests. |
| 12:12 |
|
SFENCE joined #minetest-dev |
| 12:15 |
MTDiscord |
<luatic> Presently, 5.9-dev breaks backward compatibility ("a property of a software that allows for interoperability with an older legacy system"): Death sounds that worked fine in 5.8 and earlier won't work in 5.9. Realistically, many mods and games won't be updated in a timely manner, leaving users frustrated. |
| 12:17 |
MTDiscord |
<luatic> 5.9-dev presently also harms the use case of wanting a short sound to not be cut off when the object dies. |
| 12:18 |
MTDiscord |
<luatic> I think my PR can keep everyone happy, both in terms of available functionality and in terms of keeping backward compatibility. |
| 12:28 |
|
andarius68 joined #minetest-dev |
| 12:57 |
|
SFENCE joined #minetest-dev |
| 15:29 |
|
appguru joined #minetest-dev |
| 15:54 |
|
TheCoffeMaker joined #minetest-dev |
| 16:15 |
|
TheCoffeMaker joined #minetest-dev |
| 16:22 |
MTDiscord |
<jordan4ibanez> Needs to be a new setting because it was just showcased that this can be wanted behavior |
| 16:49 |
sfan5 |
merging #14419, #14369 in 10m |
| 16:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/14419 -- [no sq] Fix some common SAO methods to not generate useless update packets by sfan5 |
| 16:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/14369 -- Try to preserve metatable when exchanging data with the async env by y5nw |
| 17:00 |
|
Noisytoot joined #minetest-dev |
| 17:36 |
sfan5 |
https://dev.minetest.net/Code_style_guidelines#C.2B.2B_features I revised this section a bit |
| 19:24 |
|
appguru joined #minetest-dev |
| 19:25 |
appguru |
i'd like to merge #14436 in 10m |
| 19:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/14436 -- Stop sounds if objects get out of range, but not if objects are removed by appgurueu |
| 19:30 |
MTDiscord |
<warr1024> "Stop sounds if objects get out of range, but not if objects are removed by appgurueu, but do stop them if they're removed by anybody else" |
| 19:31 |
appguru |
heh |
| 19:31 |
appguru |
do you have a good suggestion for how i could reword this? it's a bit lengthy already |
| 19:33 |
appguru |
I think I'll go with "Do not stop sounds if objects are removed serverside" |
| 19:33 |
MTDiscord |
<warr1024> I'd probably use punctuation instead of " by " for the separator. It'd break the flow a bit better, so "not if objects are removed - appguru" or "not if objects are removed [appguru]" or something. |
| 19:33 |
MTDiscord |
<warr1024> Ah, if you mean the PR itself ... heh |
| 19:35 |
appguru |
Actually I think I'll go with "Fix attached sounds stopping if objects are removed serverside" |
| 19:36 |
appguru |
done |
| 19:38 |
MTDiscord |
<warr1024> OIC, this doesn't add stopping sounds out of range, that's already a feature, this just fixes a related nuance? |
| 19:42 |
MTDiscord |
<grorp> Stopping sounds when an object is removed client-side (including when it goes out of range) was added to 5.9-dev by #14341. |
| 19:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/14341 -- Remove sound attached to active object when active objects is removed by sfence |
| 19:42 |
MTDiscord |
<grorp> And is now partially reverted. |
| 19:44 |
MTDiscord |
<grorp> lol, I didn't know what "OIC" means, so I asked Duckduckgo and the first result was "what does it mean when a girl says OIC" |
| 19:44 |
MTDiscord |
<warr1024> lol |
| 19:44 |
MTDiscord |
<warr1024> for anyone else who didn't know, it means what it sounds like: "oh, I see." :-) |
| 19:45 |
celeron55_ |
sfan5: i quickly read through the diff for that wiki page and it looked ok |
| 20:33 |
|
proller joined #minetest-dev |
| 20:52 |
sfan5 |
👍 |
| 20:52 |
sfan5 |
merging #14434 in 10m |
| 20:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/14434 -- Reduce translations log spam by sfan5 |
| 21:33 |
sfan5 |
spent way too long refactoring some code today. in hindsight not sure if this was a good use of my time |
| 21:34 |
MTDiscord |
<jordan4ibanez> Did you enjoy it? |
| 21:35 |
sfan5 |
maybe |
| 21:35 |
MTDiscord |
<jordan4ibanez> Then it might have been a good use of your time |
| 22:15 |
|
TheCoffeMaker joined #minetest-dev |
| 22:48 |
|
TheCoffeMaker joined #minetest-dev |
| 23:08 |
|
BuckarooBanzai joined #minetest-dev |
| 23:32 |
|
panwolfram joined #minetest-dev |
