Time |
Nick |
Message |
00:04 |
|
SFENCE joined #minetest-dev |
00:17 |
|
TheCoffeMaker joined #minetest-dev |
00:22 |
|
SFENCE joined #minetest-dev |
00:39 |
|
ShadowBot joined #minetest-dev |
00:39 |
|
SFENCE joined #minetest-dev |
00:57 |
|
SFENCE joined #minetest-dev |
01:14 |
|
SFENCE joined #minetest-dev |
01:20 |
|
Noisytoot joined #minetest-dev |
01:39 |
|
SFENCE joined #minetest-dev |
01:56 |
|
SFENCE joined #minetest-dev |
02:14 |
|
SFENCE joined #minetest-dev |
02:31 |
|
SFENCE joined #minetest-dev |
02:58 |
|
SFENCE joined #minetest-dev |
03:09 |
|
SFENCE joined #minetest-dev |
03:47 |
|
SFENCE joined #minetest-dev |
04:07 |
|
SFENCE joined #minetest-dev |
04:24 |
|
SFENCE joined #minetest-dev |
04:42 |
|
SFENCE joined #minetest-dev |
05:00 |
|
MTDiscord joined #minetest-dev |
05:15 |
|
SFENCE joined #minetest-dev |
08:26 |
|
ivanbu joined #minetest-dev |
09:22 |
|
Warr1024 joined #minetest-dev |
09:44 |
|
cx384 joined #minetest-dev |
09:47 |
|
Warr1024 joined #minetest-dev |
10:00 |
|
grorp joined #minetest-dev |
11:43 |
|
cranez joined #minetest-dev |
11:47 |
|
cranez1 joined #minetest-dev |
12:05 |
|
grorp joined #minetest-dev |
12:10 |
|
grorp joined #minetest-dev |
14:16 |
|
grorp joined #minetest-dev |
14:53 |
Krock |
will merge #14396 in 10 minutes |
14:53 |
ShadowBot |
https://github.com/minetest/minetest/issues/14396 -- MetaData: restore undocumented set_string behaviour by SmallJoker |
15:03 |
Krock |
done |
15:03 |
|
Lupercus joined #minetest-dev |
15:05 |
|
appguru joined #minetest-dev |
15:52 |
MTDiscord |
<jordan4ibanez> If we ever get a vulkan driver, can it be called the Minetest Banana Volcano Driver? |
15:56 |
ROllerozxa |
le irrlicht banana volkano driver |
17:06 |
sfan5 |
can I just merge #14403? it's 40 lines including unit test, basically nothing can go wrong there |
17:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/14403 -- Expose SHA256 algorithm to Lua by sfan5 |
17:06 |
sfan5 |
consuming the valuable attention of another coredev with it would be a waste |
17:10 |
MTDiscord |
<wsor4035> seems trival enough, worst case some issue gets found before release and can be reverted |
17:11 |
Krock |
go ahead |
18:09 |
|
fluxionary joined #minetest-dev |
18:24 |
|
Desour joined #minetest-dev |
18:39 |
|
SFENCE joined #minetest-dev |
18:39 |
|
calculon joined #minetest-dev |
18:53 |
rubenwardy |
trivial PR: #14410 |
18:53 |
ShadowBot |
https://github.com/minetest/minetest/issues/14410 -- Add support for ContentDB package translation by rubenwardy |
18:54 |
rubenwardy |
cdb implemention is cdb#517 |
18:54 |
ShadowBot |
https://github.com/minetest/contentdb/issues/517 -- Add package translation support by rubenwardy |
18:54 |
rubenwardy |
I adapted the .tr file parser from util/mod_translation_updater.py, very handy |
18:56 |
|
SFENCE joined #minetest-dev |
19:07 |
|
SFENCE joined #minetest-dev |
19:11 |
|
SFENCE joined #minetest-dev |
19:24 |
|
SFENCE joined #minetest-dev |
19:31 |
|
SFENCE joined #minetest-dev |
19:41 |
sfan5 |
merging #14407 in 10m |
19:41 |
ShadowBot |
https://github.com/minetest/minetest/issues/14407 -- Update LTO exclusion list by sfan5 |
19:50 |
|
SFENCE joined #minetest-dev |
19:56 |
|
SFENCE joined #minetest-dev |
19:57 |
|
SFENCE joined #minetest-dev |
20:20 |
|
SFENCE joined #minetest-dev |
20:33 |
|
SFENCE joined #minetest-dev |
20:44 |
rubenwardy |
> @\n (where the \n is a literal newline) acts as a literal newline |
20:44 |
rubenwardy |
Is this only in .lua source code, or in .tr files too? The util/mod_translation_updater.py only supports one line per translation |
20:49 |
rubenwardy |
mod_translation_updater.py bug: parsing "Something@@= Something" won't work, as it doesn't like the `@` before the `=` |
20:51 |
rubenwardy |
this is why we unit test |
20:55 |
|
SFENCE joined #minetest-dev |
20:56 |
rubenwardy |
ok, checked the c++ - it does support @\n |
20:56 |
rubenwardy |
so mod_translation_updater.py doesn't support that either |
20:57 |
|
proller joined #minetest-dev |
20:57 |
|
proller__ joined #minetest-dev |
20:58 |
y5nw |
Isn't @\n only needed in .tr files? |
20:58 |
rubenwardy |
not sure what you mean |
20:59 |
rubenwardy |
I'm talking about .tr file parsers |
21:05 |
|
TheCoffeMaker joined #minetest-dev |
21:14 |
rubenwardy |
ok, I've just rewritten the .tr parser instead of using mod_translation_updater.py https://github.com/minetest/contentdb/pull/517/commits/d7065a4d365a875a4187feff1389c18084dddbd2 |
21:14 |
rubenwardy |
mod_translation_updater.py should iterate through the lines instead of using regex, and also add unit tests |
21:28 |
rubenwardy |
created issue: #14414 |
21:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/14414 -- mod_translation_updater.py: Parses escape codes in .tr files incorrectly |
21:37 |
sfan5 |
@\n looks like quite the hack imo |
21:38 |
rubenwardy |
I think """ like in .conf would be nicer. But also, we should burn .tr with fire one day |
21:38 |
rubenwardy |
@\n is defined in lua_api.md and implemented in C+ |
21:40 |
sfan5 |
no reason for it if you have @n, is there? |
21:41 |
rubenwardy |
probably not, but it is part of the API |
21:42 |
rubenwardy |
I suppose it allows \n in the actual .lua |
21:44 |
rubenwardy |
but also @n is read as \n when parsing .tr, so you can still use \n in actual .lua |
21:51 |
rubenwardy |
merging in 10: #14410, #14341, #14408 |
21:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/14410 -- Add support for ContentDB package translation by rubenwardy |
21:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/14341 -- Remove sound attached to active object when active objects is removed by sfence |
21:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/14408 -- Add padding to settings tab buttons by kotek900 |
22:57 |
|
calculon joined #minetest-dev |
23:32 |
|
panwolfram joined #minetest-dev |
23:51 |
rubenwardy |
What's the point of the # textdomain comment? Shouldn't it just be from the filename? |
23:52 |
rubenwardy |
it's not like a mod where a user can install it wrong |