| Time |
Nick |
Message |
| 00:35 |
v-rob |
OK, pushed those changes |
| 00:37 |
v-rob |
With the removed stuff, it's only ~4.1K LoC to review, rather than ~6.5K |
| 00:39 |
|
v-rob joined #minetest-dev |
| 00:40 |
[MTMatrix] |
<Zughy> suggestion: wouldn't make sense to split table.* functions in a smaller PR? |
| 00:42 |
v-rob |
I think there's only 3 of them. |
| 00:43 |
v-rob |
No, just 2 |
| 00:43 |
v-rob |
I added them because they were very useful for the Lua code, and are also incidentally useful for mods as well. |
| 00:44 |
v-rob |
The same logic applies to minetest.(de)serialize_network(). |
| 00:45 |
v-rob |
I could split all of that into a separate prerequisite PR if that was desired. |
| 01:10 |
|
v-rob joined #minetest-dev |
| 02:43 |
|
v-rob joined #minetest-dev |
| 04:45 |
|
lhofhansl joined #minetest-dev |
| 04:45 |
|
TheCoffeMaker joined #minetest-dev |
| 04:46 |
lhofhansl |
Planning to merge #14264 in a few. |
| 04:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/14264 -- Detect air-only blocks instead of day/night differences by lhofhansl |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 05:04 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:47 |
lhofhansl |
Done. |
| 06:03 |
|
v-rob joined #minetest-dev |
| 06:54 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:36 |
|
fgaz_ joined #minetest-dev |
| 09:13 |
|
v-rob joined #minetest-dev |
| 11:03 |
|
ivanbu joined #minetest-dev |
| 12:58 |
MTDiscord |
<mistere_123> im curious what branch glsym is |
| 13:03 |
|
proller joined #minetest-dev |
| 13:07 |
|
imi joined #minetest-dev |
| 13:10 |
ROllerozxa |
see https://github.com/minetest/irrlicht/pull/276 |
| 13:11 |
ROllerozxa |
(tl:dr - a bunch of GL loader cleanups) |
| 13:19 |
|
cranez joined #minetest-dev |
| 13:37 |
|
Noisytoot joined #minetest-dev |
| 13:41 |
|
Lupercus joined #minetest-dev |
| 18:09 |
|
Lupercus joined #minetest-dev |
| 18:22 |
|
SFENCE joined #minetest-dev |
| 18:25 |
SFENCE |
I see, function base64_encode has been changed. |
| 18:25 |
SFENCE |
std::string base54_encode(std::string_view s); |
| 18:27 |
SFENCE |
So how to create std::string_view from non text data array? |
| 18:35 |
SFENCE |
I found it. |
| 18:46 |
|
proller joined #minetest-dev |
| 18:51 |
|
SFENCE joined #minetest-dev |
| 18:54 |
|
SFENCE joined #minetest-dev |
| 18:58 |
sfan5 |
you can always std::string_view(reinterpret_cast<char*>(data), data_size) |
| 18:58 |
sfan5 |
not different from a string |
| 19:08 |
sfan5 |
i was thinking of merging irr#276 later today and then tagging a new version |
| 19:09 |
ShadowBot |
https://github.com/minetest/irrlicht/issues/276 -- GL loader work by sfan5 |
| 19:12 |
|
SFENCE joined #minetest-dev |
| 19:17 |
|
v-rob joined #minetest-dev |
| 19:22 |
|
SFENCE joined #minetest-dev |
| 19:23 |
|
Desour joined #minetest-dev |
| 19:32 |
sfan5 |
rubenwardy: if you have some time maybe you could look at #14382 |
| 19:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/14382 -- [no squash] Android stuff by sfan5 |
| 19:42 |
|
Fleckenstein joined #minetest-dev |
| 19:44 |
|
SFENCE joined #minetest-dev |
| 19:48 |
|
SFENCE joined #minetest-dev |
| 20:02 |
|
SFENCE joined #minetest-dev |
| 20:12 |
sfan5 |
merging #14399, #14398, irr#276 soon |
| 20:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/14399 -- Use forward-slash (/) for path separator in translation files by srifqi |
| 20:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/14398 -- Make jpeg-turbo as the default library for compiling in macOS by ShadowRoi |
| 20:12 |
ShadowBot |
https://github.com/minetest/irrlicht/issues/276 -- GL loader work by sfan5 |
| 20:37 |
|
SFENCE joined #minetest-dev |
| 20:39 |
|
v-rob joined #minetest-dev |
| 21:00 |
|
SFENCE joined #minetest-dev |
| 21:51 |
sfan5 |
https://0x0.st/H5w2.png automatic changelog generation is pretty neat |
| 21:59 |
MTDiscord |
<paradust> sfan5: Are you aware that the MSVC tests have started failing? They are failing silently, the action still is marked green. Seems to have started about a month ago. |
| 21:59 |
sfan5 |
in minetest? yes :) |
| 22:00 |
sfan5 |
I was the one who added them to be run in the first place, and marked failures to be ignored |
| 22:00 |
MTDiscord |
<paradust> ah ok |
| 22:00 |
sfan5 |
someone™ should investigate that some day |
| 22:03 |
MTDiscord |
<jordan4ibanez> Is it me? |
| 22:09 |
MTDiscord |
<jordan4ibanez> Oh, msvc, that's because msvc likes to randomly blow up paradust |
| 22:34 |
|
TheCoffeMaker joined #minetest-dev |
| 22:42 |
|
v-rob joined #minetest-dev |
| 23:33 |
|
panwolfram joined #minetest-dev |
| 23:37 |
sfan5 |
>call get_node_or_nil |
| 23:37 |
sfan5 |
>it returns "ignore" because the area is unloaded |
| 23:37 |
sfan5 |
I am being trolled |
| 23:48 |
|
imi joined #minetest-dev |
| 23:51 |
sfan5 |
so apparently blocks get created when the mapgen is invoked but contents only appear once the mapgen finishes |
| 23:51 |
sfan5 |
not sure if that's a bug |
