| Time |
Nick |
Message |
| 00:20 |
[MTMatrix] |
<Zughy> About PRs: I think core devs that decide to support a PR should self-assign such PR. I feel like sometimes people say "I support that", label it, and then forget about it |
| 00:23 |
[MTMatrix] |
<Zughy> e.g. #11932 (rubenwardy), #11073 ("coredevs", that's cheating), #13019 (v-rob) |
| 00:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/11932 -- Add helper function to rotate a facedir by aerkiaga |
| 00:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/11073 -- Add rotation support for wallmounted nodes in 'ceiling' or 'floor' mode by Wuzzy2 |
| 00:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/13019 -- Add trailgen mapgen: v6-like with biome API support by Cartmic |
| 00:26 |
[MTMatrix] |
<Zughy> It can also help such core devs remember the "promises" they did in the past, so they can understand what's already on their table, possibly avoiding burnouts situations afterwards. Last but not least, it shows respect to the contributor |
| 00:28 |
[MTMatrix] |
<Zughy> I'd also suggest a limit, so people don't self-assign 15 PRs pretending they can pull it off |
| 01:49 |
|
v-rob joined #minetest-dev |
| 02:15 |
v-rob |
Are there policies for merging very experimental APIs? I have #14263 in a mergeable alpha state, but it's (obviously) not the complete product. However, I think it would be beneficial to allow modders to start playing with it. |
| 02:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/14263 -- Formspec/HUD replacement, part 1 by v-rob |
| 02:15 |
v-rob |
CSM is experimental and got merged, but I don't think that's the best example ever. |
| 02:16 |
v-rob |
But modders are also helpful as testers and debuggers :) |
| 03:18 |
|
v-rob joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 06:03 |
|
v-rob joined #minetest-dev |
| 08:02 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:40 |
|
calcul0n joined #minetest-dev |
| 10:31 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:11 |
|
Farooq joined #minetest-dev |
| 11:15 |
|
Farooq joined #minetest-dev |
| 11:52 |
|
Farooq joined #minetest-dev |
| 12:10 |
|
Farooq joined #minetest-dev |
| 13:20 |
|
Farooq joined #minetest-dev |
| 14:50 |
|
Farooq joined #minetest-dev |
| 15:41 |
|
appguru joined #minetest-dev |
| 15:42 |
|
jonadab joined #minetest-dev |
| 16:25 |
sfan5 |
pushing a commit that adds active_block_range=1 to util/test_multiplayer.sh configs |
| 16:25 |
sfan5 |
sorry I can't be bothered to pastebin it |
| 17:39 |
[MTMatrix] |
<Zughy> any core devs opinion about this massive documentation PR? #13503 |
| 17:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/13503 -- Documentation refactoring by Bituvo |
| 17:50 |
celeron55 |
conceptually it seems fine, but i don't have the time or endurance to actually look through whether each change is correct. well, like rollerozxa points out i'm not sure if we actually care about the ". " -> ". " source code comment change at all |
| 17:50 |
celeron55 |
and the translations also make it unwieldy, like mentioned by rollerozxa |
| 17:50 |
rubenwardy |
yeah the PR is unreviewable because it just changes too much |
| 17:51 |
celeron55 |
(i thumbed up rollerozxa's comment) |
| 17:51 |
|
Desour joined #minetest-dev |
| 17:51 |
[MTMatrix] |
<Zughy> I'll tell the author |
| 17:53 |
MTDiscord |
<luatic> I think this PR is low priority; it's just (re)formatting of the docs, isn't it? |
| 17:54 |
celeron55 |
what if it only touched the markdown files? |
| 17:54 |
[MTMatrix] |
<Zughy> done |
| 17:59 |
|
grorp joined #minetest-dev |
| 18:03 |
|
grorp1 joined #minetest-dev |
| 18:06 |
grorp1 |
"the PR is unreviewable" +1 |
| 18:10 |
sfan5 |
the bulk code changes definitely need to go |
| 18:11 |
rubenwardy |
it should also only contain related changes. Fixing both formatting and typos/line length in one PR results in a lot of noise. If you just change formatting then it's easier to compare before and after |
| 18:17 |
|
v-rob joined #minetest-dev |
| 18:19 |
sfan5 |
I wonder if there's an easy way to have a workflow check indentation in files |
| 18:20 |
sfan5 |
(so nobody accidentally uses spaces) |
| 18:22 |
grorp1 |
bump for #14048 |
| 18:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/14048 -- Fix language setting description in `settingtypes.txt` by AFCMS |
| 18:26 |
sfan5 |
go ahead and merge it, it's trivial |
| 18:27 |
grorp1 |
yay |
| 18:28 |
grorp1 |
done |
| 18:55 |
MTDiscord |
<josiah_wi> Zughy, #13577 rebased. |
| 18:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/13577 -- Extract and pull up assignFreeId from CAO/SAO by JosiahWI |
| 19:00 |
|
grorp2 joined #minetest-dev |
| 19:10 |
pgimeno |
> <sfan5> (so nobody accidentally uses spaces) |
| 19:10 |
pgimeno |
grep '^\t* ' |
| 19:23 |
|
lhofhansl joined #minetest-dev |
| 19:23 |
lhofhansl |
sfan5: #14264 |
| 19:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/14264 -- Detect air-only blocks instead of day/night differences by lhofhansl |
| 20:10 |
MTDiscord |
<jordan4ibanez> zughy, I like your opinion on #13975 please convince others, thanks |
| 20:10 |
ShadowBot |
https://github.com/minetest/minetest/issues/13975 -- Fix glitch that jolts players up edges by jordan4ibanez |
| 20:13 |
MTDiscord |
<jordan4ibanez> What else do I have to do for https://github.com/minetest/irrlicht/pull/270 ? |
| 21:21 |
|
v-rob joined #minetest-dev |
| 21:46 |
[MTMatrix] |
<Zughy> jordan4ibanez: well, it seems like we're gonna maintain yet another physics flag |
| 21:46 |
[MTMatrix] |
<Zughy> So that when we have to fix one thing related to physics we have to deal with one more exception. That seems fun, luckily I'm not a core dev |
| 21:47 |
[MTMatrix] |
<Zughy> Also, this pushes people to avoid touching physics, if fixing a bug might result in creating new flags |
| 21:48 |
MTDiscord |
<warr1024> You don't necessarily really need to keep those old physics modes around forever, but you do need to have a deprecation schedule and give people time to adapt. |
| 21:48 |
[MTMatrix] |
<Zughy> We're speaking about years. How many bugs will come out in years? |
| 21:49 |
MTDiscord |
<warr1024> Rather than just silently removing ledge grabs it might actually be nicer to make them configurable as an actual feature. Movement physics are very stilted as it is. |
| 21:49 |
[MTMatrix] |
<Zughy> And we're not great with schedules nor planning, we barely have the next milestone and a roadmap that still creates debates |
| 21:50 |
MTDiscord |
<warr1024> Sounds like we've got bigger problems to worry about then than one physics flag. |
| 21:51 |
[MTMatrix] |
<Zughy> Should I get ready for another roadmap bikeshedding? |
| 21:51 |
[MTMatrix] |
<Zughy> Which will be discussed in the next meeting anyway https://dev.minetest.net/Meetings#2024-01-21 |
| 21:52 |
MTDiscord |
<warr1024> Probably. Client movement physics have historically been one of the most heavily bikeshedded issues I've seen. |
| 21:52 |
[MTMatrix] |
<Zughy> Bugfixes are always accepted, so it's not a roadmap problem |
| 21:53 |
MTDiscord |
<warr1024> Tbh being able to customize them and prevent future arguments over minute physics details would be a pretty good use-case for SSCSM. |
| 21:54 |
[MTMatrix] |
<Zughy> About planning future milestones: good luck with that, we're not a company and we can't tell people what to focus on |
| 21:54 |
MTDiscord |
<warr1024> Don't tell me good luck, good luck yourself, member of the core team that I'm not a part of 😆 |
| 21:55 |
[MTMatrix] |
<Zughy> Good luck as is "good luck suggesting a solution that might actually work" |
| 21:55 |
[MTMatrix] |
<Zughy> *as in |
| 21:56 |
MTDiscord |
<warr1024> If real solutions were actually feasible we wouldn't have such a strong work around culture. |
| 22:02 |
MTDiscord |
<jordan4ibanez> I missed the whole argument, very sad |
| 22:02 |
MTDiscord |
<jordan4ibanez> Anyways, I agree with the sentiment of just adding in that check that was seemingly forgotten many moons ago |
| 22:09 |
|
Sharpman joined #minetest-dev |
| 22:26 |
|
v-rob joined #minetest-dev |
| 22:52 |
|
fluxionary joined #minetest-dev |
| 22:53 |
|
Mantar joined #minetest-dev |
| 22:58 |
|
appguru joined #minetest-dev |
| 23:04 |
|
MTDiscord joined #minetest-dev |
| 23:04 |
|
book` joined #minetest-dev |
| 23:04 |
|
wsor4035 joined #minetest-dev |
| 23:16 |
|
luk3yx joined #minetest-dev |
| 23:23 |
|
izzyb joined #minetest-dev |
| 23:32 |
|
panwolfram joined #minetest-dev |
