| Time |
Nick |
Message |
| 00:32 |
|
lhofhansl joined #minetest-dev |
| 00:32 |
lhofhansl |
Hello. Merging #14251 in a few. |
| 00:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/14251 -- Slight optimizations in ClientMap by lhofhansl |
| 00:53 |
lhofhansl |
Done |
| 01:42 |
rubenwardy |
sfan5: the result was no change. Except sscsm was ranked a lot higher than before |
| 02:03 |
|
nrz joined #minetest-dev |
| 02:04 |
|
book` joined #minetest-dev |
| 02:10 |
|
panwolfram joined #minetest-dev |
| 02:15 |
|
lhofhansl joined #minetest-dev |
| 02:16 |
lhofhansl |
If someone could put #13956 through the wringer and try it out that would be helpful! |
| 02:16 |
ShadowBot |
https://github.com/minetest/minetest/issues/13956 -- Continuation of x2048's Cascaded Shadows by lhofhansl |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 06:04 |
|
lhofhansl joined #minetest-dev |
| 07:23 |
|
calcul0n_ joined #minetest-dev |
| 10:09 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:13 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:24 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:08 |
|
imi joined #minetest-dev |
| 11:18 |
[MTMatrix] |
<Zughy> Any news about Lizzy? I'm talking about #11016 |
| 11:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/11016 -- Dual Wielding by LizzyFleckenstein03 |
| 12:54 |
|
appguru joined #minetest-dev |
| 14:05 |
|
calcul0n joined #minetest-dev |
| 14:07 |
|
calculon joined #minetest-dev |
| 14:23 |
sfan5 |
still hoping for a quick approval on #14238 |
| 14:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/14238 -- [no squash] Unittest and some documentation things by sfan5 |
| 14:24 |
|
grorp joined #minetest-dev |
| 14:32 |
|
Noisytoot joined #minetest-dev |
| 14:34 |
grorp |
I'm hoping for someone to review #14118, now that the Irrlicht SDL touchscreen PR is merged |
| 14:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/14118 -- Don't enable relative mouse mode if in touchscreen mode by grorp |
| 14:34 |
grorp |
(I unfortunately have too little knowledge about the pseudorandom stuff to review your PR) |
| 14:43 |
sfan5 |
it depends on the exact feature or changes but I often don't do extensive reviews of other coredevs PRs. I just trust them to be correct. |
| 15:13 |
|
json joined #minetest-dev |
| 15:19 |
Krock |
sfan5: about 14238 I wonder whether such instructions wouldn't fit better into the dev wiki for easier navigation and quicker updates |
| 15:20 |
Krock |
or was the goal explicitly to move the documentation to the repo? |
| 15:32 |
sfan5 |
IMO development docs make more sense in the repo |
| 15:36 |
nrz |
i totally agree on that point sfan5 |
| 15:36 |
nrz |
docsy is the best framework we tested and are using massively for architecture an code design at work, it's very nice to generate pages with code |
| 15:47 |
Krock |
well except that most of the development docs is in the wiki. having similar information spread in two different places is not so optional in mid-term |
| 15:48 |
Krock |
the other changes work so far so I'll still approve the PR for the sake of thos |
| 15:48 |
Krock |
+e |
| 16:10 |
|
fluxionary joined #minetest-dev |
| 16:10 |
sfan5 |
I listed the three pages that I actually use in the README |
| 16:10 |
sfan5 |
do you use any other? |
| 16:20 |
sfan5 |
okay I see it contains quite a few pages describing the architecture in the 'core' category |
| 16:20 |
sfan5 |
they are mostly outdated (think 0.4 level) but in large parts still useful |
| 16:23 |
sfan5 |
then there's some advice intended for modders, I think that should go elsewhere |
| 16:28 |
Krock |
I also use the code style guidelines which are already referenced in CONFRIBUTING.md |
| 16:29 |
Krock |
guidelines overall, I suppose. |
| 16:29 |
celeron55 |
as the person who hosts the devwiki i would agree it doesn't seem to be the ideal place for anything it contains. it's mostly a museum |
| 16:31 |
celeron55 |
but on the other hand many things in there don't have a proper place to go. it's arguable how much we want to define our organization in the source code repo, for example |
| 16:32 |
celeron55 |
the architecture descriptions are outdated but still very useful in understanding minetest - the repo could host them, if they were brought properly up to date |
| 16:33 |
celeron55 |
there has been multiple efforts trying to move the modding stuff elsewhere from th devwiki, i don't know how many are still needed for that part to become completely irrelevant |
| 16:33 |
rubenwardy |
I suggest we move dev docs to the repo, modding hints to minetest_docs or wiki, and then get rid or devwiki |
| 16:36 |
celeron55 |
the only times i use the devwiki are when i introduce a new core dev to this https://dev.minetest.net/All_rules_regarding_to_development |
| 16:37 |
celeron55 |
do you think those could be moved to the repo? |
| 16:37 |
Krock |
could. question is whether someone is willing to do that |
| 16:39 |
rubenwardy |
Having two wikis doesn't really make sense. Even if we do still need a dev wiki, it could be merged into the wiki wiki. In the repo makes sense to me |
| 16:41 |
celeron55 |
even i don't remember why it's set up like this. i think xyz set them up, and maybe he copied the idea from some other project which had it like this, or something |
| 16:42 |
Krock |
to be fair, it's better for file hosting - such as images explaining steps in a GUI or providing examples which otherwise would bloat Git |
| 16:43 |
Krock |
either way - as long similar topics are in a similar place I'm fine with that |
| 16:43 |
celeron55 |
might have to limit graphics to svg if they're on a git repo |
| 16:55 |
sfan5 |
updated the PR a bit |
| 17:02 |
MTDiscord |
<luatic> pushing https://gist.github.com/appgurueu/468f6f9d95ff5fc8589abc4341b69e59 in 10m |
| 17:11 |
|
Desour joined #minetest-dev |
| 17:13 |
MTDiscord |
<luatic> pushed |
| 17:21 |
nrz |
celeron55, anything can be done, docsy is pure markdown with files using hugo to generate. It's like https://kubernetes.io/docs/home/ render, you can customize it obvisouly. As gitlab pages in the devel repo we can do anyuthing we want an use a subdomain of minetest.net like docs.minetest.net for this |
| 17:22 |
nrz |
also docsy permits to use various branches, permitting if we want to have doc for main branche and one for each tag |
| 17:26 |
Desour |
luatic: it's kinda weird nobody noticed this memleak with leaksan. are you sure the Mesh member is meant to be owning? |
| 17:26 |
Desour |
(congratz to becoming coredev btw!) |
| 17:27 |
MTDiscord |
<luatic> Desour: animated scene nodes call grab(), so they also have to call drop(). You can compare this with non-animated scene nodes which already properly call drop() in the destructor. |
| 17:28 |
MTDiscord |
<luatic> also thanks :) |
| 17:30 |
Desour |
ah I see |
| 17:46 |
|
lhofhansl joined #minetest-dev |
| 17:46 |
lhofhansl |
Merging #14185 in a few. |
| 17:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/14185 -- Allow active blocks to be generated by lhofhansl |
| 18:27 |
lhofhansl |
Done |
| 18:38 |
|
grorp joined #minetest-dev |
| 18:41 |
grorp |
hey Krock, did you see https://github.com/minetest/minetest/issues/14188#issuecomment-1879655424 ? |
| 18:44 |
grorp |
merging #14118, #14209, #14247 in 15 min |
| 18:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/14118 -- Don't enable relative mouse mode if in touchscreen mode by grorp |
| 18:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/14209 -- Android: Use the correct value for notification by srifqi |
| 18:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/14247 -- Document settings API behavior regarding default values by grorp |
| 19:02 |
grorp |
done. |
| 19:04 |
|
grorp1 joined #minetest-dev |
| 19:07 |
|
fluxionary joined #minetest-dev |
| 19:12 |
|
qur joined #minetest-dev |
| 19:37 |
|
appguru joined #minetest-dev |
| 22:39 |
|
imi joined #minetest-dev |
| 23:23 |
[MTMatrix] |
<Zughy> Meeting notice added, 2024/01/21 (in 7 days). Tomorrow is definitely a skip, too little time |
| 23:33 |
|
panwolfram joined #minetest-dev |
