Time |
Nick |
Message |
01:32 |
|
Soni joined #minetest-dev |
02:04 |
|
Soni joined #minetest-dev |
02:48 |
|
tekakutli joined #minetest-dev |
04:00 |
|
MTDiscord joined #minetest-dev |
05:24 |
|
srifqi joined #minetest-dev |
05:25 |
srifqi |
hello. merging #13187 in 5 minutes |
05:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/13187 -- Place nodes with single tap on Android (+ bugfix) by grorp |
05:30 |
srifqi |
done |
05:48 |
|
tekakutli joined #minetest-dev |
06:00 |
|
MTDiscord joined #minetest-dev |
06:00 |
|
panwolfram joined #minetest-dev |
06:02 |
|
luk3yx joined #minetest-dev |
06:26 |
|
calcul0n_ joined #minetest-dev |
06:57 |
|
hmmmm joined #minetest-dev |
08:19 |
|
appguru joined #minetest-dev |
11:06 |
|
proller joined #minetest-dev |
14:12 |
|
TheCoffeMaker_ joined #minetest-dev |
14:13 |
|
ShadowBot` joined #minetest-dev |
14:14 |
|
Sokomine_ joined #minetest-dev |
14:47 |
|
appguru joined #minetest-dev |
16:48 |
|
vampirefrog joined #minetest-dev |
16:57 |
|
imi joined #minetest-dev |
17:01 |
|
appguru joined #minetest-dev |
17:04 |
|
Desour joined #minetest-dev |
17:17 |
|
lhofhansl joined #minetest-dev |
17:18 |
lhofhansl |
Hello... Going to merge #13431 in a few. |
17:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/13431 -- Load blocks and objects behind player when in third-persion front-view by lhofhansl |
17:18 |
lhofhansl |
Quick reminder for #13314 It's trivial, just some useful instrumentation. |
17:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/13314 -- Instrument touchMapBlocks and block loading/deserialization. by lhofhansl |
17:22 |
|
TheCoffeMaker joined #minetest-dev |
17:26 |
lhofhansl |
Done |
17:37 |
|
appguru joined #minetest-dev |
17:44 |
|
appguru joined #minetest-dev |
18:17 |
lhofhansl |
Could use more input on #13093 |
18:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/13093 -- Avoid movement jitter while attached by lhofhansl |
18:24 |
Desour |
left a comment |
18:31 |
MTDiscord |
<Warr1024> Could that have any impact on #12317? |
18:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/12317 -- Other-player movement is "bouncy" / interpolation overshoots |
18:44 |
MTDiscord |
<Fatalist error> are there any plans to implement server sent settings? |
18:44 |
MTDiscord |
<Fatalist error> ever? |
18:57 |
sfan5 |
18:08 <+rubenwardy> sfan5: did you want to retest #10100 as it's changed since your approval? |
18:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/10100 -- Additional texture modifiers by Treer |
18:57 |
sfan5 |
i don't know, best just merge it since the author has been waiting long enough |
19:04 |
rubenwardy |
well, merging in 10 then |
19:06 |
|
Alias joined #minetest-dev |
19:08 |
rubenwardy |
There's some demand for support for custom auth methods, like integration with LDAP etc. I think one way we could do this in a flexible manner is to support OAuth - servers could specify a URL for clients to open, log in, and then get an auth token to authenticate with the server |
19:09 |
rubenwardy |
the fact that you current enter username/password first would be a problem |
19:09 |
rubenwardy |
could make it a "Connect" button and query the server first |
19:10 |
rubenwardy |
doubt many would benefit, seems low priority |
19:10 |
BuckarooBanzai |
You would need a webserver to redirect back from the OAuth provider though |
19:11 |
rubenwardy |
you would need a scheme to open Minetest again |
19:11 |
rubenwardy |
or could display a code and have them copy+paste |
19:15 |
lhofhansl |
Warr1024: Possibly, if the server lag is > 0.5s |
19:27 |
MTDiscord |
<Thresher> ruben: i remember you saying #13503 was too big for one pr. suggestions? |
19:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/13503 -- Documentation refactoring by Bituvo |
19:56 |
Desour |
Thresher: you could put each change into a separate commit, that would make it easier |
19:58 |
|
v-rob joined #minetest-dev |
20:00 |
MTDiscord |
<Thresher> all commits will be squashed when the pr is merged |
20:01 |
MTDiscord |
<Thresher> you mean separate pull request? |
20:01 |
Desour |
we can also merge without squashing |
20:02 |
Desour |
also, commits can be reviewed separately. so it doesn't *have* to be separate PRs (wouldn't necessarily hurt though) |
20:02 |
MTDiscord |
<Thresher> im not sure how i would break up the changes into separate commits |
20:04 |
Desour |
you could do one of the changes (into a different branch branch_bla), and then do `$ git rebase branch_bla` from your PR branch. and repeat this for every change. this should work normally |
20:05 |
v-rob |
Ooh, I didn't realize that there was a modern v6-like mapgen PR! If it's faithful to the original v6, I'm totally reviewing that. I think that none of the other mapgens hold a candle to v6, hardcoded biomes notwithstanding. |
20:08 |
MTDiscord |
<Thresher> desour: should i do that from now on, or would you like me to manually break up each of my commits ive made? |
20:08 |
Desour |
if possible, it would be good if you break it up into commits |
20:08 |
Desour |
sry btw, we should've told you something like that earlier |
20:09 |
MTDiscord |
<Thresher> ive broken up each of my commits after the initial one |
20:09 |
|
YuGiOhJCJ joined #minetest-dev |
20:09 |
|
Thresher joined #minetest-dev |
20:10 |
MTDiscord |
<Thresher> can you see images? |
20:10 |
MTDiscord |
<Thresher> https://cdn.discordapp.com/attachments/747163566800633906/1112835267712253983/image.png |
20:10 |
rubenwardy |
v-rob: woo! Make sure to add the [supported by core dev] :) |
20:10 |
v-rob |
Yes, will do |
20:10 |
Desour |
yes we can see it. |
20:11 |
MTDiscord |
<Thresher> im not sure how i would break up the first pr commit, since all the other ones after it build on that |
20:14 |
|
TheCoffeMaker joined #minetest-dev |
20:21 |
Desour |
hm, the easiest way would probably be if you just open separate PRs |
20:24 |
MTDiscord |
<Thresher> each of the changes are intertwined with each other. i cannot feasibly separate them all |
20:25 |
|
TheCoffeMaker joined #minetest-dev |
20:32 |
Desour |
you can do one of the changes, e.g. the markdown header style thing, again, and put that into a commit/PR. git rebase will separate them |
20:39 |
Desour |
(you don't have to do this too excessively, just try to move some changes out) |
20:51 |
Zughy[m] |
does Minetest consider the order of minetest.after calls? Like, if I declare A and B, where both are minetest.after functions with the same delay, does MT always run A first and B after? |
20:54 |
MTDiscord |
<savilli> It's not true even for different delays. |
20:54 |
Zughy[m] |
oh I guess #13477 is needed |
20:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/13477 -- Reduce `minetest.after` time complexity and provide ordering guarantee by appgurueu |
21:15 |
|
TheCoffeMaker joined #minetest-dev |
21:28 |
rubenwardy |
When we remove Minetest Game, what's our upgrade path for existing users? |
21:28 |
rubenwardy |
If the existing MTG install is kept, then it should be migrated/replaced by the ContentDB version so it receives updates. We might have to increase our range of versions to support as well unless we add autoupdating |
21:28 |
rubenwardy |
If the existing MTG install is removed, then we should work out a way to combat the UX of missing worlds. I guess with a special error message for it |
21:28 |
rubenwardy |
We'd probably have to account for both cases |
22:31 |
|
panwolfram joined #minetest-dev |
22:58 |
|
lhofhansl joined #minetest-dev |
23:06 |
|
MTDiscord joined #minetest-dev |
23:07 |
|
AliasAlreadyTake joined #minetest-dev |