| Time |
Nick |
Message |
| 00:22 |
|
ShadowBot joined #minetest-dev |
| 03:00 |
MisterE[m] |
In case its not obvious, I wouldn't be in such a group since I don't work on the engine |
| 03:10 |
|
LandarVargan joined #minetest-dev |
| 03:55 |
|
tekakutli joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:19 |
|
tekakutli joined #minetest-dev |
| 05:45 |
|
calcul0n joined #minetest-dev |
| 06:18 |
|
appguru joined #minetest-dev |
| 08:40 |
Zughy[m] |
I mean, you work on the official blog |
| 09:17 |
pgimeno |
Zughy[m]: about TurkeyMcMac's PRs, would it be possible to somehow mark the ones that are open now, so that when they are closed, if someone wants to take another look at them as if they remained open, they can be identified? It sounds to me like there has been too little time for reviewing and adopting. |
| 09:18 |
pgimeno |
Keeping the "adoption needed" after close kind of works, but there are a couple ones that have that tag and are already closed. |
| 09:20 |
rubenwardy |
not sure what you mean, but you can use author:TurkeyMcMac |
| 09:21 |
pgimeno |
I think that some of the currently open ones may not have been reviewed for whether they are wanted or not. If they are closed, how can one know which ones are still in need to be reviewed? |
| 09:22 |
pgimeno |
I used `is:pr label:"Adoption needed" author:TurkeyMcMac` and two closed ones appear |
| 09:23 |
pgimeno |
I assume these were closed for good reasons, and don't need to be checked again |
| 09:27 |
pgimeno |
if the existing ones are closed, then these two would not be distinguishable from the rest, that was my point |
| 09:27 |
pgimeno |
one solution would be to remove "Adoption needed" from them |
| 09:29 |
rubenwardy |
if they are closed then they're not in need of review - they're in need of adoption |
| 09:30 |
rubenwardy |
adoption needed should be removed if the PR isn't supported though |
| 09:36 |
pgimeno |
it seems someone has removed the label for the PRs that were closed, I guess that settles it, thanks |
| 09:47 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:05 |
|
appguru joined #minetest-dev |
| 10:35 |
|
appguru joined #minetest-dev |
| 10:53 |
|
proller joined #minetest-dev |
| 11:46 |
|
fluxionary joined #minetest-dev |
| 11:55 |
|
appguru joined #minetest-dev |
| 13:41 |
|
proller joined #minetest-dev |
| 13:55 |
|
appguru joined #minetest-dev |
| 14:16 |
|
appguru joined #minetest-dev |
| 14:40 |
|
appguru joined #minetest-dev |
| 15:40 |
|
proller joined #minetest-dev |
| 17:05 |
|
tekakutli joined #minetest-dev |
| 17:21 |
|
Alias joined #minetest-dev |
| 17:46 |
|
appguru joined #minetest-dev |
| 19:16 |
|
appguru joined #minetest-dev |
| 19:38 |
|
tekakutli joined #minetest-dev |
| 19:56 |
|
appguru joined #minetest-dev |
| 20:01 |
|
proller joined #minetest-dev |
| 22:32 |
|
panwolfram joined #minetest-dev |
| 22:59 |
|
tekakutli joined #minetest-dev |
| 23:03 |
|
Krock joined #minetest-dev |
