| Time |
Nick |
Message |
| 01:16 |
|
YuGiOhJCJ joined #minetest-dev |
| 01:23 |
|
proller joined #minetest-dev |
| 01:40 |
|
proller joined #minetest-dev |
| 01:44 |
|
calculon joined #minetest-dev |
| 03:04 |
|
YuGiOhJCJ joined #minetest-dev |
| 03:43 |
|
dzho joined #minetest-dev |
| 03:43 |
|
dzho joined #minetest-dev |
| 03:52 |
|
proller joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:25 |
|
calcul0n joined #minetest-dev |
| 09:57 |
|
dv^_^ joined #minetest-dev |
| 11:37 |
|
proller joined #minetest-dev |
| 12:10 |
|
kilbith joined #minetest-dev |
| 15:40 |
|
wsor joined #minetest-dev |
| 15:40 |
|
MisterE123 joined #minetest-dev |
| 17:18 |
|
LandarVargan joined #minetest-dev |
| 18:32 |
|
Guest54 joined #minetest-dev |
| 18:33 |
Guest54 |
hey, are you aware that setting connected_glass to true break several texture packs and minetest_game? |
| 18:34 |
Guest54 |
i mean, it breaks obsidian glass in minetest game (it turns invisible) |
| 18:36 |
Guest54 |
i can provide a screenshot |
| 18:43 |
MTDiscord |
<luatic> please report the issue on https://github.com/minetest/minetest/issues |
| 18:43 |
Guest54 |
also the effect is weird on stuff like church windows |
| 18:44 |
Guest54 |
(so i doubt many people who build with glass will like it, me included) |
| 18:48 |
Guest54 |
luatic it seems paramat brought that up already some time and paramat already mentioned that it messes up some stuff: https://github.com/minetest/minetest/issues/8290#issuecomment-520171720 |
| 18:49 |
ROllerozxa |
ah paramat being paramat |
| 18:50 |
Guest54 |
i did check it, it basically makes obsidian glass walls / ceilings from a nice grid into invisible nodes |
| 18:51 |
MTDiscord |
<luatic> I don't think that issue is about a glaring rendering bug? |
| 18:51 |
Guest54 |
luatic ROllerozxa look for yourself https://mister-muffin.de/p/I2fC.png |
| 18:53 |
Guest54 |
luatic what is the rendering bug? the thing is, “connected glass” does simply not work for all glass textures, by design. |
| 18:54 |
Guest54 |
which *i guess* is why it was made it optional and defaulted to false (so you always get it right) |
| 18:57 |
rubenwardy |
The node definition still needs to opt in to allowing connected glass though |
| 18:58 |
Guest54 |
rubenwardy IIRC quite a few mods did that so users can activate connected glass if the texture pack works with it |
| 18:58 |
MTDiscord |
<luatic> well, you made it sound like a rendering bug |
| 18:59 |
MTDiscord |
<luatic> of course internal nodes are supposed to be invisible |
| 18:59 |
Guest54 |
oh, but they were not before this change |
| 19:00 |
Guest54 |
unless the user manually activated connected glass |
| 19:01 |
Guest54 |
(which probably means they had a texture pack supporting it) |
| 19:15 |
MTDiscord |
<GoodClover> Sounds like texture packs should be able to change the connected glass settings |
| 19:16 |
MTDiscord |
<GoodClover> Minetest's texture/visual system is a weird half way from two directions then bolted together :/ |
| 19:17 |
Guest54 |
GoodClover, not really. all texture packs work with non-connected glass. not all texture packs work properly with connected glass (due to assumptions about the texture that the connected glass tiling needs to make). |
| 19:18 |
|
diceLibrarian joined #minetest-dev |
| 19:18 |
MTDiscord |
<GoodClover> Exactly, and so the texture pack should decide which it is? I don't get what you're disputing |
| 19:19 |
Guest54 |
GoodClover IMO the user should decide, but the default should work for all texture packs |
| 19:21 |
Guest54 |
rubenwardy regarding opting in: a year ago mineclone2 did change glasslike to glasslike_framed_optional which i think may become surprising with the changed default https://git.minetest.land/MineClone2/MineClone2/pulls/1939 |
| 20:15 |
|
kilbith joined #minetest-dev |
| 20:32 |
Guest54 |
the connected glass thing is even more weird: if it is enabled together with the 7px pack, the glass texture from the 7px pack is simply not loaded. |
| 21:10 |
|
proller joined #minetest-dev |
| 21:16 |
sfan5 |
wait when did we change the default |
| 21:17 |
Krock |
https://github.com/minetest/minetest/pull/13242 |
| 21:18 |
Krock |
inb4 you approved it |
| 21:20 |
sfan5 |
ah, so pretty recently |
| 21:21 |
Guest54 |
anyways, no idea if "some texture packs will not work for glass anymore with default settings" was on your list for this 5.7, i just wanted you do know because it *seems* it was not considered (and if it was, i could not find it in the chatlogs) |
| 21:21 |
sfan5 |
as far as I'm aware if a mod opts into connected glass the texture pack needs to support it too |
| 21:22 |
sfan5 |
so you can blame the texture pack for not doing so |
| 21:23 |
sfan5 |
but I see how changing the global default might be a bad idea in general |
| 21:23 |
sfan5 |
it's more like that games should have the choice on the default I guess |
| 21:23 |
Krock |
sill, the setting existed and players could already freely change that before |
| 21:23 |
Guest54 |
well, mineclone2 changed the glass to optionally framed because *some* players liked it and wanted it as an option (a year ago), but i can't speak for that community. |
| 21:24 |
Krock |
if there's players who don't like it, they can turn it off. same idea. |
| 21:24 |
Guest54 |
and ofc the texture pack authors can be blamed, but it does not change the facts: before the default was changed, any texture pack would work with optionally framed glass, now it does not. |
| 21:24 |
MTDiscord |
<PrairieWind> hmm |
| 21:24 |
MTDiscord |
<PrairieWind> sorry |
| 21:25 |
|
book` joined #minetest-dev |
| 21:26 |
|
diceLibrarian joined #minetest-dev |
| 21:26 |
Guest54 |
sfan5 oh, i think i figured it out: previously the texture pack did not need to support framed glass if there was a fallback texture. minetest game always has one for glass, but that one does not get rendered if the optionally framed glass is not rendered as framed. |
| 21:27 |
Guest54 |
i mean the default_glass_detail.png |
| 21:28 |
Guest54 |
i.e. if it is not defined, you get an error indeed. |
| 21:46 |
|
Guest54 joined #minetest-dev |
| 21:56 |
|
ivanbu joined #minetest-dev |
| 22:09 |
|
ivanbu joined #minetest-dev |
| 22:39 |
|
YuGiOhJCJ joined #minetest-dev |
| 23:00 |
|
proller joined #minetest-dev |
| 23:27 |
|
diceLibrarian joined #minetest-dev |
| 23:29 |
|
Guest54 joined #minetest-dev |
| 23:39 |
|
YuGiOhJCJ joined #minetest-dev |
| 23:40 |
|
Evergreen joined #minetest-dev |
