| Time |
Nick |
Message |
| 01:24 |
|
fluxionary joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:01 |
MTDiscord |
<FatalError> what's the possbility of flashlights (that dont have a ton of lag from blocks and stuff) being possible? |
| 04:01 |
MTDiscord |
<FatalError> because the invisible light block strat isn't exactly flawless |
| 04:08 |
|
v-rob joined #minetest-dev |
| 05:11 |
|
calcul0n joined #minetest-dev |
| 05:49 |
|
olliy joined #minetest-dev |
| 06:01 |
|
v-rob joined #minetest-dev |
| 06:11 |
|
YuGiOhJCJ joined #minetest-dev |
| 06:30 |
|
v_rob joined #minetest-dev |
| 06:56 |
MTDiscord |
<luatic> With x2048's progress on rendering, we might get there |
| 07:03 |
|
appguru joined #minetest-dev |
| 07:56 |
|
MTDiscord1 joined #minetest-dev |
| 08:03 |
sfan5 |
I wouldn't say the PR is unreviewable, more like unmergable even if reviewed |
| 08:04 |
sfan5 |
at the very least the "I happed to touch this code and made it better" changes (for code unrelated to sound) should be in a separate commit |
| 08:04 |
sfan5 |
also the addition of ServerSoundRef |
| 08:48 |
|
Fixer joined #minetest-dev |
| 09:05 |
kilbith |
your async PR was a big as Desour's and it was merged; idk why there should be such a double-standard |
| 09:07 |
MTDiscord |
<luatic> kilbith: No. This PR is about twice as big as the async PR. The async PR was also mostly additions, whereas this PR includes large changes (many deletions) likely to conflict with any other changes to sound code. |
| 09:07 |
kilbith |
we are counting in thousands of LOC for both of them |
| 09:08 |
MTDiscord |
<luatic> It also took a year for the async PR to be merged. |
| 09:08 |
MTDiscord |
<luatic> kilbith: approx +2k-0.3k for sfan5's async env. vs. +3.6k-1.6k for Desour's sound refactor |
| 09:08 |
kilbith |
back in the past, nerzhul's cleanups were of the same magnitude |
| 09:09 |
MTDiscord |
<luatic> This is not only a cleanup though; it's a cleanup plus some features and bugfixes |
| 09:09 |
nrz_ |
i did some, yeah, and tried to split as much as possible |
| 09:10 |
nrz_ |
it's not always easy when we have huge refactor, and the magnitude of the refacto shows also that we may have too bigger objects in terms of respobility |
| 09:11 |
kilbith |
looks like they're accepted only if you are a core-dev tho |
| 09:11 |
kilbith |
which is understandable |
| 09:11 |
MTDiscord |
<luatic> how is that relevant - Desour is a core dev? |
| 09:12 |
MTDiscord |
<luatic> and non core devs rarely make PRs of this scale |
| 09:12 |
MTDiscord |
<luatic> and if they do, they should probably be considered for being core devs |
| 09:12 |
kilbith |
no and that's why it's "unmergable even if reviewed" |
| 09:13 |
rubenwardy |
the async PR wasn't a single commit |
| 09:13 |
kilbith |
HuguesRoss: I'd like to get news from you and if you still intend to take the scrollbar PR over |
| 09:18 |
nrz_ |
yeah if possible having multiple commits on big PR permits to understand the evolution |
| 09:21 |
rubenwardy |
devtest tools like #12628 would also help |
| 09:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/12628 -- devtest: Add moving entity to test 3d sounds by rubenwardy |
| 09:54 |
|
proller joined #minetest-dev |
| 10:09 |
|
proller joined #minetest-dev |
| 10:11 |
HuguesRoss |
kilbith: It was my intention, but my health situation got worse which is why I'm not doing *anything* right now |
| 10:12 |
HuguesRoss |
You can look at my gitlab account for proof of that, my commits fell off a cliff ~3 weeks ago: https://gitlab.com/Df458 |
| 10:17 |
HuguesRoss |
There was a brief period where things improved to a point where I could justify returning to MT, but then we took the supports off and things have been going rather poorly since |
| 10:33 |
rubenwardy |
I hope you get well soon, wishing the best |
| 10:34 |
nrz_ |
good luck HuguesRoss |
| 10:41 |
kilbith |
HuguesRoss: I'm very sorry to hear that, I'm joining the others to wish you a quick recovery |
| 10:54 |
|
vampirefrog joined #minetest-dev |
| 11:50 |
sfan5 |
HuguesRoss: get well soon, take the time you need |
| 11:51 |
sfan5 |
created #12765 |
| 11:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/12765 -- Backport 5.6.1 by sfan5 |
| 12:08 |
nrz_ |
sounds fair, didn't followed sufficient activity to judge if we have all |
| 12:09 |
|
proller joined #minetest-dev |
| 13:24 |
|
appguru joined #minetest-dev |
| 14:30 |
|
ely-the-kitsune joined #minetest-dev |
| 14:34 |
|
Desour joined #minetest-dev |
| 14:55 |
|
v-rob joined #minetest-dev |
| 14:57 |
|
v-rob joined #minetest-dev |
| 15:07 |
|
Noisytoot joined #minetest-dev |
| 15:17 |
|
ely-the-kitsune joined #minetest-dev |
| 15:17 |
|
ely-the-kitsune joined #minetest-dev |
| 15:18 |
|
ely-the-kitsune4 joined #minetest-dev |
| 15:46 |
|
Noisytoot joined #minetest-dev |
| 16:08 |
Krock |
#12763 ^ for 5.6.1 as soon it's merged |
| 16:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/12763 -- Fix UAF in craft recipes by savilli |
| 16:13 |
Desour |
it looks like the authors of the devtest media files are nowhere documented |
| 16:14 |
Desour |
(at least not in games/devtest/LICENSE.txt, LICENSE.txt or games/devtest/README.md) |
| 16:16 |
|
v-rob joined #minetest-dev |
| 16:58 |
|
ely-the-kitsune joined #minetest-dev |
| 17:02 |
|
v-rob joined #minetest-dev |
| 17:24 |
|
Noisytoot joined #minetest-dev |
| 17:48 |
|
ely-the-kitsune joined #minetest-dev |
| 19:24 |
|
v-rob joined #minetest-dev |
| 19:27 |
|
appguru joined #minetest-dev |
| 19:59 |
|
proller joined #minetest-dev |
| 20:19 |
|
troller joined #minetest-dev |
| 20:27 |
|
appguru joined #minetest-dev |
| 20:40 |
|
Noisytoot joined #minetest-dev |
| 21:05 |
|
Noisytoot joined #minetest-dev |
| 21:13 |
|
ely-the-kitsune joined #minetest-dev |
| 21:38 |
|
v-rob joined #minetest-dev |
| 22:35 |
|
panwolfram joined #minetest-dev |
| 23:37 |
|
v-rob joined #minetest-dev |
