Time |
Nick |
Message |
00:26 |
Baytuch |
Good morning |
01:53 |
|
YuGiOhJCJ joined #minetest-dev |
02:31 |
|
YuGiOhJCJ joined #minetest-dev |
04:00 |
|
MTDiscord joined #minetest-dev |
04:22 |
|
ShadowNinja joined #minetest-dev |
04:22 |
|
sfan5 joined #minetest-dev |
04:22 |
|
ShadowBot joined #minetest-dev |
04:27 |
|
beanzilla joined #minetest-dev |
04:31 |
|
nore joined #minetest-dev |
05:10 |
|
loggingbot_ joined #minetest-dev |
05:10 |
|
Topic for #minetest-dev is now Minetest core development and maintenance. Chit-chat goes to #minetest. https://dev.minetest.net/ https://github.com/minetest |
05:15 |
|
schwarzwald[m] joined #minetest-dev |
05:54 |
|
calcul0n_ joined #minetest-dev |
06:40 |
|
Alias joined #minetest-dev |
07:18 |
|
Baytuch joined #minetest-dev |
08:06 |
|
Taoki joined #minetest-dev |
10:05 |
|
HuguesRoss joined #minetest-dev |
11:01 |
Zughy[m] |
why F-Droid is still on MT 5.2? |
11:02 |
rubenwardy |
we don't maintain it, they need to update their scripts |
11:03 |
rubenwardy |
they were blocked from updating after our Android build scripts changed, but we've since made changes that allow them to update |
11:08 |
rubenwardy |
https://gitlab.com/fdroid/fdroiddata/-/issues/2116 |
11:09 |
rubenwardy |
Another thing we could do is have official support for pointing at a local minetest_android_deps build folder, rather than downloading from GitHub CI |
11:10 |
|
calcul0n joined #minetest-dev |
12:32 |
sfan5 |
I'm pretty sure moving your own built sources to where the folder should be works |
12:35 |
rubenwardy |
won't gradle override it? |
12:35 |
rubenwardy |
-ride + write |
12:36 |
sfan5 |
if the folder already exists it shouldn't do anything |
12:37 |
sfan5 |
anyway integrating minetest_android_deps with f-droid is just a bunch of work for them since each source download has to be declared separately (you can't let scripts do it) |
12:52 |
|
proller joined #minetest-dev |
13:20 |
|
proller joined #minetest-dev |
13:33 |
|
Fixer joined #minetest-dev |
14:10 |
|
proller joined #minetest-dev |
14:36 |
|
proller joined #minetest-dev |
14:46 |
schwarzwald[m] |
Who owns https://scan.coverity.com/projects/minetest-official and can I be added to it? |
14:54 |
Zughy[m] |
#11702 sounds like a "Can't fix", may I proceed? |
14:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/11702 -- All ingame audio is gone after changing audio output device |
14:55 |
sfan5 |
no need to put can't fix when it's tagged upstream issue |
14:56 |
sfan5 |
but yes can be closed |
15:04 |
schwarzwald[m] |
<schwarzwald[m]> "Who owns https://scan.coverity...." <- I've requested access to it as JosiahWI. |
15:08 |
sfan5 |
maybe an email will pop into some persons inbox |
15:08 |
sfan5 |
but given it's been last used 5 years ago I doubt we'll find out |
15:09 |
schwarzwald[m] |
So what you're saying is, some random guy registered the official repo and we don't know who he is? |
15:11 |
sfan5 |
well no |
15:11 |
sfan5 |
there are a bunch of people who were very active 5y ago but are nowhere to be found |
15:11 |
sfan5 |
+today |
15:14 |
Zughy[m] |
Fortunately JosiahWI is still an active member of the community |
15:15 |
schwarzwald[m] |
You don't say. |
15:16 |
Zughy[m] |
oh LOL you're Josiah, sorry hahaha I misread |
15:27 |
|
fluxionary joined #minetest-dev |
15:30 |
rubenwardy |
Maybe ShadowNinja? |
16:23 |
nore |
Or maybe sofar? I vaguely recall that someone set it up a long time ago, but I don't remember who it was |
16:26 |
|
btdmaster joined #minetest-dev |
16:27 |
|
btdmaster left #minetest-dev |
16:34 |
sfan5 |
oh hey I got an email from coverity |
16:35 |
sfan5 |
and there's 4 other devs on CC |
16:36 |
sfan5 |
schwarzwald[m]: it appears you already have permission to view |
16:37 |
schwarzwald[m] |
sfan5: Thanks, looks like I do now! |
16:37 |
sfan5 |
have fun viewing scan results for 0.4.15 |
16:38 |
schwarzwald[m] |
Yeah, most of these are probably really outdated. |
16:39 |
schwarzwald[m] |
I wonder whether I can upload a new build. |
16:39 |
sfan5 |
admin permission needed for that |
16:40 |
schwarzwald[m] |
I guess that means someone like sfan5 needs to do it. ^^ |
16:55 |
schwarzwald[m] |
sfan5: These haven't all been fixed.... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/4de4b628ed4c476f9dbb1f4ca3c16775f7d4a1c6) |
17:16 |
sfan5 |
submitted a fresh build to coverity |
17:16 |
sfan5 |
lets see |
17:18 |
schwarzwald[m] |
I've heard it does have false positives, so not everything it reports is a real problem. |
17:34 |
schwarzwald[m] |
It's claiming to have found 7 memory leaks. I haven't investigated the code yet to see what that's about. |
17:41 |
schwarzwald[m] |
Oops, some it analyzed some system includes for some reason, and some of the supposed memory leaks are reported in those, so they're probably false positives. |
17:51 |
schwarzwald[m] |
s/some// |
18:17 |
sfan5 |
I looked at some results, there might be like one or two real bugs in there |
18:21 |
schwarzwald[m] |
Massive pain to figure out which ones those are. ? |
18:23 |
schwarzwald[m] |
It thinks that the pointer returned by `wgettet(...)` was leaked because it wasn't saved, and I think it has to be right, because it can't have returned a pointer to a resource without dynamically allocating it. |
18:23 |
schwarzwald[m] |
So although it's quite a minor leak, I think it's legit. |
19:00 |
|
Taoki joined #minetest-dev |
19:19 |
|
Baytuch_2 joined #minetest-dev |
19:19 |
sfan5 |
merging #12451 |
19:19 |
ShadowBot |
https://github.com/minetest/minetest/issues/12451 -- Annotate light spread functions with comments by sfan5 |
19:29 |
|
nrz joined #minetest-dev |
19:30 |
nrz |
hey, just published https://github.com/minetest/minetest/pull/12462 with some fixes on interesting part, reported by coverity (not all, reading the report is lon,g and triage too :D) embed: fix: various unitinialized or badly initialized variables by nerzhu... - Also check some return values as proposed by coverity, if they are relevant to be triggered as a bug |
19:30 |
nrz |
To do |
19:30 |
nrz |
This PR is a Ready for Review. |
19:30 |
nrz |
How to test - https://github.com/minetest/minetest/pull/12462 |
19:30 |
nrz |
i was muted or matterbridge buged, anyway, just said i was admin on coverity and checked some issues, and fixed some useful. Majority of them are not possible in theory |
19:32 |
|
kilbith joined #minetest-dev |
19:39 |
Krock |
I'd like if someone could have a look at #11939. This would make trampolines fun again |
19:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/11939 -- Restore and enhance bouncy behavior by pecksin |
19:39 |
Krock |
in the meantime I'll merge #12373 and #12382 |
19:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/12373 -- Raise default max FPS on Android to 60 by rollerozxa |
19:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/12382 -- Re-order sound-related code by SmallJoker |
19:39 |
Krock |
in ~ 15 minutes |
19:40 |
sfan5 |
speaking of important PRs -> https://github.com/minetest/minetest/milestone/19 |
19:44 |
|
HuguesRoss1 joined #minetest-dev |
19:48 |
nrz |
oh nice Krock for 12382, i was reading it and i like it ? really |
19:56 |
Krock |
merged 12382. will keep the other for some discussion |
20:07 |
|
kilbith joined #minetest-dev |
20:30 |
|
proller joined #minetest-dev |
20:43 |
|
YuGiOhJCJ joined #minetest-dev |
21:45 |
|
YuGiOhJCJ joined #minetest-dev |
22:33 |
|
panwolfram joined #minetest-dev |
23:06 |
|
AliasAlreadyTake joined #minetest-dev |