Time |
Nick |
Message |
00:00 |
|
Alias2 joined #minetest-dev |
01:10 |
|
Extex joined #minetest-dev |
02:25 |
|
queria joined #minetest-dev |
02:34 |
|
queria joined #minetest-dev |
04:00 |
|
MTDiscord joined #minetest-dev |
04:38 |
|
Shara joined #minetest-dev |
04:38 |
|
Shara joined #minetest-dev |
04:45 |
|
book` joined #minetest-dev |
04:58 |
|
loggingbot_ joined #minetest-dev |
04:58 |
|
Topic for #minetest-dev is now Minetest core development and maintenance. Chit-chat goes to #minetest. https://dev.minetest.net/ |
04:58 |
|
m42uko joined #minetest-dev |
04:58 |
|
Menchers joined #minetest-dev |
05:22 |
|
longerstaff13 joined #minetest-dev |
05:42 |
|
YuGiOhJCJ joined #minetest-dev |
07:15 |
|
specing_ joined #minetest-dev |
07:49 |
|
tech_exorcist joined #minetest-dev |
07:51 |
|
tech_exorcist joined #minetest-dev |
08:45 |
|
olliy joined #minetest-dev |
09:19 |
|
olliy joined #minetest-dev |
09:23 |
|
calcul0n_ joined #minetest-dev |
12:26 |
|
Wuzzy joined #minetest-dev |
12:50 |
BuckarooBanzai |
sfan5: wow you are fast :O |
12:50 |
sfan5 |
happened to open the notifications panel in the right moment |
12:52 |
|
proller joined #minetest-dev |
13:03 |
|
ivanbu joined #minetest-dev |
13:07 |
|
olliy1or joined #minetest-dev |
13:22 |
sfan5 |
merging #11596 in 5m |
13:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/11596 -- Add missing zstd-libs to final Docker image by BuckarooBanzay |
14:14 |
|
Taoki joined #minetest-dev |
15:15 |
|
Fixer joined #minetest-dev |
15:20 |
|
erlehmann joined #minetest-dev |
15:55 |
|
Extex joined #minetest-dev |
16:48 |
|
Pexin joined #minetest-dev |
17:16 |
|
jonadab joined #minetest-dev |
18:04 |
Krock |
error: sha1 information is lacking or useless (src/network/serverpackethandler.cpp). |
18:04 |
Krock |
github's patch output seems to be drunk |
18:06 |
Krock |
apparently fails to apply https://github.com/minetest/minetest/pull/11550/commits/ba6c1d7 even as diff :/ |
18:06 |
sfan5 |
git fetch https://github.com/minetest/minetest pull/11550/merge && git merge --no-edit FETCH_HEAD |
18:08 |
Krock |
witchcraft |
18:08 |
Krock |
thank you |
18:21 |
|
olliy joined #minetest-dev |
18:21 |
|
appguru joined #minetest-dev |
18:23 |
Krock |
sfan5: the media callback is not run when the client already got the media file. wouldn't it be easier from mod perspective to run the callback in all cases? |
18:25 |
Krock |
although the current behaviour is not complicated to use either. it just needs a manual short-circuit to the callback when the media was already sent before |
18:36 |
|
longerstaff13 joined #minetest-dev |
18:40 |
sfan5 |
uh |
18:40 |
sfan5 |
normally the same file cannot be added twice, which situation are you thinking of? |
19:05 |
|
ssieb joined #minetest-dev |
19:06 |
Krock |
for example, when a mod wants to show a map to the player. the formspec sending is callback-based, and the map a generated, dynamically-sent png |
19:07 |
Krock |
if this map is opened multiple times (although always the same file), the callback is not run directly, and the mod has to deal with this case in particular |
19:15 |
|
specing_ joined #minetest-dev |
19:16 |
sfan5 |
is the map generated generated once or everytime the formspec is viewed? |
19:17 |
sfan5 |
I think I know what you're getting at though: the client should send TOSERVER_HAVE_MEDIA if it detects that it already has the media? |
20:07 |
Krock |
yes that's what I meant. Since the client is ready already, it might be convenient to run the callback anyway |
20:07 |
Krock |
yes, the map could be generated generated everytime everytime or not, but it does not matter much |
20:10 |
sfan5 |
if you generate it everytime you'd use ephemeral anyway |
20:10 |
sfan5 |
and this problem would not exist since you also have to choose a more-or-less unique media name |
20:18 |
sfan5 |
pushed a commit changing that |
20:28 |
sfan5 |
Krock: want me to change the while to for or is that only an idea? |
21:16 |
|
calcul0n joined #minetest-dev |
21:26 |
|
proller joined #minetest-dev |
21:44 |
|
proller joined #minetest-dev |
22:24 |
|
erlehmann joined #minetest-dev |
22:32 |
|
proller joined #minetest-dev |
23:11 |
|
proller joined #minetest-dev |
23:53 |
|
proller joined #minetest-dev |
23:59 |
|
AliasAlreadyTake joined #minetest-dev |