Time Nick Message 12:50 BuckarooBanzai sfan5: wow you are fast :O 12:50 sfan5 happened to open the notifications panel in the right moment 13:22 sfan5 merging #11596 in 5m 13:22 ShadowBot https://github.com/minetest/minetest/issues/11596 -- Add missing zstd-libs to final Docker image by BuckarooBanzay 18:04 Krock error: sha1 information is lacking or useless (src/network/serverpackethandler.cpp). 18:04 Krock github's patch output seems to be drunk 18:06 Krock apparently fails to apply https://github.com/minetest/minetest/pull/11550/commits/ba6c1d7 even as diff :/ 18:06 sfan5 git fetch https://github.com/minetest/minetest pull/11550/merge && git merge --no-edit FETCH_HEAD 18:08 Krock witchcraft 18:08 Krock thank you 18:23 Krock sfan5: the media callback is not run when the client already got the media file. wouldn't it be easier from mod perspective to run the callback in all cases? 18:25 Krock although the current behaviour is not complicated to use either. it just needs a manual short-circuit to the callback when the media was already sent before 18:40 sfan5 uh 18:40 sfan5 normally the same file cannot be added twice, which situation are you thinking of? 19:06 Krock for example, when a mod wants to show a map to the player. the formspec sending is callback-based, and the map a generated, dynamically-sent png 19:07 Krock if this map is opened multiple times (although always the same file), the callback is not run directly, and the mod has to deal with this case in particular 19:16 sfan5 is the map generated generated once or everytime the formspec is viewed? 19:17 sfan5 I think I know what you're getting at though: the client should send TOSERVER_HAVE_MEDIA if it detects that it already has the media? 20:07 Krock yes that's what I meant. Since the client is ready already, it might be convenient to run the callback anyway 20:07 Krock yes, the map could be generated generated everytime everytime or not, but it does not matter much 20:10 sfan5 if you generate it everytime you'd use ephemeral anyway 20:10 sfan5 and this problem would not exist since you also have to choose a more-or-less unique media name 20:18 sfan5 pushed a commit changing that 20:28 sfan5 Krock: want me to change the while to for or is that only an idea?