| Time |
Nick |
Message |
| 00:06 |
|
naxeu_ joined #minetest-dev |
| 00:07 |
naxeu_ |
Hello. I'm trying to compile mintest from source. But I get a error on a c++ file |
| 00:07 |
naxeu_ |
command: cmake . -DIRRLICHT_INCLUDE_DIR=$PWD/../irrlicht/include -DIRRLICHT_LIBRARY=$PWD/../irrlicht/lib/Linux/libIrrlicht.a |
| 00:10 |
naxeu_ |
stderr log: https://bin.veracry.pt/?8f8cd9474c7e240b#FnjPHj73xXMYWjgHdBtSREaqxQMLH9J7cDaAi9HTrbLV |
| 00:11 |
MTDiscord |
<Jordach> try "${PWD}/../irrlicht/" |
| 00:11 |
MTDiscord |
<Jordach> try enclosing them in brackets, had similar issues with unusual paths |
| 00:12 |
MTDiscord |
<Jordach> wait no |
| 00:12 |
naxeu_ |
But the problem isn't on cmake. It is no make |
| 00:12 |
naxeu_ |
*no -> on |
| 00:12 |
MTDiscord |
<Jordach> $PWD would be invalid as there's no variable available in bash |
| 00:14 |
MTDiscord |
<Jordach> you can try the following |
| 00:14 |
MTDiscord |
<Jordach> cmake . -DIRRLICHT_INCLUDE_DIR="../irrlicht/include" -DIRRLICHT_LIBRARY="../irrlicht/lib/Linux/libIrrlicht.a" |
| 00:16 |
naxeu_ |
I've run from the real path since the root "/" |
| 00:16 |
naxeu_ |
No changes |
| 00:16 |
naxeu_ |
The error is when I run make |
| 00:17 |
naxeu_ |
On client/gameui.cpp, |
| 00:17 |
naxeu_ |
irrlicht_changes/static_text.h |
| 00:18 |
naxeu_ |
The full version is on this link https://vcr.pt/BZOW8 |
| 00:19 |
naxeu_ |
@dev_team |
| 00:24 |
MTDiscord |
<Jordach> are you using the minetest forked irrlicht or the original irrlicht |
| 00:25 |
naxeu_ |
Forked |
| 00:26 |
MTDiscord |
<Jordach> hmm |
| 00:26 |
MTDiscord |
<Jordach> stable-5 version of MT or master branch |
| 00:27 |
MTDiscord |
<Jordach> because it looks like you used the stable branch which currently is incompatible with the MT fork of irrlicht |
| 00:28 |
MTDiscord |
<Benrob0329> @naxeu_#0000 link against libirrlichtMt.a |
| 00:28 |
MTDiscord |
<Benrob0329> naxeu_ ^ |
| 00:29 |
MTDiscord |
<Jordach> if the library was missing he'd get a linking error, not a compiling error |
| 00:29 |
MTDiscord |
<josiah_wi> He did enter the wrong library name. |
| 00:29 |
MTDiscord |
<Benrob0329> Linking against the non MT branded library Segfaulted for me, so still a good precaution |
| 00:33 |
naxeu_ |
Do I have to put --depth=1 when cloning minetest |
| 00:33 |
naxeu_ |
? |
| 00:34 |
MTDiscord |
<Benrob0329> No, but it can speed go cloning if you aren't doing development (it only shallow clones the current state of the repo iirc) |
| 00:34 |
naxeu_ |
Benrob0329: I've also put libirrlichtMt.a as library |
| 00:35 |
naxeu_ |
I Get the same error |
| 00:35 |
MTDiscord |
<Jordach> a print out of git log would be nice |
| 00:36 |
naxeu_ |
I don't have the git log of clonning this repos |
| 00:36 |
MTDiscord |
<Benrob0329> Try a relative path rather than a variable |
| 00:36 |
naxeu_ |
I've used the real path. Same problem |
| 00:36 |
MTDiscord |
<josiah_wi> git log is a command. It shows the commit history. |
| 00:37 |
MTDiscord |
<Benrob0329> What version of MT are you trying to compile? |
| 00:37 |
naxeu_ |
Version: HEAD detached at 5.4.1 |
| 00:38 |
MTDiscord |
<Benrob0329> Don't use IrrlichtMT |
| 00:38 |
MTDiscord |
<Benrob0329> Only 5.5+ use it |
| 00:39 |
naxeu_ |
Hmm. Thank you |
| 00:39 |
naxeu_ |
There is any stable branch with 5.5? |
| 00:39 |
MTDiscord |
<Jordach> not yet, it's under development |
| 00:40 |
MTDiscord |
<Benrob0329> Testing is appreciated though |
| 00:43 |
naxeu_ |
I still getting the same error |
| 00:44 |
naxeu_ |
I've installed irrlicht form my system |
| 00:44 |
naxeu_ |
Run cmake . on minetest/ |
| 00:44 |
naxeu_ |
Then make -j$(nproc) |
| 00:45 |
naxeu_ |
Log at https://vcr.pt/MEwuO |
| 00:48 |
naxeu_ |
My c++ compiler is: |
| 00:48 |
naxeu_ |
g++ (Debian 8.3.0-6) 8.3.0 |
| 00:48 |
naxeu_ |
Any ideas? |
| 00:59 |
MTDiscord |
<Benrob0329> cmake might be holding onto your previous config |
| 01:00 |
MTDiscord |
<Benrob0329> you'll probably want to clean, I think there's a cmake clean command |
| 01:17 |
naxeu_ |
Solved! |
| 01:17 |
naxeu_ |
There is not a cmake clean command |
| 01:17 |
naxeu_ |
So I removed the folder of minetest and irrlichtMT |
| 01:18 |
naxeu_ |
And cloned again with deepth=1 ( faster :) ) |
| 01:19 |
naxeu_ |
So after that it compiled Minetest 5.5.0-dev-4d0fef8 |
| 01:21 |
naxeu_ |
I'm using Irrlicht 1.9.0mt2 bundled inside mt I think |
| 01:22 |
naxeu_ |
I can also run mt without system's libirrlicht. Awesome :) |
| 01:22 |
naxeu_ |
Thank you Benrob0329 |
| 01:55 |
|
Seirdy joined #minetest-dev |
| 02:08 |
|
specing joined #minetest-dev |
| 03:23 |
|
ssieb joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 07:01 |
|
ssieb joined #minetest-dev |
| 07:07 |
|
hlqkj joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:09 |
|
olliy joined #minetest-dev |
| 08:47 |
|
absurb joined #minetest-dev |
| 08:48 |
|
calcul0n_ joined #minetest-dev |
| 08:56 |
|
calcul0n joined #minetest-dev |
| 09:02 |
|
Kimapr joined #minetest-dev |
| 09:09 |
|
systwi joined #minetest-dev |
| 09:27 |
|
calcul0n joined #minetest-dev |
| 09:47 |
|
ssieb joined #minetest-dev |
| 10:07 |
|
amk joined #minetest-dev |
| 10:09 |
|
Fixer joined #minetest-dev |
| 10:11 |
|
amk joined #minetest-dev |
| 10:48 |
|
Kimapr joined #minetest-dev |
| 11:30 |
|
proller joined #minetest-dev |
| 12:18 |
|
proller joined #minetest-dev |
| 12:47 |
|
proller joined #minetest-dev |
| 13:02 |
|
tech_exorcist joined #minetest-dev |
| 13:21 |
|
appguru joined #minetest-dev |
| 13:55 |
|
calcul0n_ joined #minetest-dev |
| 14:04 |
|
specing_ joined #minetest-dev |
| 14:26 |
|
hlqkj joined #minetest-dev |
| 14:26 |
|
hlqkj_ joined #minetest-dev |
| 15:19 |
|
appguru joined #minetest-dev |
| 15:27 |
|
tech_exorcist joined #minetest-dev |
| 16:05 |
|
tech_exorcist joined #minetest-dev |
| 16:56 |
|
hlqkj joined #minetest-dev |
| 17:50 |
MTDiscord |
<Benrob0329> #11184 is trivial and has 2 approvals, anything in particular that's keeping it from getting merged? |
| 17:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/11184 -- Also return the ObjectRef from minetest.spawn_falling_node() by benrob0329 |
| 17:52 |
Krock |
Benrob0329: no need to be nervous |
| 17:52 |
Krock |
will merge #11184 and #11181 in 10minutes |
| 17:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/11184 -- Also return the ObjectRef from minetest.spawn_falling_node() by benrob0329 |
| 17:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/11181 -- Attachments: Avoid data loss caused by set_attach() in callbacks by SmallJoker |
| 17:52 |
MTDiscord |
<Benrob0329> I'm not, just trying to be polite while also bumping my own PR so that it's off my TODO :-) |
| 17:56 |
MTDiscord |
<josiah_wi> I'd also like to get IrrlichtMt # 22 off my TODO. :-)) |
| 18:01 |
Krock |
merging |
| 18:03 |
Krock |
I'd also prefer it we could simply replace `true` with `obj` for simplicity. adding more return values is the most precise but clobbering solution |
| 18:07 |
MTDiscord |
<Benrob0329> Like I said on the PR, we could probably get away with it but it's technically a breaking change |
| 18:07 |
rubenwardy |
I don't think it'll cause issues, it's just a matter of how pedantic you want to be |
| 18:10 |
rubenwardy |
Given its a minor issue, probably easier to side step and do true, obj |
| 18:15 |
|
ssieb joined #minetest-dev |
| 18:35 |
|
rom1504 joined #minetest-dev |
| 18:55 |
|
appguru joined #minetest-dev |
| 19:27 |
|
I_am_6r1d joined #minetest-dev |
| 20:31 |
|
Calinou joined #minetest-dev |
| 20:34 |
rubenwardy |
A useful feature for the serverlist would be to have a way of getting debug information |
| 20:34 |
rubenwardy |
so a user would search for their server, and it would show why it was rejected |
| 20:38 |
nerzhul |
rubenwardy it's not create more work it's like sfan5 said, reorg, and i'd like to see MT main codebase to be only the engine, not graphics/sound engine :D |
| 20:39 |
rubenwardy |
it's moving dependencies around |
| 20:39 |
nerzhul |
let mtirrlicht become the technical engine and the feature engine in mt :) |
| 20:39 |
rubenwardy |
there's no user benefit and I question the architectural benefit |
| 20:39 |
nerzhul |
yep, but also we can just abstract. our sound system requires some refactor, i know it works but currently it has various abstractions |
| 20:39 |
nerzhul |
it's purely architectural question |
| 20:39 |
nerzhul |
nowadays i'm more on architectural and design fixes |
| 20:40 |
nerzhul |
i should repass some linters and analysers on code to find where we can improve the core engine too a bit, but really i'd like to make the cleint evolve. I'm not confident with majority of the code. Irrlicht graphics call are too tied to each handler |
| 21:08 |
|
proller joined #minetest-dev |
| 21:08 |
|
calcul0n joined #minetest-dev |
| 21:20 |
|
Kimapr joined #minetest-dev |
| 21:48 |
|
Seirdy joined #minetest-dev |
| 21:52 |
|
calcul0n joined #minetest-dev |
| 21:59 |
|
specing left #minetest-dev |
| 23:49 |
|
Seirdy joined #minetest-dev |
