Time |
Nick |
Message |
00:39 |
|
_0_ joined #minetest-dev |
01:29 |
|
Seirdy joined #minetest-dev |
01:37 |
|
Calinou joined #minetest-dev |
04:04 |
MTDiscord |
<exe_virus> On the subject of stories, sometimes the PC can lend to the craft, for example, zelda style games and stuff that breaks the fourth wall do really well |
04:06 |
MTDiscord |
<Jordach> ™️ |
05:00 |
|
MTDiscord joined #minetest-dev |
05:10 |
|
me joined #minetest-dev |
05:19 |
|
metalune left #minetest-dev |
05:19 |
|
metalune joined #minetest-dev |
05:23 |
|
metalune left #minetest-dev |
05:23 |
|
metalune joined #minetest-dev |
05:26 |
|
metalune left #minetest-dev |
05:26 |
|
metalune joined #minetest-dev |
05:40 |
|
metalune left #minetest-dev |
05:40 |
|
metalune joined #minetest-dev |
05:44 |
|
metalune left #minetest-dev |
05:44 |
|
metalune joined #minetest-dev |
05:48 |
|
metalune left #minetest-dev |
05:48 |
|
metalune joined #minetest-dev |
05:57 |
|
metalune left #minetest-dev |
05:57 |
|
metalune joined #minetest-dev |
06:05 |
|
metalune left #minetest-dev |
06:05 |
|
metalune joined #minetest-dev |
06:24 |
|
metalune left #minetest-dev |
06:25 |
|
metalune joined #minetest-dev |
06:39 |
|
metalune left #minetest-dev |
06:39 |
|
metalune joined #minetest-dev |
06:53 |
|
metalune left #minetest-dev |
06:53 |
|
metalune joined #minetest-dev |
06:58 |
|
MTDiscord1 joined #minetest-dev |
07:23 |
|
metalune left #minetest-dev |
07:23 |
|
metalune joined #minetest-dev |
08:00 |
|
ShadowNinja joined #minetest-dev |
09:09 |
|
fluxflux joined #minetest-dev |
09:53 |
|
metalune left #minetest-dev |
09:54 |
|
metalune joined #minetest-dev |
10:08 |
|
metalune left #minetest-dev |
10:08 |
|
metalune joined #minetest-dev |
10:31 |
|
oleastre joined #minetest-dev |
10:44 |
|
m42uko joined #minetest-dev |
10:59 |
|
proller joined #minetest-dev |
11:12 |
|
calcul0n__ joined #minetest-dev |
11:18 |
|
Beton joined #minetest-dev |
12:45 |
|
oleastre joined #minetest-dev |
12:47 |
|
Fixer joined #minetest-dev |
12:52 |
|
metalune left #minetest-dev |
12:52 |
|
metalune joined #minetest-dev |
13:34 |
|
systwi_ joined #minetest-dev |
14:02 |
|
numzero joined #minetest-dev |
14:02 |
|
Fixer_ joined #minetest-dev |
14:14 |
|
calcul0n_ joined #minetest-dev |
14:20 |
|
metalune left #minetest-dev |
14:20 |
|
metalune joined #minetest-dev |
16:07 |
|
basxto joined #minetest-dev |
17:11 |
|
Wuzzy joined #minetest-dev |
17:39 |
|
fluxflux joined #minetest-dev |
18:26 |
|
proller joined #minetest-dev |
18:37 |
|
metalune left #minetest-dev |
18:37 |
|
metalune joined #minetest-dev |
18:50 |
|
Fixer joined #minetest-dev |
18:54 |
|
metalune left #minetest-dev |
18:55 |
|
metalune joined #minetest-dev |
19:08 |
|
homthack joined #minetest-dev |
19:39 |
|
Wuzzy joined #minetest-dev |
20:20 |
Krock |
will merge #10913 and #10902 in 10 minutes. both rather trivial |
20:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/10913 -- Fix documentation of formspec sound style by Wuzzy2 |
20:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/10902 -- Devtest: Remove bumpmap/parallax occl. test nodes by Wuzzy2 |
20:23 |
|
Thomas-S joined #minetest-dev |
20:23 |
|
Thomas-S joined #minetest-dev |
20:36 |
|
kilbith joined #minetest-dev |
20:37 |
kilbith |
https://forum.minetest.net/viewtopic.php?p=389517#p389517 |
20:37 |
kilbith |
I confirm that; why is there no issue for this? |
20:38 |
kilbith |
terminate called after throwing an instance of 'BaseException*' |
20:38 |
kilbith |
Thread 1 "minetest" received signal SIGABRT, Aborted. |
20:42 |
sfan5 |
Krock: 10m are over ;) |
20:42 |
Krock |
oh yes indeed |
20:42 |
Krock |
merging |
20:44 |
Krock |
kilbith: which is the last good build? |
20:44 |
sfan5 |
no idea about that but this appears in the backtrace |
20:44 |
sfan5 |
#6 0x0000555555a2a3ea in Settings::createLayer(SettingsLayer, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () |
20:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/6 -- Apples on the trees can not be eaten |
20:44 |
sfan5 |
so I have a pretty good guess what commit could have introduced this |
20:44 |
Krock |
me too |
20:45 |
Krock |
but I wonder why it works on my machine but not on Windows |
20:45 |
Krock |
kilbith: do the unittests pass? |
20:45 |
sfan5 |
read carefully, it will only break on the second time |
20:45 |
Krock |
trying to preproduce |
20:46 |
kilbith |
https://github.com/minetest/minetest/issues/10917 |
20:47 |
Krock |
so it's the map settings that aren't properly deleted |
20:48 |
sfan5 |
MapSettingsManager::~MapSettingsManager() does not get called if server init fails, certainly interesting |
20:49 |
sfan5 |
this would also mean it memoryleaks |
20:50 |
Krock |
yes. I'm glad this exception was triggered |
20:55 |
Krock |
server is deleted in ~Game, which occurs when the_game() exits |
21:00 |
Krock |
and MapSettingsManager settings_mgr is initialized by ServerMap and should be freed automatically in its destructor |
21:03 |
Krock |
where is Server::servermap or ServerEnvironment::m_map deleted? |
21:06 |
Krock |
ah. it's m_map->drop() for whatever reason |
21:07 |
Krock |
well yeah. ~ServerEnvironment is not called either when lua fails |
21:08 |
Krock |
that's because ServerEnvironment does yet not exist, but a ServerMap pointer does (only locally) |
21:09 |
Krock |
I'll check for possible solutions tomorrow |
21:21 |
|
metalune left #minetest-dev |
21:27 |
Wuzzy |
how do I fix my noise_params of the ores? I want to get the old way the ores spawned back |
21:28 |
Wuzzy |
i dont understand how to fix the noise_params deprecation |
21:34 |
|
fluxflux_ joined #minetest-dev |
21:37 |
sfan5 |
you might have to hunt down the default values in the code |
22:27 |
|
proller joined #minetest-dev |
23:02 |
kilbith |
lhofhansl is desperately needing a review on zstd support, people: https://github.com/minetest/minetest/pull/10788#issuecomment-773658459 |
23:03 |
kilbith |
much more worth than shitposting on Discord... |
23:04 |
kilbith |
^ sfan5 |
23:05 |
sfan5 |
I do not use Discord btw |
23:05 |
sfan5 |
but anyway: first there's the 5.4.0 release on the table, after that I can dedicate my time (when available) to much needed PR reviews |