| Time |
Nick |
Message |
| 01:19 |
|
ssieb joined #minetest-dev |
| 04:56 |
|
MTDiscord joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 05:36 |
|
olliy joined #minetest-dev |
| 05:53 |
|
olliy joined #minetest-dev |
| 06:03 |
|
lhofhansl joined #minetest-dev |
| 06:59 |
nerzhul |
rubenwardy: if you talk about the character input for every keyboard mapping (french, russian, greek...) it should yes, but it's not easy because we handle KEY PRESS event and SDL2 KEY PRESS event is not a symbol but a keyboard key id. There is another event to map to have the real text and it needs to rework our whole textbox input to properly work |
| 07:00 |
nerzhul |
Krock: ok will conform to irrlicht style, will do the change today for i hope an integration today |
| 07:41 |
nerzhul |
i think ruberwardy we will need a new type of event to handle properly the text input provided by SDL2, but i will tell you later after more investigations |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:45 |
|
calcul0n__ joined #minetest-dev |
| 09:20 |
|
Fleckenstein joined #minetest-dev |
| 10:33 |
|
calcul0n_ joined #minetest-dev |
| 11:05 |
rubenwardy |
The event used by text boxes should be SDL_TEXTINPUT rather than KEY_PRESSED |
| 11:16 |
|
Beton joined #minetest-dev |
| 11:25 |
|
Fixer joined #minetest-dev |
| 11:31 |
|
kb1000 joined #minetest-dev |
| 12:08 |
|
_Zaizen_[m] joined #minetest-dev |
| 12:08 |
|
Newbyte joined #minetest-dev |
| 12:08 |
|
Lone_Wolf joined #minetest-dev |
| 12:08 |
|
zughy[m] joined #minetest-dev |
| 12:08 |
|
giov4[m] joined #minetest-dev |
| 13:03 |
nerzhul |
yep i know :p |
| 13:03 |
nerzhul |
but also it's not possible to map it to our current code |
| 13:50 |
|
lisac joined #minetest-dev |
| 14:21 |
|
EliasFleckenstei joined #minetest-dev |
| 15:47 |
|
pgimeno joined #minetest-dev |
| 16:56 |
|
Wuzzy joined #minetest-dev |
| 17:23 |
|
hecks joined #minetest-dev |
| 17:34 |
nerzhul |
Krock: #10787 code style has been fixed |
| 17:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/10787 -- Refactor/gui editbox by nerzhul |
| 17:36 |
Krock |
nerzhul: looks better now. what about https://github.com/minetest/minetest/pull/10787/files#diff-ce53a1915750696414f4dd6a97e8473e2654887ebddd68308d552a87d57af804R328-R333 |
| 17:36 |
Krock |
and https://github.com/minetest/minetest/pull/10787/files#diff-ce53a1915750696414f4dd6a97e8473e2654887ebddd68308d552a87d57af804R345-R348 ? |
| 17:37 |
nerzhul |
i can do the same function exercise, let me a minute |
| 17:37 |
|
Taoki joined #minetest-dev |
| 17:38 |
Krock |
two indents are enough, and there are tabs/spaces mixed |
| 17:41 |
nerzhul |
strange, i clang-format the file |
| 17:42 |
nerzhul |
i just push another commit to make it nicer (and also enhance the code condition readability) |
| 17:42 |
Krock |
clang-format still doesn't work as we'd like to have it. still too limited formatting settings |
| 17:42 |
nerzhul |
i should change KEY_BACK too, but it's time to lunch |
| 17:42 |
rubenwardy |
the config is pretty broken |
| 17:42 |
nerzhul |
we may enhance it & update it too |
| 17:43 |
Krock |
unless there are new clang-format features, it won't help picking that up again |
| 17:45 |
nerzhul |
if you have better formatter to run all around the code i'm fine, and i think having a commit for it is fine too :D |
| 17:46 |
|
fluxflux_ joined #minetest-dev |
| 17:48 |
nerzhul |
ok code is fine now Krock, can you recheck ? |
| 17:50 |
Krock |
similar cases still exist. whatever. enjoy your meal. |
| 18:29 |
nerzhul |
thanks Krock, i miss some other ? i will check |
| 18:30 |
nerzhul |
ah yeah key C & X |
| 18:40 |
nerzhul |
Krock: it's now fixed and should be fine to you, i also merged a little bit code from CTRL+C & CTRL+X handlers |
| 19:15 |
|
Fleckenstein joined #minetest-dev |
| 19:27 |
pgimeno |
shouldn't the existence of the bridge and the fact that the channel is logged, be noted in the topic? https://freenode.net/policies#public-logging |
| 19:28 |
sfan5 |
the irc log is mentioned in the topic |
| 19:29 |
pgimeno |
it's linked, but does a random link qualify as announcing to incoming users that the channel is logged? |
| 19:32 |
|
EliasFleckenstei joined #minetest-dev |
| 19:48 |
|
Fixer_ joined #minetest-dev |
| 20:24 |
|
appguru joined #minetest-dev |
| 20:29 |
|
Fixer joined #minetest-dev |
| 21:19 |
|
Fixer_ joined #minetest-dev |
| 21:24 |
|
Fixer joined #minetest-dev |
| 23:42 |
|
longerstaff13 joined #minetest-dev |
| 23:46 |
MTDiscord |
<exe_virus> How do I best bring a pending PR for minetest game to the attention of the appropriate devs? https://github.com/minetest/minetest_game/pull/2803 |
