Time |
Nick |
Message |
01:12 |
|
Taoki joined #minetest-dev |
01:34 |
|
olliy joined #minetest-dev |
02:36 |
|
AntumD joined #minetest-dev |
05:00 |
|
MTDiscord joined #minetest-dev |
08:00 |
|
ShadowNinja joined #minetest-dev |
09:02 |
|
YuGiOhJCJ joined #minetest-dev |
09:23 |
|
calcul0n_ joined #minetest-dev |
10:20 |
|
Beton joined #minetest-dev |
10:29 |
|
calcul0n__ joined #minetest-dev |
10:44 |
|
Fleckenstein joined #minetest-dev |
10:59 |
|
EliasFleckenstei joined #minetest-dev |
10:59 |
|
EliasFleckenstei joined #minetest-dev |
11:47 |
|
pmp-p joined #minetest-dev |
11:51 |
|
Fixer joined #minetest-dev |
11:59 |
nerzhul |
i just published #10787 in order to continue my previous code factorization |
11:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/10787 -- Refactor/gui editbox by nerzhul |
12:01 |
nerzhul |
this reduce 200 lines of duplicated code |
12:01 |
nerzhul |
when sfan5 or Krock is around :) |
12:02 |
|
lisac joined #minetest-dev |
12:16 |
Krock |
what's the purpose of renaming the variables? afaik that's Irrlicht code we adjusted slightly |
12:16 |
Krock |
tracking changes will be much more difficult this way |
15:13 |
celeron55 |
you're assuming irrlicht will be developed though |
15:13 |
celeron55 |
of course if there's no reason to rename them then probably they shouldn't be |
15:43 |
|
BuckarooBanzai2 joined #minetest-dev |
15:59 |
nerzhul |
Krock: i merge the code and adapt to our code style. Note that variables coming from the 2 merged classes doesn't have the same coding style haha |
15:59 |
nerzhul |
i just kept the variable names from the class which is using our coding style |
16:00 |
nerzhul |
also please note we are in our own code, we can do anything, but if we use a forked irrlicht we can reintegrate it properly with irrlicht (ugly) codestyle) |
16:03 |
nerzhul |
and Krock, at a point i think b oth classes can be merged, regarding some tiny differences i saw in them i think it may become a single one at the end, or a veryt close one |
16:03 |
nerzhul |
see all those code duplicated in mouse & key press handling |
16:08 |
|
Fleckenstein joined #minetest-dev |
16:14 |
|
jingkaimori joined #minetest-dev |
16:16 |
jingkaimori |
The current name of IrrlichtBaW is changed to Nabla,and the repo named IrrlichtBaW is not maintained. |
16:17 |
jingkaimori |
This branch requires c++ 17,beyond c++ 11.So effort to migrate to irrlichtbaw or nabla maybe useless |
16:18 |
jingkaimori |
https://github.com/Devsh-Graphics-Programming/Nabla |
16:27 |
nerzhul |
i really think we cannot follow this one |
16:27 |
nerzhul |
we should just improve the things we need in irrlicht and that's all, do some code cleanups, refactor |
16:27 |
nerzhul |
c++11 move |
16:27 |
|
EliasFleckenstei joined #minetest-dev |
16:28 |
jingkaimori |
The way Nabla manage its dependency is horrible |
16:28 |
nerzhul |
sounds yes |
16:29 |
jingkaimori |
This project simply copy all the repo in its source |
16:29 |
jingkaimori |
That's why find_module makes no sense and ExternalProject is the only solution for including the project |
16:30 |
|
m42uko joined #minetest-dev |
16:31 |
jingkaimori |
The reason why I want to follow this one is Nabla intergrated SDL2 |
16:32 |
|
EliasFleckenstei joined #minetest-dev |
16:33 |
|
EliasFleckenstei joined #minetest-dev |
18:37 |
|
EliasFleckenstei joined #minetest-dev |
18:40 |
|
Fleckenstein joined #minetest-dev |
18:40 |
|
proller joined #minetest-dev |
19:05 |
|
proller joined #minetest-dev |
19:13 |
|
EliasFleckenstei joined #minetest-dev |
19:31 |
|
Fleckenstein joined #minetest-dev |
19:59 |
|
Fixer_ joined #minetest-dev |
20:20 |
|
fluxflux_ joined #minetest-dev |
21:09 |
nerzhul |
just for SDL 2 sounds crazy |
21:09 |
nerzhul |
my forked irrlicht is nearly complete with SDL2 |
21:09 |
nerzhul |
only text input & cursor is missing |
21:09 |
nerzhul |
only proper SDL2 text input & cursor is missing |
21:09 |
nerzhul |
only proper SDL2 text input & cursor is missing |
21:24 |
MTDiscord |
<appguru> your last message was sent twiceß |
21:25 |
rubenwardy |
your last message contains a ß |
21:25 |
rubenwardy |
nice, nerzhul though |
21:26 |
rubenwardy |
Does using SDL magically fix the input issues? |
21:28 |
|
lhofhansl joined #minetest-dev |
21:29 |
lhofhansl |
Is there interest in a PR to add zstd support? |
21:31 |
Krock |
there's definitely interest from server owners in #minetest-hub |
21:31 |
MTDiscord |
<appguru> I too would like to see performance improvements |
21:32 |
Krock |
nerzhul: regarding the variable name changes.. yes, we can do everything with it, but backporting fixes from Irrlicht might not be as easy to do any more |
21:32 |
Krock |
we can also hope that the code just works (TM) so there's never anything to fix |
21:46 |
|
olliy joined #minetest-dev |
22:37 |
lhofhansl |
Ok filed: #10788 |
22:37 |
ShadowBot |
https://github.com/minetest/minetest/issues/10788 -- Add zstd support. by lhofhansl |