| Time |
Nick |
Message |
| 00:03 |
|
appguru1 joined #minetest-dev |
| 01:04 |
|
Ritchie joined #minetest-dev |
| 02:51 |
|
YuGiOhJCJ joined #minetest-dev |
| 03:24 |
|
Ritchie joined #minetest-dev |
| 04:50 |
|
oiaohm joined #minetest-dev |
| 04:53 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:04 |
|
oil_boi joined #minetest-dev |
| 06:50 |
|
proller joined #minetest-dev |
| 07:24 |
|
calcul0n joined #minetest-dev |
| 07:37 |
|
absurb joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 09:24 |
|
Lunatrius joined #minetest-dev |
| 10:25 |
|
erlehmann joined #minetest-dev |
| 11:09 |
|
Fixer joined #minetest-dev |
| 11:23 |
|
fluxflux joined #minetest-dev |
| 11:44 |
|
appguru joined #minetest-dev |
| 12:47 |
|
NetherEran joined #minetest-dev |
| 15:13 |
|
vesper joined #minetest-dev |
| 15:13 |
|
tsadok joined #minetest-dev |
| 16:55 |
Krock |
will merge trivial #10133 in 10 minutes |
| 16:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/10133 -- Fix undeclared global in devtest by Wuzzy2 |
| 16:58 |
Krock |
rubenwardy: what's the difference between "SEvent translated;" and the empty brace init? https://github.com/minetest/minetest/pull/10128#discussion_r448584841 |
| 16:58 |
rubenwardy |
Initialisation |
| 16:58 |
Krock |
since when does C++ know default values for primitives? that's new to me |
| 16:59 |
rubenwardy |
You commented to remove that brace in mother PR, and it broke movement on Android |
| 16:59 |
rubenwardy |
#10046 |
| 16:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/10046 -- Android: Fix only right strafe working by rubenwardy |
| 16:59 |
Krock |
well, you have to assign all struct values manually, no? |
| 17:01 |
Krock |
this PR totally went unnoticed by me.. hmm. will need to look into structs and C++11 again. sorry for the troubles |
| 17:03 |
rubenwardy |
I'm not entirely sure how it works, my ide did say to initialise it like that, it was like that before, and it fixed the bug |
| 17:03 |
Krock |
-.- thanks IDE, an explanation would be more helpful |
| 17:04 |
Krock |
merging... |
| 17:06 |
sfan5 |
https://en.cppreference.com/w/cpp/language/aggregate_initialization |
| 17:06 |
sfan5 |
see syntax (2) which exists since C++11 |
| 17:08 |
sfan5 |
I think it looks ugly and in "modern" c++ you'd even write std::string s{"hello world"}; which we thankfully don't do |
| 17:08 |
sfan5 |
(that concept is described by https://en.cppreference.com/w/cpp/language/list_initialization though) |
| 17:11 |
Krock |
as long empty brace (default init) writes 0 values to struct members and the largest union member, it's probably fine |
| 17:12 |
|
skyliner_369 joined #minetest-dev |
| 19:04 |
|
Foz joined #minetest-dev |
| 19:33 |
|
_Zaizen_ joined #minetest-dev |
| 20:07 |
|
absurb_ joined #minetest-dev |
| 20:15 |
|
Fixer joined #minetest-dev |
| 21:22 |
|
Zughy joined #minetest-dev |
| 21:24 |
|
oiaohm joined #minetest-dev |
| 21:39 |
Zughy |
hey there, I wanted to fix #8273 with a friend. There are 2 options: either having a default name or checking if the user is in the main menu. Any preference? |
| 21:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/8273 -- Error on exit from main menu. |
| 21:40 |
sfan5 |
how would the latter look? |
| 21:42 |
Zughy |
well, we didn't give it much of a thought yet, we wanted to ask first (I mean, rn I don't know how to check for it, but that's the challenge ¯\_(ツ)_/¯ as MainMenuData doesn't have a property for it) |
| 21:45 |
pgimeno |
but why is launch_game called on exit? |
| 21:46 |
Zughy |
yeah, I asked that myself too |
| 21:48 |
Zughy |
oh, it's inside a while |
| 21:59 |
|
MarwolTuk joined #minetest-dev |
| 22:24 |
|
Taoki joined #minetest-dev |
| 22:29 |
Zughy |
uhm, is checking RenderingEngine::run() safe or we're touching some black magic things? |
| 22:30 |
Zughy |
sanity checks, singleton and all |
| 22:36 |
sfan5 |
surely there's some way to *not* try to open a world when the mainmenu is exiting |
| 22:36 |
sfan5 |
like without explicitly checking e.g. "is the mainmenu gone?" |
