Minetest logo

IRC log for #minetest-dev, 2020-06-12

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
01:32 ANAND joined #minetest-dev
01:49 reductum joined #minetest-dev
02:20 oiaohm joined #minetest-dev
02:25 Miner_48er joined #minetest-dev
03:11 ANAND joined #minetest-dev
03:34 ANAND joined #minetest-dev
04:29 hecks Seeking second approval for #10015, let's get this into 5.3
04:29 ShadowBot https://github.com/minetest/minetest/issues/10015 -- Fix bone-attached entities by hecktest
04:46 ANAND Yes please, that's a good PR.
05:06 ANAND Just opening the files page of #10029 reduces my computer to a crawl. :)
05:06 ShadowBot https://github.com/minetest/minetest/issues/10029 -- Change clang-format configuration, remove all original files from whitelist by rubenwardy
05:18 ANAND rubenwardy: Personally, I'd really prefer single tab indent for continuation lines. Two seems to be overkill.
05:19 ANAND Changing to 1 would also make the PR much leaner in terms of changed lines.
05:23 ANAND CF seems to have messed up all whitespace-based alignment. It'd be nice if CF could be made to ignore this.
06:02 NetherEran joined #minetest-dev
06:25 Foz joined #minetest-dev
06:30 calcul0n joined #minetest-dev
07:43 hecks #7749 snail HUD mystery solved
07:43 ShadowBot https://github.com/minetest/minetest/issues/7749 -- Optimize HUD element rendering
07:43 hecks irrlicht's 2D is *not* good
07:44 hecks but the way it's being used just escalates this problem
07:50 ANAND Nice find, hecks!
08:00 ShadowNinja joined #minetest-dev
08:03 NetherEran joined #minetest-dev
08:04 mizux joined #minetest-dev
08:12 rubenwardy ANAND: then work out how to fix it then
08:14 ANAND rubenwardy: You mean the whitespace alignment?
08:14 rubenwardy Two space continuation
08:15 rubenwardy Or alignment
08:16 rubenwardy The first is because I was unable to find a setting to control different behaviour for if statement continuation than normal continuation
08:17 rubenwardy The second is unintentional
08:18 ANAND I see
08:27 ANAND Yeah, I'm unable to find a separate config setting for if continuation lines
08:33 ANAND And neither can I find a way to prevent CF from removing spaces used in alignment.
08:51 Darcidride joined #minetest-dev
09:43 ANAND #9880, anyone?
09:43 ShadowBot https://github.com/minetest/minetest/issues/9880 -- LuaItemStack: Add __eq metamethod by ClobberXD
09:44 ANAND It's not as large a PR as the bind-mouse-buttons PR ;)
09:44 ANAND And neither is #7587
09:44 ShadowBot https://github.com/minetest/minetest/issues/7587 -- Implement on_wielditem_change callback registration by ClobberXD
09:48 ANAND rubenwardy: You might be interested in 9880, as you're the one who suggested using the __eq metamethod.
10:06 NetherEran ANAND: on_wielditem_change doesn't seem to trigger when an item is dropped or moved to the wielded slot in the inventory. That kind of makes it weird to use for stuff like wield3D.
10:07 NetherEran Also doesn't trigger when the last item of a stack is placed
10:10 sfan5 hm that's a good point
10:10 ANAND Technically, the callback runs only when the wield index changes (i.e. player selects a different slot), but I see how that's not very useful.
10:10 sfan5 on_wield and on_unwield have the same issue
10:10 ANAND Yeah
10:11 ANAND I think this can be fixed though
10:12 ANAND I'll go back on my words - modifying the same slot is still technically a wielditem change
10:13 ANAND Change of wield idx is sent to the server as TOSERVER_PLAYERITEM, but I'm pretty changing the actual item is considered as an inventory change
10:14 ANAND This can be fixed, but it wouldn't be pretty...
10:15 ANAND API-wise though, we could just pass two different itemstacks but with old_wield_idx and new_wield_idx being equal
10:16 ANAND The question is, should this callback include changes to the actual items, and not just change in wield idx?
10:17 ANAND From a modding standpoint, I'd prefer having one callback do both, instead of having a separate callbacks like on_wielditem_change and on_wieldidx_change
10:18 ANAND Thanks for your inputs, NetherEran :)
10:19 NetherEran yw
10:20 sfan5 ANAND: it should do both imo
10:20 sfan5 anything else is inconvenient for no reason
10:20 ANAND Agreed
10:30 Beton joined #minetest-dev
10:34 proller joined #minetest-dev
11:38 oil_boi joined #minetest-dev
11:54 sfan5 huh never though #9961 would get an approval on time before the feature freeze
11:54 ShadowBot https://github.com/minetest/minetest/issues/9961 -- Server pushing media at runtime by sfan5
11:54 sfan5 thought*
12:32 erlehmann joined #minetest-dev
12:36 Fixer joined #minetest-dev
12:51 ANAND joined #minetest-dev
12:55 NetherEran joined #minetest-dev
14:32 oil_boi #9978 please :L
14:32 ShadowBot https://github.com/minetest/minetest/issues/9978 -- Add new_pos to moveresult output by oilboi
14:46 oiaohm joined #minetest-dev
14:50 Lone_Wolf joined #minetest-dev
15:07 Taoki joined #minetest-dev
15:21 Taoki joined #minetest-dev
15:28 olliy joined #minetest-dev
15:45 NetherEran joined #minetest-dev
16:06 PGimeno crap, I missed this: https://github.com/minetest/minetest/blob/master/builtin/common/vector.lua#L214
16:07 PGimeno why limit it to vectors separated 90°?
16:07 PGimeno it's much more useful without that limitation
16:11 PGimeno NetherEran?
16:25 NetherEran With the algorithm used it's simpler computationally to have it this way. Keep in mind that when the up vector is left out, roll is just assumed to be zero which simplifies a lot of the cases where a non-ortogonal up vector would be used.
16:44 Krock will merge #9982 in 10 minutes
16:44 ShadowBot https://github.com/minetest/minetest/issues/9982 -- Add LevelDB player database. by luk3yx
16:53 Krock merging
17:26 PGimeno http://www.formauri.es/personal/pgimeno/pastes/benchmk-dir2rot.lua - in my tests, that version is ~7x faster than the current implementation
17:28 PGimeno it also removes the aforementioned limitation
17:58 Kimapr joined #minetest-dev
18:03 Wuzzy joined #minetest-dev
18:06 NetherEran cool, I won't deny that I chose the algorithm I used because of my poor understanding of linear algebra.
18:49 Awkor[m] joined #minetest-dev
20:55 oil_boi So I guess I should just close #9978?
20:55 ShadowBot https://github.com/minetest/minetest/issues/9978 -- Add new_pos to moveresult output by oilboi
20:58 lisac joined #minetest-dev
21:05 Zughy joined #minetest-dev
21:08 Zughy Hey there. Why exactly this got removed from the 5.3.0 milestone after being labeled like so for 17 days and with two approvals (one from a core dev) for 13? The link you provided doesn't work sfan5
21:08 Zughy https://github.com/minetest/minetest/pull/9862
21:10 sfan5 feature freeze will start in a few days and considering there is a flaw I consider it unlikely that it will be ready and receive a second dev approval in time
21:12 mizux joined #minetest-dev
21:13 sfan5 this is not supposed to be a bad thing for your PR, I'm just sorting the milestone a bit
21:18 Zughy It was simply... unexpected, as we were thrilled for the 5.3.0 and to be featured in it. But yes, it's a good point indeed. We'll fix it this weekend
21:23 sfan5 getting added to the milestone unforunately doesn't guarantee that a dev happens to look at your PR in time
21:24 sfan5 s/a dev/(at least) two devs/
21:28 sfan5 "The link you provided doesn't work sfan5" didn't see this, it's supposed to be working
21:28 _Zaizen_ joined #minetest-dev
21:31 sfan5 merging game#2692 in a few minutes
21:31 ShadowBot https://github.com/minetest/minetest_game/issues/2692 -- Change brake rail to red by hoodedice
21:33 Zughy I don't want to start a flame or anything, but it sounds a bit disrespecting both for who wants to help and for who thought to see a feature implemented. Having a PR noticed is hard already, seeing it "milestoned" is even harder, and then there is also the lack of certainty to see it tested in time? I mean... meh?
21:34 sfan5 it's disappointing no doubt but how do you want to fix the issue of dev time?
21:35 absurb joined #minetest-dev
22:11 Alia joined #minetest-dev
22:24 Fixer joined #minetest-dev
22:32 search_social joined #minetest-dev
22:34 hecks joined #minetest-dev
23:02 olliy joined #minetest-dev
23:58 oil_boi Krock, how does one create log entries on shutdown with clientside api?

| Channels | #minetest-dev index | Today | | Google Search | Plaintext