| Time |
Nick |
Message |
| 00:23 |
|
reductum joined #minetest-dev |
| 00:30 |
|
appguru1 joined #minetest-dev |
| 00:34 |
hecks |
Why does refreshing visuals require remaking the object in the first place? |
| 00:45 |
|
Miner_48er joined #minetest-dev |
| 00:50 |
|
ANAND joined #minetest-dev |
| 01:09 |
|
ANAND joined #minetest-dev |
| 01:24 |
skyliner_369 |
I'm wondering if there are instructions on packing the game into a nice android apk, or is android development on hold, or even deprecated? |
| 01:32 |
hecks |
#10026 please review |
| 01:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/10026 -- Preserve model animation frame when expiring visuals by hecktest |
| 02:29 |
Lone_Wolf |
5.3 will be the next android release IIRC @skyliner_369 |
| 02:57 |
|
ANAND joined #minetest-dev |
| 05:32 |
|
ANAND joined #minetest-dev |
| 05:52 |
|
calcul0n joined #minetest-dev |
| 06:05 |
|
jonadab joined #minetest-dev |
| 07:20 |
|
oil_boi joined #minetest-dev |
| 07:27 |
|
mizux joined #minetest-dev |
| 07:28 |
|
olliy joined #minetest-dev |
| 07:36 |
|
olliy joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:23 |
ANAND |
#7924, anyone? |
| 08:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/7924 -- Allow binding dig, place actions to keys; remove LMB/RMB hardcoding by ClobberXD |
| 08:37 |
|
NetherEran joined #minetest-dev |
| 10:12 |
|
NetherEran_ joined #minetest-dev |
| 10:30 |
|
proller joined #minetest-dev |
| 10:31 |
|
Fixer joined #minetest-dev |
| 10:32 |
|
Beton joined #minetest-dev |
| 10:53 |
|
ANAND joined #minetest-dev |
| 12:32 |
|
erlehmann joined #minetest-dev |
| 12:35 |
|
NetherEran joined #minetest-dev |
| 13:46 |
|
YuGiOhJCJ joined #minetest-dev |
| 13:57 |
|
NetherEran_ joined #minetest-dev |
| 14:10 |
|
oil_boi joined #minetest-dev |
| 14:25 |
rubenwardy |
The Linux kernel uses clang-format |
| 15:17 |
ANAND |
rubenwardy: Nice! I was going to attempt to fix clang-format too. :) |
| 15:17 |
rubenwardy |
consider helping, there's still a lot of tweaking to do |
| 15:17 |
ANAND |
Will do |
| 15:18 |
rubenwardy |
I'm browing through the 30,000 line changes looking for errors |
| 15:18 |
ANAND |
:) |
| 15:19 |
ANAND |
https://github.com/minetest/minetest/pull/10029/files#diff-f113cef4f91a8357ad6e70154acdde98R118-R119 |
| 15:19 |
ANAND |
Unintended, right? |
| 15:19 |
ANAND |
i.e. config needs to be tweaked to fix this? |
| 15:20 |
rubenwardy |
I think that makes sense, it can fit it all on one line if it breaks first |
| 15:20 |
rubenwardy |
the braces are weird though, I think I'd prefer them together |
| 15:23 |
rubenwardy |
Clang-Format has a bracing style called "Linux", but ironically the Linux kernel doesn't use it |
| 15:39 |
|
Lone_Wolf joined #minetest-dev |
| 15:45 |
ANAND |
I see |
| 15:45 |
ANAND |
Makes sense to adjust a bit if clang-format can't be 100% tweaked to our style |
| 15:48 |
ANAND |
rubenwardy: What's the "merge conflict avoidance strategy"? |
| 15:48 |
rubenwardy |
read above |
| 15:48 |
rubenwardy |
it's in the PR desc |
| 15:49 |
ANAND |
Ah ok, I thought it referred to something else |
| 15:50 |
rubenwardy |
ANAND: any idea what happens if two actions are bound to the same key? |
| 15:51 |
rubenwardy |
Wondering if it is worth introducting KeyType::USE and KeyType::PUNCH which are bound to the same as KeyType::DIG |
| 15:51 |
rubenwardy |
perhaps DIG itself should be PUNCH_DIG |
| 15:52 |
ANAND |
IIRC, only the last-bound action is triggered |
| 15:52 |
rubenwardy |
even when changing manually? |
| 15:52 |
ANAND |
From minetest.conf, yes |
| 15:54 |
ANAND |
I like the idea of separating use and dig/punch though. We could implement that in a later PR, maybe. |
| 15:55 |
ANAND |
Only some braces have been moved to a new line while some others are left untouched: https://github.com/minetest/minetest/pull/10029/files#diff-f113cef4f91a8357ad6e70154acdde98R115-R125 |
| 15:55 |
ANAND |
Is it due to line-length? |
| 15:56 |
ANAND |
If so, should closing braces be placed together with the opening braces (even if the opening braces are placed in a separate line), for consistency? |
| 15:58 |
oil_boi |
!tell hecks Is there a download link for your game? |
| 15:58 |
ShadowBot |
oil_boi: O.K. |
| 16:03 |
ANAND |
It'd be nice to have a follow-up PR to convert NULL -> nullptr |
| 16:04 |
ANAND |
This would create a bunch of merge conflicts as well, and it might be easier for PR authors if they have to rebase only once. |
| 16:10 |
ANAND |
It might make sense to properly define Minetest's code style once this PR is merged. |
| 16:11 |
ANAND |
I'm still doubtful about a bunch of stylistic choices (apart from the most obvious ones like spacing and */& placement) to this date. |
| 16:14 |
|
Kimapr joined #minetest-dev |
| 16:17 |
ANAND |
Braces for union is moved to the same line as the keyword, while they're moved to a new line for a struct. |
| 16:17 |
ANAND |
Might need to enforce newline braces for unions as well |
| 16:17 |
rubenwardy |
I wasn't sure what they counted as |
| 16:18 |
ANAND |
They're resemble classes, functions and structs, IMO. |
| 16:18 |
rubenwardy |
I guess they are the most like a struct |
| 16:18 |
ANAND |
Yeah |
| 16:18 |
ANAND |
They are certainly not similar to if, else, try, catch, etc. |
| 16:19 |
ANAND |
The latter are called control statements, I think |
| 16:20 |
rubenwardy |
should PP macros indent before or after the hash? |
| 16:55 |
PGimeno |
whom should I PM about a possible security issue? |
| 16:56 |
sfan5 |
any coredev who is available |
| 17:04 |
* Krock |
<- |
| 17:05 |
Krock |
just checking in sfan5. how can I help you? |
| 17:06 |
sfan5 |
with what? |
| 17:06 |
Krock |
<sfan5> any coredev who is available |
| 17:06 |
Krock |
oh, that's not a question |
| 17:07 |
sfan5 |
it's an answer to PGimeno |
| 17:07 |
Krock |
context matters |
| 17:09 |
rubenwardy |
lol |
| 17:09 |
sfan5 |
https://gitlab.com/minetest/minetest/-/jobs/589159952#L687 |
| 17:09 |
sfan5 |
huh |
| 17:11 |
Krock |
it's drunk |
| 17:13 |
rubenwardy |
weird |
| 17:13 |
rubenwardy |
I ran it again, and it still fails |
| 17:16 |
|
catapulte joined #minetest-dev |
| 17:31 |
oil_boi |
is moveresult of a player accessible through lua api yet? |
| 17:33 |
sfan5 |
the server doesn't do collision detection for players |
| 17:33 |
sfan5 |
if you mean clientside: also no |
| 17:33 |
oil_boi |
:( |
| 17:34 |
Krock |
issue already exists |
| 17:35 |
Krock |
no need to open a new one |
| 17:42 |
PGimeno |
just got a crash: http://txti.delightcreative.com/vaxvi |
| 17:43 |
Krock |
cool |
| 17:43 |
Krock |
perhaps an unhandled index in the list, or whatsoever |
| 17:46 |
|
reductum joined #minetest-dev |
| 17:48 |
PGimeno |
enabling a mod that depends on another which isn't selected, silently deselects it, is that by design? |
| 17:49 |
PGimeno |
well, this is a chaos |
| 17:50 |
PGimeno |
the other mod is selected, but the original mod gets deselected every time |
| 17:53 |
Krock |
that should not happen |
| 17:53 |
Krock |
dependencies should be enabled together with the main mod, but not disabled |
| 17:57 |
PGimeno |
sorry, that was a mod name conflict, it was the result of my tests for #6898 |
| 17:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/6898 -- Allow distinguishing mods by modpack |
| 18:02 |
|
NetherEran joined #minetest-dev |
| 18:03 |
Krock |
would it make sense to send inventory actions in another channel? |
| 18:04 |
Krock |
goal: less data to re-send when there's loss |
| 18:05 |
sfan5 |
do inventory actions really generate that much traffic? |
| 18:06 |
Krock |
no, but the data is relatively high |
| 18:06 |
Krock |
s/data/packet size/ |
| 18:07 |
Krock |
at least someone had >64 KiB of data in an inventory list in 5.0.0 |
| 18:07 |
Krock |
hence the bugfix in 5.0.1 |
| 18:07 |
sfan5 |
perhaps they could use a less wasteful serialization format |
| 18:08 |
Krock |
would only help for very large inventory lists, whereas metadata cannot be improved |
| 18:08 |
Krock |
unless the packet is compressed |
| 18:42 |
|
shadowmaker joined #minetest-dev |
| 18:47 |
shadowmaker |
Mmm... Hello. |
| 18:47 |
shadowmaker |
I need help |
| 18:48 |
shadowmaker |
I would like to know if it's possible to connect a gamepad to play |
| 18:50 |
Krock |
^ rubenwardy ? |
| 18:50 |
rubenwardy |
the game pad support sucks |
| 18:59 |
shadowmaker |
? |
| 18:59 |
shadowmaker |
Wow |
| 19:00 |
shadowmaker |
I thought this was the development IRC |
| 19:00 |
shadowmaker |
;) |
| 19:01 |
shadowmaker |
Well... If I can't play with the joysticks, would you explain how do I enable keyboard in the Android version |
| 19:02 |
shadowmaker |
I've gone to settings and I've configured the keys, but the movement ones doesn't work |
| 19:03 |
shadowmaker |
And I think this shall work (the problem must be mine) but I've tried everything |
| 19:07 |
sfan5 |
known bug but I can't find the issue |
| 19:07 |
sfan5 |
merging #10021, #10006 in 5 minutes |
| 19:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/10021 -- content_cao: Do not expire visuals for texture updates by sfan5 |
| 19:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/10006 -- Use multiple light positions for CAO lighting by sfan5 |
| 19:09 |
Lone_Wolf |
I think the bug was fixed wasn't it? |
| 19:17 |
shadowmaker |
I've installed the last version **in the Google Play** (maybe that's the problem) i will try with the last github release |
| 19:17 |
|
hecks joined #minetest-dev |
| 19:18 |
Krock |
the Android builds are outdated |
| 19:18 |
Krock |
-> https://minetest.rubenwardy.com/android/ for a new build |
| 19:18 |
rubenwardy |
https://github.com/rubenwardy/minetest/releases/ |
| 19:19 |
shadowmaker |
Thanks :) |
| 20:00 |
|
LoneWolfHT joined #minetest-dev |
| 20:44 |
|
bodqhrohro_ joined #minetest-dev |
| 21:28 |
|
proller joined #minetest-dev |
| 23:51 |
|
bodqhrohro joined #minetest-dev |
| 23:54 |
|
proller joined #minetest-dev |
