| Time |
Nick |
Message |
| 00:11 |
|
gh00p joined #minetest-dev |
| 00:43 |
|
gh00p joined #minetest-dev |
| 00:52 |
rubenwardy |
sorry, I've feature creeped #9944 ... |
| 00:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/9944 -- Add buttons to ContentDB in game buttonbar and configure world by rubenwardy |
| 00:56 |
rubenwardy |
ooooh |
| 00:57 |
rubenwardy |
we could make the configure dialog use hypertext for listing dependencies. You could then make it possible to go directly to searching a mod on contentdb when clicking on a missing mod name |
| 00:57 |
rubenwardy |
well, not as good as dependency management |
| 00:58 |
rubenwardy |
heh, this feels like bad design due to bad design |
| 01:00 |
rubenwardy |
If I had a C++ download manager, I could use it to power a `http_img` element just for the main menu |
| 01:00 |
rubenwardy |
it would allow scroll_container in the ContentDB dialog |
| 01:01 |
rubenwardy |
heh, dependency management first |
| 01:07 |
|
erlehmann joined #minetest-dev |
| 01:14 |
|
nephele_ joined #minetest-dev |
| 01:29 |
|
YuGiOhJCJ joined #minetest-dev |
| 01:29 |
ANAND |
Would someone be able to take a look at #7587? It's ready for review, and I hope to not get caught in the trap of eternal rebasing. :) |
| 01:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/7587 -- Implement on_wielditem_change callback registration by ClobberXD |
| 01:48 |
|
gh00p joined #minetest-dev |
| 01:57 |
|
lisac joined #minetest-dev |
| 02:23 |
skyliner_369 |
with the lava flowing animation in a texture pack... can that also be any height/animation length? |
| 02:34 |
|
gh00p joined #minetest-dev |
| 02:40 |
|
Lunatrius` joined #minetest-dev |
| 03:27 |
|
gh00p joined #minetest-dev |
| 04:33 |
|
gh00p joined #minetest-dev |
| 05:40 |
|
calcul0n joined #minetest-dev |
| 05:43 |
skyliner_369 |
in Minecraft, I play with the brightness slider cranked all the way to bright... how would I achieve that look in the graphics settings? |
| 06:01 |
|
NetherEran joined #minetest-dev |
| 06:05 |
ANAND |
skyliner_369: That used to be possible in Minetest 0.4.x versions (by increasing value of the setting 'display_gamma'), but since then, the light curve has been tweaked to disallow brightening of pitch-black areas to prevent cheating. |
| 06:07 |
skyliner_369 |
Oh... I didn't even think that would be considered cheating. |
| 06:08 |
ANAND |
It was indeed used by quite a few players to see in pitch-black *indoor* areas, which gives them a huge upper hand in PvP, for example. |
| 06:08 |
ANAND |
I'm personally not too happy about that change, to be frank |
| 06:09 |
ANAND |
I agree some nerfing was required, but now I'm literally night-blind >.> |
| 06:09 |
skyliner_369 |
ahhhhh. I'm unhappy about it too. how does one appreciate the, frankly, awesome gave generation? |
| 06:10 |
ANAND |
Gamma *sorta* works, but even if you do increase gamma, the sky brightens up way too much, making it even harder to see in the dark outdoors. |
| 06:42 |
|
erlehmann joined #minetest-dev |
| 07:17 |
skyliner_369 |
what's this about? "2020-05-27 03:14:17: WARNING[Main]: Irrlicht: PNG warning: iCCP: too many profiles |
| 07:17 |
skyliner_369 |
2020-05-27 03:14:18: WARNING[Main]: Irrlicht: PNG warning: iCCP: known incorrect sRGB profile" |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 09:03 |
ANAND |
Is 2-tab indent for continuation lines a violation of our code-style? |
| 09:06 |
skyliner_369 |
I think it was photoshop's BS making its way through GIMP's file handling. I'm destroying as much data as possible and batch processing the files into GIF files (Yes, GIF is full 4-channel capable.) and then reconverting them back to indexed PNGs with high compression. |
| 09:08 |
ANAND |
Tested #9862 and #9923 - both of them work as expected. I've posted a brief(-ish) comment in both the PRs explaining how I tested the PRs. |
| 09:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/9862 -- Items: on_wield and on_unwield callbacks implemented by CrazyminerMC |
| 09:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/9923 -- Fix inventory swapping not calling all callbacks by appgurueu |
| 09:09 |
ANAND |
I'm planning to *try* to review at least one PR every day. |
| 09:16 |
sfan5 |
skyliner_369: assuming mean the lava_source/lava_flowing in minetest_game: yes that can have any number of frames too |
| 09:27 |
|
_Zaizen_ joined #minetest-dev |
| 10:28 |
|
proller joined #minetest-dev |
| 11:32 |
|
Fixer joined #minetest-dev |
| 11:58 |
sfan5 |
https://0x0.st/ipR1.png < this brings up a good point |
| 11:58 |
sfan5 |
games should not be able to set default values for mods that the *user* trusts |
| 11:59 |
sfan5 |
this might already be the case tho, I didn't check |
| 12:02 |
rubenwardy |
confirmed to be an issue |
| 12:08 |
|
gorbachev_pizza joined #minetest-dev |
| 12:45 |
|
gd___ joined #minetest-dev |
| 12:47 |
|
gorbachev_pizza_ joined #minetest-dev |
| 14:08 |
|
gh00p joined #minetest-dev |
| 14:19 |
|
Taoki joined #minetest-dev |
| 14:23 |
|
gh00p joined #minetest-dev |
| 14:31 |
rubenwardy |
#9948 |
| 14:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/9948 -- Make ContentDB downloads not block the UI by rubenwardy |
| 14:32 |
sfan5 |
I guess a progress indicator would be harder to do, right? |
| 14:32 |
rubenwardy |
yeah, it requires tracking the download |
| 14:32 |
rubenwardy |
and inter-thread communication |
| 14:33 |
rubenwardy |
I'm planning on improving the download API - there's no reason it should need to use a Lua thread |
| 14:33 |
rubenwardy |
this will be in the form of a download manager |
| 14:33 |
rubenwardy |
this is an easy win |
| 14:33 |
rubenwardy |
err |
| 14:33 |
rubenwardy |
this PR is an easy win |
| 14:34 |
sfan5 |
what happens if you leave the menu while a download is pending? |
| 14:35 |
rubenwardy |
if you exit the main menu, it'll stop the download and it won't resume |
| 14:35 |
rubenwardy |
+on restart |
| 14:35 |
rubenwardy |
when installing, the UI will freeze :D |
| 14:36 |
sfan5 |
the menu doesn't really look good at default settings https://a.uguu.se/byGImii1OG7z_.png |
| 14:36 |
sfan5 |
also I didn't press anything yet it says downloading, debug code? |
| 14:36 |
rubenwardy |
oh yes oops |
| 14:37 |
rubenwardy |
note to self: add TODO comment above debug code |
| 14:37 |
rubenwardy |
yeah, that hurts me eyes |
| 14:40 |
sfan5 |
with font_size=15 (which I also use in my usual config): https://a.uguu.se/Akbu3CMqQemD_.png |
| 14:41 |
sfan5 |
can formspecs center text yet? |
| 14:41 |
rubenwardy |
not yet |
| 14:41 |
rubenwardy |
I could use a borderless button |
| 14:41 |
rubenwardy |
it would render the text the same as a normal button, but no background |
| 14:41 |
rubenwardy |
also - the font size of text in buttons should probably decrease if there's no enough space |
| 14:42 |
sfan5 |
ah yes, the early days of HTML "I could just use a borderless table for layout" :D |
| 14:42 |
rubenwardy |
yeah |
| 14:42 |
rubenwardy |
hacks |
| 14:42 |
sfan5 |
rubenwardy: then I'd suggest a borderless button for the 1 / 150 |
| 14:42 |
sfan5 |
add more space and you can have both good looking (centered) text and no overlaps |
| 14:42 |
sfan5 |
also the > and >> should ideally be icons |
| 14:43 |
sfan5 |
re font size, button space: everything looks much better when you maximize the window (like most people do, hopefully) |
| 14:44 |
sfan5 |
so what we really need is for formspecs to scale sanely when you have a small window |
| 14:44 |
rubenwardy |
yeah |
| 15:13 |
|
NetherEran joined #minetest-dev |
| 15:19 |
rubenwardy |
updated to FSv3 / real coordinates, changes the page nums to use the button hack: https://rwdy.uk/X5mEw.png |
| 15:19 |
rubenwardy |
to make this look nicer, more formspec support is probably needed |
| 15:20 |
rubenwardy |
for example - an area label that wraps and truncates text with "..." would be good |
| 15:20 |
rubenwardy |
plus a feasible way to use scroll_container with this |
| 15:20 |
sfan5 |
looks good |
| 15:20 |
sfan5 |
or well "better" |
| 15:20 |
ANAND |
Haha, that's a nice way to centre text :) |
| 15:20 |
rubenwardy |
with that label origin PR, you can use labels to center text |
| 15:20 |
rubenwardy |
but there's no bounds |
| 15:21 |
rubenwardy |
so it can end up escaping the space it should be contained in |
| 15:22 |
rubenwardy |
I'll look into some fancy icons too |
| 15:25 |
rubenwardy |
I should probably just steal them from font awesome |
| 15:25 |
rubenwardy |
or creative |
| 15:49 |
rubenwardy |
I was considering removing the "View" button, and instead having users click the package title |
| 15:49 |
rubenwardy |
or screenshot, but I worry about discoverability |
| 15:50 |
ANAND |
Yeah, that's an issue |
| 15:50 |
ANAND |
Once we integrate scroll_container, we can maybe move buttons below the title and description. |
| 15:51 |
rubenwardy |
heh |
| 15:52 |
rubenwardy |
we should be able to have enough space, it's just not utilised very well on lower screen resolutions |
| 15:52 |
rubenwardy |
having the textarea truncate would be a good start |
| 15:52 |
rubenwardy |
merging #9948 in 10 |
| 15:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/9948 -- Make ContentDB downloads not block the UI by rubenwardy |
| 15:54 |
|
ANAND joined #minetest-dev |
| 16:06 |
rubenwardy |
are you even developing if your PRs don't cause merge conflicts with your other PRs |
| 16:06 |
nephele |
first you write the code, and then you cut it down into conflicting reviewable pieces :D |
| 16:22 |
|
appguru joined #minetest-dev |
| 17:00 |
|
gh00p joined #minetest-dev |
| 17:04 |
|
Warr1024 joined #minetest-dev |
| 17:06 |
Krock |
What's this "Show Toast"? A notification API for Android? |
| 17:13 |
sfan5 |
https://developer.android.com/guide/topics/ui/notifiers/toasts.html?hl=en |
| 17:25 |
Krock |
ah okay. Thanks |
| 17:26 |
rubenwardy |
!map bread staple |
| 17:26 |
rubenwardy |
!mod bread staple |
| 17:26 |
ShadowBot |
rubenwardy: <lucky [mod] bread staple site:forum.minetest.net> |
| 17:26 |
sfan5 |
wow very useful ShadowBot |
| 17:26 |
Krock |
til ShadowBot can do that |
| 17:27 |
rubenwardy |
https://forum.minetest.net/viewtopic.php?f=9&t=20215 |
| 17:28 |
sfan5 |
hm |
| 17:28 |
sfan5 |
that's a revolutionary mod |
| 17:28 |
Krock |
the only requirement for a good server |
| 17:28 |
|
appguru joined #minetest-dev |
| 17:31 |
|
Darcidride joined #minetest-dev |
| 17:56 |
|
Warr1024 joined #minetest-dev |
| 18:20 |
|
nerzhul joined #minetest-dev |
| 18:27 |
|
Foz joined #minetest-dev |
| 18:43 |
|
Kimapr joined #minetest-dev |
| 18:44 |
|
Kimapr joined #minetest-dev |
| 19:09 |
skyliner_369 |
thought I sanitized the texture files but apparently I haven't. what is the correct sRGB profile for a texture pack? |
| 19:09 |
sfan5 |
none at all IIRC |
| 19:12 |
skyliner_369 |
ok. let me check |
| 19:19 |
skyliner_369 |
odd... the pictures have no color profile to save... |
| 19:27 |
skyliner_369 |
if this doesn't work I'll have to throw my hands in the air and ask for some help. |
| 19:27 |
skyliner_369 |
someone* |
| 19:44 |
sfan5 |
merging #9947, #9940 in 10 minutes |
| 19:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/9947 -- [no squash] Builtin entity related fixes by sfan5 |
| 19:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/9940 -- Value copy / allocation optimizations mostly in server, SAO and serialize code by sfan5 |
| 19:49 |
|
gh00p joined #minetest-dev |
| 20:21 |
|
NetherEran joined #minetest-dev |
| 20:44 |
|
NetherEran joined #minetest-dev |
| 20:54 |
|
NetherEran joined #minetest-dev |
| 21:24 |
|
NetherEran joined #minetest-dev |
| 21:49 |
skyliner_369 |
do I have to manually go through all 243 images in GIMP and uncheck enable color management and then overwrite each file? bimp seems to be unable to remove the color profile data... |
| 21:50 |
sfan5 |
absolutely not |
| 21:50 |
sfan5 |
download optipng and run all files through it with the "-strip all" option |
| 21:50 |
skyliner_369 |
oh thanks! |
| 21:51 |
skyliner_369 |
my google-fu is... aweful |
| 21:51 |
sfan5 |
note that this will (most likely) convert them to indexed color UNLESS you run it with -nx |
| 21:51 |
skyliner_369 |
converting to indexed is fine. strip all is fine too |
| 21:51 |
Warr1024 |
There are other nice png optimization tools, too, like advpng. I like to run my png assets through all of them in bulk via script. |
| 21:59 |
skyliner_369 |
how's "optipng -o7 -zm1-9 -clobber -strip "all" " look so far? there's no command example... |
| 22:00 |
sfan5 |
should work |
| 22:01 |
sfan5 |
-zm1-9 is usually overkill and -clobber is the default |
| 22:01 |
skyliner_369 |
and how do I indicate all files the exe is in? just a simple *.png? and overkill is good |
| 22:02 |
skyliner_369 |
gonna be away from my PC a while... plus my PC has many cores to play with |
| 22:02 |
sfan5 |
optipng is single-threaded so that'll be disappointing |
| 22:02 |
sfan5 |
yes *.png works |
| 22:03 |
skyliner_369 |
can't open the input file? |
| 22:06 |
skyliner_369 |
I think it's being silly and trying to find a literal *.png... |
| 22:11 |
|
appguru joined #minetest-dev |
| 22:48 |
skyliner_369 |
Well the images are compressed and metastripped. Now to run errands and then test the pack later |
| 22:49 |
rubenwardy |
https://forum.minetest.net/viewtopic.php?f=6&t=24818 |
| 22:51 |
sfan5 |
yeah those should be warnings instead |
| 22:56 |
|
gh00p_ joined #minetest-dev |
| 23:00 |
skyliner_369 |
I just know the game crashes when I load a certain block while using the texture pack, and I'll test it later with the sanitized images. If it still dies, ill submit a zip with the textures to bug tracking. |
| 23:30 |
|
gh00p joined #minetest-dev |
| 23:39 |
|
gh00p joined #minetest-dev |
| 23:46 |
|
gh00p joined #minetest-dev |
