Time |
Nick |
Message |
00:00 |
|
Cornelia joined #minetest-dev |
00:18 |
|
Lia joined #minetest-dev |
00:48 |
|
calcul0n joined #minetest-dev |
00:51 |
|
Cornelia joined #minetest-dev |
01:31 |
|
Cornelia joined #minetest-dev |
02:14 |
|
twoelk|2 left #minetest-dev |
03:41 |
|
ssieb joined #minetest-dev |
04:59 |
|
behalebabo joined #minetest-dev |
07:32 |
|
YuGiOhJCJ joined #minetest-dev |
07:36 |
|
Wuzzy joined #minetest-dev |
07:42 |
|
twoelk joined #minetest-dev |
08:45 |
sfan5 |
merging #8751 |
08:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/8751 -- Do not add group values of zero to group lists. by shacknetisp |
08:51 |
ANAND |
sfan5: Would you be able to approve (and hopefully merge) #8746? |
08:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/8746 -- Use `InteractAction` enum to denote interaction actions by ClobberXD |
08:52 |
sfan5 |
will look at it later |
08:52 |
ANAND |
Ok, thanks |
09:20 |
ANAND |
I thought #8461 was merged months ago. Just noticed it was still open o_O |
09:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/8461 -- Reimplement particles using the Irrlicht particle system and improve collision handling by DTA7 |
09:20 |
sfan5 |
merging #8759 in 5 minutes (or whenever) |
09:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/8759 -- Optimize usage of TOSERVER_GOTBLOCKS packet by sfan5 |
09:32 |
sfan5 |
merged. |
09:54 |
|
proller joined #minetest-dev |
10:07 |
sfan5 |
also merging #8433 |
10:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/8433 -- Fix/Add inventory_overlay for nodes without inventory_image by DS-Minetest |
10:18 |
ANAND |
yay |
11:31 |
ANAND |
Trivial PR: #8761 |
11:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/8761 -- guiConfirmRegistration: Automatically set focus to password field by ClobberXD |
11:32 |
ANAND |
Does anyone know what `dstream` is used for, btw? |
11:33 |
ANAND |
Is it the "debug stream" of sorts? |
11:33 |
ANAND |
If so, where are the dstream log messages displayed? |
11:47 |
|
Fixer joined #minetest-dev |
11:53 |
|
Taoki joined #minetest-dev |
12:16 |
|
proller joined #minetest-dev |
12:36 |
|
proller joined #minetest-dev |
13:00 |
|
Cornelia joined #minetest-dev |
13:07 |
|
BuckarooBanzai joined #minetest-dev |
13:10 |
|
BuckarooBanzai joined #minetest-dev |
13:36 |
|
Cornelia joined #minetest-dev |
14:33 |
ANAND |
sky.cpp is full of magic numbers :'( |
14:41 |
celeron55 |
it's a piece of art |
14:42 |
celeron55 |
you don't question the colors used in mona lisa |
14:42 |
celeron55 |
or the size of the nose |
14:44 |
celeron55 |
or that the sky is up |
14:46 |
ANAND |
Makes perfect sense |
14:48 |
* ANAND |
tries to figure out the "stuff" by himself |
14:49 |
|
DS-minetest joined #minetest-dev |
15:09 |
|
atlas_ joined #minetest-dev |
15:11 |
red-045 |
If sky.cpp is a work of art what is connection.cpp? |
15:26 |
|
ensonic joined #minetest-dev |
15:29 |
Soni |
minetest should have native cratera compatibility |
15:30 |
rubenwardy |
if you keep posting that here, I'll quiet you |
15:31 |
rubenwardy |
feature suggestions are better in #minetest or Github, and we've already said we don't want support for such a secure language anyway |
15:31 |
rubenwardy |
if you'd like to see that, I suggest implementing it in a fork |
15:31 |
rubenwardy |
if you create code to abstract away lua, that may be accepted upstream too |
16:19 |
|
Krock joined #minetest-dev |
16:44 |
Krock |
sfan5: would you prefer if I'd move the player->setModified() call to Server::setInventoryModified? |
16:44 |
Krock |
context https://github.com/minetest/minetest/pull/8742#discussion_r311437763 |
16:45 |
Krock |
hmm in terms of up-to-date saved inventories that would be a better choice |
16:46 |
Krock |
or in both places, because l_object directly calls SendInventory |
16:54 |
sfan5 |
Krock: yes that would make much more sense |
16:55 |
Krock |
updated the PR acordingly |
16:58 |
Krock |
will merge #8656 and #8677 in 17 minutes |
16:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/8656 -- Hide chat when console is open by ClobberXD |
16:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/8677 -- Unify wield item handling by SmallJoker |
17:00 |
Krock |
#8761 too |
17:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/8761 -- guiConfirmRegistration: Automatically set focus to password field by ClobberXD |
17:03 |
Krock |
sfan5: I assume PR #8746 is also OK for you? The code has again the same structure as before |
17:03 |
ShadowBot |
https://github.com/minetest/minetest/issues/8746 -- Use `InteractAction` enum to denote interaction actions by ClobberXD |
17:06 |
sfan5 |
Krock: yes, fine by me |
17:08 |
Krock |
thanks. will merge that PR too afterwards :) |
17:15 |
Krock |
merging |
17:16 |
|
atlas- joined #minetest-dev |
17:17 |
Krock |
mmh rebasing and pushing #8746 manually |
17:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/8746 -- Use `InteractAction` enum to denote interaction actions by ClobberXD |
17:22 |
Krock |
done |
18:18 |
rubenwardy |
merging #8762 as trivial |
18:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/8762 -- Fix usage of wrong variable in builtin chat command handling. by shacknetisp |
18:18 |
rubenwardy |
in a few |
18:29 |
|
ssieb joined #minetest-dev |
18:40 |
Krock |
it's great that people use master branch builds so we can do testing in production |
18:41 |
sfan5 |
that's how it was before we decided that 5.0 was a breaking release |
18:41 |
sfan5 |
i guess people are just returning to doing that |
18:44 |
Krock |
yeah, felt very silent around 5.0.0 so that's likely the issue there |
18:44 |
Krock |
ofc it's great to see them testing Minetest |
18:54 |
|
twoelk|2 joined #minetest-dev |
19:00 |
|
lisac joined #minetest-dev |
19:10 |
rubenwardy |
regression: players now have infinite range |
19:11 |
Krock |
excuse me what |
19:11 |
rubenwardy |
reporter reproduced it with a 5.0.1 server and 5.1-dev client, I can reproduce it in singleplayer |
19:12 |
Krock |
the heck how did this happen |
19:12 |
Krock |
looking into it |
19:12 |
sfan5 |
you managed to break both the anticheat and the client-side behaviour? |
19:12 |
sfan5 |
impressive |
19:12 |
Krock |
thanks |
19:15 |
Krock |
stupid error. found it |
19:15 |
Krock |
it's only client-side though |
19:16 |
Krock |
testing.. |
19:21 |
Krock |
will push https://krock-works.uk.to/u/patches/0001-Game-Fix-double-BS-multiplication.patch in a minute |
19:22 |
rubenwardy |
nice |
19:22 |
Krock |
<<<< |
19:23 |
Krock |
0c533dc |
19:25 |
* Sokomine |
tries to sneak the html-like formspecs in with all the merging going on |
19:28 |
Krock |
I guess such range check errors are only overseen when you focus on detecting the right item (hand slot or main slot) plus checking the digging speeds of how it should be |
21:00 |
|
paramat joined #minetest-dev |
21:02 |
|
ssieb joined #minetest-dev |
21:04 |
paramat |
merging #8728 |
21:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/8728 -- Avoid crash caused by, and improve, 'findSpawnPos()' by paramat |
21:09 |
|
vesper11 joined #minetest-dev |
21:49 |
|
calcul0n joined #minetest-dev |
22:03 |
|
SolarArray joined #minetest-dev |
22:08 |
|
proller joined #minetest-dev |
22:57 |
|
FullTimeLinux joined #minetest-dev |
23:11 |
|
paramat joined #minetest-dev |
23:12 |
|
troller joined #minetest-dev |
23:22 |
|
Lia joined #minetest-dev |
23:25 |
|
Cornelia joined #minetest-dev |
23:31 |
|
twoelk|2 left #minetest-dev |