Time |
Nick |
Message |
00:28 |
|
paramat joined #minetest-dev |
01:09 |
|
ANAND joined #minetest-dev |
02:15 |
|
Ruslan1 joined #minetest-dev |
03:30 |
|
Cornelia joined #minetest-dev |
03:37 |
|
ssieb joined #minetest-dev |
04:34 |
|
Player-2 joined #minetest-dev |
05:25 |
|
ANAND joined #minetest-dev |
06:11 |
|
paramat joined #minetest-dev |
06:11 |
paramat |
will merge #7824 in 15 mins (trivial) |
06:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/7824 -- Framed glasslike: Fix and document top/base textures feature by paramat |
06:33 |
|
thePalindrome joined #minetest-dev |
06:39 |
paramat |
merging |
06:41 |
paramat |
merged |
06:46 |
|
YuGiOhJCJ joined #minetest-dev |
06:49 |
|
YuGiOhJCJ joined #minetest-dev |
07:09 |
|
ANAND joined #minetest-dev |
09:41 |
|
troller joined #minetest-dev |
10:22 |
|
Wuzzy joined #minetest-dev |
10:49 |
|
troller joined #minetest-dev |
10:55 |
|
Fixer joined #minetest-dev |
11:01 |
|
Fixer_ joined #minetest-dev |
11:13 |
|
Fixer joined #minetest-dev |
11:26 |
|
AntumDeluge joined #minetest-dev |
11:29 |
|
Darcidride joined #minetest-dev |
11:47 |
|
AntumD joined #minetest-dev |
12:11 |
|
calcul0n joined #minetest-dev |
12:13 |
|
twoelk joined #minetest-dev |
12:37 |
|
T4im joined #minetest-dev |
13:45 |
|
troller joined #minetest-dev |
14:07 |
|
troller joined #minetest-dev |
16:43 |
|
ANAND joined #minetest-dev |
17:12 |
|
H4mlet joined #minetest-dev |
17:25 |
|
Gael-de-Sailly joined #minetest-dev |
17:35 |
|
longerstaff13 joined #minetest-dev |
17:35 |
|
xerox123 joined #minetest-dev |
17:36 |
|
longerstaff13-m joined #minetest-dev |
17:57 |
|
Krock joined #minetest-dev |
18:02 |
Krock |
T4im: I don't understand what you mean in https://github.com/minetest/minetest/pull/7629#issuecomment-433706849 |
18:03 |
Krock |
default to "False" for all development builds? |
18:04 |
T4im |
well, depends what you mean by development build |
18:04 |
Krock |
set(DEVELOPMENT_BUILD TRUE) |
18:04 |
T4im |
what i mean is, that if you don't set any flags, it should default to false |
18:05 |
Krock |
that would be quite pointless because we want the updater to notify players when possible |
18:05 |
T4im |
the goal should probably be that you can enable it for any binaries you distribute; but not if you just build it from git locally |
18:05 |
T4im |
yea but not players building from git |
18:05 |
T4im |
only players taking a distributed binary |
18:06 |
T4im |
whoever is building those binaries can enable the flag; i.e. travis can do that |
18:06 |
Krock |
..which take binaries from people which compile from git |
18:06 |
T4im |
yes, exactly, those people can enable it for those builds they distribute |
18:07 |
Krock |
I'd be happier to have this enabled by default for full releases (i.e. -DDEVELOPMENT_BUILD=0) and let the package maintainers decide about in-dev builds |
18:08 |
Krock |
since I'm mainly concerned that it would be yet another feature nobody uses because it's disabled by default (such as the inventory item animations) |
18:08 |
T4im |
well, the amount of people building them for distribution are probably not that many |
18:09 |
T4im |
(as in distributing prebuild binaries, not distributors) |
18:09 |
T4im |
but; defaultint to true for full releases; sure, could be implied :) |
18:15 |
T4im |
so opt-out for releases, opt-in for in-dev? :) |
18:16 |
Krock |
inconsistent when viewed as a whole but that would make most sense to me |
18:16 |
T4im |
seems reasonable |
18:17 |
Krock |
however, this requires the cmake cache to be re-configured to have an effect |
18:18 |
Krock |
just running the build system would take whatever was defined last |
18:19 |
T4im |
same with every setting, like changing between debug and release builds (cmake build type i mean) |
18:20 |
Krock |
except that those are meant to be static |
18:20 |
|
H4mlet joined #minetest-dev |
18:22 |
T4im |
hm; i mean if that would be a problem, maybe you can make it aware of environment variables to switch without reconfiguraiton |
18:38 |
|
ssieb joined #minetest-dev |
19:03 |
|
proller__ joined #minetest-dev |
20:41 |
|
sofar joined #minetest-dev |
20:48 |
|
Ruslan1 joined #minetest-dev |
21:22 |
|
Fixer_ joined #minetest-dev |
22:19 |
|
unknown_ joined #minetest-dev |
22:19 |
|
Taoki joined #minetest-dev |
22:52 |
|
proller__ joined #minetest-dev |
23:12 |
|
Ruslan1 joined #minetest-dev |
23:24 |
|
twoelk|2 joined #minetest-dev |
23:31 |
|
calcul0n joined #minetest-dev |
23:43 |
|
twoelk|2 left #minetest-dev |