Minetest logo

IRC log for #minetest-dev, 2018-10-08

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
01:04 Ruslan1 joined #minetest-dev
01:21 paramat joined #minetest-dev
05:04 Lymkwi joined #minetest-dev
06:10 jas_ joined #minetest-dev
09:56 Fixer joined #minetest-dev
10:20 calcul0n joined #minetest-dev
12:34 T4im joined #minetest-dev
13:21 Gael-de-Sailly joined #minetest-dev
13:54 maxy joined #minetest-dev
14:37 Ruslan1 joined #minetest-dev
14:39 nore hmmm why was #4428 closed?
14:40 ShadowBot https://github.com/minetest/minetest/issues/4428 -- Different "Dimensions" / Other worlds
15:11 indiana joined #minetest-dev
16:23 twoelk joined #minetest-dev
16:56 Krock joined #minetest-dev
17:01 Cornelia joined #minetest-dev
17:04 Krock p_gimeno: checking against "std::abs(v.second - fs) > std::abs(fs * 0.000005f)" for precision is way shorter than taking the sign in account both times ;)
17:05 Krock s/second/first/
17:21 p_gimeno Krock: hmm, dodgy
17:22 Krock *shrug* maybe. it works.
17:22 p_gimeno I've noticed the last commit removes the first test. My proposal was to keep both, in order to test both directions.
17:25 p_gimeno It's just that testing both directions by checking if they round-tripped was not right.
17:26 Krock but it would be good if these functions could result in no data loss
17:26 Krock i.e.  tof32(tou32(u32_num)) == u32_num
17:26 Krock but I guess that's hard to do when the platform does not have enough mantissa bits
17:27 Krock for whatever reason
17:27 p_gimeno any difference in mantissa bits will cause a round-trip failure in one of the directions
17:30 p_gimeno especially for numbers that are periodic in binary like 0.1f
17:34 Krock I see
17:51 twoelk left #minetest-dev
18:14 Krock thanks for your review sfan5. Will merge #7684 tomorrow - would be great if other protocol bump PRs could be reviewed too to merge them close together
18:14 ShadowBot https://github.com/minetest/minetest/issues/7684 -- Add core.remove_detached_inventory by SmallJoker
18:15 Krock nvm, only two other open PRs which dump the protocol actually.
18:23 Krock rebased #7521
18:23 ShadowBot https://github.com/minetest/minetest/issues/7521 -- Implement ChatMessage into the API by SmallJoker
18:24 Krock ^ nerzhul might be interested in this?
18:33 Jordach joined #minetest-dev
18:45 kilbith joined #minetest-dev
19:22 paramat joined #minetest-dev
20:57 Ruslan1 joined #minetest-dev
20:58 paramat rubenwardy game#2180 needs another +1. changes look fine to me but i'm neutral on the concept
20:58 ShadowBot https://github.com/minetest/minetest_game/issues/2180 -- Add blueberry bushes by random-geek
22:31 nerzhul SmallJoker sure i'm interested in, but i can't remember where this pr is

| Channels | #minetest-dev index | Today | | Google Search | Plaintext