Time |
Nick |
Message |
00:10 |
|
Lia joined #minetest-dev |
00:17 |
|
srifqi joined #minetest-dev |
00:45 |
|
Tmanyo joined #minetest-dev |
00:56 |
|
Fritigern joined #minetest-dev |
01:24 |
|
srifqi joined #minetest-dev |
01:26 |
|
srifqi left #minetest-dev |
02:51 |
|
AndroBuilder joined #minetest-dev |
03:02 |
|
Wuzzy joined #minetest-dev |
06:30 |
|
srifqi joined #minetest-dev |
06:33 |
srifqi |
~tell paramat My exam already done, I've some days until another exam. |
06:33 |
ShadowBot |
srifqi: O.K. |
06:33 |
srifqi |
rubenwardy: I've added option to use fixed joystick's position, you can try it. #7126 |
06:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/7126 -- Android: Replace movement buttons with joystick by srifqi |
07:07 |
|
srifqi left #minetest-dev |
07:36 |
nerzhul |
srifqi option is quite nice but in android users will never use options, it should just work :) |
08:06 |
nerzhul |
i justed push #7179 please review when you get time. Please note i will try to add some unittests on that part |
08:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/7179 -- [WIP] Client eventmanager refactor by nerzhul |
08:12 |
|
srifqi joined #minetest-dev |
08:13 |
srifqi |
nerzhul: we can't use two different virtual joystick mode at the same time, right? |
08:14 |
|
YuGiOhJCJ joined #minetest-dev |
08:19 |
|
Lymkwi joined #minetest-dev |
08:26 |
|
shivajiva joined #minetest-dev |
08:33 |
|
srifqi left #minetest-dev |
08:46 |
nerzhul |
in irrlicht ? or something else ? |
08:46 |
nerzhul |
in some games you got 2 joysticks like PS1 controler |
08:53 |
|
davisonio joined #minetest-dev |
09:17 |
|
Lymkwi joined #minetest-dev |
09:20 |
|
proller joined #minetest-dev |
09:54 |
|
Lymkwi joined #minetest-dev |
10:17 |
|
YuGiOhJCJ joined #minetest-dev |
10:27 |
|
Fixer joined #minetest-dev |
10:50 |
|
troller joined #minetest-dev |
10:52 |
|
ThomasMonroe joined #minetest-dev |
11:19 |
nerzhul |
#7179 is now ready. I added unittests. It can be merge when somebody has reviewed it (rubenwardy, Krock, sfan5, when you get time) |
11:19 |
ShadowBot |
https://github.com/minetest/minetest/issues/7179 -- Client eventmanager refactor by nerzhul |
11:19 |
nerzhul |
at least unittests permit to speedup the review process :) |
11:24 |
|
srifqi joined #minetest-dev |
11:25 |
srifqi |
nerzhul: I mean, you said "android users will never use options". |
11:25 |
srifqi |
If they want fixed joystick's position, they can just use settings. |
11:29 |
nerzhul |
yes, but what i mean is android users doesn't care about setting, they watn good ergonomy by defualt |
11:31 |
srifqi |
It's a matter of choice, IMO. |
11:31 |
srifqi |
It's always hard to choose which option is best. |
11:31 |
srifqi |
:( |
11:32 |
srifqi |
Have you test it? :D |
11:35 |
nerzhul |
i didn't tested it |
11:35 |
nerzhul |
for me you should have it at 10%/10% margin on the bottom left corner |
11:38 |
|
Fixer_ joined #minetest-dev |
11:39 |
nerzhul |
i push 2 trivial commits to master (warnings reported by clang) |
11:42 |
nerzhul |
hmm i got another warning to fix introduced by c5b4e541749c50805519ce040d98a0a8e5e0ec03 |
11:56 |
nerzhul |
srifqi, not 10% it's too big, but 5% |
12:03 |
srifqi |
Let me try. |
12:33 |
|
proller joined #minetest-dev |
12:34 |
srifqi |
How about one or two "button_size" instead using percentage? |
12:34 |
srifqi |
nerzhul: Percentage can increase along with screen size. |
12:49 |
|
srifqi joined #minetest-dev |
13:01 |
|
clavi joined #minetest-dev |
13:32 |
rubenwardy |
merging #7148 in 15 |
13:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/7148 -- Optional alpha channel support for entities by stujones11 |
13:39 |
|
antims joined #minetest-dev |
13:41 |
rubenwardy |
I'm going to make a trivial change to 7148, which is adding a feature flag |
13:55 |
rubenwardy |
done |
14:03 |
|
YuGiOhJCJ joined #minetest-dev |
14:26 |
|
Wuzzy joined #minetest-dev |
14:29 |
|
Lone-Star joined #minetest-dev |
14:33 |
|
Fixer joined #minetest-dev |
15:06 |
|
proller joined #minetest-dev |
15:12 |
|
Gael-de-Sailly joined #minetest-dev |
15:13 |
nerzhul |
ty for the review rubenwardy & Krock i will fix the clang problem asap and merge |
15:25 |
|
DI3HARD139 joined #minetest-dev |
15:26 |
|
Krock joined #minetest-dev |
15:34 |
|
proller joined #minetest-dev |
15:39 |
|
Beton joined #minetest-dev |
15:43 |
|
srifqi left #minetest-dev |
15:46 |
nerzhul |
rubenwardy, i assure you approve 7179 if clang build issue is fixed no ? |
15:46 |
rubenwardy |
if it passes the builds then yes |
15:48 |
nerzhul |
it's a header inclusion issue on clang, i just need to find how to fix it :) |
15:48 |
nerzhul |
and we will have more unittests heh |
15:53 |
nerzhul |
oh i think i know what's the problem, u8 should not be defined at this moment |
15:53 |
nerzhul |
then the hash compilation failed, should be fixed, we will see in 5 mins |
15:53 |
nerzhul |
clang 6 doesn't have this problem |
15:55 |
|
cx384 joined #minetest-dev |
15:56 |
IcyDiamond |
How does string.gsub work in the lua used in minetest? |
15:56 |
IcyDiamond |
Oh, nevermind, I'm stupod |
15:56 |
IcyDiamond |
stupid* |
15:57 |
rubenwardy |
lol |
15:57 |
nerzhul |
look at Lua 5.1 doc |
15:59 |
|
Fritigern joined #minetest-dev |
16:30 |
|
Wuzzy joined #minetest-dev |
16:43 |
|
Darcidride joined #minetest-dev |
17:03 |
|
Wuzzy joined #minetest-dev |
17:24 |
|
Wuzzy joined #minetest-dev |
17:30 |
|
Wuzzy2 joined #minetest-dev |
18:07 |
|
Wuzzy2 joined #minetest-dev |
18:16 |
|
fwhcat joined #minetest-dev |
18:25 |
|
Raven262 joined #minetest-dev |
18:28 |
|
paramat joined #minetest-dev |
18:32 |
paramat |
hi, please can anyone +1 #7169 ? you can somewhat trust me on the code as i very much know what i'm doing here, carefully tested |
18:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/7169 -- Mgcarpathian: Mapgen loop optimisations. fabs() -> std::fabs() by paramat |
18:46 |
Krock |
paramat, unfolding the pow function doesn't make a big difference at all. Using the XZY loops makes most of the performance gain |
18:46 |
paramat |
yes probably |
18:47 |
paramat |
although i have been told that the power optimisation is significant |
18:48 |
paramat |
oh nice, thanks |
18:48 |
Krock |
depends on the compiler |
18:49 |
paramat |
ok. after this i'll fix the spawn level issue in that mapgen |
18:51 |
|
Warr1024 joined #minetest-dev |
19:00 |
|
Wuzzy2 joined #minetest-dev |
19:22 |
|
Amaz joined #minetest-dev |
19:28 |
|
Wuzzy3 joined #minetest-dev |
19:32 |
Krock |
Will merge #7168 and #6900 (trivial and already announced to merge in the meeting 19 days ago) in 10 minutes |
19:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/7168 -- fix static initialization order dependency by not having one by nOOb3167 |
19:32 |
ShadowBot |
https://github.com/minetest/minetest/issues/6900 -- core.rotate_node: Do not trigger after_place_node by SmallJoker |
19:37 |
IcyDiamond |
Keep up the good work fellas, I love this engine and I hope it goes a long way! |
19:46 |
paramat |
finished merging? i have one to do |
19:52 |
|
troller joined #minetest-dev |
20:04 |
paramat |
ok merging #7169 now |
20:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/7169 -- Mgcarpathian: Mapgen loop optimisations. fabs() -> std::fabs() by paramat |
20:10 |
paramat |
done, 90 commits, good work |
20:10 |
IcyDiamond |
:D |
20:14 |
|
fwhcat joined #minetest-dev |
20:32 |
|
proller joined #minetest-dev |
20:37 |
|
twoelk joined #minetest-dev |
20:53 |
|
BakerPrime_ joined #minetest-dev |
20:53 |
|
newbie|3 joined #minetest-dev |
21:06 |
|
lisac joined #minetest-dev |
21:58 |
|
red-001 joined #minetest-dev |
22:01 |
|
troller joined #minetest-dev |
22:43 |
|
Wuzzy3 joined #minetest-dev |
23:03 |
|
YuGiOhJCJ joined #minetest-dev |
23:43 |
|
Wuzzy2 joined #minetest-dev |
23:44 |
rubenwardy |
Guys, crack open the champagne |
23:44 |
rubenwardy |
90 PRs! |
23:57 |
paramat |
\90/ |