Time |
Nick |
Message |
00:04 |
|
MarisaG joined #minetest-dev |
00:04 |
|
MarisaG left #minetest-dev |
00:33 |
|
YuGiOhJCJ joined #minetest-dev |
00:33 |
|
Lunatrius joined #minetest-dev |
01:09 |
|
YuGiOhJCJ joined #minetest-dev |
01:31 |
|
Lymkwi joined #minetest-dev |
02:59 |
|
reductum joined #minetest-dev |
03:13 |
|
reductum joined #minetest-dev |
04:50 |
|
DI3HARD139 joined #minetest-dev |
06:21 |
|
sofar joined #minetest-dev |
06:33 |
|
sofar joined #minetest-dev |
06:47 |
|
sofar joined #minetest-dev |
08:34 |
|
paramat joined #minetest-dev |
08:44 |
|
MoNTE48 joined #minetest-dev |
08:45 |
paramat |
should we be using std::fabs() (while including <cmath>) instead of fabs()? |
09:08 |
|
Flitzpiepe joined #minetest-dev |
09:25 |
|
Flitzpiepe joined #minetest-dev |
09:26 |
nerzhul |
paramat, we really should as we are a C++11 program |
09:30 |
|
Wuzzy joined #minetest-dev |
09:35 |
paramat |
thanks |
09:36 |
paramat |
yes likewise for fmin fmax |
09:37 |
paramat |
noted so i don't have to ask again |
09:43 |
|
red-001 joined #minetest-dev |
10:04 |
|
proller__ joined #minetest-dev |
10:11 |
|
Fritigern joined #minetest-dev |
10:12 |
paramat |
i'll merge #7169 in a few hours, carefully tested and i'm very confident about the code (working in my speciality), semi-trivial |
10:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/7169 -- Mgcarpathian: Mapgen loop optimisations. fabs() -> std::fabs() by paramat |
10:13 |
paramat |
will also merge game#2096 later |
10:13 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2096 -- Xpanes: Description 'Iron Bar' -> 'Steel Bars' by paramat |
10:21 |
|
MoNTE48 joined #minetest-dev |
10:40 |
|
Fritigern joined #minetest-dev |
10:41 |
|
Fixer joined #minetest-dev |
10:48 |
|
proller__ joined #minetest-dev |
10:56 |
|
Flitzpiepe joined #minetest-dev |
11:07 |
paramat |
merging game2096 |
11:10 |
paramat |
done |
11:14 |
nerzhul |
@paramat your mapgen optmisation is a good place for a unittest, i hope at a point we can unittest all mapgen results |
11:22 |
|
srifqi joined #minetest-dev |
11:26 |
|
Lone-Star joined #minetest-dev |
11:30 |
|
Fritigern joined #minetest-dev |
11:32 |
|
YuGiOhJCJ joined #minetest-dev |
12:40 |
|
Lone-Star joined #minetest-dev |
12:41 |
|
paramat joined #minetest-dev |
12:45 |
|
ThomasMonroe joined #minetest-dev |
12:47 |
|
Flitzpiepe joined #minetest-dev |
13:21 |
|
Flitzpiepe joined #minetest-dev |
13:31 |
|
RichardTheTurd joined #minetest-dev |
13:39 |
|
antims joined #minetest-dev |
13:49 |
nerzhul |
Can someone approve #7168 ? thanks |
13:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/7168 -- fix static initialization order dependency by not having one by nOOb3167 |
13:50 |
|
Beton joined #minetest-dev |
13:58 |
paramat |
looking |
14:00 |
|
Flitzpiepe joined #minetest-dev |
14:00 |
paramat |
hmm beyond me, sorry |
14:06 |
rubenwardy |
daily reminder that #6396 and #7099 both only need one more approval |
14:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/6396 -- Add reasons to on_dieplayer and on_hpchange by rubenwardy |
14:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/7099 -- Add formspec theming using prepended strings by rubenwardy |
14:28 |
nerzhul |
rubenwardy 6396 is mergeable i added my approval |
14:29 |
rubenwardy |
for a big PR don't you need to != yourself? |
14:29 |
rubenwardy |
*two |
14:29 |
nerzhul |
i don't know who added the rule if there is a such rule, i never heard about it |
14:30 |
nerzhul |
we are both coredevs |
14:30 |
nerzhul |
and it's "just" a callback |
14:30 |
nerzhul |
if we were 10 coredevs and the projet is more active why not at a point, but there is no interest currently |
14:30 |
rubenwardy |
true |
14:31 |
nerzhul |
go ahead for 6396 |
14:31 |
rubenwardy |
cool |
14:32 |
rubenwardy |
I'll merge both in 30 |
14:34 |
rubenwardy |
my next PR: depends and such in mod.conf |
14:38 |
rubenwardy |
nerzhul, in C++11 compilers are told to automagically std::move() and returned classes, providing they don't need implicit conversion there |
14:38 |
rubenwardy |
so it's fine to return std::strings and std::vectors |
14:38 |
rubenwardy |
would be good to have smth like std::vector_nocpy<> tbh |
14:42 |
|
Player_2 joined #minetest-dev |
14:46 |
|
ThomasMonroe joined #minetest-dev |
15:04 |
rubenwardy |
merging... |
15:04 |
|
Taoki joined #minetest-dev |
15:04 |
rubenwardy |
done |
15:09 |
rubenwardy |
game#2098 |
15:09 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2098 -- Add formspec theming, remove sfinv's dependency on default by rubenwardy |
15:11 |
|
Lunatrius joined #minetest-dev |
15:16 |
|
twoelk joined #minetest-dev |
15:18 |
|
ThomasMonroe_ joined #minetest-dev |
15:54 |
|
MoNTE48 joined #minetest-dev |
15:56 |
|
TMcSquared joined #minetest-dev |
16:01 |
|
troller joined #minetest-dev |
16:06 |
|
Fixer joined #minetest-dev |
16:23 |
|
Gael-de-Sailly joined #minetest-dev |
16:36 |
|
Flitzpiepe joined #minetest-dev |
16:54 |
|
sofar joined #minetest-dev |
16:58 |
|
sofar joined #minetest-dev |
17:05 |
|
Krock joined #minetest-dev |
17:18 |
rubenwardy |
#6243 |
17:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/6243 -- Load dependencies and description from mod.conf by rubenwardy |
17:20 |
* sofar |
claps |
17:22 |
rubenwardy |
merging game#2098 in 5 |
17:22 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2098 -- Add formspec theming, remove sfinv's dependency on default by rubenwardy |
17:28 |
rubenwardy |
merging |
17:39 |
|
Raven262 joined #minetest-dev |
17:41 |
|
ThomasMonroe_ joined #minetest-dev |
18:06 |
rubenwardy |
updated #6243 |
18:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/6243 -- Load dependencies and description from mod.conf by rubenwardy |
18:45 |
Thomas-S |
Could someone please review #7116? There is still one approval missing. Thanks in advance! |
18:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/7116 -- Formspecs: Add a <use_color_alpha> parameter to the box[] element by Thomas--S |
18:59 |
|
Gael-de-Sailly joined #minetest-dev |
19:10 |
|
proller joined #minetest-dev |
19:34 |
|
MoNTE48 joined #minetest-dev |
19:43 |
|
Fritigern joined #minetest-dev |
19:44 |
|
twoelk left #minetest-dev |
19:45 |
|
Taoki joined #minetest-dev |
19:53 |
nerzhul |
rubenwardy commented #6243 |
19:53 |
ShadowBot |
https://github.com/minetest/minetest/issues/6243 -- Load dependencies and description from mod.conf by rubenwardy |
19:53 |
rubenwardy |
thanks |
19:57 |
rubenwardy |
good suggestions |
20:47 |
rubenwardy |
nerzhul, updated |
20:54 |
|
ThomasMonroe joined #minetest-dev |
20:54 |
|
proller joined #minetest-dev |
20:54 |
nerzhul |
:+1: |
20:57 |
rubenwardy |
will merge un 15m |
21:05 |
|
troller joined #minetest-dev |
21:14 |
rubenwardy |
done |
21:39 |
|
Sokomine joined #minetest-dev |
21:49 |
|
proller joined #minetest-dev |
22:10 |
|
Raven262 joined #minetest-dev |
22:29 |
|
Gael-de-Sailly joined #minetest-dev |
22:33 |
|
Lymkwi joined #minetest-dev |
23:19 |
|
troller joined #minetest-dev |